]> git.sur5r.net Git - openocd/commit
jtag/drivers/cmsis-dap: fix connect in cmsis_dap_swd_switch_seq()
authorAntonio Borneo <borneo.antonio@gmail.com>
Sat, 23 Jun 2018 13:12:46 +0000 (15:12 +0200)
committerTomas Vanek <vanekt@fbl.cz>
Tue, 3 Jul 2018 06:27:14 +0000 (07:27 +0100)
commit91c125a906221481d7b9ee2c7e4588fbe6ade85c
tree70c5d6023d14578652c5bfb05e66ab038e3ee77d
parent8b8b66559d5fbfeb1dd408a1af17dc0be52b5a9f
jtag/drivers/cmsis-dap: fix connect in cmsis_dap_swd_switch_seq()

The proc cmsis_dap_swd_switch_seq() is part of the SWD API for
this interface driver. It is valid only when the interface is
used in SWD mode.
In this proc there is the need to call, in sequence, first
cmsis_dap_cmd_DAP_Disconnect() then cmsis_dap_cmd_DAP_Connect().
The latter call requires the connection mode as parameter, that
inside cmsis_dap_swd_switch_seq() can only be CONNECT_SWD.

The current implementation is not correct and in some cases can
pass mode CONNECT_JTAG. Moreover, JTAG is optional in CMSIS-DAP
and passing mode CONNECT_JTAG triggers an error with SWD-only
interfaces.

Use mode CONNECT_SWD in SWD specific cmsis_dap_swd_switch_seq().

Change-Id: Ib455bf5b69cb2a2d146a6c8875387b00c27a5690
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/4571
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
src/jtag/drivers/cmsis_dap_usb.c