]> git.sur5r.net Git - openocd/commit
helper: hexify correctly handle signed chars
authorSpencer Oliver <spen@spen-soft.co.uk>
Mon, 28 Jan 2013 11:45:51 +0000 (11:45 +0000)
committerØyvind Harboe <oyvindharboe@gmail.com>
Thu, 31 Jan 2013 14:50:24 +0000 (14:50 +0000)
commitbf3f35092ea96b33ceda33d497ec04514e94cb00
tree5acbf84f4bcf2f348ee4571e354626b72b9a5d5a
parent4a5c9a4965eff5aa678ccc7d1f50da714238b77a
helper: hexify correctly handle signed chars

The current implementation of hexify was not correctly handling signed chars.

This function is currently used by the ti-icdi driver and as such was causing
random write issues.

As a note perhaps a better long term fix would be to change to using uint8_t
buffers rather than char. This will require changes to the ti-icdi driver
aswell.

Change-Id: I572e69ff2b99227a7d412de056458c0393794b03
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/1124
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
src/helper/binarybuffer.c