]> git.sur5r.net Git - u-boot/blobdiff - arch/powerpc/cpu/mpc8xxx/ddr/interactive.c
Merge branch 'master' of git://git.denx.de/u-boot-nand-flash
[u-boot] / arch / powerpc / cpu / mpc8xxx / ddr / interactive.c
index cb71f94ba1ecd1540728892dc0bf3c72d3b1f94c..3b661129cb0395854427fd39f335b7aba8ba8e7e 100644 (file)
@@ -1,9 +1,7 @@
 /*
  * Copyright 2010-2012 Freescale Semiconductor, Inc.
  *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * Version 2 or any later versionas published by the Free Software Foundation.
+ * SPDX-License-Identifier:    GPL-2.0+
  */
 
 /*
@@ -152,33 +150,33 @@ static void lowest_common_dimm_parameters_edit(fsl_ddr_info_t *pinfo,
        common_timing_params_t *p = &pinfo->common_timing_params[ctrl_num];
 
        static const struct options_string options[] = {
-               COMMON_TIMING(tCKmin_X_ps),
-               COMMON_TIMING(tCKmax_ps),
-               COMMON_TIMING(tCKmax_max_ps),
-               COMMON_TIMING(tRCD_ps),
-               COMMON_TIMING(tRP_ps),
-               COMMON_TIMING(tRAS_ps),
-               COMMON_TIMING(tWR_ps),
-               COMMON_TIMING(tWTR_ps),
-               COMMON_TIMING(tRFC_ps),
-               COMMON_TIMING(tRRD_ps),
-               COMMON_TIMING(tRC_ps),
+               COMMON_TIMING(tckmin_x_ps),
+               COMMON_TIMING(tckmax_ps),
+               COMMON_TIMING(tckmax_max_ps),
+               COMMON_TIMING(trcd_ps),
+               COMMON_TIMING(trp_ps),
+               COMMON_TIMING(tras_ps),
+               COMMON_TIMING(twr_ps),
+               COMMON_TIMING(twtr_ps),
+               COMMON_TIMING(trfc_ps),
+               COMMON_TIMING(trrd_ps),
+               COMMON_TIMING(trc_ps),
                COMMON_TIMING(refresh_rate_ps),
-               COMMON_TIMING(tIS_ps),
-               COMMON_TIMING(tIH_ps),
-               COMMON_TIMING(tDS_ps),
-               COMMON_TIMING(tDH_ps),
-               COMMON_TIMING(tRTP_ps),
-               COMMON_TIMING(tDQSQ_max_ps),
-               COMMON_TIMING(tQHS_ps),
+               COMMON_TIMING(tis_ps),
+               COMMON_TIMING(tih_ps),
+               COMMON_TIMING(tds_ps),
+               COMMON_TIMING(tdh_ps),
+               COMMON_TIMING(trtp_ps),
+               COMMON_TIMING(tdqsq_max_ps),
+               COMMON_TIMING(tqhs_ps),
                COMMON_TIMING(ndimms_present),
                COMMON_TIMING(lowest_common_SPD_caslat),
                COMMON_TIMING(highest_common_derated_caslat),
                COMMON_TIMING(additive_latency),
-               COMMON_TIMING(all_DIMMs_burst_lengths_bitmask),
-               COMMON_TIMING(all_DIMMs_registered),
-               COMMON_TIMING(all_DIMMs_unbuffered),
-               COMMON_TIMING(all_DIMMs_ECC_capable),
+               COMMON_TIMING(all_dimms_burst_lengths_bitmask),
+               COMMON_TIMING(all_dimms_registered),
+               COMMON_TIMING(all_dimms_unbuffered),
+               COMMON_TIMING(all_dimms_ecc_capable),
                COMMON_TIMING(total_mem),
                COMMON_TIMING(base_address),
        };
@@ -207,6 +205,7 @@ static void fsl_ddr_dimm_parameters_edit(fsl_ddr_info_t *pinfo,
                DIMM_PARM(primary_sdram_width),
                DIMM_PARM(ec_sdram_width),
                DIMM_PARM(registered_dimm),
+               DIMM_PARM(device_width),
 
                DIMM_PARM(n_row_addr),
                DIMM_PARM(n_col_addr),
@@ -215,34 +214,34 @@ static void fsl_ddr_dimm_parameters_edit(fsl_ddr_info_t *pinfo,
                DIMM_PARM(burst_lengths_bitmask),
                DIMM_PARM(row_density),
 
-               DIMM_PARM(tCKmin_X_ps),
-               DIMM_PARM(tCKmin_X_minus_1_ps),
-               DIMM_PARM(tCKmin_X_minus_2_ps),
-               DIMM_PARM(tCKmax_ps),
+               DIMM_PARM(tckmin_x_ps),
+               DIMM_PARM(tckmin_x_minus_1_ps),
+               DIMM_PARM(tckmin_x_minus_2_ps),
+               DIMM_PARM(tckmax_ps),
 
-               DIMM_PARM(caslat_X),
-               DIMM_PARM(caslat_X_minus_1),
-               DIMM_PARM(caslat_X_minus_2),
+               DIMM_PARM(caslat_x),
+               DIMM_PARM(caslat_x_minus_1),
+               DIMM_PARM(caslat_x_minus_2),
 
                DIMM_PARM(caslat_lowest_derated),
 
-               DIMM_PARM(tRCD_ps),
-               DIMM_PARM(tRP_ps),
-               DIMM_PARM(tRAS_ps),
-               DIMM_PARM(tWR_ps),
-               DIMM_PARM(tWTR_ps),
-               DIMM_PARM(tRFC_ps),
-               DIMM_PARM(tRRD_ps),
-               DIMM_PARM(tRC_ps),
+               DIMM_PARM(trcd_ps),
+               DIMM_PARM(trp_ps),
+               DIMM_PARM(tras_ps),
+               DIMM_PARM(twr_ps),
+               DIMM_PARM(twtr_ps),
+               DIMM_PARM(trfc_ps),
+               DIMM_PARM(trrd_ps),
+               DIMM_PARM(trc_ps),
                DIMM_PARM(refresh_rate_ps),
 
-               DIMM_PARM(tIS_ps),
-               DIMM_PARM(tIH_ps),
-               DIMM_PARM(tDS_ps),
-               DIMM_PARM(tDH_ps),
-               DIMM_PARM(tRTP_ps),
-               DIMM_PARM(tDQSQ_max_ps),
-               DIMM_PARM(tQHS_ps),
+               DIMM_PARM(tis_ps),
+               DIMM_PARM(tih_ps),
+               DIMM_PARM(tds_ps),
+               DIMM_PARM(tdh_ps),
+               DIMM_PARM(trtp_ps),
+               DIMM_PARM(tdqsq_max_ps),
+               DIMM_PARM(tqhs_ps),
 
                DIMM_PARM(rank_density),
                DIMM_PARM(capacity),
@@ -265,40 +264,41 @@ static void print_dimm_parameters(const dimm_params_t *pdimm)
                DIMM_PARM(primary_sdram_width),
                DIMM_PARM(ec_sdram_width),
                DIMM_PARM(registered_dimm),
+               DIMM_PARM(device_width),
 
                DIMM_PARM(n_row_addr),
                DIMM_PARM(n_col_addr),
                DIMM_PARM(edc_config),
                DIMM_PARM(n_banks_per_sdram_device),
 
-               DIMM_PARM(tCKmin_X_ps),
-               DIMM_PARM(tCKmin_X_minus_1_ps),
-               DIMM_PARM(tCKmin_X_minus_2_ps),
-               DIMM_PARM(tCKmax_ps),
+               DIMM_PARM(tckmin_x_ps),
+               DIMM_PARM(tckmin_x_minus_1_ps),
+               DIMM_PARM(tckmin_x_minus_2_ps),
+               DIMM_PARM(tckmax_ps),
 
-               DIMM_PARM(caslat_X),
-               DIMM_PARM(tAA_ps),
-               DIMM_PARM(caslat_X_minus_1),
-               DIMM_PARM(caslat_X_minus_2),
+               DIMM_PARM(caslat_x),
+               DIMM_PARM(taa_ps),
+               DIMM_PARM(caslat_x_minus_1),
+               DIMM_PARM(caslat_x_minus_2),
                DIMM_PARM(caslat_lowest_derated),
 
-               DIMM_PARM(tRCD_ps),
-               DIMM_PARM(tRP_ps),
-               DIMM_PARM(tRAS_ps),
-               DIMM_PARM(tWR_ps),
-               DIMM_PARM(tWTR_ps),
-               DIMM_PARM(tRFC_ps),
-               DIMM_PARM(tRRD_ps),
-               DIMM_PARM(tRC_ps),
+               DIMM_PARM(trcd_ps),
+               DIMM_PARM(trp_ps),
+               DIMM_PARM(tras_ps),
+               DIMM_PARM(twr_ps),
+               DIMM_PARM(twtr_ps),
+               DIMM_PARM(trfc_ps),
+               DIMM_PARM(trrd_ps),
+               DIMM_PARM(trc_ps),
                DIMM_PARM(refresh_rate_ps),
 
-               DIMM_PARM(tIS_ps),
-               DIMM_PARM(tIH_ps),
-               DIMM_PARM(tDS_ps),
-               DIMM_PARM(tDH_ps),
-               DIMM_PARM(tRTP_ps),
-               DIMM_PARM(tDQSQ_max_ps),
-               DIMM_PARM(tQHS_ps),
+               DIMM_PARM(tis_ps),
+               DIMM_PARM(tih_ps),
+               DIMM_PARM(tds_ps),
+               DIMM_PARM(tdh_ps),
+               DIMM_PARM(trtp_ps),
+               DIMM_PARM(tdqsq_max_ps),
+               DIMM_PARM(tqhs_ps),
        };
        static const unsigned int n_opts = ARRAY_SIZE(options);
 
@@ -325,41 +325,41 @@ static void print_lowest_common_dimm_parameters(
                const common_timing_params_t *plcd_dimm_params)
 {
        static const struct options_string options[] = {
-               COMMON_TIMING(tCKmax_max_ps),
-               COMMON_TIMING(tRCD_ps),
-               COMMON_TIMING(tRP_ps),
-               COMMON_TIMING(tRAS_ps),
-               COMMON_TIMING(tWR_ps),
-               COMMON_TIMING(tWTR_ps),
-               COMMON_TIMING(tRFC_ps),
-               COMMON_TIMING(tRRD_ps),
-               COMMON_TIMING(tRC_ps),
+               COMMON_TIMING(tckmax_max_ps),
+               COMMON_TIMING(trcd_ps),
+               COMMON_TIMING(trp_ps),
+               COMMON_TIMING(tras_ps),
+               COMMON_TIMING(twr_ps),
+               COMMON_TIMING(twtr_ps),
+               COMMON_TIMING(trfc_ps),
+               COMMON_TIMING(trrd_ps),
+               COMMON_TIMING(trc_ps),
                COMMON_TIMING(refresh_rate_ps),
-               COMMON_TIMING(tIS_ps),
-               COMMON_TIMING(tDS_ps),
-               COMMON_TIMING(tDH_ps),
-               COMMON_TIMING(tRTP_ps),
-               COMMON_TIMING(tDQSQ_max_ps),
-               COMMON_TIMING(tQHS_ps),
+               COMMON_TIMING(tis_ps),
+               COMMON_TIMING(tds_ps),
+               COMMON_TIMING(tdh_ps),
+               COMMON_TIMING(trtp_ps),
+               COMMON_TIMING(tdqsq_max_ps),
+               COMMON_TIMING(tqhs_ps),
                COMMON_TIMING(lowest_common_SPD_caslat),
                COMMON_TIMING(highest_common_derated_caslat),
                COMMON_TIMING(additive_latency),
                COMMON_TIMING(ndimms_present),
-               COMMON_TIMING(all_DIMMs_registered),
-               COMMON_TIMING(all_DIMMs_unbuffered),
-               COMMON_TIMING(all_DIMMs_ECC_capable),
+               COMMON_TIMING(all_dimms_registered),
+               COMMON_TIMING(all_dimms_unbuffered),
+               COMMON_TIMING(all_dimms_ecc_capable),
        };
        static const unsigned int n_opts = ARRAY_SIZE(options);
 
        /* Clock frequencies */
-       printf("tCKmin_X_ps = %u (%u MHz)\n",
-              plcd_dimm_params->tCKmin_X_ps,
-              picos_to_mhz(plcd_dimm_params->tCKmin_X_ps));
-       printf("tCKmax_ps = %u (%u MHz)\n",
-              plcd_dimm_params->tCKmax_ps,
-              picos_to_mhz(plcd_dimm_params->tCKmax_ps));
-       printf("all_DIMMs_burst_lengths_bitmask = %02X\n",
-              plcd_dimm_params->all_DIMMs_burst_lengths_bitmask);
+       printf("tckmin_x_ps = %u (%u MHz)\n",
+              plcd_dimm_params->tckmin_x_ps,
+              picos_to_mhz(plcd_dimm_params->tckmin_x_ps));
+       printf("tckmax_ps = %u (%u MHz)\n",
+              plcd_dimm_params->tckmax_ps,
+              picos_to_mhz(plcd_dimm_params->tckmax_ps));
+       printf("all_dimms_burst_lengths_bitmask = %02X\n",
+              plcd_dimm_params->all_dimms_burst_lengths_bitmask);
 
        print_option_table(options, n_opts, plcd_dimm_params);
 
@@ -421,9 +421,9 @@ static void fsl_ddr_options_edit(fsl_ddr_info_t *pinfo,
                CTRL_OPTIONS(memctl_interleaving),
                CTRL_OPTIONS(memctl_interleaving_mode),
                CTRL_OPTIONS(ba_intlv_ctl),
-               CTRL_OPTIONS(ECC_mode),
-               CTRL_OPTIONS(ECC_init_using_memctl),
-               CTRL_OPTIONS(DQS_config),
+               CTRL_OPTIONS(ecc_mode),
+               CTRL_OPTIONS(ecc_init_using_memctl),
+               CTRL_OPTIONS(dqs_config),
                CTRL_OPTIONS(self_refresh_in_sleep),
                CTRL_OPTIONS(dynamic_power),
                CTRL_OPTIONS(data_bus_width),
@@ -442,9 +442,10 @@ static void fsl_ddr_options_edit(fsl_ddr_info_t *pinfo,
                 * These can probably be changed to 2T_EN and 3T_EN
                 * (using a leading numerical character) without problem
                 */
-               CTRL_OPTIONS(twoT_en),
-               CTRL_OPTIONS(threeT_en),
+               CTRL_OPTIONS(twot_en),
+               CTRL_OPTIONS(threet_en),
                CTRL_OPTIONS(ap_en),
+               CTRL_OPTIONS(x4_en),
                CTRL_OPTIONS(bstopre),
                CTRL_OPTIONS(wrlvl_override),
                CTRL_OPTIONS(wrlvl_sample),
@@ -454,8 +455,8 @@ static void fsl_ddr_options_edit(fsl_ddr_info_t *pinfo,
                CTRL_OPTIONS(rcw_2),
                CTRL_OPTIONS(ddr_cdr1),
                CTRL_OPTIONS(ddr_cdr2),
-               CTRL_OPTIONS(tCKE_clock_pulse_width_ps),
-               CTRL_OPTIONS(tFAW_window_four_activates_ps),
+               CTRL_OPTIONS(tcke_clock_pulse_width_ps),
+               CTRL_OPTIONS(tfaw_window_four_activates_ps),
                CTRL_OPTIONS(trwt_override),
                CTRL_OPTIONS(trwt),
        };
@@ -665,9 +666,9 @@ static void print_memctl_options(const memctl_options_t *popts)
                CTRL_OPTIONS(memctl_interleaving),
                CTRL_OPTIONS(memctl_interleaving_mode),
                CTRL_OPTIONS_HEX(ba_intlv_ctl),
-               CTRL_OPTIONS(ECC_mode),
-               CTRL_OPTIONS(ECC_init_using_memctl),
-               CTRL_OPTIONS(DQS_config),
+               CTRL_OPTIONS(ecc_mode),
+               CTRL_OPTIONS(ecc_init_using_memctl),
+               CTRL_OPTIONS(dqs_config),
                CTRL_OPTIONS(self_refresh_in_sleep),
                CTRL_OPTIONS(dynamic_power),
                CTRL_OPTIONS(data_bus_width),
@@ -685,10 +686,11 @@ static void print_memctl_options(const memctl_options_t *popts)
                 * These can probably be changed to 2T_EN and 3T_EN
                 * (using a leading numerical character) without problem
                 */
-               CTRL_OPTIONS(twoT_en),
-               CTRL_OPTIONS(threeT_en),
+               CTRL_OPTIONS(twot_en),
+               CTRL_OPTIONS(threet_en),
                CTRL_OPTIONS(registered_dimm_en),
                CTRL_OPTIONS(ap_en),
+               CTRL_OPTIONS(x4_en),
                CTRL_OPTIONS(bstopre),
                CTRL_OPTIONS(wrlvl_override),
                CTRL_OPTIONS(wrlvl_sample),
@@ -698,8 +700,8 @@ static void print_memctl_options(const memctl_options_t *popts)
                CTRL_OPTIONS(rcw_2),
                CTRL_OPTIONS_HEX(ddr_cdr1),
                CTRL_OPTIONS_HEX(ddr_cdr2),
-               CTRL_OPTIONS(tCKE_clock_pulse_width_ps),
-               CTRL_OPTIONS(tFAW_window_four_activates_ps),
+               CTRL_OPTIONS(tcke_clock_pulse_width_ps),
+               CTRL_OPTIONS(tfaw_window_four_activates_ps),
                CTRL_OPTIONS(trwt_override),
                CTRL_OPTIONS(trwt),
        };
@@ -956,10 +958,10 @@ void ddr2_spd_dump(const ddr2_spd_eeprom_t *spd)
               " spd->tqhs,        * 45 Max Read DataHold skew tQHS *");
        printf("%-3d    : %02x %s\n", 46, spd->pll_relock,
               " spd->pll_relock,  * 46 PLL Relock time *");
-       printf("%-3d    : %02x %s\n", 47, spd->Tcasemax,
-              " spd->Tcasemax,    * 47 Tcasemax *");
-       printf("%-3d    : %02x %s\n", 48, spd->psiTAdram,
-              " spd->psiTAdram,   * 48 Thermal Resistance of DRAM Package "
+       printf("%-3d    : %02x %s\n", 47, spd->t_casemax,
+              " spd->t_casemax,    * 47 t_casemax *");
+       printf("%-3d    : %02x %s\n", 48, spd->psi_ta_dram,
+              " spd->psi_ta_dram,   * 48 Thermal Resistance of DRAM Package "
               "from Top (Case) to Ambient (Psi T-A DRAM) *");
        printf("%-3d    : %02x %s\n", 49, spd->dt0_mode,
               " spd->dt0_mode,    * 49 DRAM Case Temperature Rise from "
@@ -994,11 +996,11 @@ void ddr2_spd_dump(const ddr2_spd_eeprom_t *spd)
               " spd->dt7,         * 57 DRAM Case Temperature Rise from "
               "Ambient due to Bank Interleave Reads with "
               "Auto-Precharge (DT7) *");
-       printf("%-3d    : %02x %s\n", 58, spd->psiTApll,
-              " spd->psiTApll,    * 58 Thermal Resistance of PLL Package form"
+       printf("%-3d    : %02x %s\n", 58, spd->psi_ta_pll,
+              " spd->psi_ta_pll,    * 58 Thermal Resistance of PLL Package form"
               " Top (Case) to Ambient (Psi T-A PLL) *");
-       printf("%-3d    : %02x %s\n", 59, spd->psiTAreg,
-              " spd->psiTAreg,    * 59 Thermal Reisitance of Register Package"
+       printf("%-3d    : %02x %s\n", 59, spd->psi_ta_reg,
+              " spd->psi_ta_reg,    * 59 Thermal Reisitance of Register Package"
               " from Top (Case) to Ambient (Psi T-A Register) *");
        printf("%-3d    : %02x %s\n", 60, spd->dtpllactive,
               " spd->dtpllactive, * 60 PLL Case Temperature Rise from "
@@ -1085,43 +1087,43 @@ void ddr3_spd_dump(const ddr3_spd_eeprom_t *spd)
                "mtb_dividend   Medium Timebase (MTB) Dividend");
        PRINT_NXS(11, spd->mtb_divisor,
                "mtb_divisor    Medium Timebase (MTB) Divisor");
-       PRINT_NXS(12, spd->tCK_min,
-               "tCK_min        SDRAM Minimum Cycle Time");
+       PRINT_NXS(12, spd->tck_min,
+                 "tck_min        SDRAM Minimum Cycle Time");
        PRINT_NXS(13, spd->res_13,
                "res_13         Reserved");
        PRINT_NXS(14, spd->caslat_lsb,
                "caslat_lsb     CAS Latencies Supported, LSB");
        PRINT_NXS(15, spd->caslat_msb,
                "caslat_msb     CAS Latencies Supported, MSB");
-       PRINT_NXS(16, spd->tAA_min,
-               "tAA_min        Min CAS Latency Time");
-       PRINT_NXS(17, spd->tWR_min,
-               "tWR_min        Min Write REcovery Time");
-       PRINT_NXS(18, spd->tRCD_min,
-               "tRCD_min       Min RAS# to CAS# Delay Time");
-       PRINT_NXS(19, spd->tRRD_min,
-               "tRRD_min       Min Row Active to Row Active Delay Time");
-       PRINT_NXS(20, spd->tRP_min,
-               "tRP_min        Min Row Precharge Delay Time");
-       PRINT_NXS(21, spd->tRAS_tRC_ext,
-               "tRAS_tRC_ext   Upper Nibbles for tRAS and tRC");
-       PRINT_NXS(22, spd->tRAS_min_lsb,
-               "tRAS_min_lsb   Min Active to Precharge Delay Time, LSB");
-       PRINT_NXS(23, spd->tRC_min_lsb,
-               "tRC_min_lsb    Min Active to Active/Refresh Delay Time, LSB");
-       PRINT_NXS(24, spd->tRFC_min_lsb,
-               "tRFC_min_lsb   Min Refresh Recovery Delay Time LSB");
-       PRINT_NXS(25, spd->tRFC_min_msb,
-               "tRFC_min_msb   Min Refresh Recovery Delay Time MSB");
-       PRINT_NXS(26, spd->tWTR_min,
-               "tWTR_min       Min Internal Write to Read Command Delay Time");
-       PRINT_NXS(27, spd->tRTP_min,
-               "tRTP_min "
-               "Min Internal Read to Precharge Command Delay Time");
-       PRINT_NXS(28, spd->tFAW_msb,
-               "tFAW_msb       Upper Nibble for tFAW");
-       PRINT_NXS(29, spd->tFAW_min,
-               "tFAW_min       Min Four Activate Window Delay Time");
+       PRINT_NXS(16, spd->taa_min,
+                 "taa_min        Min CAS Latency Time");
+       PRINT_NXS(17, spd->twr_min,
+                 "twr_min        Min Write REcovery Time");
+       PRINT_NXS(18, spd->trcd_min,
+                 "trcd_min       Min RAS# to CAS# Delay Time");
+       PRINT_NXS(19, spd->trrd_min,
+                 "trrd_min       Min Row Active to Row Active Delay Time");
+       PRINT_NXS(20, spd->trp_min,
+                 "trp_min        Min Row Precharge Delay Time");
+       PRINT_NXS(21, spd->tras_trc_ext,
+                 "tras_trc_ext   Upper Nibbles for tRAS and tRC");
+       PRINT_NXS(22, spd->tras_min_lsb,
+                 "tras_min_lsb   Min Active to Precharge Delay Time, LSB");
+       PRINT_NXS(23, spd->trc_min_lsb,
+                 "trc_min_lsb Min Active to Active/Refresh Delay Time, LSB");
+       PRINT_NXS(24, spd->trfc_min_lsb,
+                 "trfc_min_lsb   Min Refresh Recovery Delay Time LSB");
+       PRINT_NXS(25, spd->trfc_min_msb,
+                 "trfc_min_msb   Min Refresh Recovery Delay Time MSB");
+       PRINT_NXS(26, spd->twtr_min,
+                 "twtr_min Min Internal Write to Read Command Delay Time");
+       PRINT_NXS(27, spd->trtp_min,
+                 "trtp_min "
+                 "Min Internal Read to Precharge Command Delay Time");
+       PRINT_NXS(28, spd->tfaw_msb,
+                 "tfaw_msb       Upper Nibble for tFAW");
+       PRINT_NXS(29, spd->tfaw_min,
+                 "tfaw_min       Min Four Activate Window Delay Time");
        PRINT_NXS(30, spd->opt_features,
                "opt_features   SDRAM Optional Features");
        PRINT_NXS(31, spd->therm_ref_opt,
@@ -1130,16 +1132,16 @@ void ddr3_spd_dump(const ddr3_spd_eeprom_t *spd)
                "therm_sensor  SDRAM Thermal Sensor");
        PRINT_NXS(33, spd->device_type,
                "device_type  SDRAM Device Type");
-       PRINT_NXS(34, spd->fine_tCK_min,
-               "fine_tCK_min  Fine offset for tCKmin");
-       PRINT_NXS(35, spd->fine_tAA_min,
-               "fine_tAA_min  Fine offset for tAAmin");
-       PRINT_NXS(36, spd->fine_tRCD_min,
-               "fine_tRCD_min Fine offset for tRCDmin");
-       PRINT_NXS(37, spd->fine_tRP_min,
-               "fine_tRP_min  Fine offset for tRPmin");
-       PRINT_NXS(38, spd->fine_tRC_min,
-               "fine_tRC_min  Fine offset for tRCmin");
+       PRINT_NXS(34, spd->fine_tck_min,
+                 "fine_tck_min  Fine offset for tCKmin");
+       PRINT_NXS(35, spd->fine_taa_min,
+                 "fine_taa_min  Fine offset for tAAmin");
+       PRINT_NXS(36, spd->fine_trcd_min,
+                 "fine_trcd_min Fine offset for tRCDmin");
+       PRINT_NXS(37, spd->fine_trp_min,
+                 "fine_trp_min  Fine offset for tRPmin");
+       PRINT_NXS(38, spd->fine_trc_min,
+                 "fine_trc_min  Fine offset for tRCmin");
 
        printf("%-3d-%3d: ",  39, 59);  /* Reserved, General Section */
 
@@ -1369,14 +1371,15 @@ struct data_strings {
 
 #define DATA_OPTIONS(name, step, dimm) {#name, step, dimm}
 
-unsigned long long fsl_ddr_interactive(fsl_ddr_info_t *pinfo)
-{
-       unsigned long long ddrsize;
-       const char *prompt = "FSL DDR>";
-       char buffer[CONFIG_SYS_CBSIZE];
-       char *argv[CONFIG_SYS_MAXARGS + 1];     /* NULL terminated */
-       int argc;
-       unsigned int next_step = STEP_GET_SPD;
+static unsigned int fsl_ddr_parse_interactive_cmd(
+       char **argv,
+       int argc,
+       unsigned int *pstep_mask,
+       unsigned int *pctlr_mask,
+       unsigned int *pdimm_mask,
+       unsigned int *pdimm_number_required
+        ) {
+
        static const struct data_strings options[] = {
                DATA_OPTIONS(spd, STEP_GET_SPD, 1),
                DATA_OPTIONS(dimmparms, STEP_COMPUTE_DIMM_PARMS, 1),
@@ -1386,6 +1389,69 @@ unsigned long long fsl_ddr_interactive(fsl_ddr_info_t *pinfo)
                DATA_OPTIONS(regs, STEP_COMPUTE_REGS, 0),
        };
        static const unsigned int n_opts = ARRAY_SIZE(options);
+
+       unsigned int i, j;
+       unsigned int error = 0;
+
+       for (i = 1; i < argc; i++) {
+               unsigned int matched = 0;
+
+               for (j = 0; j < n_opts; j++) {
+                       if (strcmp(options[j].data_name, argv[i]) != 0)
+                               continue;
+                       *pstep_mask |= options[j].step_mask;
+                       *pdimm_number_required =
+                               options[j].dimm_number_required;
+                       matched = 1;
+                       break;
+               }
+
+               if (matched)
+                       continue;
+
+               if (argv[i][0] == 'c') {
+                       char c = argv[i][1];
+                       if (isdigit(c))
+                               *pctlr_mask |= 1 << (c - '0');
+                       continue;
+               }
+
+               if (argv[i][0] == 'd') {
+                       char c = argv[i][1];
+                       if (isdigit(c))
+                               *pdimm_mask |= 1 << (c - '0');
+                       continue;
+               }
+
+               printf("unknown arg %s\n", argv[i]);
+               *pstep_mask = 0;
+               error = 1;
+               break;
+       }
+
+       return error;
+}
+
+int fsl_ddr_interactive_env_var_exists(void)
+{
+       char buffer[CONFIG_SYS_CBSIZE];
+
+       if (getenv_f("ddr_interactive", buffer, CONFIG_SYS_CBSIZE) >= 0)
+               return 1;
+
+       return 0;
+}
+
+unsigned long long fsl_ddr_interactive(fsl_ddr_info_t *pinfo, int var_is_set)
+{
+       unsigned long long ddrsize;
+       const char *prompt = "FSL DDR>";
+       char buffer[CONFIG_SYS_CBSIZE];
+       char buffer2[CONFIG_SYS_CBSIZE];
+       char *p = NULL;
+       char *argv[CONFIG_SYS_MAXARGS + 1];     /* NULL terminated */
+       int argc;
+       unsigned int next_step = STEP_GET_SPD;
        const char *usage = {
                "commands:\n"
                "print      print SPD and intermediate computed data\n"
@@ -1393,21 +1459,45 @@ unsigned long long fsl_ddr_interactive(fsl_ddr_info_t *pinfo)
                "recompute  reload SPD and options to default and recompute regs\n"
                "edit       modify spd, parameter, or option\n"
                "compute    recompute registers from current next_step to end\n"
+               "copy       copy parameters\n"
                "next_step  shows current next_step\n"
                "help       this message\n"
                "go         program the memory controller and continue with u-boot\n"
        };
 
+       if (var_is_set) {
+               if (getenv_f("ddr_interactive", buffer2, CONFIG_SYS_CBSIZE) > 0) {
+                       p = buffer2;
+               } else {
+                       var_is_set = 0;
+               }
+       }
+
        /*
         * The strategy for next_step is that it points to the next
         * step in the computation process that needs to be done.
         */
        while (1) {
-               /*
-                * No need to worry for buffer overflow here in
-                * this function;  readline() maxes out at CFG_CBSIZE
-                */
-               readline_into_buffer(prompt, buffer, 0);
+               if (var_is_set) {
+                       char *pend = strchr(p, ';');
+                       if (pend) {
+                               /* found command separator, copy sub-command */
+                               *pend = '\0';
+                               strcpy(buffer, p);
+                               p = pend + 1;
+                       } else {
+                               /* separator not found, copy whole string */
+                               strcpy(buffer, p);
+                               p = NULL;
+                               var_is_set = 0;
+                       }
+               } else {
+                       /*
+                        * No need to worry for buffer overflow here in
+                        * this function;  readline() maxes out at CFG_CBSIZE
+                        */
+                       readline_into_buffer(prompt, buffer, 0);
+               }
                argc = parse_line(buffer, argv);
                if (argc == 0)
                        continue;
@@ -1425,64 +1515,160 @@ unsigned long long fsl_ddr_interactive(fsl_ddr_info_t *pinfo)
                        continue;
                }
 
-               if (strcmp(argv[0], "edit") == 0) {
-                       unsigned int i, j;
+               if (strcmp(argv[0], "copy") == 0) {
                        unsigned int error = 0;
                        unsigned int step_mask = 0;
-                       unsigned int ctlr_mask = 0;
-                       unsigned int dimm_mask = 0;
-                       char *p_element = NULL;
-                       char *p_value = NULL;
+                       unsigned int src_ctlr_mask = 0;
+                       unsigned int src_dimm_mask = 0;
                        unsigned int dimm_number_required = 0;
-                       unsigned int ctrl_num;
-                       unsigned int dimm_num;
-                       unsigned int matched = 0;
+                       unsigned int src_ctlr_num = 0;
+                       unsigned int src_dimm_num = 0;
+                       unsigned int dst_ctlr_num = -1;
+                       unsigned int dst_dimm_num = -1;
+                       unsigned int i, num_dest_parms;
 
                        if (argc == 1) {
-                               /* Only the element and value must be last */
-                               printf("edit <c#> <d#> "
-                                       "<spd|dimmparms|commonparms|opts|"
-                                       "addresses|regs> <element> <value>\n");
-                               printf("for spd, specify byte number for "
-                                       "element\n");
+                               printf("copy <src c#> <src d#> <spd|dimmparms|commonparms|opts|addresses|regs> <dst c#> <dst d#>\n");
                                continue;
                        }
 
-                       for (i = 1; i < argc - 2; i++) {
-                               for (j = 0; j < n_opts; j++) {
-                                       if (strcmp(options[j].data_name,
-                                               argv[i]) != 0)
-                                               continue;
-                                       step_mask |= options[j].step_mask;
-                                       dimm_number_required =
-                                               options[j].dimm_number_required;
-                                       matched = 1;
-                                       break;
+                       error = fsl_ddr_parse_interactive_cmd(
+                               argv, argc,
+                               &step_mask,
+                               &src_ctlr_mask,
+                               &src_dimm_mask,
+                               &dimm_number_required
+                       );
+
+                       /* XXX: only dimm_number_required and step_mask will
+                          be used by this function.  Parse the controller and
+                          DIMM number separately because it is easier.  */
+
+                       if (error)
+                               continue;
+
+                       /* parse source destination controller / DIMM */
+
+                       num_dest_parms = dimm_number_required ? 2 : 1;
+
+                       for (i = 0; i < argc; i++) {
+                               if (argv[i][0] == 'c') {
+                                       char c = argv[i][1];
+                                       if (isdigit(c)) {
+                                               src_ctlr_num = (c - '0');
+                                               break;
+                                       }
                                }
+                       }
 
-                               if (matched)
-                                       continue;
+                       for (i = 0; i < argc; i++) {
+                               if (argv[i][0] == 'd') {
+                                       char c = argv[i][1];
+                                       if (isdigit(c)) {
+                                               src_dimm_num = (c - '0');
+                                               break;
+                                       }
+                               }
+                       }
+
+                       /* parse destination controller / DIMM */
 
+                       for (i = argc - 1; i >= argc - num_dest_parms; i--) {
                                if (argv[i][0] == 'c') {
                                        char c = argv[i][1];
-                                       if (isdigit(c))
-                                               ctlr_mask |= 1 << (c - '0');
-                                       continue;
+                                       if (isdigit(c)) {
+                                               dst_ctlr_num = (c - '0');
+                                               break;
+                                       }
                                }
+                       }
 
+                       for (i = argc - 1; i >= argc - num_dest_parms; i--) {
                                if (argv[i][0] == 'd') {
                                        char c = argv[i][1];
-                                       if (isdigit(c))
-                                               dimm_mask |= 1 << (c - '0');
-                                       continue;
+                                       if (isdigit(c)) {
+                                               dst_dimm_num = (c - '0');
+                                               break;
+                                       }
                                }
+                       }
+
+                       /* TODO: validate inputs */
+
+                       debug("src_ctlr_num = %u, src_dimm_num = %u, dst_ctlr_num = %u, dst_dimm_num = %u, step_mask = %x\n",
+                               src_ctlr_num, src_dimm_num, dst_ctlr_num, dst_dimm_num, step_mask);
 
-                               printf("unknown arg %s\n", argv[i]);
-                               step_mask = 0;
-                               error = 1;
+
+                       switch (step_mask) {
+
+                       case STEP_GET_SPD:
+                               memcpy(&(pinfo->spd_installed_dimms[dst_ctlr_num][dst_dimm_num]),
+                                       &(pinfo->spd_installed_dimms[src_ctlr_num][src_dimm_num]),
+                                       sizeof(pinfo->spd_installed_dimms[0][0]));
                                break;
+
+                       case STEP_COMPUTE_DIMM_PARMS:
+                               memcpy(&(pinfo->dimm_params[dst_ctlr_num][dst_dimm_num]),
+                                       &(pinfo->dimm_params[src_ctlr_num][src_dimm_num]),
+                                       sizeof(pinfo->dimm_params[0][0]));
+                               break;
+
+                       case STEP_COMPUTE_COMMON_PARMS:
+                               memcpy(&(pinfo->common_timing_params[dst_ctlr_num]),
+                                       &(pinfo->common_timing_params[src_ctlr_num]),
+                                       sizeof(pinfo->common_timing_params[0]));
+                               break;
+
+                       case STEP_GATHER_OPTS:
+                               memcpy(&(pinfo->memctl_opts[dst_ctlr_num]),
+                                       &(pinfo->memctl_opts[src_ctlr_num]),
+                                       sizeof(pinfo->memctl_opts[0]));
+                               break;
+
+                       /* someday be able to have addresses to copy addresses... */
+
+                       case STEP_COMPUTE_REGS:
+                               memcpy(&(pinfo->fsl_ddr_config_reg[dst_ctlr_num]),
+                                       &(pinfo->fsl_ddr_config_reg[src_ctlr_num]),
+                                       sizeof(pinfo->memctl_opts[0]));
+                               break;
+
+                       default:
+                               printf("unexpected step_mask value\n");
+                       }
+
+                       continue;
+
+               }
+
+               if (strcmp(argv[0], "edit") == 0) {
+                       unsigned int error = 0;
+                       unsigned int step_mask = 0;
+                       unsigned int ctlr_mask = 0;
+                       unsigned int dimm_mask = 0;
+                       char *p_element = NULL;
+                       char *p_value = NULL;
+                       unsigned int dimm_number_required = 0;
+                       unsigned int ctrl_num;
+                       unsigned int dimm_num;
+
+                       if (argc == 1) {
+                               /* Only the element and value must be last */
+                               printf("edit <c#> <d#> "
+                                       "<spd|dimmparms|commonparms|opts|"
+                                       "addresses|regs> <element> <value>\n");
+                               printf("for spd, specify byte number for "
+                                       "element\n");
+                               continue;
                        }
 
+                       error = fsl_ddr_parse_interactive_cmd(
+                               argv, argc - 2,
+                               &step_mask,
+                               &ctlr_mask,
+                               &dimm_mask,
+                               &dimm_number_required
+                       );
 
                        if (error)
                                continue;
@@ -1629,12 +1815,11 @@ unsigned long long fsl_ddr_interactive(fsl_ddr_info_t *pinfo)
                }
 
                if (strcmp(argv[0], "print") == 0) {
-                       unsigned int i, j;
                        unsigned int error = 0;
                        unsigned int step_mask = 0;
                        unsigned int ctlr_mask = 0;
                        unsigned int dimm_mask = 0;
-                       unsigned int matched = 0;
+                       unsigned int dimm_number_required = 0;
 
                        if (argc == 1) {
                                printf("print [c<n>] [d<n>] [spd] [dimmparms] "
@@ -1642,38 +1827,13 @@ unsigned long long fsl_ddr_interactive(fsl_ddr_info_t *pinfo)
                                continue;
                        }
 
-                       for (i = 1; i < argc; i++) {
-                               for (j = 0; j < n_opts; j++) {
-                                       if (strcmp(options[j].data_name,
-                                               argv[i]) != 0)
-                                               continue;
-                                       step_mask |= options[j].step_mask;
-                                       matched = 1;
-                                       break;
-                               }
-
-                               if (matched)
-                                       continue;
-
-                               if (argv[i][0] == 'c') {
-                                       char c = argv[i][1];
-                                       if (isdigit(c))
-                                               ctlr_mask |= 1 << (c - '0');
-                                       continue;
-                               }
-
-                               if (argv[i][0] == 'd') {
-                                       char c = argv[i][1];
-                                       if (isdigit(c))
-                                               dimm_mask |= 1 << (c - '0');
-                                       continue;
-                               }
-
-                               printf("unknown arg %s\n", argv[i]);
-                               step_mask = 0;
-                               error = 1;
-                               break;
-                       }
+                       error = fsl_ddr_parse_interactive_cmd(
+                               argv, argc,
+                               &step_mask,
+                               &ctlr_mask,
+                               &dimm_mask,
+                               &dimm_number_required
+                       );
 
                        if (error)
                                continue;