]> git.sur5r.net Git - u-boot/blobdiff - arch/x86/cpu/mp_init.c
dm: core: Replace of_offset with accessor
[u-boot] / arch / x86 / cpu / mp_init.c
index 7917350bff267acd988d68065b35269e00e84729..988073cc7953f188cf1ffc7758263df83934b437 100644 (file)
 #include <dm.h>
 #include <errno.h>
 #include <malloc.h>
+#include <qfw.h>
 #include <asm/atomic.h>
 #include <asm/cpu.h>
 #include <asm/interrupt.h>
 #include <asm/lapic.h>
+#include <asm/microcode.h>
 #include <asm/mp.h>
 #include <asm/msr.h>
 #include <asm/mtrr.h>
 #include <asm/processor.h>
 #include <asm/sipi.h>
-#include <asm/fw_cfg.h>
 #include <dm/device-internal.h>
 #include <dm/uclass-internal.h>
 #include <dm/lists.h>
@@ -195,7 +196,7 @@ static int save_bsp_msrs(char *start, int size)
        msr_count = 2 * num_var_mtrrs + NUM_FIXED_MTRRS + 1;
 
        if ((msr_count * sizeof(struct saved_msr)) > size) {
-               printf("Cannot mirror all %d msrs.\n", msr_count);
+               printf("Cannot mirror all %d msrs\n", msr_count);
                return -ENOSPC;
        }
 
@@ -243,12 +244,14 @@ static int load_sipi_vector(atomic_t **ap_countp, int num_cpus)
 
        params->stack_size = CONFIG_AP_STACK_SIZE;
        size = params->stack_size * num_cpus;
-       stack = memalign(size, 4096);
+       stack = memalign(4096, size);
        if (!stack)
                return -ENOMEM;
        params->stack_top = (u32)(stack + size);
-
-       params->microcode_ptr = 0;
+#if !defined(CONFIG_QEMU) && !defined(CONFIG_HAVE_FSP)
+       params->microcode_ptr = ucode_base;
+       debug("Microcode at %x\n", params->microcode_ptr);
+#endif
        params->msr_table_ptr = (u32)msr_save;
        ret = save_bsp_msrs(msr_save, sizeof(msr_save));
        if (ret < 0)
@@ -283,21 +286,25 @@ static int check_cpu_devices(int expected_cpus)
 }
 
 /* Returns 1 for timeout. 0 on success */
-static int apic_wait_timeout(int total_delay, int delay_step)
+static int apic_wait_timeout(int total_delay, const char *msg)
 {
        int total = 0;
-       int timeout = 0;
 
+       if (!(lapic_read(LAPIC_ICR) & LAPIC_ICR_BUSY))
+               return 0;
+
+       debug("Waiting for %s...", msg);
        while (lapic_read(LAPIC_ICR) & LAPIC_ICR_BUSY) {
-               udelay(delay_step);
-               total += delay_step;
+               udelay(50);
+               total += 50;
                if (total >= total_delay) {
-                       timeout = 1;
-                       break;
+                       debug("timed out: aborting\n");
+                       return -ETIMEDOUT;
                }
        }
+       debug("done\n");
 
-       return timeout;
+       return 0;
 }
 
 static int start_aps(int ap_count, atomic_t *num_aps)
@@ -320,73 +327,42 @@ static int start_aps(int ap_count, atomic_t *num_aps)
 
        debug("Attempting to start %d APs\n", ap_count);
 
-       if ((lapic_read(LAPIC_ICR) & LAPIC_ICR_BUSY)) {
-               debug("Waiting for ICR not to be busy...");
-               if (apic_wait_timeout(1000, 50)) {
-                       debug("timed out. Aborting.\n");
-                       return -1;
-               } else {
-                       debug("done.\n");
-               }
-       }
+       if (apic_wait_timeout(1000, "ICR not to be busy"))
+               return -ETIMEDOUT;
 
        /* Send INIT IPI to all but self */
        lapic_write(LAPIC_ICR2, SET_LAPIC_DEST_FIELD(0));
        lapic_write(LAPIC_ICR, LAPIC_DEST_ALLBUT | LAPIC_INT_ASSERT |
                    LAPIC_DM_INIT);
-       debug("Waiting for 10ms after sending INIT.\n");
+       debug("Waiting for 10ms after sending INIT\n");
        mdelay(10);
 
        /* Send 1st SIPI */
-       if ((lapic_read(LAPIC_ICR) & LAPIC_ICR_BUSY)) {
-               debug("Waiting for ICR not to be busy...");
-               if (apic_wait_timeout(1000, 50)) {
-                       debug("timed out. Aborting.\n");
-                       return -1;
-               } else {
-                       debug("done.\n");
-               }
-       }
+       if (apic_wait_timeout(1000, "ICR not to be busy"))
+               return -ETIMEDOUT;
 
        lapic_write(LAPIC_ICR2, SET_LAPIC_DEST_FIELD(0));
        lapic_write(LAPIC_ICR, LAPIC_DEST_ALLBUT | LAPIC_INT_ASSERT |
                    LAPIC_DM_STARTUP | sipi_vector);
-       debug("Waiting for 1st SIPI to complete...");
-       if (apic_wait_timeout(10000, 50)) {
-               debug("timed out.\n");
-               return -1;
-       } else {
-               debug("done.\n");
-       }
+       if (apic_wait_timeout(10000, "first SIPI to complete"))
+               return -ETIMEDOUT;
 
        /* Wait for CPUs to check in up to 200 us */
        wait_for_aps(num_aps, ap_count, 200, 15);
 
        /* Send 2nd SIPI */
-       if ((lapic_read(LAPIC_ICR) & LAPIC_ICR_BUSY)) {
-               debug("Waiting for ICR not to be busy...");
-               if (apic_wait_timeout(1000, 50)) {
-                       debug("timed out. Aborting.\n");
-                       return -1;
-               } else {
-                       debug("done.\n");
-               }
-       }
+       if (apic_wait_timeout(1000, "ICR not to be busy"))
+               return -ETIMEDOUT;
 
        lapic_write(LAPIC_ICR2, SET_LAPIC_DEST_FIELD(0));
        lapic_write(LAPIC_ICR, LAPIC_DEST_ALLBUT | LAPIC_INT_ASSERT |
                    LAPIC_DM_STARTUP | sipi_vector);
-       debug("Waiting for 2nd SIPI to complete...");
-       if (apic_wait_timeout(10000, 50)) {
-               debug("timed out.\n");
-               return -1;
-       } else {
-               debug("done.\n");
-       }
+       if (apic_wait_timeout(10000, "second SIPI to complete"))
+               return -ETIMEDOUT;
 
        /* Wait for CPUs to check in */
        if (wait_for_aps(num_aps, ap_count, 10000, 50)) {
-               debug("Not all APs checked in: %d/%d.\n",
+               debug("Not all APs checked in: %d/%d\n",
                      atomic_read(num_aps), ap_count);
                return -1;
        }
@@ -410,7 +386,7 @@ static int bsp_do_flight_plan(struct udevice *cpu, struct mp_params *mp_params)
                        /* Wait for the APs to check in */
                        if (wait_for_aps(&rec->cpus_entered, num_aps,
                                         timeout_us, step_us)) {
-                               debug("MP record %d timeout.\n", i);
+                               debug("MP record %d timeout\n", i);
                                ret = -1;
                        }
                }
@@ -430,9 +406,7 @@ static int init_bsp(struct udevice **devp)
        int ret;
 
        cpu_get_name(processor_name);
-       debug("CPU: %s.\n", processor_name);
-
-       lapic_setup();
+       debug("CPU: %s\n", processor_name);
 
        apic_id = lapicid();
        ret = find_cpu_by_apic_id(apic_id, devp);
@@ -444,7 +418,7 @@ static int init_bsp(struct udevice **devp)
        return 0;
 }
 
-#ifdef CONFIG_QEMU
+#ifdef CONFIG_QFW
 static int qemu_cpu_fixup(void)
 {
        int ret;
@@ -520,7 +494,7 @@ int mp_init(struct mp_params *p)
        if (ret)
                return ret;
 
-#ifdef CONFIG_QEMU
+#ifdef CONFIG_QFW
        ret = qemu_cpu_fixup();
        if (ret)
                return ret;
@@ -587,12 +561,17 @@ int mp_init(struct mp_params *p)
 
 int mp_init_cpu(struct udevice *cpu, void *unused)
 {
+       struct cpu_platdata *plat = dev_get_parent_platdata(cpu);
+
        /*
         * Multiple APs are brought up simultaneously and they may get the same
         * seq num in the uclass_resolve_seq() during device_probe(). To avoid
         * this, set req_seq to the reg number in the device tree in advance.
         */
-       cpu->req_seq = fdtdec_get_int(gd->fdt_blob, cpu->of_offset, "reg", -1);
+       cpu->req_seq = fdtdec_get_int(gd->fdt_blob, dev_of_offset(cpu), "reg",
+                                     -1);
+       plat->ucode_version = microcode_read_rev();
+       plat->device_id = gd->arch.x86_device;
 
        return device_probe(cpu);
 }