SPDX: Convert all of our single license tags to Linux Kernel style

[u-boot] / cmd / mtdparts.c

diff --git a/cmd/mtdparts.c b/cmd/mtdparts.c
index d3fde77ef0cb91587fb462bbd40f23e47b5a2f76..c4010091338fe30e9531917b9622fa2686214123 100644 (file)
--- a/cmd/mtdparts.c
+++ b/cmd/mtdparts.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * (C) Copyright 2002
  * Wolfgang Denk, DENX Software Engineering, wd@denx.de.
@@ -20,8 +21,6 @@
  *
  *   $Id: cmdlinepart.c,v 1.17 2004/11/26 11:18:47 lavinen Exp $
  *   Copyright 2002 SYSGO Real-Time Solutions GmbH
- *
- * SPDX-License-Identifier:    GPL-2.0+
  */
 
 /*
@@ -81,7 +80,7 @@
 #include <linux/mtd/mtd.h>
 
 #if defined(CONFIG_CMD_NAND)
-#include <linux/mtd/nand.h>
+#include <linux/mtd/rawnand.h>
 #include <nand.h>
 #endif
 
@@ -133,9 +132,9 @@ static const char *mtdparts_default = MTDPARTS_DEFAULT;
 #define MTDIDS_MAXLEN          128
 #define MTDPARTS_MAXLEN                512
 #define PARTITION_MAXLEN       16
-static char last_ids[MTDIDS_MAXLEN];
-static char last_parts[MTDPARTS_MAXLEN];
-static char last_partition[PARTITION_MAXLEN];
+static char last_ids[MTDIDS_MAXLEN + 1];
+static char last_parts[MTDPARTS_MAXLEN + 1];
+static char last_partition[PARTITION_MAXLEN + 1];
 
 /* low level jffs2 cache cleaning routine */
 extern void jffs2_free_cache(struct part_info *part);
@@ -240,15 +239,22 @@ static void index_partitions(void)
                        if (dev == current_mtd_dev) {
                                mtddevnum += current_mtd_partnum;
                                env_set_ulong("mtddevnum", mtddevnum);
+                               debug("=> mtddevnum %d,\n", mtddevnum);
                                break;
                        }
                        mtddevnum += dev->num_parts;
                }
 
                part = mtd_part_info(current_mtd_dev, current_mtd_partnum);
-               env_set("mtddevname", part->name);
+               if (part) {
+                       env_set("mtddevname", part->name);
+
+                       debug("=> mtddevname %s\n", part->name);
+               } else {
+                       env_set("mtddevname", NULL);
 
-               debug("=> mtddevnum %d,\n=> mtddevname %s\n", mtddevnum, part->name);
+                       debug("=> mtddevname NULL\n");
+               }
        } else {
                env_set("mtddevnum", NULL);
                env_set("mtddevname", NULL);
@@ -866,15 +872,12 @@ static int device_parse(const char *const mtd_dev, const char **ret, struct mtd_
                return 1;
        }
 
-#ifdef DEBUG
        pend = strchr(p, ';');
-#endif
        debug("dev type = %d (%s), dev num = %d, mtd-id = %s\n",
                        id->type, MTD_DEV_TYPE(id->type),
                        id->num, id->mtd_id);
        debug("parsing partitions %.*s\n", (int)(pend ? pend - p : strlen(p)), p);
 
-
        /* parse partitions */
        num_parts = 0;
 
@@ -912,12 +915,6 @@ static int device_parse(const char *const mtd_dev, const char **ret, struct mtd_
                return 1;
        }
 
-       if (num_parts == 0) {
-               printf("no partitions for device %s%d (%s)\n",
-                               MTD_DEV_TYPE(id->type), id->num, id->mtd_id);
-               return 1;
-       }
-
        debug("\ntotal partitions: %d\n", num_parts);
 
        /* check for next device presence */
@@ -1533,11 +1530,11 @@ static int spread_partitions(void)
  * @param buf temporary buffer pointer MTDPARTS_MAXLEN long
  * @return mtdparts variable string, NULL if not found
  */
-static const char *getenv_mtdparts(char *buf)
+static const char *env_get_mtdparts(char *buf)
 {
        if (gd->flags & GD_FLG_ENV_READY)
-               return getenv("mtdparts");
-       if (getenv_f("mtdparts", buf, MTDPARTS_MAXLEN) != -1)
+               return env_get("mtdparts");
+       if (env_get_f("mtdparts", buf, MTDPARTS_MAXLEN) != -1)
                return buf;
        return NULL;
 }
@@ -1565,7 +1562,7 @@ static int parse_mtdparts(const char *const mtdparts)
        }
 
        /* re-read 'mtdparts' variable, mtd_devices_init may be updating env */
-       p = getenv_mtdparts(tmp_parts);
+       p = env_get_mtdparts(tmp_parts);
        if (!p)
                p = mtdparts;
 
@@ -1593,8 +1590,10 @@ static int parse_mtdparts(const char *const mtdparts)
                list_add_tail(&dev->link, &devices);
                err = 0;
        }
-       if (err == 1)
+       if (err == 1) {
+               free(dev);
                device_delall(&devices);
+       }
 
        return err;
 }
@@ -1723,16 +1722,16 @@ int mtdparts_init(void)
        const char *ids, *parts;
        const char *current_partition;
        int ids_changed;
-       char tmp_ep[PARTITION_MAXLEN];
+       char tmp_ep[PARTITION_MAXLEN + 1];
        char tmp_parts[MTDPARTS_MAXLEN];
 
        debug("\n---mtdparts_init---\n");
        if (!initialized) {
                INIT_LIST_HEAD(&mtdids);
                INIT_LIST_HEAD(&devices);
-               memset(last_ids, 0, MTDIDS_MAXLEN);
-               memset(last_parts, 0, MTDPARTS_MAXLEN);
-               memset(last_partition, 0, PARTITION_MAXLEN);
+               memset(last_ids, 0, sizeof(last_ids));
+               memset(last_parts, 0, sizeof(last_parts));
+               memset(last_partition, 0, sizeof(last_partition));
 #if defined(CONFIG_SYS_MTDPARTS_RUNTIME)
                board_mtdparts_default(&mtdids_default, &mtdparts_default);
 #endif
@@ -1741,13 +1740,14 @@ int mtdparts_init(void)
        }
 
        /* get variables */
-       ids = getenv("mtdids");
-       parts = getenv_mtdparts(tmp_parts);
-       current_partition = getenv("partition");
+       ids = env_get("mtdids");
+       parts = env_get_mtdparts(tmp_parts);
+       current_partition = env_get("partition");
 
        /* save it for later parsing, cannot rely on current partition pointer
         * as 'partition' variable may be updated during init */
-       tmp_ep[0] = '\0';
+       memset(tmp_parts, 0, sizeof(tmp_parts));
+       memset(tmp_ep, 0, sizeof(tmp_ep));
        if (current_partition)
                strncpy(tmp_ep, current_partition, PARTITION_MAXLEN);
 
@@ -1850,7 +1850,7 @@ int mtdparts_init(void)
                        current_mtd_partnum = pnum;
                        current_save();
                }
-       } else if (getenv("partition") == NULL) {
+       } else if (env_get("partition") == NULL) {
                debug("no partition variable set, setting...\n");
                current_save();
        }