]> git.sur5r.net Git - u-boot/blobdiff - common/spl/spl_mmc.c
spl: spl_mmc: Minor cosmetics
[u-boot] / common / spl / spl_mmc.c
index 7bae16beba064472c5f4ebd48d17d4e63b3b78fc..f5ac844c0a3a0bf95e8413960eeab3311f0b6289 100644 (file)
@@ -8,25 +8,25 @@
  */
 #include <common.h>
 #include <spl.h>
+#include <linux/compiler.h>
 #include <asm/u-boot.h>
 #include <mmc.h>
-#include <version.h>
 #include <image.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
 static int mmc_load_image_raw_sector(struct mmc *mmc, unsigned long sector)
 {
-       unsigned long err;
+       unsigned long count;
        u32 image_size_sectors;
        struct image_header *header;
 
        header = (struct image_header *)(CONFIG_SYS_TEXT_BASE -
-                                               sizeof(struct image_header));
+                                        sizeof(struct image_header));
 
        /* read image header to find the image size & load address */
-       err = mmc->block_dev.block_read(0, sector, 1, header);
-       if (err == 0)
+       count = mmc->block_dev.block_read(0, sector, 1, header);
+       if (count == 0)
                goto end;
 
        if (image_get_magic(header) != IH_MAGIC)
@@ -36,29 +36,33 @@ static int mmc_load_image_raw_sector(struct mmc *mmc, unsigned long sector)
 
        /* convert size to sectors - round up */
        image_size_sectors = (spl_image.size + mmc->read_bl_len - 1) /
-                               mmc->read_bl_len;
+                            mmc->read_bl_len;
 
        /* Read the header too to avoid extra memcpy */
-       err = mmc->block_dev.block_read(0, sector, image_size_sectors,
-                                       (void *)spl_image.load_addr);
+       count = mmc->block_dev.block_read(0, sector, image_size_sectors,
+                                         (void *) spl_image.load_addr);
 
 end:
+       if (count == 0) {
 #ifdef CONFIG_SPL_LIBCOMMON_SUPPORT
-       if (err == 0)
-               printf("spl: mmc blk read err - %lu\n", err);
+               puts("spl: mmc block read error\n");
 #endif
+               return -1;
+       }
 
-       return (err == 0);
+       return 0;
 }
 
 #ifdef CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION
 static int mmc_load_image_raw_partition(struct mmc *mmc, int partition)
 {
        disk_partition_t info;
+       int err;
 
-       if (get_partition_info(&mmc->block_dev, partition, &info)) {
+       err = get_partition_info(&mmc->block_dev, partition, &info);
+       if (err) {
 #ifdef CONFIG_SPL_LIBCOMMON_SUPPORT
-               printf("spl: partition error\n");
+               puts("spl: partition error\n");
 #endif
                return -1;
        }
@@ -70,33 +74,38 @@ static int mmc_load_image_raw_partition(struct mmc *mmc, int partition)
 #ifdef CONFIG_SPL_OS_BOOT
 static int mmc_load_image_raw_os(struct mmc *mmc)
 {
-       if (!mmc->block_dev.block_read(0,
-                                      CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR,
-                                      CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTORS,
-                                      (void *)CONFIG_SYS_SPL_ARGS_ADDR)) {
+       unsigned long count;
+
+       count = mmc->block_dev.block_read(0,
+               CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR,
+               CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTORS,
+               (void *) CONFIG_SYS_SPL_ARGS_ADDR);
+       if (count == 0) {
 #ifdef CONFIG_SPL_LIBCOMMON_SUPPORT
-               printf("mmc args blk read error\n");
+               puts("spl: mmc block read error\n");
 #endif
                return -1;
        }
 
        return mmc_load_image_raw_sector(mmc,
-                                               CONFIG_SYS_MMCSD_RAW_MODE_KERNEL_SECTOR);
+               CONFIG_SYS_MMCSD_RAW_MODE_KERNEL_SECTOR);
 }
 #endif
 
 void spl_mmc_load_image(void)
 {
        struct mmc *mmc;
-       int err;
        u32 boot_mode;
+       int err;
+       __maybe_unused int part;
 
        mmc_initialize(gd->bd);
+
        /* We register only one device. So, the dev id is always 0 */
        mmc = find_mmc_device(0);
        if (!mmc) {
 #ifdef CONFIG_SPL_LIBCOMMON_SUPPORT
-               puts("spl: mmc device not found!!\n");
+               puts("spl: mmc device not found\n");
 #endif
                hang();
        }
@@ -104,16 +113,22 @@ void spl_mmc_load_image(void)
        err = mmc_init(mmc);
        if (err) {
 #ifdef CONFIG_SPL_LIBCOMMON_SUPPORT
-               printf("spl: mmc init failed: err - %d\n", err);
+               printf("spl: mmc init failed with error: %d\n", err);
 #endif
                hang();
        }
 
        boot_mode = spl_boot_mode();
-       if (boot_mode == MMCSD_MODE_RAW) {
-               debug("boot mode - RAW\n");
+       switch (boot_mode) {
+       case MMCSD_MODE_RAW:
+               debug("spl: mmc boot mode: raw\n");
+
 #ifdef CONFIG_SPL_OS_BOOT
-               if (spl_start_uboot() || mmc_load_image_raw_os(mmc))
+               if (!spl_start_uboot()) {
+                       err = mmc_load_image_raw_os(mmc);
+                       if (!err)
+                               return;
+               }
 #endif
 #ifdef CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION
                err = mmc_load_image_raw_partition(mmc,
@@ -122,63 +137,87 @@ void spl_mmc_load_image(void)
                err = mmc_load_image_raw_sector(mmc,
                        CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR);
 #endif
+               if (!err)
+                       return;
 #if defined(CONFIG_SPL_FAT_SUPPORT) || defined(CONFIG_SPL_EXT_SUPPORT)
-       }
-       if (err || boot_mode == MMCSD_MODE_FS) {
-               debug("boot mode - FS\n");
+       case MMCSD_MODE_FS:
+               debug("spl: mmc boot mode: fs\n");
+
 #ifdef CONFIG_SPL_FAT_SUPPORT
 #ifdef CONFIG_SPL_OS_BOOT
-               if (spl_start_uboot() || spl_load_image_fat_os(&mmc->block_dev,
-                                                               CONFIG_SYS_MMCSD_FS_BOOT_PARTITION))
+               if (!spl_start_uboot()) {
+                       err = spl_load_image_fat_os(&mmc->block_dev,
+                               CONFIG_SYS_MMCSD_FS_BOOT_PARTITION);
+                       if (!err)
+                               return;
+               }
 #endif
                err = spl_load_image_fat(&mmc->block_dev,
-                                       CONFIG_SYS_MMCSD_FS_BOOT_PARTITION,
-                                       CONFIG_SPL_FS_LOAD_PAYLOAD_NAME);
-               if(err)
-#endif /* CONFIG_SPL_FAT_SUPPORT */
-               {
+                                        CONFIG_SYS_MMCSD_FS_BOOT_PARTITION,
+                                        CONFIG_SPL_FS_LOAD_PAYLOAD_NAME);
+               if (!err)
+                       return;
+#endif
 #ifdef CONFIG_SPL_EXT_SUPPORT
 #ifdef CONFIG_SPL_OS_BOOT
-               if (spl_start_uboot() || spl_load_image_ext_os(&mmc->block_dev,
-                                                               CONFIG_SYS_MMCSD_FS_BOOT_PARTITION))
+               if (!spl_start_uboot()) {
+                       err = spl_load_image_ext_os(&mmc->block_dev,
+                               CONFIG_SYS_MMCSD_FS_BOOT_PARTITION);
+                       if (!err)
+                               return;
+               }
 #endif
                err = spl_load_image_ext(&mmc->block_dev,
-                                       CONFIG_SYS_MMCSD_FS_BOOT_PARTITION,
-                                       CONFIG_SPL_FS_LOAD_PAYLOAD_NAME);
-#endif /* CONFIG_SPL_EXT_SUPPORT */
-               }
-#endif /* defined(CONFIG_SPL_FAT_SUPPORT) || defined(CONFIG_SPL_EXT_SUPPORT) */
+                                        CONFIG_SYS_MMCSD_FS_BOOT_PARTITION,
+                                        CONFIG_SPL_FS_LOAD_PAYLOAD_NAME);
+               if (!err)
+                       return;
+#endif
+#endif
 #ifdef CONFIG_SUPPORT_EMMC_BOOT
-       } else if (boot_mode == MMCSD_MODE_EMMCBOOT) {
+       case MMCSD_MODE_EMMCBOOT:
                /*
                 * We need to check what the partition is configured to.
                 * 1 and 2 match up to boot0 / boot1 and 7 is user data
                 * which is the first physical partition (0).
                 */
-               int part = (mmc->part_config >> 3) & PART_ACCESS_MASK;
+               part = (mmc->part_config >> 3) & PART_ACCESS_MASK;
 
                if (part == 7)
                        part = 0;
 
                if (mmc_switch_part(0, part)) {
 #ifdef CONFIG_SPL_LIBCOMMON_SUPPORT
-                       puts("MMC partition switch failed\n");
+                       puts("spl: mmc partition switch failed\n");
 #endif
                        hang();
                }
+
 #ifdef CONFIG_SPL_OS_BOOT
-               if (spl_start_uboot() || mmc_load_image_raw_os(mmc))
+               if (!spl_start_uboot()) {
+                       err = mmc_load_image_raw_os(mmc);
+                       if (!err)
+                               return;
+               }
 #endif
+#ifdef CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION
+               err = mmc_load_image_raw_partition(mmc,
+                       CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION);
+#else
                err = mmc_load_image_raw_sector(mmc,
                        CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR);
 #endif
-       } else {
+               if (!err)
+                       return;
+#endif
+       case MMCSD_MODE_UNDEFINED:
+       default:
 #ifdef CONFIG_SPL_LIBCOMMON_SUPPORT
-               puts("spl: wrong MMC boot mode\n");
+               if (err)
+                       puts("spl: mmc: no boot mode left to try\n");
+               else
+                       puts("spl: mmc: wrong boot mode\n");
 #endif
                hang();
        }
-
-       if (err)
-               hang();
 }