]> git.sur5r.net Git - u-boot/blobdiff - common/usb_kbd.c
mkimage: Sort the option processing code by option
[u-boot] / common / usb_kbd.c
index 2d788314c8d9051491588c32468fecf53c381918..d84865fbbe26bb337d9453a86c03d8dbb06ae43d 100644 (file)
@@ -5,38 +5,19 @@
  * Part of this source has been derived from the Linux USB
  * project.
  *
- * See file CREDITS for list of people who contributed to this
- * project.
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
- * MA 02111-1307 USA
- *
+ * SPDX-License-Identifier:    GPL-2.0+
  */
 #include <common.h>
+#include <console.h>
+#include <dm.h>
+#include <errno.h>
 #include <malloc.h>
+#include <memalign.h>
 #include <stdio_dev.h>
 #include <asm/byteorder.h>
 
 #include <usb.h>
 
-#ifdef USB_KBD_DEBUG
-#define USB_KBD_PRINTF(fmt, args...)   printf(fmt, ##args)
-#else
-#define USB_KBD_PRINTF(fmt, args...)
-#endif
-
 /*
  * If overwrite_console returns 1, the stdin, stderr and stdout
  * are switched to the serial port, else the settings in the
@@ -52,7 +33,7 @@ int overwrite_console(void)
 #endif
 
 /* Keyboard sampling rate */
-#define REPEAT_RATE    (40 / 4)        /* 40msec -> 25cps */
+#define REPEAT_RATE    40              /* 40msec -> 25cps */
 #define REPEAT_DELAY   10              /* 10 x REPEAT_RATE = 400msec */
 
 #define NUM_LOCK       0x53
@@ -87,6 +68,21 @@ static const unsigned char usb_kbd_numkey_shifted[] = {
        '|', '~', ':', '"', '~', '<', '>', '?'
 };
 
+static const unsigned char usb_kbd_num_keypad[] = {
+       '/', '*', '-', '+', '\r',
+       '1', '2', '3', '4', '5', '6', '7', '8', '9', '0',
+       '.', 0, 0, 0, '='
+};
+
+/*
+ * map arrow keys to ^F/^B ^N/^P, can't really use the proper
+ * ANSI sequence for arrow keys because the queuing code breaks
+ * when a single keypress expands to 3 queue elements
+ */
+static const unsigned char usb_kbd_arrow[] = {
+       0x6, 0x2, 0xe, 0x10
+};
+
 /*
  * NOTE: It's important for the NUM, CAPS, SCROLL-lock bits to be in this
  *       order. See usb_kbd_setled() function!
@@ -99,43 +95,35 @@ static const unsigned char usb_kbd_numkey_shifted[] = {
 #define USB_KBD_LEDMASK                \
        (USB_KBD_NUMLOCK | USB_KBD_CAPSLOCK | USB_KBD_SCROLLLOCK)
 
+/*
+ * USB Keyboard reports are 8 bytes in boot protocol.
+ * Appendix B of HID Device Class Definition 1.11
+ */
+#define USB_KBD_BOOT_REPORT_SIZE 8
+
 struct usb_kbd_pdata {
+       unsigned long   intpipe;
+       int             intpktsize;
+       int             intinterval;
+       unsigned long   last_report;
+       struct int_queue *intq;
+
        uint32_t        repeat_delay;
 
        uint32_t        usb_in_pointer;
        uint32_t        usb_out_pointer;
        uint8_t         usb_kbd_buffer[USB_KBD_BUFFER_LEN];
 
-       uint8_t         new[8];
-       uint8_t         old[8];
+       uint8_t         *new;
+       uint8_t         old[USB_KBD_BOOT_REPORT_SIZE];
 
        uint8_t         flags;
 };
 
-/* Generic keyboard event polling. */
-void usb_kbd_generic_poll(void)
-{
-       struct stdio_dev *dev;
-       struct usb_device *usb_kbd_dev;
-       struct usb_kbd_pdata *data;
-       struct usb_interface *iface;
-       struct usb_endpoint_descriptor *ep;
-       int pipe;
-       int maxp;
-
-       /* Get the pointer to USB Keyboard device pointer */
-       dev = stdio_get_by_name(DEVNAME);
-       usb_kbd_dev = (struct usb_device *)dev->priv;
-       data = usb_kbd_dev->privptr;
-       iface = &usb_kbd_dev->config.if_desc[0];
-       ep = &iface->ep_desc[0];
-       pipe = usb_rcvintpipe(usb_kbd_dev, ep->bEndpointAddress);
+extern int __maybe_unused net_busy_flag;
 
-       /* Submit a interrupt transfer request */
-       maxp = usb_maxpacket(usb_kbd_dev, pipe);
-       usb_submit_int_msg(usb_kbd_dev, pipe, data->new,
-                       maxp > 8 ? 8 : maxp, ep->bInterval);
-}
+/* The period of time between two calls of usb_kbd_testc(). */
+static unsigned long __maybe_unused kbd_testc_tms;
 
 /* Puts character in the queue and sets up the in and out pointer. */
 static void usb_kbd_put_queue(struct usb_kbd_pdata *data, char c)
@@ -166,11 +154,12 @@ static void usb_kbd_setled(struct usb_device *dev)
 {
        struct usb_interface *iface = &dev->config.if_desc[0];
        struct usb_kbd_pdata *data = dev->privptr;
-       uint32_t leds = data->flags & USB_KBD_LEDMASK;
+       ALLOC_ALIGN_BUFFER(uint32_t, leds, 1, USB_DMA_MINALIGN);
 
+       *leds = data->flags & USB_KBD_LEDMASK;
        usb_control_msg(dev, usb_sndctrlpipe(dev, 0),
                USB_REQ_SET_REPORT, USB_TYPE_CLASS | USB_RECIP_INTERFACE,
-               0x200, iface->desc.bInterfaceNumber, (void *)&leds, 1, 0);
+               0x200, iface->desc.bInterfaceNumber, leds, 1, 0);
 }
 
 #define CAPITAL_MASK   0x20
@@ -210,7 +199,7 @@ static int usb_kbd_translate(struct usb_kbd_pdata *data, unsigned char scancode,
                }
        }
 
-       if ((scancode > 0x1d) && (scancode < 0x3a)) {
+       if ((scancode > 0x1d) && (scancode < 0x39)) {
                /* Shift pressed */
                if (modifier & (LEFT_SHIFT | RIGHT_SHIFT))
                        keycode = usb_kbd_numkey_shifted[scancode - 0x1e];
@@ -218,6 +207,14 @@ static int usb_kbd_translate(struct usb_kbd_pdata *data, unsigned char scancode,
                        keycode = usb_kbd_numkey[scancode - 0x1e];
        }
 
+       /* Arrow keys */
+       if ((scancode >= 0x4f) && (scancode <= 0x52))
+               keycode = usb_kbd_arrow[scancode - 0x4f];
+
+       /* Numeric keypad */
+       if ((scancode >= 0x54) && (scancode <= 0x67))
+               keycode = usb_kbd_num_keypad[scancode - 0x54];
+
        if (data->flags & USB_KBD_CTRL)
                keycode = scancode - 0x3;
 
@@ -239,7 +236,7 @@ static int usb_kbd_translate(struct usb_kbd_pdata *data, unsigned char scancode,
 
        /* Report keycode if any */
        if (keycode) {
-               USB_KBD_PRINTF("%c", keycode);
+               debug("%c", keycode);
                usb_kbd_put_queue(data, keycode);
        }
 
@@ -261,8 +258,11 @@ static uint32_t usb_kbd_service_key(struct usb_device *dev, int i, int up)
                old = data->old;
        }
 
-       if ((old[i] > 3) && (memscan(new + 2, old[i], 6) == new + 8))
+       if ((old[i] > 3) &&
+           (memscan(new + 2, old[i], USB_KBD_BOOT_REPORT_SIZE - 2) ==
+                       new + USB_KBD_BOOT_REPORT_SIZE)) {
                res |= usb_kbd_translate(data, old[i], data->new[0], up);
+       }
 
        return res;
 }
@@ -280,7 +280,7 @@ static int usb_kbd_irq_worker(struct usb_device *dev)
        else if ((data->new[0] == LEFT_CNTR) || (data->new[0] == RIGHT_CNTR))
                data->flags |= USB_KBD_CTRL;
 
-       for (i = 2; i < 8; i++) {
+       for (i = 2; i < USB_KBD_BOOT_REPORT_SIZE; i++) {
                res |= usb_kbd_service_key(dev, i, 0);
                res |= usb_kbd_service_key(dev, i, 1);
        }
@@ -292,7 +292,7 @@ static int usb_kbd_irq_worker(struct usb_device *dev)
        if (res == 1)
                usb_kbd_setled(dev);
 
-       memcpy(data->old, data->new, 8);
+       memcpy(data->old, data->new, USB_KBD_BOOT_REPORT_SIZE);
 
        return 1;
 }
@@ -300,9 +300,10 @@ static int usb_kbd_irq_worker(struct usb_device *dev)
 /* Keyboard interrupt handler */
 static int usb_kbd_irq(struct usb_device *dev)
 {
-       if ((dev->irq_status != 0) || (dev->irq_act_len != 8)) {
-               USB_KBD_PRINTF("USB KBD: Error %lX, len %d\n",
-                               dev->irq_status, dev->irq_act_len);
+       if ((dev->irq_status != 0) ||
+           (dev->irq_act_len != USB_KBD_BOOT_REPORT_SIZE)) {
+               debug("USB KBD: Error %lX, len %d\n",
+                     dev->irq_status, dev->irq_act_len);
                return 1;
        }
 
@@ -312,27 +313,61 @@ static int usb_kbd_irq(struct usb_device *dev)
 /* Interrupt polling */
 static inline void usb_kbd_poll_for_event(struct usb_device *dev)
 {
-#if    defined(CONFIG_SYS_USB_EVENT_POLL)
-       usb_event_poll();
+#if defined(CONFIG_SYS_USB_EVENT_POLL)
+       struct usb_kbd_pdata *data = dev->privptr;
+
+       /* Submit a interrupt transfer request */
+       usb_submit_int_msg(dev, data->intpipe, &data->new[0], data->intpktsize,
+                          data->intinterval);
+
        usb_kbd_irq_worker(dev);
-#elif  defined(CONFIG_SYS_USB_EVENT_POLL_VIA_CONTROL_EP)
+#elif defined(CONFIG_SYS_USB_EVENT_POLL_VIA_CONTROL_EP) || \
+      defined(CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE)
+#if defined(CONFIG_SYS_USB_EVENT_POLL_VIA_CONTROL_EP)
        struct usb_interface *iface;
        struct usb_kbd_pdata *data = dev->privptr;
        iface = &dev->config.if_desc[0];
        usb_get_report(dev, iface->desc.bInterfaceNumber,
-                       1, 1, data->new, sizeof(data->new));
-       if (memcmp(data->old, data->new, sizeof(data->new)))
+                      1, 0, data->new, USB_KBD_BOOT_REPORT_SIZE);
+       if (memcmp(data->old, data->new, USB_KBD_BOOT_REPORT_SIZE)) {
+               usb_kbd_irq_worker(dev);
+#else
+       struct usb_kbd_pdata *data = dev->privptr;
+       if (poll_int_queue(dev, data->intq)) {
                usb_kbd_irq_worker(dev);
+               /* We've consumed all queued int packets, create new */
+               destroy_int_queue(dev, data->intq);
+               data->intq = create_int_queue(dev, data->intpipe, 1,
+                                     USB_KBD_BOOT_REPORT_SIZE, data->new,
+                                     data->intinterval);
+#endif
+               data->last_report = get_timer(0);
+       /* Repeat last usb hid report every REPEAT_RATE ms for keyrepeat */
+       } else if (data->last_report != -1 &&
+                  get_timer(data->last_report) > REPEAT_RATE) {
+               usb_kbd_irq_worker(dev);
+               data->last_report = get_timer(0);
+       }
 #endif
 }
 
 /* test if a character is in the queue */
-static int usb_kbd_testc(void)
+static int usb_kbd_testc(struct stdio_dev *sdev)
 {
        struct stdio_dev *dev;
        struct usb_device *usb_kbd_dev;
        struct usb_kbd_pdata *data;
 
+#ifdef CONFIG_CMD_NET
+       /*
+        * If net_busy_flag is 1, NET transfer is running,
+        * then we check key-pressed every second (first check may be
+        * less than 1 second) to improve TFTP booting performance.
+        */
+       if (net_busy_flag && (get_timer(kbd_testc_tms) < CONFIG_SYS_HZ))
+               return 0;
+       kbd_testc_tms = get_timer(0);
+#endif
        dev = stdio_get_by_name(DEVNAME);
        usb_kbd_dev = (struct usb_device *)dev->priv;
        data = usb_kbd_dev->privptr;
@@ -343,7 +378,7 @@ static int usb_kbd_testc(void)
 }
 
 /* gets the character from the queue */
-static int usb_kbd_getc(void)
+static int usb_kbd_getc(struct stdio_dev *sdev)
 {
        struct stdio_dev *dev;
        struct usb_device *usb_kbd_dev;
@@ -365,25 +400,24 @@ static int usb_kbd_getc(void)
 }
 
 /* probes the USB device dev for keyboard type. */
-static int usb_kbd_probe(struct usb_device *dev, unsigned int ifnum)
+static int usb_kbd_probe_dev(struct usb_device *dev, unsigned int ifnum)
 {
        struct usb_interface *iface;
        struct usb_endpoint_descriptor *ep;
        struct usb_kbd_pdata *data;
-       int pipe, maxp;
 
        if (dev->descriptor.bNumConfigurations != 1)
                return 0;
 
        iface = &dev->config.if_desc[ifnum];
 
-       if (iface->desc.bInterfaceClass != 3)
+       if (iface->desc.bInterfaceClass != USB_CLASS_HID)
                return 0;
 
-       if (iface->desc.bInterfaceSubClass != 1)
+       if (iface->desc.bInterfaceSubClass != USB_SUB_HID_BOOT)
                return 0;
 
-       if (iface->desc.bInterfaceProtocol != 1)
+       if (iface->desc.bInterfaceProtocol != USB_PROT_HID_KEYBOARD)
                return 0;
 
        if (iface->desc.bNumEndpoints != 1)
@@ -398,7 +432,7 @@ static int usb_kbd_probe(struct usb_device *dev, unsigned int ifnum)
        if ((ep->bmAttributes & 3) != 3)
                return 0;
 
-       USB_KBD_PRINTF("USB KBD: found set protocol...\n");
+       debug("USB KBD: found set protocol...\n");
 
        data = malloc(sizeof(struct usb_kbd_pdata));
        if (!data) {
@@ -409,478 +443,234 @@ static int usb_kbd_probe(struct usb_device *dev, unsigned int ifnum)
        /* Clear private data */
        memset(data, 0, sizeof(struct usb_kbd_pdata));
 
+       /* allocate input buffer aligned and sized to USB DMA alignment */
+       data->new = memalign(USB_DMA_MINALIGN,
+               roundup(USB_KBD_BOOT_REPORT_SIZE, USB_DMA_MINALIGN));
+
        /* Insert private data into USB device structure */
        dev->privptr = data;
 
        /* Set IRQ handler */
        dev->irq_handle = usb_kbd_irq;
 
-       pipe = usb_rcvintpipe(dev, ep->bEndpointAddress);
-       maxp = usb_maxpacket(dev, pipe);
+       data->intpipe = usb_rcvintpipe(dev, ep->bEndpointAddress);
+       data->intpktsize = min(usb_maxpacket(dev, data->intpipe),
+                              USB_KBD_BOOT_REPORT_SIZE);
+       data->intinterval = ep->bInterval;
+       data->last_report = -1;
 
        /* We found a USB Keyboard, install it. */
        usb_set_protocol(dev, iface->desc.bInterfaceNumber, 0);
 
-       USB_KBD_PRINTF("USB KBD: found set idle...\n");
-       usb_set_idle(dev, iface->desc.bInterfaceNumber, REPEAT_RATE, 0);
+       debug("USB KBD: found set idle...\n");
+#if !defined(CONFIG_SYS_USB_EVENT_POLL_VIA_CONTROL_EP) && \
+    !defined(CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE)
+       usb_set_idle(dev, iface->desc.bInterfaceNumber, REPEAT_RATE / 4, 0);
+#else
+       usb_set_idle(dev, iface->desc.bInterfaceNumber, 0, 0);
+#endif
 
-       USB_KBD_PRINTF("USB KBD: enable interrupt pipe...\n");
-       usb_submit_int_msg(dev, pipe, data->new, maxp > 8 ? 8 : maxp,
-                               ep->bInterval);
+       debug("USB KBD: enable interrupt pipe...\n");
+#ifdef CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE
+       data->intq = create_int_queue(dev, data->intpipe, 1,
+                                     USB_KBD_BOOT_REPORT_SIZE, data->new,
+                                     data->intinterval);
+       if (!data->intq) {
+#elif defined(CONFIG_SYS_USB_EVENT_POLL_VIA_CONTROL_EP)
+       if (usb_get_report(dev, iface->desc.bInterfaceNumber,
+                          1, 0, data->new, USB_KBD_BOOT_REPORT_SIZE) < 0) {
+#else
+       if (usb_submit_int_msg(dev, data->intpipe, data->new, data->intpktsize,
+                              data->intinterval) < 0) {
+#endif
+               printf("Failed to get keyboard state from device %04x:%04x\n",
+                      dev->descriptor.idVendor, dev->descriptor.idProduct);
+               /* Abort, we don't want to use that non-functional keyboard. */
+               return 0;
+       }
 
        /* Success. */
        return 1;
 }
 
+static int probe_usb_keyboard(struct usb_device *dev)
+{
+       char *stdinname;
+       struct stdio_dev usb_kbd_dev;
+       int error;
+
+       /* Try probing the keyboard */
+       if (usb_kbd_probe_dev(dev, 0) != 1)
+               return -ENOENT;
+
+       /* Register the keyboard */
+       debug("USB KBD: register.\n");
+       memset(&usb_kbd_dev, 0, sizeof(struct stdio_dev));
+       strcpy(usb_kbd_dev.name, DEVNAME);
+       usb_kbd_dev.flags =  DEV_FLAGS_INPUT;
+       usb_kbd_dev.getc = usb_kbd_getc;
+       usb_kbd_dev.tstc = usb_kbd_testc;
+       usb_kbd_dev.priv = (void *)dev;
+       error = stdio_register(&usb_kbd_dev);
+       if (error)
+               return error;
+
+       stdinname = getenv("stdin");
+#ifdef CONFIG_CONSOLE_MUX
+       error = iomux_doenv(stdin, stdinname);
+       if (error)
+               return error;
+#else
+       /* Check if this is the standard input device. */
+       if (strcmp(stdinname, DEVNAME))
+               return 1;
+
+       /* Reassign the console */
+       if (overwrite_console())
+               return 1;
+
+       error = console_assign(stdin, DEVNAME);
+       if (error)
+               return error;
+#endif
+
+       return 0;
+}
+
+#ifndef CONFIG_DM_USB
 /* Search for keyboard and register it if found. */
 int drv_usb_kbd_init(void)
 {
-       struct stdio_dev usb_kbd_dev, *old_dev;
-       struct usb_device *dev;
-       char *stdinname = getenv("stdin");
        int error, i;
 
+       debug("%s: Probing for keyboard\n", __func__);
        /* Scan all USB Devices */
        for (i = 0; i < USB_MAX_DEVICE; i++) {
+               struct usb_device *dev;
+
                /* Get USB device. */
                dev = usb_get_dev_index(i);
                if (!dev)
-                       return -1;
+                       break;
 
                if (dev->devnum == -1)
                        continue;
 
-               /* Try probing the keyboard */
-               if (usb_kbd_probe(dev, 0) != 1)
-                       continue;
-
-               /* We found a keyboard, check if it is already registered. */
-               USB_KBD_PRINTF("USB KBD: found set up device.\n");
-               old_dev = stdio_get_by_name(DEVNAME);
-               if (old_dev) {
-                       /* Already registered, just return ok. */
-                       USB_KBD_PRINTF("USB KBD: is already registered.\n");
-                       return 1;
-               }
-
-               /* Register the keyboard */
-               USB_KBD_PRINTF("USB KBD: register.\n");
-               memset(&usb_kbd_dev, 0, sizeof(struct stdio_dev));
-               strcpy(usb_kbd_dev.name, DEVNAME);
-               usb_kbd_dev.flags =  DEV_FLAGS_INPUT | DEV_FLAGS_SYSTEM;
-               usb_kbd_dev.putc = NULL;
-               usb_kbd_dev.puts = NULL;
-               usb_kbd_dev.getc = usb_kbd_getc;
-               usb_kbd_dev.tstc = usb_kbd_testc;
-               usb_kbd_dev.priv = (void *)dev;
-               error = stdio_register(&usb_kbd_dev);
-               if (error)
-                       return error;
-
-               /* Check if this is the standard input device. */
-               if (strcmp(stdinname, DEVNAME))
-                       return 1;
-
-               /* Reassign the console */
-               if (overwrite_console())
+               error = probe_usb_keyboard(dev);
+               if (!error)
                        return 1;
-
-               error = console_assign(stdin, DEVNAME);
-               if (error)
+               if (error && error != -ENOENT)
                        return error;
-
-               return 1;
        }
 
        /* No USB Keyboard found */
        return -1;
 }
+#endif
 
 /* Deregister the keyboard. */
-int usb_kbd_deregister(void)
+int usb_kbd_deregister(int force)
 {
 #ifdef CONFIG_SYS_STDIO_DEREGISTER
-       return stdio_deregister(DEVNAME);
+       struct stdio_dev *dev;
+       struct usb_device *usb_kbd_dev;
+       struct usb_kbd_pdata *data;
+
+       dev = stdio_get_by_name(DEVNAME);
+       if (dev) {
+               usb_kbd_dev = (struct usb_device *)dev->priv;
+               data = usb_kbd_dev->privptr;
+               if (stdio_deregister_dev(dev, force) != 0)
+                       return 1;
+#ifdef CONFIG_CONSOLE_MUX
+               if (iomux_doenv(stdin, getenv("stdin")) != 0)
+                       return 1;
+#endif
+#ifdef CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE
+               destroy_int_queue(usb_kbd_dev, data->intq);
+#endif
+               free(data->new);
+               free(data);
+       }
+
+       return 0;
 #else
        return 1;
 #endif
 }
 
-#if 0
-struct usb_hid_descriptor {
-       unsigned char  bLength;
-       unsigned char  bDescriptorType; /* 0x21 for HID */
-       unsigned short bcdHID; /* release number */
-       unsigned char  bCountryCode;
-       unsigned char  bNumDescriptors;
-       unsigned char  bReportDescriptorType;
-       unsigned short wDescriptorLength;
-} __packed;
-
-/*
- * We parse each description item into this structure. Short items data
- * values are expanded to 32-bit signed int, long items contain a pointer
- * into the data area.
- */
-
-struct hid_item {
-       unsigned char format;
-       unsigned char size;
-       unsigned char type;
-       unsigned char tag;
-       union {
-           unsigned char   u8;
-           char            s8;
-           unsigned short  u16;
-           short           s16;
-           unsigned long   u32;
-           long            s32;
-           unsigned char  *longdata;
-       } data;
-};
-
-/*
- * HID report item format
- */
-
-#define HID_ITEM_FORMAT_SHORT  0
-#define HID_ITEM_FORMAT_LONG   1
-
-/*
- * Special tag indicating long items
- */
-
-#define HID_ITEM_TAG_LONG      15
-
+#ifdef CONFIG_DM_USB
 
-static struct usb_hid_descriptor usb_kbd_hid_desc;
-
-void usb_kbd_display_hid(struct usb_hid_descriptor *hid)
+static int usb_kbd_probe(struct udevice *dev)
 {
-       printf("USB_HID_DESC:\n");
-       printf("  bLenght               0x%x\n", hid->bLength);
-       printf("  bcdHID                0x%x\n", hid->bcdHID);
-       printf("  bCountryCode          %d\n", hid->bCountryCode);
-       printf("  bNumDescriptors       0x%x\n", hid->bNumDescriptors);
-       printf("  bReportDescriptorType 0x%x\n", hid->bReportDescriptorType);
-       printf("  wDescriptorLength     0x%x\n", hid->wDescriptorLength);
-}
-
+       struct usb_device *udev = dev_get_parent_priv(dev);
+       int ret;
 
-/*
- * Fetch a report description item from the data stream. We support long
- * items, though they are not used yet.
- */
+       ret = probe_usb_keyboard(udev);
 
-static int fetch_item(unsigned char *start, unsigned char *end,
-                       struct hid_item *item)
-{
-       if ((end - start) > 0) {
-               unsigned char b = *start++;
-               item->type = (b >> 2) & 3;
-               item->tag  = (b >> 4) & 15;
-               if (item->tag == HID_ITEM_TAG_LONG) {
-                       item->format = HID_ITEM_FORMAT_LONG;
-                       if ((end - start) >= 2) {
-                               item->size = *start++;
-                               item->tag  = *start++;
-                               if ((end - start) >= item->size) {
-                                       item->data.longdata = start;
-                                       start += item->size;
-                                       return item->size;
-                               }
-                       }
-               } else {
-                       item->format = HID_ITEM_FORMAT_SHORT;
-                       item->size = b & 3;
-                       switch (item->size) {
-                       case 0:
-                               return item->size;
-                       case 1:
-                               if ((end - start) >= 1) {
-                                       item->data.u8 = *start++;
-                                       return item->size;
-                               }
-                               break;
-                       case 2:
-                               if ((end - start) >= 2) {
-                                       item->data.u16 = le16_to_cpu(
-                                               (unsigned short *)start);
-                                       start += 2;
-                                       return item->size;
-                               }
-                       case 3:
-                               item->size++;
-                               if ((end - start) >= 4) {
-                                       item->data.u32 = le32_to_cpu(
-                                               (unsigned long *)start);
-                                       start += 4;
-                                       return item->size;
-                               }
-                       }
-               }
-       }
-       return -1;
+       return ret;
 }
 
-/*
- * HID report descriptor item type (prefix bit 2, 3)
- */
-
-#define HID_ITEM_TYPE_MAIN             0
-#define HID_ITEM_TYPE_GLOBAL           1
-#define HID_ITEM_TYPE_LOCAL            2
-#define HID_ITEM_TYPE_RESERVED         3
-/*
- * HID report descriptor main item tags
- */
-
-#define HID_MAIN_ITEM_TAG_INPUT                        8
-#define HID_MAIN_ITEM_TAG_OUTPUT               9
-#define HID_MAIN_ITEM_TAG_FEATURE              11
-#define HID_MAIN_ITEM_TAG_BEGIN_COLLECTION     10
-#define HID_MAIN_ITEM_TAG_END_COLLECTION       12
-/*
- * HID report descriptor main item contents
- */
-
-#define HID_MAIN_ITEM_CONSTANT         0x001
-#define HID_MAIN_ITEM_VARIABLE         0x002
-#define HID_MAIN_ITEM_RELATIVE         0x004
-#define HID_MAIN_ITEM_WRAP             0x008
-#define HID_MAIN_ITEM_NONLINEAR                0x010
-#define HID_MAIN_ITEM_NO_PREFERRED     0x020
-#define HID_MAIN_ITEM_NULL_STATE       0x040
-#define HID_MAIN_ITEM_VOLATILE         0x080
-#define HID_MAIN_ITEM_BUFFERED_BYTE    0x100
-
-/*
- * HID report descriptor collection item types
- */
-
-#define HID_COLLECTION_PHYSICAL                0
-#define HID_COLLECTION_APPLICATION     1
-#define HID_COLLECTION_LOGICAL         2
-/*
- * HID report descriptor global item tags
- */
-
-#define HID_GLOBAL_ITEM_TAG_USAGE_PAGE         0
-#define HID_GLOBAL_ITEM_TAG_LOGICAL_MINIMUM    1
-#define HID_GLOBAL_ITEM_TAG_LOGICAL_MAXIMUM    2
-#define HID_GLOBAL_ITEM_TAG_PHYSICAL_MINIMUM   3
-#define HID_GLOBAL_ITEM_TAG_PHYSICAL_MAXIMUM   4
-#define HID_GLOBAL_ITEM_TAG_UNIT_EXPONENT      5
-#define HID_GLOBAL_ITEM_TAG_UNIT               6
-#define HID_GLOBAL_ITEM_TAG_REPORT_SIZE                7
-#define HID_GLOBAL_ITEM_TAG_REPORT_ID          8
-#define HID_GLOBAL_ITEM_TAG_REPORT_COUNT       9
-#define HID_GLOBAL_ITEM_TAG_PUSH               10
-#define HID_GLOBAL_ITEM_TAG_POP                        11
-
-/*
- * HID report descriptor local item tags
- */
-
-#define HID_LOCAL_ITEM_TAG_USAGE               0
-#define HID_LOCAL_ITEM_TAG_USAGE_MINIMUM       1
-#define HID_LOCAL_ITEM_TAG_USAGE_MAXIMUM       2
-#define HID_LOCAL_ITEM_TAG_DESIGNATOR_INDEX    3
-#define HID_LOCAL_ITEM_TAG_DESIGNATOR_MINIMUM  4
-#define HID_LOCAL_ITEM_TAG_DESIGNATOR_MAXIMUM  5
-#define HID_LOCAL_ITEM_TAG_STRING_INDEX                7
-#define HID_LOCAL_ITEM_TAG_STRING_MINIMUM      8
-#define HID_LOCAL_ITEM_TAG_STRING_MAXIMUM      9
-#define HID_LOCAL_ITEM_TAG_DELIMITER           10
-
-
-static void usb_kbd_show_item(struct hid_item *item)
+static int usb_kbd_remove(struct udevice *dev)
 {
-       switch (item->type) {
-       case HID_ITEM_TYPE_MAIN:
-               switch (item->tag) {
-               case HID_MAIN_ITEM_TAG_INPUT:
-                       printf("Main Input");
-                       break;
-               case HID_MAIN_ITEM_TAG_OUTPUT:
-                       printf("Main Output");
-                       break;
-               case HID_MAIN_ITEM_TAG_FEATURE:
-                       printf("Main Feature");
-                       break;
-               case HID_MAIN_ITEM_TAG_BEGIN_COLLECTION:
-                       printf("Main Begin Collection");
-                       break;
-               case HID_MAIN_ITEM_TAG_END_COLLECTION:
-                       printf("Main End Collection");
-                       break;
-               default:
-                       printf("Main reserved %d", item->tag);
-                       break;
-               }
-               break;
-       case HID_ITEM_TYPE_GLOBAL:
-               switch (item->tag) {
-               case HID_GLOBAL_ITEM_TAG_USAGE_PAGE:
-                       printf("- Global Usage Page");
-                       break;
-               case HID_GLOBAL_ITEM_TAG_LOGICAL_MINIMUM:
-                       printf("- Global Logical Minimum");
-                       break;
-               case HID_GLOBAL_ITEM_TAG_LOGICAL_MAXIMUM:
-                       printf("- Global Logical Maximum");
-                       break;
-               case HID_GLOBAL_ITEM_TAG_PHYSICAL_MINIMUM:
-                       printf("- Global physical Minimum");
-                       break;
-               case HID_GLOBAL_ITEM_TAG_PHYSICAL_MAXIMUM:
-                       printf("- Global physical Maximum");
-                       break;
-               case HID_GLOBAL_ITEM_TAG_UNIT_EXPONENT:
-                       printf("- Global Unit Exponent");
-                       break;
-               case HID_GLOBAL_ITEM_TAG_UNIT:
-                       printf("- Global Unit");
-                       break;
-               case HID_GLOBAL_ITEM_TAG_REPORT_SIZE:
-                       printf("- Global Report Size");
-                       break;
-               case HID_GLOBAL_ITEM_TAG_REPORT_ID:
-                       printf("- Global Report ID");
-                       break;
-               case HID_GLOBAL_ITEM_TAG_REPORT_COUNT:
-                       printf("- Global Report Count");
-                       break;
-               case HID_GLOBAL_ITEM_TAG_PUSH:
-                       printf("- Global Push");
-                       break;
-               case HID_GLOBAL_ITEM_TAG_POP:
-                       printf("- Global Pop");
-                       break;
-               default:
-                       printf("- Global reserved %d", item->tag);
-                       break;
-               }
-               break;
-       case HID_ITEM_TYPE_LOCAL:
-               switch (item->tag) {
-               case HID_LOCAL_ITEM_TAG_USAGE:
-                       printf("-- Local Usage");
-                       break;
-               case HID_LOCAL_ITEM_TAG_USAGE_MINIMUM:
-                       printf("-- Local Usage Minimum");
-                       break;
-               case HID_LOCAL_ITEM_TAG_USAGE_MAXIMUM:
-                       printf("-- Local Usage Maximum");
-                       break;
-               case HID_LOCAL_ITEM_TAG_DESIGNATOR_INDEX:
-                       printf("-- Local Designator Index");
-                       break;
-               case HID_LOCAL_ITEM_TAG_DESIGNATOR_MINIMUM:
-                       printf("-- Local Designator Minimum");
-                       break;
-               case HID_LOCAL_ITEM_TAG_DESIGNATOR_MAXIMUM:
-                       printf("-- Local Designator Maximum");
-                       break;
-               case HID_LOCAL_ITEM_TAG_STRING_INDEX:
-                       printf("-- Local String Index");
-                       break;
-               case HID_LOCAL_ITEM_TAG_STRING_MINIMUM:
-                       printf("-- Local String Minimum");
-                       break;
-               case HID_LOCAL_ITEM_TAG_STRING_MAXIMUM:
-                       printf("-- Local String Maximum");
-                       break;
-               case HID_LOCAL_ITEM_TAG_DELIMITER:
-                       printf("-- Local Delimiter");
-                       break;
-               default:
-                       printf("-- Local reserved %d", item->tag);
-                       break;
-               }
-               break;
-       default:
-               printf("--- reserved %d", item->type);
-               break;
-       }
-       switch (item->size) {
-       case 1:
-               printf("  %d", item->data.u8);
-               break;
-       case 2:
-               printf("  %d", item->data.u16);
-               break;
-       case 4:
-               printf("  %ld", item->data.u32);
-               break;
-       }
-       printf("\n");
-}
-
+       struct usb_device *udev = dev_get_parent_priv(dev);
+       struct usb_kbd_pdata *data;
+       struct stdio_dev *sdev;
+       int ret;
 
-static int usb_kbd_get_hid_desc(struct usb_device *dev)
-{
-       unsigned char buffer[256];
-       struct usb_descriptor_header *head;
-       struct usb_config_descriptor *config;
-       int index, len, i;
-       unsigned char *start, *end;
-       struct hid_item item;
-
-       if (usb_get_configuration_no(dev, &buffer[0], 0) == -1)
-               return -1;
-       head = (struct usb_descriptor_header *)&buffer[0];
-       if (head->bDescriptorType != USB_DT_CONFIG) {
-               printf(" ERROR: NOT USB_CONFIG_DESC %x\n",
-                               head->bDescriptorType);
-               return -1;
+       sdev = stdio_get_by_name(DEVNAME);
+       if (!sdev) {
+               ret = -ENXIO;
+               goto err;
        }
-       index = head->bLength;
-       config = (struct usb_config_descriptor *)&buffer[0];
-       len = le16_to_cpu(config->wTotalLength);
-       /*
-        * Ok the first entry must be a configuration entry,
-        * now process the others
-        */
-       head = (struct usb_descriptor_header *)&buffer[index];
-       while (index+1 < len) {
-               if (head->bDescriptorType == USB_DT_HID) {
-                       printf("HID desc found\n");
-                       memcpy(&usb_kbd_hid_desc, &buffer[index],
-                                       buffer[index]);
-                       le16_to_cpus(&usb_kbd_hid_desc.bcdHID);
-                       le16_to_cpus(&usb_kbd_hid_desc.wDescriptorLength);
-                       usb_kbd_display_hid(&usb_kbd_hid_desc);
-                       len = 0;
-                       break;
-               }
-               index += head->bLength;
-               head = (struct usb_descriptor_header *)&buffer[index];
+       data = udev->privptr;
+       if (stdio_deregister_dev(sdev, true)) {
+               ret = -EPERM;
+               goto err;
        }
-       if (len > 0)
-               return -1;
-       len = usb_kbd_hid_desc.wDescriptorLength;
-       index = usb_get_class_descriptor(dev, 0, USB_DT_REPORT, 0, &buffer[0],
-                                               len);
-       if (index < 0) {
-               printf("reading report descriptor failed\n");
-               return -1;
+#ifdef CONFIG_CONSOLE_MUX
+       if (iomux_doenv(stdin, getenv("stdin"))) {
+               ret = -ENOLINK;
+               goto err;
        }
-       printf(" report descriptor (size %u, read %d)\n", len, index);
-       start = &buffer[0];
-       end = &buffer[len];
-       i = 0;
-       do {
-               index = fetch_item(start, end, &item);
-               i += index;
-               i++;
-               if (index >= 0)
-                       usb_kbd_show_item(&item);
-
-               start += index;
-               start++;
-       } while (index >= 0);
+#endif
+#ifdef CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE
+       destroy_int_queue(udev, data->intq);
+#endif
+       free(data->new);
+       free(data);
 
+       return 0;
+err:
+       printf("%s: warning, ret=%d", __func__, ret);
+       return ret;
 }
 
+static const struct udevice_id usb_kbd_ids[] = {
+       { .compatible = "usb-keyboard" },
+       { }
+};
+
+U_BOOT_DRIVER(usb_kbd) = {
+       .name   = "usb_kbd",
+       .id     = UCLASS_KEYBOARD,
+       .of_match = usb_kbd_ids,
+       .probe = usb_kbd_probe,
+       .remove = usb_kbd_remove,
+};
+
+static const struct usb_device_id kbd_id_table[] = {
+       {
+               .match_flags = USB_DEVICE_ID_MATCH_INT_CLASS |
+                       USB_DEVICE_ID_MATCH_INT_SUBCLASS |
+                       USB_DEVICE_ID_MATCH_INT_PROTOCOL,
+               .bInterfaceClass = USB_CLASS_HID,
+               .bInterfaceSubClass = USB_SUB_HID_BOOT,
+               .bInterfaceProtocol = USB_PROT_HID_KEYBOARD,
+       },
+       { }             /* Terminating entry */
+};
+
+U_BOOT_USB_DEVICE(usb_kbd, kbd_id_table);
+
 #endif