]> git.sur5r.net Git - u-boot/blobdiff - drivers/cfi_flash.c
Merge branch 'mpc86xx'
[u-boot] / drivers / cfi_flash.c
index c6c2751d6432220f30920fa2cc28e9b265e43fca..37172379b9875ed3628092d4b894f7aa402c979a 100644 (file)
  *
  * Tested Architectures
  * Port Width  Chip Width    # of banks           Flash Chip  Board
- * 32         16            1             23F128J3    seranoa/eagle
- * 64         16            1             23F128J3    seranoa/falcon
+ * 32         16            1             28F128J3    seranoa/eagle
+ * 64         16            1             28F128J3    seranoa/falcon
  *
  */
 
 /* The DEBUG define must be before common to enable debugging */
-#undef DEBUG
+/* #define DEBUG       */
+
 #include <common.h>
+#include <watchdog.h>
 #include <asm/processor.h>
+#include <asm/byteorder.h>
+#include <environment.h>
 #ifdef CFG_FLASH_CFI_DRIVER
+
 /*
  * This file implements a Common Flash Interface (CFI) driver for U-Boot.
  * The width of the port and the width of the chips are determined at initialization.
 #define AMD_CMD_WRITE                  0xA0
 #define AMD_CMD_ERASE_START            0x80
 #define AMD_CMD_ERASE_SECTOR           0x30
+#define AMD_CMD_UNLOCK_START           0xAA
+#define AMD_CMD_UNLOCK_ACK             0x55
+#define AMD_CMD_WRITE_TO_BUFFER                0x25
+#define AMD_CMD_WRITE_BUFFER_CONFIRM   0x29
 
 #define AMD_STATUS_TOGGLE              0x40
 #define AMD_STATUS_ERROR               0x20
 
+#define AMD_ADDR_ERASE_START   ((info->portwidth == FLASH_CFI_8BIT) ? 0xAAA : 0x555)
+#define AMD_ADDR_START         ((info->portwidth == FLASH_CFI_8BIT) ? 0xAAA : 0x555)
+#define AMD_ADDR_ACK           ((info->portwidth == FLASH_CFI_8BIT) ? 0x555 : 0x2AA)
+
 #define FLASH_OFFSET_CFI               0x55
 #define FLASH_OFFSET_CFI_RESP          0x10
 #define FLASH_OFFSET_PRIMARY_VENDOR    0x13
+#define FLASH_OFFSET_EXT_QUERY_T_P_ADDR        0x15    /* extended query table primary addr */
 #define FLASH_OFFSET_WTOUT             0x1F
 #define FLASH_OFFSET_WBTOUT            0x20
 #define FLASH_OFFSET_ETOUT             0x21
 #define CFI_CMDSET_SST             258
 
 
+#ifdef CFG_FLASH_CFI_AMD_RESET /* needed for STM_ID_29W320DB on UC100 */
+# undef  FLASH_CMD_RESET
+# define FLASH_CMD_RESET                AMD_CMD_RESET /* use AMD-Reset instead */
+#endif
+
+
 typedef union {
        unsigned char c;
        unsigned short w;
@@ -151,9 +171,22 @@ typedef union {
 
 #define NUM_ERASE_REGIONS 4
 
+/* use CFG_MAX_FLASH_BANKS_DETECT if defined */
+#ifdef CFG_MAX_FLASH_BANKS_DETECT
+static ulong bank_base[CFG_MAX_FLASH_BANKS_DETECT] = CFG_FLASH_BANKS_LIST;
+flash_info_t flash_info[CFG_MAX_FLASH_BANKS_DETECT];   /* FLASH chips info */
+#else
 static ulong bank_base[CFG_MAX_FLASH_BANKS] = CFG_FLASH_BANKS_LIST;
+flash_info_t flash_info[CFG_MAX_FLASH_BANKS];          /* FLASH chips info */
+#endif
+
+/*
+ * Check if chip width is defined. If not, start detecting with 8bit.
+ */
+#ifndef CFG_FLASH_CFI_WIDTH
+#define CFG_FLASH_CFI_WIDTH    FLASH_CFI_8BIT
+#endif
 
-flash_info_t flash_info[CFG_MAX_FLASH_BANKS];  /* info for FLASH chips   */
 
 /*-----------------------------------------------------------------------
  * Functions
@@ -163,31 +196,27 @@ typedef unsigned long flash_sect_t;
 
 static void flash_add_byte (flash_info_t * info, cfiword_t * cword, uchar c);
 static void flash_make_cmd (flash_info_t * info, uchar cmd, void *cmdbuf);
-static void flash_write_cmd (flash_info_t * info, flash_sect_t sect,
-                            uint offset, uchar cmd);
+static void flash_write_cmd (flash_info_t * info, flash_sect_t sect, uint offset, uchar cmd);
 static void flash_unlock_seq (flash_info_t * info, flash_sect_t sect);
-static int flash_isequal (flash_info_t * info, flash_sect_t sect, uint offset,
-                         uchar cmd);
-static int flash_isset (flash_info_t * info, flash_sect_t sect, uint offset,
-                       uchar cmd);
-static int flash_toggle (flash_info_t * info, flash_sect_t sect, uint offset,
-                        uchar cmd);
+static int flash_isequal (flash_info_t * info, flash_sect_t sect, uint offset, uchar cmd);
+static int flash_isset (flash_info_t * info, flash_sect_t sect, uint offset, uchar cmd);
+static int flash_toggle (flash_info_t * info, flash_sect_t sect, uint offset, uchar cmd);
 static int flash_detect_cfi (flash_info_t * info);
-static ulong flash_get_size (ulong base, int banknum);
-static int flash_write_cfiword (flash_info_t * info, ulong dest,
-                               cfiword_t cword);
+static int flash_write_cfiword (flash_info_t * info, ulong dest, cfiword_t cword);
 static int flash_full_status_check (flash_info_t * info, flash_sect_t sector,
                                    ulong tout, char *prompt);
+ulong flash_get_size (ulong base, int banknum);
+#if defined(CFG_ENV_IS_IN_FLASH) || defined(CFG_ENV_ADDR_REDUND) || (CFG_MONITOR_BASE >= CFG_FLASH_BASE)
+static flash_info_t *flash_get_info(ulong base);
+#endif
 #ifdef CFG_FLASH_USE_BUFFER_WRITE
-static int flash_write_cfibuffer (flash_info_t * info, ulong dest, uchar * cp,
-                                 int len);
+static int flash_write_cfibuffer (flash_info_t * info, ulong dest, uchar * cp, int len);
 #endif
 
 /*-----------------------------------------------------------------------
  * create an address based on the offset and the port width
  */
-inline uchar *flash_make_addr (flash_info_t * info, flash_sect_t sect,
-                              uint offset)
+inline uchar *flash_make_addr (flash_info_t * info, flash_sect_t sect, uint offset)
 {
        return ((uchar *) (info->start[sect] + (offset * info->portwidth)));
 }
@@ -210,7 +239,7 @@ static void flash_printqry (flash_info_t * info, flash_sect_t sect)
        cfiptr_t cptr;
        int x, y;
 
-       for (x = 0; x < 0x40; x += 16 / info->portwidth) {
+       for (x = 0; x < 0x40; x += 16U / info->portwidth) {
                cptr.cp =
                        flash_make_addr (info, sect,
                                         x + FLASH_OFFSET_CFI_RESP);
@@ -229,7 +258,6 @@ static void flash_printqry (flash_info_t * info, flash_sect_t sect)
                debug ("\n");
        }
 }
-
 #endif
 
 
@@ -285,7 +313,6 @@ ushort flash_read_ushort (flash_info_t * info, flash_sect_t sect, uint offset)
  */
 ulong flash_read_long (flash_info_t * info, flash_sect_t sect, uint offset)
 {
-
        uchar *addr;
        ulong retval;
 
@@ -303,8 +330,7 @@ ulong flash_read_long (flash_info_t * info, flash_sect_t sect, uint offset)
 #endif
 #if defined(__LITTLE_ENDIAN)
        retval = (addr[0] << 16) | (addr[(info->portwidth)] << 24) |
-               (addr[(2 * info->portwidth)]) | (addr[(3 * info->portwidth)]
-                                                << 8);
+               (addr[(2 * info->portwidth)]) | (addr[(3 * info->portwidth)] << 8);
 #else
        retval = (addr[(2 * info->portwidth) - 1] << 24) |
                (addr[(info->portwidth) - 1] << 16) |
@@ -314,6 +340,7 @@ ulong flash_read_long (flash_info_t * info, flash_sect_t sect, uint offset)
        return retval;
 }
 
+
 /*-----------------------------------------------------------------------
  */
 unsigned long flash_init (void)
@@ -321,26 +348,109 @@ unsigned long flash_init (void)
        unsigned long size = 0;
        int i;
 
+#ifdef CFG_FLASH_PROTECTION
+       char *s = getenv("unlock");
+#endif
+
        /* Init: no FLASHes known */
        for (i = 0; i < CFG_MAX_FLASH_BANKS; ++i) {
                flash_info[i].flash_id = FLASH_UNKNOWN;
                size += flash_info[i].size = flash_get_size (bank_base[i], i);
                if (flash_info[i].flash_id == FLASH_UNKNOWN) {
-                       printf ("## Unknown FLASH on Bank %d - Size = 0x%08lx = %ld MB\n", i, flash_info[i].size, flash_info[i].size << 20);
+#ifndef CFG_FLASH_QUIET_TEST
+                       printf ("## Unknown FLASH on Bank %d - Size = 0x%08lx = %ld MB\n",
+                               i, flash_info[i].size, flash_info[i].size << 20);
+#endif /* CFG_FLASH_QUIET_TEST */
                }
+#ifdef CFG_FLASH_PROTECTION
+               else if ((s != NULL) && (strcmp(s, "yes") == 0)) {
+                       /*
+                        * Only the U-Boot image and it's environment is protected,
+                        * all other sectors are unprotected (unlocked) if flash
+                        * hardware protection is used (CFG_FLASH_PROTECTION) and
+                        * the environment variable "unlock" is set to "yes".
+                        */
+                       if (flash_info[i].legacy_unlock) {
+                               int k;
+
+                               /*
+                                * Disable legacy_unlock temporarily, since
+                                * flash_real_protect would relock all other sectors
+                                * again otherwise.
+                                */
+                               flash_info[i].legacy_unlock = 0;
+
+                               /*
+                                * Legacy unlocking (e.g. Intel J3) -> unlock only one
+                                * sector. This will unlock all sectors.
+                                */
+                               flash_real_protect (&flash_info[i], 0, 0);
+
+                               flash_info[i].legacy_unlock = 1;
+
+                               /*
+                                * Manually mark other sectors as unlocked (unprotected)
+                                */
+                               for (k = 1; k < flash_info[i].sector_count; k++)
+                                       flash_info[i].protect[k] = 0;
+                       } else {
+                               /*
+                                * No legancy unlocking -> unlock all sectors
+                                */
+                               flash_protect (FLAG_PROTECT_CLEAR,
+                                              flash_info[i].start[0],
+                                              flash_info[i].start[0] + flash_info[i].size - 1,
+                                              &flash_info[i]);
+                       }
+               }
+#endif /* CFG_FLASH_PROTECTION */
        }
 
        /* Monitor protection ON by default */
 #if (CFG_MONITOR_BASE >= CFG_FLASH_BASE)
        flash_protect (FLAG_PROTECT_SET,
                       CFG_MONITOR_BASE,
-                      CFG_MONITOR_BASE + CFG_MONITOR_LEN - 1,
-                      &flash_info[0]);
+                      CFG_MONITOR_BASE + monitor_flash_len  - 1,
+                      flash_get_info(CFG_MONITOR_BASE));
 #endif
 
+       /* Environment protection ON by default */
+#ifdef CFG_ENV_IS_IN_FLASH
+       flash_protect (FLAG_PROTECT_SET,
+                      CFG_ENV_ADDR,
+                      CFG_ENV_ADDR + CFG_ENV_SECT_SIZE - 1,
+                      flash_get_info(CFG_ENV_ADDR));
+#endif
+
+       /* Redundant environment protection ON by default */
+#ifdef CFG_ENV_ADDR_REDUND
+       flash_protect (FLAG_PROTECT_SET,
+                      CFG_ENV_ADDR_REDUND,
+                      CFG_ENV_ADDR_REDUND + CFG_ENV_SIZE_REDUND - 1,
+                      flash_get_info(CFG_ENV_ADDR_REDUND));
+#endif
        return (size);
 }
 
+/*-----------------------------------------------------------------------
+ */
+#if defined(CFG_ENV_IS_IN_FLASH) || defined(CFG_ENV_ADDR_REDUND) || (CFG_MONITOR_BASE >= CFG_FLASH_BASE)
+static flash_info_t *flash_get_info(ulong base)
+{
+       int i;
+       flash_info_t * info = 0;
+
+       for (i = 0; i < CFG_MAX_FLASH_BANKS; i ++) {
+               info = & flash_info[i];
+               if (info->size && info->start[0] <= base &&
+                   base <= info->start[0] + info->size - 1)
+                       break;
+       }
+
+       return i == CFG_MAX_FLASH_BANKS ? 0 : info;
+}
+#endif
+
 /*-----------------------------------------------------------------------
  */
 int flash_erase (flash_info_t * info, int s_first, int s_last)
@@ -350,11 +460,11 @@ int flash_erase (flash_info_t * info, int s_first, int s_last)
        flash_sect_t sect;
 
        if (info->flash_id != FLASH_MAN_CFI) {
-               printf ("Can't erase unknown flash type - aborted\n");
+               puts ("Can't erase unknown flash type - aborted\n");
                return 1;
        }
        if ((s_first < 0) || (s_first > s_last)) {
-               printf ("- no sectors to erase\n");
+               puts ("- no sectors to erase\n");
                return 1;
        }
 
@@ -367,7 +477,7 @@ int flash_erase (flash_info_t * info, int s_first, int s_last)
        if (prot) {
                printf ("- Warning: %d protected sectors will not be erased!\n", prot);
        } else {
-               printf ("\n");
+               putc ('\n');
        }
 
 
@@ -376,21 +486,17 @@ int flash_erase (flash_info_t * info, int s_first, int s_last)
                        switch (info->vendor) {
                        case CFI_CMDSET_INTEL_STANDARD:
                        case CFI_CMDSET_INTEL_EXTENDED:
-                               flash_write_cmd (info, sect, 0,
-                                                FLASH_CMD_CLEAR_STATUS);
-                               flash_write_cmd (info, sect, 0,
-                                                FLASH_CMD_BLOCK_ERASE);
-                               flash_write_cmd (info, sect, 0,
-                                                FLASH_CMD_ERASE_CONFIRM);
+                               flash_write_cmd (info, sect, 0, FLASH_CMD_CLEAR_STATUS);
+                               flash_write_cmd (info, sect, 0, FLASH_CMD_BLOCK_ERASE);
+                               flash_write_cmd (info, sect, 0, FLASH_CMD_ERASE_CONFIRM);
                                break;
                        case CFI_CMDSET_AMD_STANDARD:
                        case CFI_CMDSET_AMD_EXTENDED:
                                flash_unlock_seq (info, sect);
-                               flash_write_cmd (info, sect, 0x555,
-                                                AMD_CMD_ERASE_START);
+                               flash_write_cmd (info, sect, AMD_ADDR_ERASE_START,
+                                                       AMD_CMD_ERASE_START);
                                flash_unlock_seq (info, sect);
-                               flash_write_cmd (info, sect, 0,
-                                                AMD_CMD_ERASE_SECTOR);
+                               flash_write_cmd (info, sect, 0, AMD_CMD_ERASE_SECTOR);
                                break;
                        default:
                                debug ("Unkown flash vendor %d\n",
@@ -402,10 +508,10 @@ int flash_erase (flash_info_t * info, int s_first, int s_last)
                            (info, sect, info->erase_blk_tout, "erase")) {
                                rcode = 1;
                        } else
-                               printf (".");
+                               putc ('.');
                }
        }
-       printf (" done\n");
+       puts (" done\n");
        return rcode;
 }
 
@@ -416,7 +522,7 @@ void flash_print_info (flash_info_t * info)
        int i;
 
        if (info->flash_id != FLASH_MAN_CFI) {
-               printf ("missing or unknown FLASH type\n");
+               puts ("missing or unknown FLASH type\n");
                return;
        }
 
@@ -424,9 +530,13 @@ void flash_print_info (flash_info_t * info)
                (info->portwidth << 3), (info->chipwidth << 3));
        printf ("  Size: %ld MB in %d Sectors\n",
                info->size >> 20, info->sector_count);
-       printf (" Erase timeout %ld ms, write timeout %ld ms, buffer write timeout %ld ms, buffer size %d\n", info->erase_blk_tout, info->write_tout, info->buffer_write_tout, info->buffer_size);
+       printf (" Erase timeout %ld ms, write timeout %ld ms, buffer write timeout %ld ms, buffer size %d\n",
+               info->erase_blk_tout,
+               info->write_tout,
+               info->buffer_write_tout,
+               info->buffer_size);
 
-       printf ("  Sector Start Addresses:");
+       puts ("  Sector Start Addresses:");
        for (i = 0; i < info->sector_count; ++i) {
 #ifdef CFG_FLASH_EMPTY_INFO
                int k;
@@ -458,14 +568,14 @@ void flash_print_info (flash_info_t * info)
                        info->start[i],
                        erased ? " E" : "  ",
                        info->protect[i] ? "RO " : "   ");
-#else
+#else  /* ! CFG_FLASH_EMPTY_INFO */
                if ((i % 5) == 0)
                        printf ("\n   ");
                printf (" %08lX%s",
-                       info->start[i], info->protect[i] ? " (RO)" : "     ");
+                       info->start[i], info->protect[i] ? " (RO)" : "     ");
 #endif
        }
-       printf ("\n");
+       putc ('\n');
        return;
 }
 
@@ -486,24 +596,6 @@ int write_buff (flash_info_t * info, uchar * src, ulong addr, ulong cnt)
 #ifdef CFG_FLASH_USE_BUFFER_WRITE
        int buffered_size;
 #endif
-       int x8mode = 0;
-
-       /* special handling of 16 bit devices in 8 bit mode */
-       if ((info->interface == FLASH_CFI_X8X16)
-           && (info->chipwidth == FLASH_CFI_BY8)) {
-               switch (info->vendor) {
-               case CFI_CMDSET_INTEL_STANDARD:
-               case CFI_CMDSET_INTEL_EXTENDED:
-                       x8mode = info->portwidth;
-                       info->portwidth >>= 1;  /* XXX - Need to test on x9/x16 in parallel. */
-                       /*info->portwidth = FLASH_CFI_8BIT; */ /* XXX - Need to test on x9/x16 in parallel. */
-                       break;
-               case CFI_CMDSET_AMD_STANDARD:
-               case CFI_CMDSET_AMD_EXTENDED:
-               default:
-                       break;
-               }
-       }
        /* get lower aligned address */
        /* get lower aligned address */
        wp = (addr & ~(info->portwidth - 1));
@@ -532,9 +624,25 @@ int write_buff (flash_info_t * info, uchar * src, ulong addr, ulong cnt)
        buffered_size = (info->portwidth / info->chipwidth);
        buffered_size *= info->buffer_size;
        while (cnt >= info->portwidth) {
-               i = buffered_size > cnt ? cnt : buffered_size;
+               /* prohibit buffer write when buffer_size is 1 */
+               if (info->buffer_size == 1) {
+                       cword.l = 0;
+                       for (i = 0; i < info->portwidth; i++)
+                               flash_add_byte (info, &cword, *src++);
+                       if ((rc = flash_write_cfiword (info, wp, cword)) != 0)
+                               return rc;
+                       wp += info->portwidth;
+                       cnt -= info->portwidth;
+                       continue;
+               }
+
+               /* write buffer until next buffered_size aligned boundary */
+               i = buffered_size - (wp % buffered_size);
+               if (i > cnt)
+                       i = cnt;
                if ((rc = flash_write_cfibuffer (info, wp, src, i)) != ERR_OK)
                        return rc;
+               i -= i & (info->portwidth - 1);
                wp += i;
                src += i;
                cnt -= i;
@@ -567,10 +675,6 @@ int write_buff (flash_info_t * info, uchar * src, ulong addr, ulong cnt)
                flash_add_byte (info, &cword, (*(uchar *) cp));
        }
 
-       /* special handling of 16 bit devices in 8 bit mode */
-       if (x8mode) {
-               info->portwidth = x8mode;;
-       }
        return flash_write_cfiword (info, wp, cword);
 }
 
@@ -594,8 +698,12 @@ int flash_real_protect (flash_info_t * info, long sector, int prot)
                                      prot ? "protect" : "unprotect")) == 0) {
 
                info->protect[sector] = prot;
-               /* Intel's unprotect unprotects all locking */
-               if (prot == 0) {
+
+               /*
+                * On some of Intel's flash chips (marked via legacy_unlock)
+                * unprotect unprotects all locking.
+                */
+               if ((prot == 0) && (info->legacy_unlock)) {
                        flash_sect_t i;
 
                        for (i = 0; i < info->sector_count; i++) {
@@ -604,7 +712,6 @@ int flash_real_protect (flash_info_t * info, long sector, int prot)
                        }
                }
        }
-
        return retcode;
 }
 
@@ -621,7 +728,7 @@ void flash_read_user_serial (flash_info_t * info, void *buffer, int offset,
        src = flash_make_addr (info, 0, FLASH_OFFSET_USER_PROTECTION);
        flash_write_cmd (info, 0, 0, FLASH_CMD_READ_ID);
        memcpy (dst, src + offset, len);
-       flash_write_cmd (info, 0, 0, FLASH_CMD_RESET);
+       flash_write_cmd (info, 0, 0, info->cmd_reset);
 }
 
 /*
@@ -635,7 +742,7 @@ void flash_read_factory_serial (flash_info_t * info, void *buffer, int offset,
        src = flash_make_addr (info, 0, FLASH_OFFSET_INTEL_PROTECTION);
        flash_write_cmd (info, 0, 0, FLASH_CMD_READ_ID);
        memcpy (buffer, src + offset, len);
-       flash_write_cmd (info, 0, 0, FLASH_CMD_RESET);
+       flash_write_cmd (info, 0, 0, info->cmd_reset);
 }
 
 #endif /* CFG_FLASH_PROTECTION */
@@ -673,10 +780,14 @@ static int flash_status_check (flash_info_t * info, flash_sect_t sector,
 {
        ulong start;
 
+#if CFG_HZ != 1000
+       tout *= CFG_HZ/1000;
+#endif
+
        /* Wait for command completion */
        start = get_timer (0);
        while (flash_is_busy (info, sector)) {
-               if (get_timer (start) > info->erase_blk_tout * CFG_HZ) {
+               if (get_timer (start) > tout) {
                        printf ("Flash %s timeout at address %lx data %lx\n",
                                prompt, info->start[sector],
                                flash_read_long (info, sector, 0));
@@ -700,31 +811,27 @@ static int flash_full_status_check (flash_info_t * info, flash_sect_t sector,
        switch (info->vendor) {
        case CFI_CMDSET_INTEL_EXTENDED:
        case CFI_CMDSET_INTEL_STANDARD:
-               if ((retcode != ERR_OK)
+               if ((retcode == ERR_OK)
                    && !flash_isequal (info, sector, 0, FLASH_STATUS_DONE)) {
                        retcode = ERR_INVAL;
                        printf ("Flash %s error at address %lx\n", prompt,
                                info->start[sector]);
-                       if (flash_isset
-                           (info, sector, 0,
-                            FLASH_STATUS_ECLBS | FLASH_STATUS_PSLBS)) {
-                               printf ("Command Sequence Error.\n");
-                       } else if (flash_isset
-                                  (info, sector, 0, FLASH_STATUS_ECLBS)) {
-                               printf ("Block Erase Error.\n");
+                       if (flash_isset (info, sector, 0, FLASH_STATUS_ECLBS | FLASH_STATUS_PSLBS)) {
+                               puts ("Command Sequence Error.\n");
+                       } else if (flash_isset (info, sector, 0, FLASH_STATUS_ECLBS)) {
+                               puts ("Block Erase Error.\n");
                                retcode = ERR_NOT_ERASED;
-                       } else if (flash_isset
-                                  (info, sector, 0, FLASH_STATUS_PSLBS)) {
-                               printf ("Locking Error\n");
+                       } else if (flash_isset (info, sector, 0, FLASH_STATUS_PSLBS)) {
+                               puts ("Locking Error\n");
                        }
                        if (flash_isset (info, sector, 0, FLASH_STATUS_DPS)) {
-                               printf ("Block locked.\n");
+                               puts ("Block locked.\n");
                                retcode = ERR_PROTECTED;
                        }
                        if (flash_isset (info, sector, 0, FLASH_STATUS_VPENS))
-                               printf ("Vpp Low Error.\n");
+                               puts ("Vpp Low Error.\n");
                }
-               flash_write_cmd (info, sector, 0, FLASH_CMD_RESET);
+               flash_write_cmd (info, sector, 0, info->cmd_reset);
                break;
        default:
                break;
@@ -736,18 +843,42 @@ static int flash_full_status_check (flash_info_t * info, flash_sect_t sector,
  */
 static void flash_add_byte (flash_info_t * info, cfiword_t * cword, uchar c)
 {
+#if defined(__LITTLE_ENDIAN)
+       unsigned short  w;
+       unsigned int    l;
+       unsigned long long ll;
+#endif
+
        switch (info->portwidth) {
        case FLASH_CFI_8BIT:
                cword->c = c;
                break;
        case FLASH_CFI_16BIT:
+#if defined(__LITTLE_ENDIAN)
+               w = c;
+               w <<= 8;
+               cword->w = (cword->w >> 8) | w;
+#else
                cword->w = (cword->w << 8) | c;
+#endif
                break;
        case FLASH_CFI_32BIT:
+#if defined(__LITTLE_ENDIAN)
+               l = c;
+               l <<= 24;
+               cword->l = (cword->l >> 8) | l;
+#else
                cword->l = (cword->l << 8) | c;
+#endif
                break;
        case FLASH_CFI_64BIT:
+#if defined(__LITTLE_ENDIAN)
+               ll = c;
+               ll <<= 56;
+               cword->ll = (cword->ll >> 8) | ll;
+#else
                cword->ll = (cword->ll << 8) | c;
+#endif
                break;
        }
 }
@@ -759,27 +890,20 @@ static void flash_add_byte (flash_info_t * info, cfiword_t * cword, uchar c)
 static void flash_make_cmd (flash_info_t * info, uchar cmd, void *cmdbuf)
 {
        int i;
-
-#if defined(__LITTLE_ENDIAN)
-       ushort stmp;
-#endif
        uchar *cp = (uchar *) cmdbuf;
 
-       for (i = 0; i < info->portwidth; i++)
-               *cp++ = ((i + 1) % info->chipwidth) ? '\0' : cmd;
 #if defined(__LITTLE_ENDIAN)
-       if (info->portwidth == 2) {
-               stmp = *(ushort *) cmdbuf;
-               *(ushort *) cmdbuf = swab16 (stmp);
-       }
+       for (i = info->portwidth; i > 0; i--)
+#else
+       for (i = 1; i <= info->portwidth; i++)
 #endif
+               *cp++ = (i & (info->chipwidth - 1)) ? '\0' : cmd;
 }
 
 /*
  * Write a proper sized command to the correct address
  */
-static void flash_write_cmd (flash_info_t * info, flash_sect_t sect,
-                            uint offset, uchar cmd)
+static void flash_write_cmd (flash_info_t * info, flash_sect_t sect, uint offset, uchar cmd)
 {
 
        volatile cfiptr_t addr;
@@ -792,18 +916,27 @@ static void flash_write_cmd (flash_info_t * info, flash_sect_t sect,
                debug ("fwc addr %p cmd %x %x 8bit x %d bit\n", addr.cp, cmd,
                       cword.c, info->chipwidth << CFI_FLASH_SHIFT_WIDTH);
                *addr.cp = cword.c;
+#ifdef CONFIG_BLACKFIN
+               asm("ssync;");
+#endif
                break;
        case FLASH_CFI_16BIT:
                debug ("fwc addr %p cmd %x %4.4x 16bit x %d bit\n", addr.wp,
                       cmd, cword.w,
                       info->chipwidth << CFI_FLASH_SHIFT_WIDTH);
                *addr.wp = cword.w;
+#ifdef CONFIG_BLACKFIN
+               asm("ssync;");
+#endif
                break;
        case FLASH_CFI_32BIT:
                debug ("fwc addr %p cmd %x %8.8lx 32bit x %d bit\n", addr.lp,
                       cmd, cword.l,
                       info->chipwidth << CFI_FLASH_SHIFT_WIDTH);
                *addr.lp = cword.l;
+#ifdef CONFIG_BLACKFIN
+               asm("ssync;");
+#endif
                break;
        case FLASH_CFI_64BIT:
 #ifdef DEBUG
@@ -818,20 +951,22 @@ static void flash_write_cmd (flash_info_t * info, flash_sect_t sect,
                }
 #endif
                *addr.llp = cword.ll;
+#ifdef CONFIG_BLACKFIN
+               asm("ssync;");
+#endif
                break;
        }
 }
 
 static void flash_unlock_seq (flash_info_t * info, flash_sect_t sect)
 {
-       flash_write_cmd (info, sect, 0x555, 0xAA);
-       flash_write_cmd (info, sect, 0x2AA, 0x55);
+       flash_write_cmd (info, sect, AMD_ADDR_START, AMD_CMD_UNLOCK_START);
+       flash_write_cmd (info, sect, AMD_ADDR_ACK, AMD_CMD_UNLOCK_ACK);
 }
 
 /*-----------------------------------------------------------------------
  */
-static int flash_isequal (flash_info_t * info, flash_sect_t sect, uint offset,
-                         uchar cmd)
+static int flash_isequal (flash_info_t * info, flash_sect_t sect, uint offset, uchar cmd)
 {
        cfiptr_t cptr;
        cfiword_t cword;
@@ -876,8 +1011,7 @@ static int flash_isequal (flash_info_t * info, flash_sect_t sect, uint offset,
 
 /*-----------------------------------------------------------------------
  */
-static int flash_isset (flash_info_t * info, flash_sect_t sect, uint offset,
-                       uchar cmd)
+static int flash_isset (flash_info_t * info, flash_sect_t sect, uint offset, uchar cmd)
 {
        cfiptr_t cptr;
        cfiword_t cword;
@@ -907,8 +1041,7 @@ static int flash_isset (flash_info_t * info, flash_sect_t sect, uint offset,
 
 /*-----------------------------------------------------------------------
  */
-static int flash_toggle (flash_info_t * info, flash_sect_t sect, uint offset,
-                        uchar cmd)
+static int flash_toggle (flash_info_t * info, flash_sect_t sect, uint offset, uchar cmd)
 {
        cfiptr_t cptr;
        cfiword_t cword;
@@ -946,33 +1079,24 @@ static int flash_detect_cfi (flash_info_t * info)
 {
        debug ("flash detect cfi\n");
 
-       for (info->portwidth = FLASH_CFI_8BIT;
+       for (info->portwidth = CFG_FLASH_CFI_WIDTH;
             info->portwidth <= FLASH_CFI_64BIT; info->portwidth <<= 1) {
                for (info->chipwidth = FLASH_CFI_BY8;
                     info->chipwidth <= info->portwidth;
                     info->chipwidth <<= 1) {
-                       flash_write_cmd (info, 0, 0, FLASH_CMD_RESET);
-                       flash_write_cmd (info, 0, FLASH_OFFSET_CFI,
-                                        FLASH_CMD_CFI);
-                       if (flash_isequal
-                           (info, 0, FLASH_OFFSET_CFI_RESP, 'Q')
-                           && flash_isequal (info, 0,
-                                             FLASH_OFFSET_CFI_RESP + 1, 'R')
-                           && flash_isequal (info, 0,
-                                             FLASH_OFFSET_CFI_RESP + 2,
-                                             'Y')) {
-                               info->interface =
-                                       flash_read_ushort (info, 0,
-                                                          FLASH_OFFSET_INTERFACE);
+                       flash_write_cmd (info, 0, 0, info->cmd_reset);
+                       flash_write_cmd (info, 0, FLASH_OFFSET_CFI, FLASH_CMD_CFI);
+                       if (flash_isequal (info, 0, FLASH_OFFSET_CFI_RESP, 'Q')
+                           && flash_isequal (info, 0, FLASH_OFFSET_CFI_RESP + 1, 'R')
+                           && flash_isequal (info, 0, FLASH_OFFSET_CFI_RESP + 2, 'Y')) {
+                               info->interface = flash_read_ushort (info, 0, FLASH_OFFSET_INTERFACE);
                                debug ("device interface is %d\n",
                                       info->interface);
                                debug ("found port %d chip %d ",
                                       info->portwidth, info->chipwidth);
                                debug ("port %d bits chip %d bits\n",
-                                      info->
-                                      portwidth << CFI_FLASH_SHIFT_WIDTH,
-                                      info->
-                                      chipwidth << CFI_FLASH_SHIFT_WIDTH);
+                                      info->portwidth << CFI_FLASH_SHIFT_WIDTH,
+                                      info->chipwidth << CFI_FLASH_SHIFT_WIDTH);
                                return 1;
                        }
                }
@@ -985,7 +1109,7 @@ static int flash_detect_cfi (flash_info_t * info)
  * The following code cannot be run from FLASH!
  *
  */
-static ulong flash_get_size (ulong base, int banknum)
+ulong flash_get_size (ulong base, int banknum)
 {
        flash_info_t *info = &flash_info[banknum];
        int i, j;
@@ -996,13 +1120,15 @@ static ulong flash_get_size (ulong base, int banknum)
        uchar num_erase_regions;
        int erase_region_size;
        int erase_region_count;
+#ifdef CFG_FLASH_PROTECTION
+       int ext_addr;
+       info->legacy_unlock = 0;
+#endif
 
        info->start[0] = base;
 
        if (flash_detect_cfi (info)) {
-               info->vendor =
-                       flash_read_ushort (info, 0,
-                                          FLASH_OFFSET_PRIMARY_VENDOR);
+               info->vendor = flash_read_ushort (info, 0, FLASH_OFFSET_PRIMARY_VENDOR);
 #ifdef DEBUG
                flash_printqry (info, 0);
 #endif
@@ -1011,6 +1137,13 @@ static ulong flash_get_size (ulong base, int banknum)
                case CFI_CMDSET_INTEL_EXTENDED:
                default:
                        info->cmd_reset = FLASH_CMD_RESET;
+#ifdef CFG_FLASH_PROTECTION
+                       /* read legacy lock/unlock bit from intel flash */
+                       ext_addr = flash_read_ushort (info, 0,
+                                                     FLASH_OFFSET_EXT_QUERY_T_P_ADDR);
+                       info->legacy_unlock =
+                               flash_read_uchar (info, ext_addr + 5) & 0x08;
+#endif
                        break;
                case CFI_CMDSET_AMD_STANDARD:
                case CFI_CMDSET_AMD_EXTENDED:
@@ -1025,9 +1158,7 @@ static ulong flash_get_size (ulong base, int banknum)
                    && (info->chipwidth == FLASH_CFI_BY8)) {
                        size_ratio >>= 1;
                }
-               num_erase_regions =
-                       flash_read_uchar (info,
-                                         FLASH_OFFSET_NUM_ERASE_REGIONS);
+               num_erase_regions = flash_read_uchar (info, FLASH_OFFSET_NUM_ERASE_REGIONS);
                debug ("size_ratio %d port %d bits chip %d bits\n",
                       size_ratio, info->portwidth << CFI_FLASH_SHIFT_WIDTH,
                       info->chipwidth << CFI_FLASH_SHIFT_WIDTH);
@@ -1036,7 +1167,8 @@ static ulong flash_get_size (ulong base, int banknum)
                sector = base;
                for (i = 0; i < num_erase_regions; i++) {
                        if (i > NUM_ERASE_REGIONS) {
-                               printf ("%d erase regions found, only %d used\n", num_erase_regions, NUM_ERASE_REGIONS);
+                               printf ("%d erase regions found, only %d used\n",
+                                       num_erase_regions, NUM_ERASE_REGIONS);
                                break;
                        }
                        tmp = flash_read_long (info, 0,
@@ -1046,57 +1178,73 @@ static ulong flash_get_size (ulong base, int banknum)
                                (tmp & 0xffff) ? ((tmp & 0xffff) * 256) : 128;
                        tmp >>= 16;
                        erase_region_count = (tmp & 0xffff) + 1;
-                       printf ("erase_region_count = %d erase_region_size = %d\n", erase_region_count, erase_region_size);
+                       debug ("erase_region_count = %d erase_region_size = %d\n",
+                               erase_region_count, erase_region_size);
                        for (j = 0; j < erase_region_count; j++) {
                                info->start[sect_cnt] = sector;
                                sector += (erase_region_size * size_ratio);
-                               info->protect[sect_cnt] =
-                                       flash_isset (info, sect_cnt,
-                                                    FLASH_OFFSET_PROTECT,
-                                                    FLASH_STATUS_PROTECT);
+
+                               /*
+                                * Only read protection status from supported devices (intel...)
+                                */
+                               switch (info->vendor) {
+                               case CFI_CMDSET_INTEL_EXTENDED:
+                               case CFI_CMDSET_INTEL_STANDARD:
+                                       info->protect[sect_cnt] =
+                                               flash_isset (info, sect_cnt,
+                                                            FLASH_OFFSET_PROTECT,
+                                                            FLASH_STATUS_PROTECT);
+                                       break;
+                               default:
+                                       info->protect[sect_cnt] = 0; /* default: not protected */
+                               }
+
                                sect_cnt++;
                        }
                }
 
                info->sector_count = sect_cnt;
                /* multiply the size by the number of chips */
-               info->size =
-                       (1 << flash_read_uchar (info, FLASH_OFFSET_SIZE)) *
-                       size_ratio;
-               info->buffer_size =
-                       (1 <<
-                        flash_read_ushort (info, 0,
-                                           FLASH_OFFSET_BUFFER_SIZE));
+               info->size = (1 << flash_read_uchar (info, FLASH_OFFSET_SIZE)) * size_ratio;
+               info->buffer_size = (1 << flash_read_ushort (info, 0, FLASH_OFFSET_BUFFER_SIZE));
                tmp = 1 << flash_read_uchar (info, FLASH_OFFSET_ETOUT);
-               info->erase_blk_tout =
-                       (tmp *
-                        (1 <<
-                         flash_read_uchar (info, FLASH_OFFSET_EMAX_TOUT)));
-               tmp = 1 << flash_read_uchar (info, FLASH_OFFSET_WBTOUT);
-               info->buffer_write_tout =
-                       (tmp *
-                        (1 <<
-                         flash_read_uchar (info, FLASH_OFFSET_WBMAX_TOUT)));
-               tmp = 1 << flash_read_uchar (info, FLASH_OFFSET_WTOUT);
-               info->write_tout =
-                       (tmp *
-                        (1 <<
-                         flash_read_uchar (info,
-                                           FLASH_OFFSET_WMAX_TOUT))) / 1000;
+               info->erase_blk_tout = (tmp * (1 << flash_read_uchar (info, FLASH_OFFSET_EMAX_TOUT)));
+               tmp = (1 << flash_read_uchar (info, FLASH_OFFSET_WBTOUT)) *
+                       (1 << flash_read_uchar (info, FLASH_OFFSET_WBMAX_TOUT));
+               info->buffer_write_tout = tmp / 1000 + (tmp % 1000 ? 1 : 0); /* round up when converting to ms */
+               tmp = (1 << flash_read_uchar (info, FLASH_OFFSET_WTOUT)) *
+                     (1 << flash_read_uchar (info, FLASH_OFFSET_WMAX_TOUT));
+               info->write_tout = tmp / 1000 + (tmp % 1000 ? 1 : 0); /* round up when converting to ms */
                info->flash_id = FLASH_MAN_CFI;
+               if ((info->interface == FLASH_CFI_X8X16) && (info->chipwidth == FLASH_CFI_BY8)) {
+                       info->portwidth >>= 1;  /* XXX - Need to test on x8/x16 in parallel. */
+               }
        }
 
-       flash_write_cmd (info, 0, 0, FLASH_CMD_RESET);
+       flash_write_cmd (info, 0, 0, info->cmd_reset);
        return (info->size);
 }
 
+/* loop through the sectors from the highest address
+ * when the passed address is greater or equal to the sector address
+ * we have a match
+ */
+static flash_sect_t find_sector (flash_info_t * info, ulong addr)
+{
+       flash_sect_t sector;
+
+       for (sector = info->sector_count - 1; sector >= 0; sector--) {
+               if (addr >= info->start[sector])
+                       break;
+       }
+       return sector;
+}
 
 /*-----------------------------------------------------------------------
  */
 static int flash_write_cfiword (flash_info_t * info, ulong dest,
                                cfiword_t cword)
 {
-
        cfiptr_t ctladdr;
        cfiptr_t cptr;
        int flag;
@@ -1117,7 +1265,7 @@ static int flash_write_cfiword (flash_info_t * info, ulong dest,
                flag = ((cptr.lp[0] & cword.l) == cword.l);
                break;
        case FLASH_CFI_64BIT:
-               flag = ((cptr.lp[0] & cword.ll) == cword.ll);
+               flag = ((cptr.llp[0] & cword.ll) == cword.ll);
                break;
        default:
                return 2;
@@ -1137,7 +1285,7 @@ static int flash_write_cfiword (flash_info_t * info, ulong dest,
        case CFI_CMDSET_AMD_EXTENDED:
        case CFI_CMDSET_AMD_STANDARD:
                flash_unlock_seq (info, 0);
-               flash_write_cmd (info, 0, 0x555, AMD_CMD_WRITE);
+               flash_write_cmd (info, 0, AMD_ADDR_START, AMD_CMD_WRITE);
                break;
        }
 
@@ -1160,26 +1308,16 @@ static int flash_write_cfiword (flash_info_t * info, ulong dest,
        if (flag)
                enable_interrupts ();
 
-       return flash_full_status_check (info, 0, info->write_tout, "write");
+#if defined(CONFIG_MCF52x2)
+       WATCHDOG_RESET();
+#endif
+
+       return flash_full_status_check (info, find_sector (info, dest),
+                                       info->write_tout, "write");
 }
 
 #ifdef CFG_FLASH_USE_BUFFER_WRITE
 
-/* loop through the sectors from the highest address
- * when the passed address is greater or equal to the sector address
- * we have a match
- */
-static flash_sect_t find_sector (flash_info_t * info, ulong addr)
-{
-       flash_sect_t sector;
-
-       for (sector = info->sector_count - 1; sector >= 0; sector--) {
-               if (addr >= info->start[sector])
-                       break;
-       }
-       return sector;
-}
-
 static int flash_write_cfibuffer (flash_info_t * info, ulong dest, uchar * cp,
                                  int len)
 {
@@ -1189,61 +1327,105 @@ static int flash_write_cfibuffer (flash_info_t * info, ulong dest, uchar * cp,
        volatile cfiptr_t src;
        volatile cfiptr_t dst;
 
-       src.cp = cp;
-       dst.cp = (uchar *) dest;
-       sector = find_sector (info, dest);
-       flash_write_cmd (info, sector, 0, FLASH_CMD_CLEAR_STATUS);
-       flash_write_cmd (info, sector, 0, FLASH_CMD_WRITE_TO_BUFFER);
-       if ((retcode =
-            flash_status_check (info, sector, info->buffer_write_tout,
-                                "write to buffer")) == ERR_OK) {
-               /* reduce the number of loops by the width of the port  */
+       switch (info->vendor) {
+       case CFI_CMDSET_INTEL_STANDARD:
+       case CFI_CMDSET_INTEL_EXTENDED:
+               src.cp = cp;
+               dst.cp = (uchar *) dest;
+               sector = find_sector (info, dest);
+               flash_write_cmd (info, sector, 0, FLASH_CMD_CLEAR_STATUS);
+               flash_write_cmd (info, sector, 0, FLASH_CMD_WRITE_TO_BUFFER);
+               if ((retcode = flash_status_check (info, sector, info->buffer_write_tout,
+                                                  "write to buffer")) == ERR_OK) {
+                       /* reduce the number of loops by the width of the port  */
+                       switch (info->portwidth) {
+                       case FLASH_CFI_8BIT:
+                               cnt = len;
+                               break;
+                       case FLASH_CFI_16BIT:
+                               cnt = len >> 1;
+                               break;
+                       case FLASH_CFI_32BIT:
+                               cnt = len >> 2;
+                               break;
+                       case FLASH_CFI_64BIT:
+                               cnt = len >> 3;
+                               break;
+                       default:
+                               return ERR_INVAL;
+                               break;
+                       }
+                       flash_write_cmd (info, sector, 0, (uchar) cnt - 1);
+                       while (cnt-- > 0) {
+                               switch (info->portwidth) {
+                               case FLASH_CFI_8BIT:
+                                       *dst.cp++ = *src.cp++;
+                                       break;
+                               case FLASH_CFI_16BIT:
+                                       *dst.wp++ = *src.wp++;
+                                       break;
+                               case FLASH_CFI_32BIT:
+                                       *dst.lp++ = *src.lp++;
+                                       break;
+                               case FLASH_CFI_64BIT:
+                                       *dst.llp++ = *src.llp++;
+                                       break;
+                               default:
+                                       return ERR_INVAL;
+                                       break;
+                               }
+                       }
+                       flash_write_cmd (info, sector, 0,
+                                        FLASH_CMD_WRITE_BUFFER_CONFIRM);
+                       retcode = flash_full_status_check (info, sector,
+                                                          info->buffer_write_tout,
+                                                          "buffer write");
+               }
+               return retcode;
+
+       case CFI_CMDSET_AMD_STANDARD:
+       case CFI_CMDSET_AMD_EXTENDED:
+               src.cp = cp;
+               dst.cp = (uchar *) dest;
+               sector = find_sector (info, dest);
+
+               flash_unlock_seq(info,0);
+               flash_write_cmd (info, sector, 0, AMD_CMD_WRITE_TO_BUFFER);
+
                switch (info->portwidth) {
                case FLASH_CFI_8BIT:
                        cnt = len;
+                       flash_write_cmd (info, sector, 0,  (uchar) cnt - 1);
+                       while (cnt-- > 0) *dst.cp++ = *src.cp++;
                        break;
                case FLASH_CFI_16BIT:
                        cnt = len >> 1;
+                       flash_write_cmd (info, sector, 0,  (uchar) cnt - 1);
+                       while (cnt-- > 0) *dst.wp++ = *src.wp++;
                        break;
                case FLASH_CFI_32BIT:
                        cnt = len >> 2;
+                       flash_write_cmd (info, sector, 0,  (uchar) cnt - 1);
+                       while (cnt-- > 0) *dst.lp++ = *src.lp++;
                        break;
                case FLASH_CFI_64BIT:
                        cnt = len >> 3;
+                       flash_write_cmd (info, sector, 0,  (uchar) cnt - 1);
+                       while (cnt-- > 0) *dst.llp++ = *src.llp++;
                        break;
                default:
                        return ERR_INVAL;
-                       break;
                }
-               flash_write_cmd (info, sector, 0, (uchar) cnt - 1);
-               while (cnt-- > 0) {
-                       switch (info->portwidth) {
-                       case FLASH_CFI_8BIT:
-                               *dst.cp++ = *src.cp++;
-                               break;
-                       case FLASH_CFI_16BIT:
-                               *dst.wp++ = *src.wp++;
-                               break;
-                       case FLASH_CFI_32BIT:
-                               *dst.lp++ = *src.lp++;
-                               break;
-                       case FLASH_CFI_64BIT:
-                               *dst.llp++ = *src.llp++;
-                               break;
-                       default:
-                               return ERR_INVAL;
-                               break;
-                       }
-               }
-               flash_write_cmd (info, sector, 0,
-                                FLASH_CMD_WRITE_BUFFER_CONFIRM);
-               retcode =
-                       flash_full_status_check (info, sector,
-                                                info->buffer_write_tout,
-                                                "buffer write");
+
+               flash_write_cmd (info, sector, 0, AMD_CMD_WRITE_BUFFER_CONFIRM);
+               retcode = flash_full_status_check (info, sector, info->buffer_write_tout,
+                                                  "buffer write");
+               return retcode;
+
+       default:
+               debug ("Unknown Command Set\n");
+               return ERR_INVAL;
        }
-       flash_write_cmd (info, sector, 0, FLASH_CMD_CLEAR_STATUS);
-       return retcode;
 }
-#endif /* CFG_USE_FLASH_BUFFER_WRITE */
+#endif /* CFG_FLASH_USE_BUFFER_WRITE */
 #endif /* CFG_FLASH_CFI */