]> git.sur5r.net Git - u-boot/blobdiff - drivers/ddr/marvell/a38x/ddr3_training_leveling.c
ARM: mvebu: a38x: sync ddr training code with upstream
[u-boot] / drivers / ddr / marvell / a38x / ddr3_training_leveling.c
index 3a9e81f1b79bcc0389d0c05ad8e8d55e694fb732..6248ffc3fb332668b8299f1a46957bfcf71d692f 100644 (file)
@@ -3,17 +3,9 @@
  * Copyright (C) Marvell International Ltd. and its affiliates
  */
 
-#include <common.h>
-#include <spl.h>
-#include <asm/io.h>
-#include <asm/arch/cpu.h>
-#include <asm/arch/soc.h>
-
 #include "ddr3_init.h"
 
-#define WL_ITERATION_NUM               10
-#define ONE_CLOCK_ERROR_SHIFT          2
-#define ALIGN_ERROR_SHIFT              -2
+#define WL_ITERATION_NUM       10
 
 static u32 pup_mask_table[] = {
        0x000000ff,
@@ -27,26 +19,30 @@ static struct write_supp_result wr_supp_res[MAX_INTERFACE_NUM][MAX_BUS_NUM];
 static int ddr3_tip_dynamic_write_leveling_seq(u32 dev_num);
 static int ddr3_tip_dynamic_read_leveling_seq(u32 dev_num);
 static int ddr3_tip_dynamic_per_bit_read_leveling_seq(u32 dev_num);
-static int ddr3_tip_wl_supp_align_err_shift(u32 dev_num, u32 if_id, u32 bus_id,
-                                           u32 bus_id_delta);
 static int ddr3_tip_wl_supp_align_phase_shift(u32 dev_num, u32 if_id,
-                                             u32 bus_id, u32 offset,
-                                             u32 bus_id_delta);
+                                             u32 bus_id);
 static int ddr3_tip_xsb_compare_test(u32 dev_num, u32 if_id, u32 bus_id,
-                                    u32 edge_offset, u32 bus_id_delta);
-static int ddr3_tip_wl_supp_one_clk_err_shift(u32 dev_num, u32 if_id,
-                                             u32 bus_id, u32 bus_id_delta);
+                                    u32 edge_offset);
 
-u32 hws_ddr3_tip_max_cs_get(void)
+u32 ddr3_tip_max_cs_get(u32 dev_num)
 {
-       u32 c_cs;
+       u32 c_cs, if_id, bus_id;
        static u32 max_cs;
-       struct hws_topology_map *tm = ddr3_get_topology_map();
+       struct mv_ddr_topology_map *tm = mv_ddr_topology_map_get();
+       u32 octets_per_if_num = ddr3_tip_dev_attr_get(dev_num, MV_ATTR_OCTET_PER_INTERFACE);
 
        if (!max_cs) {
+               CHECK_STATUS(ddr3_tip_get_first_active_if((u8)dev_num,
+                                                         tm->if_act_mask,
+                                                         &if_id));
+               for (bus_id = 0; bus_id < octets_per_if_num; bus_id++) {
+                       VALIDATE_BUS_ACTIVE(tm->bus_act_mask, bus_id);
+                       break;
+               }
+
                for (c_cs = 0; c_cs < NUM_OF_CS; c_cs++) {
                        VALIDATE_ACTIVE(tm->
-                                       interface_params[0].as_bus_params[0].
+                                       interface_params[if_id].as_bus_params[bus_id].
                                        cs_bitmask, c_cs);
                        max_cs++;
                }
@@ -55,13 +51,17 @@ u32 hws_ddr3_tip_max_cs_get(void)
        return max_cs;
 }
 
+enum {
+       PASS,
+       FAIL
+};
 /*****************************************************************************
 Dynamic read leveling
 ******************************************************************************/
 int ddr3_tip_dynamic_read_leveling(u32 dev_num, u32 freq)
 {
        u32 data, mask;
-       u32 max_cs = hws_ddr3_tip_max_cs_get();
+       u32 max_cs = ddr3_tip_max_cs_get(dev_num);
        u32 bus_num, if_id, cl_val;
        enum hws_speed_bin speed_bin_index;
        /* save current CS value */
@@ -71,82 +71,9 @@ int ddr3_tip_dynamic_read_leveling(u32 dev_num, u32 freq)
        u8 rl_values[NUM_OF_CS][MAX_BUS_NUM][MAX_INTERFACE_NUM];
        struct pattern_info *pattern_table = ddr3_tip_get_pattern_table();
        u16 *mask_results_pup_reg_map = ddr3_tip_get_mask_results_pup_reg_map();
-       struct hws_topology_map *tm = ddr3_get_topology_map();
-
-       if (rl_version == 0) {
-               /* OLD RL machine */
-               data = 0x40;
-               data |= (1 << 20);
-
-               /* TBD multi CS */
-               CHECK_STATUS(ddr3_tip_if_write(
-                                    dev_num, ACCESS_TYPE_MULTICAST,
-                                    PARAM_NOT_CARE, TRAINING_REG,
-                                    data, 0x11ffff));
-               CHECK_STATUS(ddr3_tip_if_write(
-                                    dev_num, ACCESS_TYPE_MULTICAST,
-                                    PARAM_NOT_CARE,
-                                    TRAINING_PATTERN_BASE_ADDRESS_REG,
-                                    0, 0xfffffff8));
-               CHECK_STATUS(ddr3_tip_if_write(
-                                    dev_num, ACCESS_TYPE_MULTICAST,
-                                    PARAM_NOT_CARE, TRAINING_REG,
-                                    (u32)(1 << 31), (u32)(1 << 31)));
-
-               for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-                       VALIDATE_ACTIVE(tm->if_act_mask, if_id);
-                       training_result[training_stage][if_id] = TEST_SUCCESS;
-                       if (ddr3_tip_if_polling
-                           (dev_num, ACCESS_TYPE_UNICAST, if_id, 0,
-                            (u32)(1 << 31), TRAINING_REG,
-                            MAX_POLLING_ITERATIONS) != MV_OK) {
-                               DEBUG_LEVELING(
-                                       DEBUG_LEVEL_ERROR,
-                                       ("RL: DDR3 poll failed(1) IF %d\n",
-                                        if_id));
-                               training_result[training_stage][if_id] =
-                                       TEST_FAILED;
-
-                               if (debug_mode == 0)
-                                       return MV_FAIL;
-                       }
-               }
-
-               /* read read-leveling result */
-               CHECK_STATUS(ddr3_tip_if_read
-                            (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             TRAINING_REG, data_read, 1 << 30));
-               /* exit read leveling mode */
-               CHECK_STATUS(ddr3_tip_if_write
-                            (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             TRAINING_SW_2_REG, 0x8, 0x9));
-               CHECK_STATUS(ddr3_tip_if_write
-                            (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             TRAINING_SW_1_REG, 1 << 16, 1 << 16));
-
-               /* disable RL machine all Trn_CS[3:0] , [16:0] */
-
-               CHECK_STATUS(ddr3_tip_if_write
-                            (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             TRAINING_REG, 0, 0xf1ffff));
-
-               for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-                       VALIDATE_ACTIVE(tm->if_act_mask, if_id);
-                       if ((data_read[if_id] & (1 << 30)) == 0) {
-                               DEBUG_LEVELING(
-                                       DEBUG_LEVEL_ERROR,
-                                       ("\n_read Leveling failed for IF %d\n",
-                                        if_id));
-                               training_result[training_stage][if_id] =
-                                       TEST_FAILED;
-                               if (debug_mode == 0)
-                                       return MV_FAIL;
-                       }
-               }
-               return MV_OK;
-       }
+       u32 octets_per_if_num = ddr3_tip_dev_attr_get(dev_num, MV_ATTR_OCTET_PER_INTERFACE);
+       struct mv_ddr_topology_map *tm = mv_ddr_topology_map_get();
 
-       /* NEW RL machine */
        for (effective_cs = 0; effective_cs < NUM_OF_CS; effective_cs++)
                for (bus_num = 0; bus_num < MAX_BUS_NUM; bus_num++)
                        for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++)
@@ -154,18 +81,18 @@ int ddr3_tip_dynamic_read_leveling(u32 dev_num, u32 freq)
 
        for (effective_cs = 0; effective_cs < max_cs; effective_cs++) {
                for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-                       VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+                       VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
                        training_result[training_stage][if_id] = TEST_SUCCESS;
 
                        /* save current cs enable reg val */
                        CHECK_STATUS(ddr3_tip_if_read
                                     (dev_num, ACCESS_TYPE_UNICAST, if_id,
-                                     CS_ENABLE_REG, cs_enable_reg_val,
+                                     DUAL_DUNIT_CFG_REG, cs_enable_reg_val,
                                      MASK_ALL_BITS));
                        /* enable single cs */
                        CHECK_STATUS(ddr3_tip_if_write
                                     (dev_num, ACCESS_TYPE_UNICAST, if_id,
-                                     CS_ENABLE_REG, (1 << 3), (1 << 3)));
+                                     DUAL_DUNIT_CFG_REG, (1 << 3), (1 << 3)));
                }
 
                ddr3_tip_reset_fifo_ptr(dev_num);
@@ -183,7 +110,7 @@ int ddr3_tip_dynamic_read_leveling(u32 dev_num, u32 freq)
                /* BUS count is 0 shifted 26 */
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             ODPG_DATA_CONTROL_REG, 0x3, 0x3));
+                             ODPG_DATA_CTRL_REG, 0x3, 0x3));
                CHECK_STATUS(ddr3_tip_configure_odpg
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE, 0,
                              pattern_table[PATTERN_RL].num_of_phases_tx, 0,
@@ -203,17 +130,17 @@ int ddr3_tip_dynamic_read_leveling(u32 dev_num, u32 freq)
                /* General Training Opcode register */
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             ODPG_WRITE_READ_MODE_ENABLE_REG, 0,
+                             ODPG_WR_RD_MODE_ENA_REG, 0,
                              MASK_ALL_BITS));
 
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             ODPG_TRAINING_CONTROL_REG,
+                             GENERAL_TRAINING_OPCODE_REG,
                              (0x301b01 | effective_cs << 2), 0x3c3fef));
 
                /* Object1 opcode register 0 & 1 */
                for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-                       VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+                       VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
                        speed_bin_index =
                                tm->interface_params[if_id].speed_bin_index;
                        cl_val =
@@ -222,13 +149,13 @@ int ddr3_tip_dynamic_read_leveling(u32 dev_num, u32 freq)
                        mask = (0xff << 9) | (0x1f << 17) | (0x3 << 25);
                        CHECK_STATUS(ddr3_tip_if_write
                                     (dev_num, ACCESS_TYPE_UNICAST, if_id,
-                                     ODPG_OBJ1_OPCODE_REG, data, mask));
+                                     OPCODE_REG0_REG(1), data, mask));
                }
 
                /* Set iteration count to max value */
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             TRAINING_OPCODE_1_REG, 0xd00, 0xd00));
+                             OPCODE_REG1_REG(1), 0xd00, 0xd00));
 
                /*
                 *     Phase 2: Mask config
@@ -252,11 +179,11 @@ int ddr3_tip_dynamic_read_leveling(u32 dev_num, u32 freq)
                /* data pup rd reset enable  */
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             SDRAM_CONFIGURATION_REG, 0, (1 << 30)));
+                             SDRAM_CFG_REG, 0, (1 << 30)));
                /* data pup rd reset disable */
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             SDRAM_CONFIGURATION_REG, (1 << 30), (1 << 30)));
+                             SDRAM_CFG_REG, (1 << 30), (1 << 30)));
                /* training SW override & training RL mode */
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
@@ -270,72 +197,46 @@ int ddr3_tip_dynamic_read_leveling(u32 dev_num, u32 freq)
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
                              TRAINING_REG, (u32)(1 << 31), (u32)(1 << 31)));
 
-               /********* trigger training *******************/
-               /* Trigger, poll on status and disable ODPG */
-               CHECK_STATUS(ddr3_tip_if_write
-                            (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             ODPG_TRAINING_TRIGGER_REG, 0x1, 0x1));
-               CHECK_STATUS(ddr3_tip_if_write
-                            (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             ODPG_TRAINING_STATUS_REG, 0x1, 0x1));
+               /* trigger training */
+               mv_ddr_training_enable();
 
-               /* check for training done + results pass */
-               if (ddr3_tip_if_polling
-                   (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE, 0x2, 0x2,
-                    ODPG_TRAINING_STATUS_REG,
-                    MAX_POLLING_ITERATIONS) != MV_OK) {
-                       DEBUG_LEVELING(DEBUG_LEVEL_ERROR,
-                                      ("Training Done Failed\n"));
+               /* check for training done */
+               if (mv_ddr_is_training_done(MAX_POLLING_ITERATIONS, &data) != MV_OK) {
+                       DEBUG_LEVELING(DEBUG_LEVEL_ERROR, ("training done failed\n"));
                        return MV_FAIL;
                }
+               /* check for training pass */
+               if (data != PASS)
+                       DEBUG_LEVELING(DEBUG_LEVEL_INFO, ("training result failed\n"));
 
-               for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-                       VALIDATE_ACTIVE(tm->if_act_mask, if_id);
-                       CHECK_STATUS(ddr3_tip_if_read
-                                    (dev_num, ACCESS_TYPE_UNICAST,
-                                     if_id,
-                                     ODPG_TRAINING_TRIGGER_REG, data_read,
-                                     0x4));
-                       data = data_read[if_id];
-                       if (data != 0x0) {
-                               DEBUG_LEVELING(DEBUG_LEVEL_ERROR,
-                                              ("Training Result Failed\n"));
-                       }
-               }
+               /* disable odpg; switch back to functional mode */
+               mv_ddr_odpg_disable();
 
-               /*disable ODPG - Back to functional mode */
-               CHECK_STATUS(ddr3_tip_if_write
-                            (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             ODPG_ENABLE_REG, 0x1 << ODPG_DISABLE_OFFS,
-                             (0x1 << ODPG_DISABLE_OFFS)));
-               if (ddr3_tip_if_polling
-                   (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE, 0x0, 0x1,
-                    ODPG_ENABLE_REG, MAX_POLLING_ITERATIONS) != MV_OK) {
-                       DEBUG_LEVELING(DEBUG_LEVEL_ERROR,
-                                      ("ODPG disable failed "));
+               if (mv_ddr_is_odpg_done(MAX_POLLING_ITERATIONS) != MV_OK) {
+                       DEBUG_LEVELING(DEBUG_LEVEL_ERROR, ("odpg disable failed\n"));
                        return MV_FAIL;
                }
-               CHECK_STATUS(ddr3_tip_if_write
-                            (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             ODPG_DATA_CONTROL_REG, 0, MASK_ALL_BITS));
+
+               ddr3_tip_if_write(0, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
+                                 ODPG_DATA_CTRL_REG, 0, MASK_ALL_BITS);
 
                /* double loop on bus, pup */
                for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-                       VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+                       VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
                        /* check training done */
                        is_any_pup_fail = 0;
                        for (bus_num = 0;
-                            bus_num < tm->num_of_bus_per_interface;
+                            bus_num < octets_per_if_num;
                             bus_num++) {
-                               VALIDATE_ACTIVE(tm->bus_act_mask, bus_num);
+                               VALIDATE_BUS_ACTIVE(tm->bus_act_mask, bus_num);
                                if (ddr3_tip_if_polling
                                    (dev_num, ACCESS_TYPE_UNICAST,
                                     if_id, (1 << 25), (1 << 25),
                                     mask_results_pup_reg_map[bus_num],
                                     MAX_POLLING_ITERATIONS) != MV_OK) {
                                        DEBUG_LEVELING(DEBUG_LEVEL_ERROR,
-                                                      ("\n_r_l: DDR3 poll failed(2) for bus %d",
-                                                       bus_num));
+                                                      ("\n_r_l: DDR3 poll failed(2) for IF %d CS %d bus %d",
+                                                       if_id, effective_cs, bus_num));
                                        is_any_pup_fail = 1;
                                } else {
                                        /* read result per pup */
@@ -374,26 +275,26 @@ int ddr3_tip_dynamic_read_leveling(u32 dev_num, u32 freq)
                /* set ODPG to functional */
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             ODPG_DATA_CONTROL_REG, 0x0, MASK_ALL_BITS));
+                             ODPG_DATA_CTRL_REG, 0x0, MASK_ALL_BITS));
 
                /*
                 * Copy the result from the effective CS search to the
                 * real Functional CS
                 */
-               /*ddr3_tip_write_cs_result(dev_num, RL_PHY_REG); */
+               /*ddr3_tip_write_cs_result(dev_num, RL_PHY_REG(0); */
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             ODPG_DATA_CONTROL_REG, 0x0, MASK_ALL_BITS));
+                             ODPG_DATA_CTRL_REG, 0x0, MASK_ALL_BITS));
        }
 
        for (effective_cs = 0; effective_cs < max_cs; effective_cs++) {
                /* double loop on bus, pup */
                for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-                       VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+                       VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
                        for (bus_num = 0;
-                            bus_num < tm->num_of_bus_per_interface;
+                            bus_num < octets_per_if_num;
                             bus_num++) {
-                               VALIDATE_ACTIVE(tm->bus_act_mask, bus_num);
+                               VALIDATE_BUS_ACTIVE(tm->bus_act_mask, bus_num);
                                /* read result per pup from arry */
                                data = rl_values[effective_cs][bus_num][if_id];
                                data = (data & 0x1f) |
@@ -403,9 +304,8 @@ int ddr3_tip_dynamic_read_leveling(u32 dev_num, u32 freq)
                                                   if_id,
                                                   ACCESS_TYPE_UNICAST,
                                                   bus_num, DDR_PHY_DATA,
-                                                  RL_PHY_REG +
-                                                  ((effective_cs ==
-                                                    0) ? 0x0 : 0x4), data);
+                                                  RL_PHY_REG(effective_cs),
+                                                  data);
                        }
                }
        }
@@ -413,11 +313,11 @@ int ddr3_tip_dynamic_read_leveling(u32 dev_num, u32 freq)
        effective_cs = 0;
 
        for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-               VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+               VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
                /* restore cs enable value */
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_UNICAST, if_id,
-                             CS_ENABLE_REG, cs_enable_reg_val[if_id],
+                             DUAL_DUNIT_CFG_REG, cs_enable_reg_val[if_id],
                              MASK_ALL_BITS));
                if (odt_config != 0) {
                        CHECK_STATUS(ddr3_tip_write_additional_odt_setting
@@ -426,7 +326,7 @@ int ddr3_tip_dynamic_read_leveling(u32 dev_num, u32 freq)
        }
 
        for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-               VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+               VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
                if (training_result[training_stage][if_id] == TEST_FAILED)
                        return MV_FAIL;
        }
@@ -440,8 +340,8 @@ int ddr3_tip_dynamic_read_leveling(u32 dev_num, u32 freq)
 int ddr3_tip_legacy_dynamic_write_leveling(u32 dev_num)
 {
        u32 c_cs, if_id, cs_mask = 0;
-       u32 max_cs = hws_ddr3_tip_max_cs_get();
-       struct hws_topology_map *tm = ddr3_get_topology_map();
+       u32 max_cs = ddr3_tip_max_cs_get(dev_num);
+       struct mv_ddr_topology_map *tm = mv_ddr_topology_map_get();
 
        /*
         * In TRAINIUNG reg (0x15b0) write 0x80000008 | cs_mask:
@@ -456,7 +356,7 @@ int ddr3_tip_legacy_dynamic_write_leveling(u32 dev_num)
                cs_mask = cs_mask | 1 << (20 + c_cs);
 
        for (if_id = 0; if_id < MAX_INTERFACE_NUM; if_id++) {
-               VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+               VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, 0,
                              TRAINING_REG, (0x80000008 | cs_mask),
@@ -481,8 +381,8 @@ int ddr3_tip_legacy_dynamic_write_leveling(u32 dev_num)
 int ddr3_tip_legacy_dynamic_read_leveling(u32 dev_num)
 {
        u32 c_cs, if_id, cs_mask = 0;
-       u32 max_cs = hws_ddr3_tip_max_cs_get();
-       struct hws_topology_map *tm = ddr3_get_topology_map();
+       u32 max_cs = ddr3_tip_max_cs_get(dev_num);
+       struct mv_ddr_topology_map *tm = mv_ddr_topology_map_get();
 
        /*
         * In TRAINIUNG reg (0x15b0) write 0x80000040 | cs_mask:
@@ -502,7 +402,7 @@ int ddr3_tip_legacy_dynamic_read_leveling(u32 dev_num)
        mdelay(100);
 
        for (if_id = 0; if_id < MAX_INTERFACE_NUM; if_id++) {
-               VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+               VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
                if (ddr3_tip_if_polling
                    (dev_num, ACCESS_TYPE_UNICAST, if_id, 0,
                     (u32)0x80000000, TRAINING_REG,
@@ -535,38 +435,39 @@ int ddr3_tip_dynamic_per_bit_read_leveling(u32 dev_num, u32 freq)
        u32 data2_write[MAX_INTERFACE_NUM][MAX_BUS_NUM];
        struct pattern_info *pattern_table = ddr3_tip_get_pattern_table();
        u16 *mask_results_dq_reg_map = ddr3_tip_get_mask_results_dq_reg();
-       struct hws_topology_map *tm = ddr3_get_topology_map();
+       u32 octets_per_if_num = ddr3_tip_dev_attr_get(dev_num, MV_ATTR_OCTET_PER_INTERFACE);
+       struct mv_ddr_topology_map *tm = mv_ddr_topology_map_get();
 
        for (if_id = 0; if_id < MAX_INTERFACE_NUM; if_id++) {
-               VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+               VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
                for (bus_num = 0;
-                    bus_num <= tm->num_of_bus_per_interface; bus_num++) {
-                       VALIDATE_ACTIVE(tm->bus_act_mask, bus_num);
+                    bus_num <= octets_per_if_num; bus_num++) {
+                       VALIDATE_BUS_ACTIVE(tm->bus_act_mask, bus_num);
                        per_bit_rl_pup_status[if_id][bus_num] = 0;
                        data2_write[if_id][bus_num] = 0;
                        /* read current value of phy register 0x3 */
                        CHECK_STATUS(ddr3_tip_bus_read
                                     (dev_num, if_id, ACCESS_TYPE_UNICAST,
                                      bus_num, DDR_PHY_DATA,
-                                     READ_CENTRALIZATION_PHY_REG,
+                                     CRX_PHY_REG(0),
                                      &phyreg3_arr[if_id][bus_num]));
                }
        }
 
        /* NEW RL machine */
        for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-               VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+               VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
                training_result[training_stage][if_id] = TEST_SUCCESS;
 
                /* save current cs enable reg val */
                CHECK_STATUS(ddr3_tip_if_read
                             (dev_num, ACCESS_TYPE_UNICAST, if_id,
-                             CS_ENABLE_REG, &cs_enable_reg_val[if_id],
+                             DUAL_DUNIT_CFG_REG, &cs_enable_reg_val[if_id],
                              MASK_ALL_BITS));
                /* enable single cs */
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_UNICAST, if_id,
-                             CS_ENABLE_REG, (1 << 3), (1 << 3)));
+                             DUAL_DUNIT_CFG_REG, (1 << 3), (1 << 3)));
        }
 
        ddr3_tip_reset_fifo_ptr(dev_num);
@@ -584,7 +485,7 @@ int ddr3_tip_dynamic_per_bit_read_leveling(u32 dev_num, u32 freq)
                /* BUS count is 0 shifted 26 */
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             ODPG_DATA_CONTROL_REG, 0x3, 0x3));
+                             ODPG_DATA_CTRL_REG, 0x3, 0x3));
                CHECK_STATUS(ddr3_tip_configure_odpg
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE, 0,
                              pattern_table[PATTERN_TEST].num_of_phases_tx, 0,
@@ -604,15 +505,15 @@ int ddr3_tip_dynamic_per_bit_read_leveling(u32 dev_num, u32 freq)
                /* General Training Opcode register */
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             ODPG_WRITE_READ_MODE_ENABLE_REG, 0,
+                             ODPG_WR_RD_MODE_ENA_REG, 0,
                              MASK_ALL_BITS));
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             ODPG_TRAINING_CONTROL_REG, 0x301b01, 0x3c3fef));
+                             GENERAL_TRAINING_OPCODE_REG, 0x301b01, 0x3c3fef));
 
                /* Object1 opcode register 0 & 1 */
                for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-                       VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+                       VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
                        speed_bin_index =
                                tm->interface_params[if_id].speed_bin_index;
                        cl_val =
@@ -621,13 +522,13 @@ int ddr3_tip_dynamic_per_bit_read_leveling(u32 dev_num, u32 freq)
                        mask = (0xff << 9) | (0x1f << 17) | (0x3 << 25);
                        CHECK_STATUS(ddr3_tip_if_write
                                     (dev_num, ACCESS_TYPE_UNICAST, if_id,
-                                     ODPG_OBJ1_OPCODE_REG, data, mask));
+                                     OPCODE_REG0_REG(1), data, mask));
                }
 
                /* Set iteration count to max value */
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             TRAINING_OPCODE_1_REG, 0xd00, 0xd00));
+                             OPCODE_REG1_REG(1), 0xd00, 0xd00));
 
                /*
                 *     Phase 2: Mask config
@@ -651,11 +552,11 @@ int ddr3_tip_dynamic_per_bit_read_leveling(u32 dev_num, u32 freq)
                /* data pup rd reset enable  */
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             SDRAM_CONFIGURATION_REG, 0, (1 << 30)));
+                             SDRAM_CFG_REG, 0, (1 << 30)));
                /* data pup rd reset disable */
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             SDRAM_CONFIGURATION_REG, (1 << 30), (1 << 30)));
+                             SDRAM_CFG_REG, (1 << 30), (1 << 30)));
                /* training SW override & training RL mode */
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
@@ -669,63 +570,37 @@ int ddr3_tip_dynamic_per_bit_read_leveling(u32 dev_num, u32 freq)
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
                              TRAINING_REG, (u32)(1 << 31), (u32)(1 << 31)));
 
-               /********* trigger training *******************/
-               /* Trigger, poll on status and disable ODPG */
-               CHECK_STATUS(ddr3_tip_if_write
-                            (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             ODPG_TRAINING_TRIGGER_REG, 0x1, 0x1));
-               CHECK_STATUS(ddr3_tip_if_write
-                            (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             ODPG_TRAINING_STATUS_REG, 0x1, 0x1));
+               /* trigger training */
+               mv_ddr_training_enable();
 
-               /*check for training done + results pass */
-               if (ddr3_tip_if_polling
-                   (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE, 0x2, 0x2,
-                    ODPG_TRAINING_STATUS_REG,
-                    MAX_POLLING_ITERATIONS) != MV_OK) {
-                       DEBUG_LEVELING(DEBUG_LEVEL_ERROR,
-                                      ("Training Done Failed\n"));
+               /* check for training done */
+               if (mv_ddr_is_training_done(MAX_POLLING_ITERATIONS, &data) != MV_OK) {
+                       DEBUG_LEVELING(DEBUG_LEVEL_ERROR, ("training done failed\n"));
                        return MV_FAIL;
                }
+               /* check for training pass */
+               if (data != PASS)
+                       DEBUG_LEVELING(DEBUG_LEVEL_INFO, ("training result failed\n"));
 
-               for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-                       VALIDATE_ACTIVE(tm->if_act_mask, if_id);
-                       CHECK_STATUS(ddr3_tip_if_read
-                                    (dev_num, ACCESS_TYPE_UNICAST,
-                                     if_id,
-                                     ODPG_TRAINING_TRIGGER_REG, data_read,
-                                     0x4));
-                       data = data_read[if_id];
-                       if (data != 0x0) {
-                               DEBUG_LEVELING(DEBUG_LEVEL_ERROR,
-                                              ("Training Result Failed\n"));
-                       }
-               }
+               /* disable odpg; switch back to functional mode */
+               mv_ddr_odpg_disable();
 
-               /*disable ODPG - Back to functional mode */
-               CHECK_STATUS(ddr3_tip_if_write
-                            (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             ODPG_ENABLE_REG, 0x1 << ODPG_DISABLE_OFFS,
-                             (0x1 << ODPG_DISABLE_OFFS)));
-               if (ddr3_tip_if_polling
-                   (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE, 0x0, 0x1,
-                    ODPG_ENABLE_REG, MAX_POLLING_ITERATIONS) != MV_OK) {
-                       DEBUG_LEVELING(DEBUG_LEVEL_ERROR,
-                                      ("ODPG disable failed "));
+               if (mv_ddr_is_odpg_done(MAX_POLLING_ITERATIONS) != MV_OK) {
+                       DEBUG_LEVELING(DEBUG_LEVEL_ERROR, ("odpg disable failed\n"));
                        return MV_FAIL;
                }
-               CHECK_STATUS(ddr3_tip_if_write
-                            (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             ODPG_DATA_CONTROL_REG, 0, MASK_ALL_BITS));
+
+               ddr3_tip_if_write(0, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
+                                 ODPG_DATA_CTRL_REG, 0, MASK_ALL_BITS);
 
                /* double loop on bus, pup */
                for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-                       VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+                       VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
                        /* check training done */
                        for (bus_num = 0;
-                            bus_num < tm->num_of_bus_per_interface;
+                            bus_num < octets_per_if_num;
                             bus_num++) {
-                               VALIDATE_ACTIVE(tm->bus_act_mask, bus_num);
+                               VALIDATE_BUS_ACTIVE(tm->bus_act_mask, bus_num);
 
                                if (per_bit_rl_pup_status[if_id][bus_num]
                                    == 0) {
@@ -795,11 +670,11 @@ int ddr3_tip_dynamic_per_bit_read_leveling(u32 dev_num, u32 freq)
                        /* if there is DLL that is not checked yet */
                        for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1;
                             if_id++) {
-                               VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+                               VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
                                for (bus_num = 0;
-                                    bus_num < tm->num_of_bus_per_interface;
+                                    bus_num < octets_per_if_num;
                                     bus_num++) {
-                                       VALIDATE_ACTIVE(tm->bus_act_mask,
+                                       VALIDATE_BUS_ACTIVE(tm->bus_act_mask,
                                                        bus_num);
                                        if (per_bit_rl_pup_status[if_id]
                                            [bus_num] != 1) {
@@ -811,7 +686,7 @@ int ddr3_tip_dynamic_per_bit_read_leveling(u32 dev_num, u32 freq)
                                                          if_id,
                                                          ACCESS_TYPE_UNICAST,
                                                          bus_num, DDR_PHY_DATA,
-                                                         READ_CENTRALIZATION_PHY_REG,
+                                                         CRX_PHY_REG(0),
                                                          (phyreg3_arr[if_id]
                                                           [bus_num] +
                                                           adll_array[curr_numb])));
@@ -828,18 +703,17 @@ int ddr3_tip_dynamic_per_bit_read_leveling(u32 dev_num, u32 freq)
        }               /* for ( curr_numb = 0; curr_numb <3; curr_numb++) */
 
        for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-               VALIDATE_ACTIVE(tm->if_act_mask, if_id);
-               for (bus_num = 0; bus_num < tm->num_of_bus_per_interface;
+               VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
+               for (bus_num = 0; bus_num < octets_per_if_num;
                     bus_num++) {
-                       VALIDATE_ACTIVE(tm->bus_act_mask, bus_num);
+                       VALIDATE_BUS_ACTIVE(tm->bus_act_mask, bus_num);
                        if (per_bit_rl_pup_status[if_id][bus_num] == 1)
                                ddr3_tip_bus_write(dev_num,
                                                   ACCESS_TYPE_UNICAST,
                                                   if_id,
                                                   ACCESS_TYPE_UNICAST,
                                                   bus_num, DDR_PHY_DATA,
-                                                  RL_PHY_REG +
-                                                  CS_REG_VALUE(effective_cs),
+                                                  RL_PHY_REG(effective_cs),
                                                   data2_write[if_id]
                                                   [bus_num]);
                        else
@@ -881,22 +755,22 @@ int ddr3_tip_dynamic_per_bit_read_leveling(u32 dev_num, u32 freq)
        /* set ODPG to functional */
        CHECK_STATUS(ddr3_tip_if_write
                     (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                     ODPG_DATA_CONTROL_REG, 0x0, MASK_ALL_BITS));
+                     ODPG_DATA_CTRL_REG, 0x0, MASK_ALL_BITS));
        /*
         * Copy the result from the effective CS search to the real
         * Functional CS
         */
-       ddr3_tip_write_cs_result(dev_num, RL_PHY_REG);
+       ddr3_tip_write_cs_result(dev_num, RL_PHY_REG(0));
        CHECK_STATUS(ddr3_tip_if_write
                     (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                     ODPG_DATA_CONTROL_REG, 0x0, MASK_ALL_BITS));
+                     ODPG_DATA_CTRL_REG, 0x0, MASK_ALL_BITS));
 
        for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-               VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+               VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
                /* restore cs enable value */
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_UNICAST, if_id,
-                             CS_ENABLE_REG, cs_enable_reg_val[if_id],
+                             DUAL_DUNIT_CFG_REG, cs_enable_reg_val[if_id],
                              MASK_ALL_BITS));
                if (odt_config != 0) {
                        CHECK_STATUS(ddr3_tip_write_additional_odt_setting
@@ -905,7 +779,7 @@ int ddr3_tip_dynamic_per_bit_read_leveling(u32 dev_num, u32 freq)
        }
 
        for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-               VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+               VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
                if (training_result[training_stage][if_id] == TEST_FAILED)
                        return MV_FAIL;
        }
@@ -918,7 +792,8 @@ int ddr3_tip_calc_cs_mask(u32 dev_num, u32 if_id, u32 effective_cs,
 {
        u32 all_bus_cs = 0, same_bus_cs;
        u32 bus_cnt;
-       struct hws_topology_map *tm = ddr3_get_topology_map();
+       u32 octets_per_if_num = ddr3_tip_dev_attr_get(dev_num, MV_ATTR_OCTET_PER_INTERFACE);
+       struct mv_ddr_topology_map *tm = mv_ddr_topology_map_get();
 
        *cs_mask = same_bus_cs = CS_BIT_MASK;
 
@@ -931,8 +806,8 @@ int ddr3_tip_calc_cs_mask(u32 dev_num, u32 if_id, u32 effective_cs,
         * If they are they are not the same then it's mixed mode so all CS
         * should be configured (when configuring the MRS)
         */
-       for (bus_cnt = 0; bus_cnt < tm->num_of_bus_per_interface; bus_cnt++) {
-               VALIDATE_ACTIVE(tm->bus_act_mask, bus_cnt);
+       for (bus_cnt = 0; bus_cnt < octets_per_if_num; bus_cnt++) {
+               VALIDATE_BUS_ACTIVE(tm->bus_act_mask, bus_cnt);
 
                all_bus_cs |= tm->interface_params[if_id].
                        as_bus_params[bus_cnt].cs_bitmask;
@@ -953,9 +828,9 @@ int ddr3_tip_calc_cs_mask(u32 dev_num, u32 if_id, u32 effective_cs,
 /*
  * Dynamic write leveling
  */
-int ddr3_tip_dynamic_write_leveling(u32 dev_num)
+int ddr3_tip_dynamic_write_leveling(u32 dev_num, int phase_remove)
 {
-       u32 reg_data = 0, iter, if_id, bus_cnt;
+       u32 reg_data = 0, temp = 0, iter, if_id, bus_cnt;
        u32 cs_enable_reg_val[MAX_INTERFACE_NUM] = { 0 };
        u32 cs_mask[MAX_INTERFACE_NUM];
        u32 read_data_sample_delay_vals[MAX_INTERFACE_NUM] = { 0 };
@@ -967,28 +842,36 @@ int ddr3_tip_dynamic_write_leveling(u32 dev_num)
        u8 wl_values[NUM_OF_CS][MAX_BUS_NUM][MAX_INTERFACE_NUM];
        u16 *mask_results_pup_reg_map = ddr3_tip_get_mask_results_pup_reg_map();
        u32 cs_mask0[MAX_INTERFACE_NUM] = { 0 };
-       u32 max_cs = hws_ddr3_tip_max_cs_get();
-       struct hws_topology_map *tm = ddr3_get_topology_map();
+       u32 max_cs = ddr3_tip_max_cs_get(dev_num);
+       u32 octets_per_if_num = ddr3_tip_dev_attr_get(dev_num, MV_ATTR_OCTET_PER_INTERFACE);
+       struct mv_ddr_topology_map *tm = mv_ddr_topology_map_get();
 
        for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-               VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+               VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
 
                training_result[training_stage][if_id] = TEST_SUCCESS;
 
                /* save Read Data Sample Delay */
                CHECK_STATUS(ddr3_tip_if_read
                             (dev_num, ACCESS_TYPE_UNICAST, if_id,
-                             READ_DATA_SAMPLE_DELAY,
+                             RD_DATA_SMPL_DLYS_REG,
                              read_data_sample_delay_vals, MASK_ALL_BITS));
                /* save Read Data Ready Delay */
                CHECK_STATUS(ddr3_tip_if_read
                             (dev_num, ACCESS_TYPE_UNICAST, if_id,
-                             READ_DATA_READY_DELAY, read_data_ready_delay_vals,
+                             RD_DATA_RDY_DLYS_REG, read_data_ready_delay_vals,
                              MASK_ALL_BITS));
                /* save current cs reg val */
                CHECK_STATUS(ddr3_tip_if_read
                             (dev_num, ACCESS_TYPE_UNICAST, if_id,
-                             CS_ENABLE_REG, cs_enable_reg_val, MASK_ALL_BITS));
+                             DUAL_DUNIT_CFG_REG, cs_enable_reg_val, MASK_ALL_BITS));
+       }
+
+       if (ddr3_tip_dev_attr_get(dev_num, MV_ATTR_TIP_REV) < MV_TIP_REV_3) {
+               /* Enable multi-CS */
+               CHECK_STATUS(ddr3_tip_if_write
+                            (dev_num, ACCESS_TYPE_UNICAST, if_id,
+                            DUAL_DUNIT_CFG_REG, 0, (1 << 3)));
        }
 
        /*
@@ -998,19 +881,19 @@ int ddr3_tip_dynamic_write_leveling(u32 dev_num)
        /*Assert 10 refresh commands to DRAM to all CS */
        for (iter = 0; iter < WL_ITERATION_NUM; iter++) {
                for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-                       VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+                       VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
                        CHECK_STATUS(ddr3_tip_if_write
                                     (dev_num, ACCESS_TYPE_UNICAST,
-                                     if_id, SDRAM_OPERATION_REG,
+                                     if_id, SDRAM_OP_REG,
                                      (u32)((~(0xf) << 8) | 0x2), 0xf1f));
                }
        }
        /* check controller back to normal */
        for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-               VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+               VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
                if (ddr3_tip_if_polling
                    (dev_num, ACCESS_TYPE_UNICAST, if_id, 0, 0x1f,
-                    SDRAM_OPERATION_REG, MAX_POLLING_ITERATIONS) != MV_OK) {
+                    SDRAM_OP_REG, MAX_POLLING_ITERATIONS) != MV_OK) {
                        DEBUG_LEVELING(DEBUG_LEVEL_ERROR,
                                       ("WL: DDR3 poll failed(3)"));
                }
@@ -1019,24 +902,30 @@ int ddr3_tip_dynamic_write_leveling(u32 dev_num)
        for (effective_cs = 0; effective_cs < max_cs; effective_cs++) {
                /*enable write leveling to all cs  - Q off , WL n */
                /* calculate interface cs mask */
-               CHECK_STATUS(ddr3_tip_write_mrs_cmd(dev_num, cs_mask0, MRS1_CMD,
+               CHECK_STATUS(ddr3_tip_write_mrs_cmd(dev_num, cs_mask0, MR_CMD1,
                                                    0x1000, 0x1080));
 
                for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-                       VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+                       VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
                        /* cs enable is active low */
                        ddr3_tip_calc_cs_mask(dev_num, if_id, effective_cs,
                                              &cs_mask[if_id]);
                }
 
-               /* Enable Output buffer to relevant CS - Q on , WL on */
-               CHECK_STATUS(ddr3_tip_write_mrs_cmd
-                            (dev_num, cs_mask, MRS1_CMD, 0x80, 0x1080));
+               if (ddr3_tip_dev_attr_get(dev_num, MV_ATTR_TIP_REV) >= MV_TIP_REV_3) {
+                       /* Enable Output buffer to relevant CS - Q on , WL on */
+                       CHECK_STATUS(ddr3_tip_write_mrs_cmd
+                                    (dev_num, cs_mask, MR_CMD1, 0x80, 0x1080));
 
-               /*enable odt for relevant CS */
-               CHECK_STATUS(ddr3_tip_if_write
-                            (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             0x1498, (0x3 << (effective_cs * 2)), 0xf));
+                       /*enable odt for relevant CS */
+                       CHECK_STATUS(ddr3_tip_if_write
+                                    (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
+                                     0x1498, (0x3 << (effective_cs * 2)), 0xf));
+               } else {
+                       /* FIXME: should be the same as _CPU case */
+                       CHECK_STATUS(ddr3_tip_write_mrs_cmd
+                                    (dev_num, cs_mask, MR_CMD1, 0xc0, 0x12c4));
+               }
 
                /*
                 *     Phase 2: Set training IP to write leveling mode
@@ -1044,110 +933,91 @@ int ddr3_tip_dynamic_write_leveling(u32 dev_num)
 
                CHECK_STATUS(ddr3_tip_dynamic_write_leveling_seq(dev_num));
 
+               /* phase 3: trigger training */
+               mv_ddr_training_enable();
+
+               /* check for training done */
+               if (mv_ddr_is_training_done(MAX_POLLING_ITERATIONS, data_read) != MV_OK) {
+                       DEBUG_LEVELING(DEBUG_LEVEL_ERROR, ("training done failed\n"));
+               } else { /* check for training pass */
+                       reg_data = data_read[0];
+#if defined(CONFIG_ARMADA_38X) /* JIRA #1498 for 16 bit with ECC */
+                       if (tm->bus_act_mask == 0xb) /* set to data to 0 to skip the check */
+                               reg_data = 0;
+#endif
+                       if (reg_data != PASS)
+                               DEBUG_LEVELING(DEBUG_LEVEL_INFO, ("training result failed\n"));
+
+                       /* check for training completion per bus */
+                       for (bus_cnt = 0; bus_cnt < octets_per_if_num; bus_cnt++) {
+                               VALIDATE_BUS_ACTIVE(tm->bus_act_mask, bus_cnt);
+                               /* training status */
+                               ddr3_tip_if_read(0, ACCESS_TYPE_UNICAST, 0,
+                                             mask_results_pup_reg_map[bus_cnt],
+                                             data_read, MASK_ALL_BITS);
+                               reg_data = data_read[0];
+                               DEBUG_LEVELING(DEBUG_LEVEL_TRACE, ("WL: IF %d BUS %d reg 0x%x\n",
+                                                                  0, bus_cnt, reg_data));
+                               if ((reg_data & (1 << 25)) == 0)
+                                       res_values[bus_cnt] = 1;
+                               ddr3_tip_if_read(0, ACCESS_TYPE_UNICAST, 0,
+                                             mask_results_pup_reg_map[bus_cnt],
+                                             data_read, 0xff);
+                               /*
+                                * Save the read value that should be
+                                * write to PHY register
+                                */
+                               wl_values[effective_cs][bus_cnt][0] = (u8)data_read[0];
+                       }
+               }
+
                /*
-                *     Phase 3: Trigger training
+                *     Phase 3.5: Validate result
                 */
-
-               CHECK_STATUS(ddr3_tip_if_write
-                            (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             ODPG_TRAINING_TRIGGER_REG, 0x1, 0x1));
-
                for (if_id = 0; if_id < MAX_INTERFACE_NUM; if_id++) {
-                       VALIDATE_ACTIVE(tm->if_act_mask, if_id);
-
-                       /* training done */
-                       if (ddr3_tip_if_polling
-                           (dev_num, ACCESS_TYPE_UNICAST, if_id,
-                            (1 << 1), (1 << 1), ODPG_TRAINING_STATUS_REG,
-                            MAX_POLLING_ITERATIONS) != MV_OK) {
-                               DEBUG_LEVELING(
-                                       DEBUG_LEVEL_ERROR,
-                                       ("WL: DDR3 poll (4) failed (Data: 0x%x)\n",
-                                        reg_data));
-                       }
-#if !defined(CONFIG_ARMADA_38X)        /*Disabled. JIRA #1498 */
-                       else {
+                       VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
+                       for (bus_cnt = 0; bus_cnt < octets_per_if_num; bus_cnt++) {
+                               VALIDATE_BUS_ACTIVE(tm->bus_act_mask, bus_cnt);
+                               /*
+                                * Read result control register according to subphy
+                                * "16" below is for a half-phase
+                                */
+                               reg_data = wl_values[effective_cs][bus_cnt][if_id] + 16;
+                               /*
+                                * Write to WL register: ADLL [4:0], Phase [8:6],
+                                * Centralization ADLL [15:10] + 0x10
+                                */
+                               reg_data = (reg_data & 0x1f) |
+                                          (((reg_data & 0xe0) >> 5) << 6) |
+                                          (((reg_data & 0x1f) + phy_reg1_val) << 10);
+                               /* Search with WL CS0 subphy reg */
+                               ddr3_tip_bus_write(dev_num, ACCESS_TYPE_UNICAST, if_id,
+                                                  ACCESS_TYPE_UNICAST, bus_cnt,
+                                                  DDR_PHY_DATA, WL_PHY_REG(0), reg_data);
+                               /*
+                                * Check for change in data read from DRAM.
+                                * If changed, fix the result
+                                */
                                CHECK_STATUS(ddr3_tip_if_read
-                                            (dev_num, ACCESS_TYPE_UNICAST,
+                                            (dev_num,
+                                             ACCESS_TYPE_UNICAST,
                                              if_id,
-                                             ODPG_TRAINING_TRIGGER_REG,
-                                             &reg_data, (1 << 2)));
-                               if (reg_data != 0) {
+                                             TRAINING_WL_REG,
+                                             data_read, MASK_ALL_BITS));
+                               if (((data_read[if_id] & (1 << (bus_cnt + 20))) >>
+                                    (bus_cnt + 20)) == 0) {
                                        DEBUG_LEVELING(
                                                DEBUG_LEVEL_ERROR,
-                                               ("WL: WL failed IF %d reg_data=0x%x\n",
-                                                if_id, reg_data));
-                               }
-                       }
-#endif
-               }
-
-               for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-                       VALIDATE_ACTIVE(tm->if_act_mask, if_id);
-                       /* training done */
-                       if (ddr3_tip_if_polling
-                           (dev_num, ACCESS_TYPE_UNICAST, if_id,
-                            (1 << 1), (1 << 1), ODPG_TRAINING_STATUS_REG,
-                            MAX_POLLING_ITERATIONS) != MV_OK) {
-                               DEBUG_LEVELING(
-                                       DEBUG_LEVEL_ERROR,
-                                       ("WL: DDR3 poll (4) failed (Data: 0x%x)\n",
-                                        reg_data));
-                       } else {
-#if !defined(CONFIG_ARMADA_38X)        /*Disabled. JIRA #1498 */
-                               CHECK_STATUS(ddr3_tip_if_read
-                                            (dev_num, ACCESS_TYPE_UNICAST,
-                                             if_id,
-                                             ODPG_TRAINING_STATUS_REG,
-                                             data_read, (1 << 2)));
-                               reg_data = data_read[if_id];
-                               if (reg_data != 0) {
+                                               ("WLValues was changed from 0x%X",
+                                                wl_values[effective_cs]
+                                                [bus_cnt][if_id]));
+                                       wl_values[effective_cs]
+                                       [bus_cnt][if_id] += 32;
                                        DEBUG_LEVELING(
                                                DEBUG_LEVEL_ERROR,
-                                               ("WL: WL failed IF %d reg_data=0x%x\n",
-                                                if_id, reg_data));
-                               }
-#endif
-
-                               /* check for training completion per bus */
-                               for (bus_cnt = 0;
-                                    bus_cnt < tm->num_of_bus_per_interface;
-                                    bus_cnt++) {
-                                       VALIDATE_ACTIVE(tm->bus_act_mask,
-                                                       bus_cnt);
-                                       /* training status */
-                                       CHECK_STATUS(ddr3_tip_if_read
-                                                    (dev_num,
-                                                     ACCESS_TYPE_UNICAST,
-                                                     if_id,
-                                                     mask_results_pup_reg_map
-                                                     [bus_cnt], data_read,
-                                                     (1 << 25)));
-                                       reg_data = data_read[if_id];
-                                       DEBUG_LEVELING(
-                                               DEBUG_LEVEL_TRACE,
-                                               ("WL: IF %d BUS %d reg 0x%x\n",
-                                                if_id, bus_cnt, reg_data));
-                                       if (reg_data == 0) {
-                                               res_values[
-                                                       (if_id *
-                                                        tm->num_of_bus_per_interface)
-                                                       + bus_cnt] = 1;
-                                       }
-                                       CHECK_STATUS(ddr3_tip_if_read
-                                                    (dev_num,
-                                                     ACCESS_TYPE_UNICAST,
-                                                     if_id,
-                                                     mask_results_pup_reg_map
-                                                     [bus_cnt], data_read,
-                                                     0xff));
-                                       /*
-                                        * Save the read value that should be
-                                        * write to PHY register
-                                        */
-                                       wl_values[effective_cs]
-                                               [bus_cnt][if_id] =
-                                               (u8)data_read[if_id];
+                                               ("to 0x%X",
+                                                wl_values[effective_cs]
+                                                [bus_cnt][if_id]));
                                }
                        }
                }
@@ -1159,15 +1029,21 @@ int ddr3_tip_dynamic_write_leveling(u32 dev_num)
                /* disable DQs toggling */
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                             WR_LEVELING_DQS_PATTERN_REG, 0x0, 0x1));
+                             WL_DQS_PATTERN_REG, 0x0, 0x1));
 
                /* Update MRS 1 (WL off) */
-               CHECK_STATUS(ddr3_tip_write_mrs_cmd(dev_num, cs_mask0, MRS1_CMD,
-                                                   0x1000, 0x1080));
+               if (ddr3_tip_dev_attr_get(dev_num, MV_ATTR_TIP_REV) >= MV_TIP_REV_3) {
+                       CHECK_STATUS(ddr3_tip_write_mrs_cmd(dev_num, cs_mask0, MR_CMD1,
+                                                           0x1000, 0x1080));
+               } else {
+                       /* FIXME: should be same as _CPU case */
+                       CHECK_STATUS(ddr3_tip_write_mrs_cmd(dev_num, cs_mask0, MR_CMD1,
+                                                           0x1000, 0x12c4));
+               }
 
                /* Update MRS 1 (return to functional mode - Q on , WL off) */
                CHECK_STATUS(ddr3_tip_write_mrs_cmd
-                            (dev_num, cs_mask0, MRS1_CMD, 0x0, 0x1080));
+                            (dev_num, cs_mask0, MR_CMD1, 0x0, 0x1080));
 
                /* set phy to normal mode */
                CHECK_STATUS(ddr3_tip_if_write
@@ -1186,16 +1062,16 @@ int ddr3_tip_dynamic_write_leveling(u32 dev_num)
 
        for (effective_cs = 0; effective_cs < max_cs; effective_cs++) {
                for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-                       VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+                       VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
                        test_res = 0;
                        for (bus_cnt = 0;
-                            bus_cnt < tm->num_of_bus_per_interface;
+                            bus_cnt < octets_per_if_num;
                             bus_cnt++) {
-                               VALIDATE_ACTIVE(tm->bus_act_mask, bus_cnt);
+                               VALIDATE_BUS_ACTIVE(tm->bus_act_mask, bus_cnt);
                                /* check if result == pass */
                                if (res_values
                                    [(if_id *
-                                     tm->num_of_bus_per_interface) +
+                                     octets_per_if_num) +
                                     bus_cnt] == 0) {
                                        /*
                                         * read result control register
@@ -1214,6 +1090,18 @@ int ddr3_tip_dynamic_write_leveling(u32 dev_num)
                                                (((reg_data & 0xe0) >> 5) << 6) |
                                                (((reg_data & 0x1f) +
                                                  phy_reg1_val) << 10);
+                                       /*
+                                        * in case phase remove should be executed
+                                        * need to remove more than one phase.
+                                        * this will take place only in low frequency,
+                                        * where there could be more than one phase between sub-phys
+                                        */
+                                       if (phase_remove == 1) {
+                                               temp = (reg_data >> WR_LVL_PH_SEL_OFFS) & WR_LVL_PH_SEL_PHASE1;
+                                               reg_data &= ~(WR_LVL_PH_SEL_MASK << WR_LVL_PH_SEL_OFFS);
+                                               reg_data |= (temp << WR_LVL_PH_SEL_OFFS);
+                                       }
+
                                        ddr3_tip_bus_write(
                                                dev_num,
                                                ACCESS_TYPE_UNICAST,
@@ -1221,9 +1109,7 @@ int ddr3_tip_dynamic_write_leveling(u32 dev_num)
                                                ACCESS_TYPE_UNICAST,
                                                bus_cnt,
                                                DDR_PHY_DATA,
-                                               WL_PHY_REG +
-                                               effective_cs *
-                                               CS_REGISTER_ADDR_OFFSET,
+                                               WL_PHY_REG(effective_cs),
                                                reg_data);
                                } else {
                                        test_res = 1;
@@ -1259,38 +1145,48 @@ int ddr3_tip_dynamic_write_leveling(u32 dev_num)
         * Copy the result from the effective CS search to the real
         * Functional CS
         */
-       /* ddr3_tip_write_cs_result(dev_num, WL_PHY_REG); */
+       /* ddr3_tip_write_cs_result(dev_num, WL_PHY_REG(0); */
        /* restore saved values */
        for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-               VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+               VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
                /* restore Read Data Sample Delay */
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_UNICAST, if_id,
-                             READ_DATA_SAMPLE_DELAY,
+                             RD_DATA_SMPL_DLYS_REG,
                              read_data_sample_delay_vals[if_id],
                              MASK_ALL_BITS));
 
                /* restore Read Data Ready Delay */
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_UNICAST, if_id,
-                             READ_DATA_READY_DELAY,
+                             RD_DATA_RDY_DLYS_REG,
                              read_data_ready_delay_vals[if_id],
                              MASK_ALL_BITS));
 
                /* enable multi cs */
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_UNICAST, if_id,
-                             CS_ENABLE_REG, cs_enable_reg_val[if_id],
+                             DUAL_DUNIT_CFG_REG, cs_enable_reg_val[if_id],
                              MASK_ALL_BITS));
        }
 
-       /* Disable modt0 for CS0 training - need to adjust for multy CS */
-       CHECK_STATUS(ddr3_tip_if_write
-                    (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE, 0x1498,
-                     0x0, 0xf));
+       if (ddr3_tip_dev_attr_get(dev_num, MV_ATTR_TIP_REV) >= MV_TIP_REV_3) {
+               /* Disable modt0 for CS0 training - need to adjust for multi-CS
+                * in case of ddr4 set 0xf else 0
+                */
+               if (odt_config != 0) {
+                       CHECK_STATUS(ddr3_tip_if_write(dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
+                                                      SDRAM_ODT_CTRL_HIGH_REG, 0x0, 0xf));
+               }
+               else {
+                       CHECK_STATUS(ddr3_tip_if_write(dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
+                                                      SDRAM_ODT_CTRL_HIGH_REG, 0xf, 0xf));
+               }
+
+       }
 
        for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-               VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+               VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
                if (training_result[training_stage][if_id] == TEST_FAILED)
                        return MV_FAIL;
        }
@@ -1306,28 +1202,27 @@ int ddr3_tip_dynamic_write_leveling_supp(u32 dev_num)
        int adll_offset;
        u32 if_id, bus_id, data, data_tmp;
        int is_if_fail = 0;
-       struct hws_topology_map *tm = ddr3_get_topology_map();
+       u32 octets_per_if_num = ddr3_tip_dev_attr_get(dev_num, MV_ATTR_OCTET_PER_INTERFACE);
+       struct mv_ddr_topology_map *tm = mv_ddr_topology_map_get();
 
        for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-               VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+               VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
                is_if_fail = 0;
 
-               for (bus_id = 0; bus_id < GET_TOPOLOGY_NUM_OF_BUSES();
-                    bus_id++) {
-                       VALIDATE_ACTIVE(tm->bus_act_mask, bus_id);
+               for (bus_id = 0; bus_id < octets_per_if_num; bus_id++) {
+                       VALIDATE_BUS_ACTIVE(tm->bus_act_mask, bus_id);
                        wr_supp_res[if_id][bus_id].is_pup_fail = 1;
                        CHECK_STATUS(ddr3_tip_bus_read
                                     (dev_num, if_id, ACCESS_TYPE_UNICAST,
                                      bus_id, DDR_PHY_DATA,
-                                     WRITE_CENTRALIZATION_PHY_REG +
-                                     effective_cs * CS_REGISTER_ADDR_OFFSET,
+                                     CTX_PHY_REG(effective_cs),
                                      &data));
                        DEBUG_LEVELING(
                                DEBUG_LEVEL_TRACE,
                                ("WL Supp: adll_offset=0 data delay = %d\n",
                                 data));
                        if (ddr3_tip_wl_supp_align_phase_shift
-                           (dev_num, if_id, bus_id, 0, 0) == MV_OK) {
+                           (dev_num, if_id, bus_id) == MV_OK) {
                                DEBUG_LEVELING(
                                        DEBUG_LEVEL_TRACE,
                                        ("WL Supp: IF %d bus_id %d adll_offset=0 Success !\n",
@@ -1340,14 +1235,12 @@ int ddr3_tip_dynamic_write_leveling_supp(u32 dev_num)
                        CHECK_STATUS(ddr3_tip_bus_write
                                     (dev_num, ACCESS_TYPE_UNICAST, if_id,
                                      ACCESS_TYPE_UNICAST, bus_id, DDR_PHY_DATA,
-                                     WRITE_CENTRALIZATION_PHY_REG +
-                                     effective_cs * CS_REGISTER_ADDR_OFFSET,
+                                     CTX_PHY_REG(effective_cs),
                                      data + adll_offset));
                        CHECK_STATUS(ddr3_tip_bus_read
                                     (dev_num, if_id, ACCESS_TYPE_UNICAST,
                                      bus_id, DDR_PHY_DATA,
-                                     WRITE_CENTRALIZATION_PHY_REG +
-                                     effective_cs * CS_REGISTER_ADDR_OFFSET,
+                                     CTX_PHY_REG(effective_cs),
                                      &data_tmp));
                        DEBUG_LEVELING(
                                DEBUG_LEVEL_TRACE,
@@ -1355,7 +1248,7 @@ int ddr3_tip_dynamic_write_leveling_supp(u32 dev_num)
                                 adll_offset, data_tmp));
 
                        if (ddr3_tip_wl_supp_align_phase_shift
-                           (dev_num, if_id, bus_id, adll_offset, 0) == MV_OK) {
+                           (dev_num, if_id, bus_id) == MV_OK) {
                                DEBUG_LEVELING(
                                        DEBUG_LEVEL_TRACE,
                                        ("WL Supp: IF %d bus_id %d adll_offset= %d Success !\n",
@@ -1368,21 +1261,19 @@ int ddr3_tip_dynamic_write_leveling_supp(u32 dev_num)
                        CHECK_STATUS(ddr3_tip_bus_write
                                     (dev_num, ACCESS_TYPE_UNICAST, if_id,
                                      ACCESS_TYPE_UNICAST, bus_id, DDR_PHY_DATA,
-                                     WRITE_CENTRALIZATION_PHY_REG +
-                                     effective_cs * CS_REGISTER_ADDR_OFFSET,
+                                     CTX_PHY_REG(effective_cs),
                                      data + adll_offset));
                        CHECK_STATUS(ddr3_tip_bus_read
                                     (dev_num, if_id, ACCESS_TYPE_UNICAST,
                                      bus_id, DDR_PHY_DATA,
-                                     WRITE_CENTRALIZATION_PHY_REG +
-                                     effective_cs * CS_REGISTER_ADDR_OFFSET,
+                                     CTX_PHY_REG(effective_cs),
                                      &data_tmp));
                        DEBUG_LEVELING(
                                DEBUG_LEVEL_TRACE,
                                ("WL Supp: adll_offset= %d data delay = %d\n",
                                 adll_offset, data_tmp));
                        if (ddr3_tip_wl_supp_align_phase_shift
-                           (dev_num, if_id, bus_id, adll_offset, 0) == MV_OK) {
+                           (dev_num, if_id, bus_id) == MV_OK) {
                                DEBUG_LEVELING(
                                        DEBUG_LEVEL_TRACE,
                                        ("WL Supp: IF %d bus_id %d adll_offset= %d Success !\n",
@@ -1396,13 +1287,11 @@ int ddr3_tip_dynamic_write_leveling_supp(u32 dev_num)
                                is_if_fail = 1;
                        }
                }
-               DEBUG_LEVELING(DEBUG_LEVEL_TRACE,
-                              ("WL Supp: IF %d bus_id %d is_pup_fail %d\n",
-                               if_id, bus_id, is_if_fail));
 
                if (is_if_fail == 1) {
                        DEBUG_LEVELING(DEBUG_LEVEL_ERROR,
-                                      ("WL Supp: IF %d failed\n", if_id));
+                                      ("WL Supp: CS# %d: IF %d failed\n",
+                                       effective_cs, if_id));
                        training_result[training_stage][if_id] = TEST_FAILED;
                } else {
                        training_result[training_stage][if_id] = TEST_SUCCESS;
@@ -1410,7 +1299,7 @@ int ddr3_tip_dynamic_write_leveling_supp(u32 dev_num)
        }
 
        for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-               VALIDATE_ACTIVE(tm->if_act_mask, if_id);
+               VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
                if (training_result[training_stage][if_id] == TEST_FAILED)
                        return MV_FAIL;
        }
@@ -1422,87 +1311,129 @@ int ddr3_tip_dynamic_write_leveling_supp(u32 dev_num)
  * Phase Shift
  */
 static int ddr3_tip_wl_supp_align_phase_shift(u32 dev_num, u32 if_id,
-                                             u32 bus_id, u32 offset,
-                                             u32 bus_id_delta)
+                                             u32 bus_id)
 {
+       u32 original_phase;
+       u32 data, write_data;
+
        wr_supp_res[if_id][bus_id].stage = PHASE_SHIFT;
-       if (ddr3_tip_xsb_compare_test(dev_num, if_id, bus_id,
-                                     0, bus_id_delta) == MV_OK) {
-               wr_supp_res[if_id][bus_id].is_pup_fail = 0;
-               return MV_OK;
-       } else if (ddr3_tip_xsb_compare_test(dev_num, if_id, bus_id,
-                                            ONE_CLOCK_ERROR_SHIFT,
-                                            bus_id_delta) == MV_OK) {
-               /* 1 clock error */
-               wr_supp_res[if_id][bus_id].stage = CLOCK_SHIFT;
-               DEBUG_LEVELING(DEBUG_LEVEL_TRACE,
-                              ("Supp: 1 error clock for if %d pup %d with ofsset %d success\n",
-                               if_id, bus_id, offset));
-               ddr3_tip_wl_supp_one_clk_err_shift(dev_num, if_id, bus_id, 0);
-               wr_supp_res[if_id][bus_id].is_pup_fail = 0;
-               return MV_OK;
-       } else if (ddr3_tip_xsb_compare_test(dev_num, if_id, bus_id,
-                                            ALIGN_ERROR_SHIFT,
-                                            bus_id_delta) == MV_OK) {
-               /* align error */
-               DEBUG_LEVELING(DEBUG_LEVEL_TRACE,
-                              ("Supp: align error for if %d pup %d with ofsset %d success\n",
-                               if_id, bus_id, offset));
-               wr_supp_res[if_id][bus_id].stage = ALIGN_SHIFT;
-               ddr3_tip_wl_supp_align_err_shift(dev_num, if_id, bus_id, 0);
-               wr_supp_res[if_id][bus_id].is_pup_fail = 0;
+       if (ddr3_tip_xsb_compare_test
+           (dev_num, if_id, bus_id, 0) == MV_OK)
                return MV_OK;
-       } else {
-               wr_supp_res[if_id][bus_id].is_pup_fail = 1;
-               return MV_FAIL;
+
+       /* Read current phase */
+       CHECK_STATUS(ddr3_tip_bus_read
+                    (dev_num, if_id, ACCESS_TYPE_UNICAST, bus_id,
+                     DDR_PHY_DATA, WL_PHY_REG(effective_cs), &data));
+       original_phase = (data >> 6) & 0x7;
+
+       /* Set phase (0x0[6-8]) -2 */
+       if (original_phase >= 1) {
+               if (original_phase == 1)
+                       write_data = data & ~0x1df;
+               else
+                       write_data = (data & ~0x1c0) |
+                                    ((original_phase - 2) << 6);
+               ddr3_tip_bus_write(dev_num, ACCESS_TYPE_UNICAST, if_id,
+                                  ACCESS_TYPE_UNICAST, bus_id, DDR_PHY_DATA,
+                                  WL_PHY_REG(effective_cs), write_data);
+               if (ddr3_tip_xsb_compare_test
+                   (dev_num, if_id, bus_id, -2) == MV_OK)
+                       return MV_OK;
        }
+
+       /* Set phase (0x0[6-8]) +2 */
+       if (original_phase <= 5) {
+               write_data = (data & ~0x1c0) |
+                            ((original_phase + 2) << 6);
+               ddr3_tip_bus_write(dev_num, ACCESS_TYPE_UNICAST, if_id,
+                                  ACCESS_TYPE_UNICAST, bus_id, DDR_PHY_DATA,
+                                  WL_PHY_REG(effective_cs), write_data);
+               if (ddr3_tip_xsb_compare_test
+                   (dev_num, if_id, bus_id, 2) == MV_OK)
+                       return MV_OK;
+       }
+
+       /* Set phase (0x0[6-8]) +4 */
+       if (original_phase <= 3) {
+               write_data = (data & ~0x1c0) |
+                            ((original_phase + 4) << 6);
+               ddr3_tip_bus_write(dev_num, ACCESS_TYPE_UNICAST, if_id,
+                                  ACCESS_TYPE_UNICAST, bus_id, DDR_PHY_DATA,
+                                  WL_PHY_REG(effective_cs), write_data);
+               if (ddr3_tip_xsb_compare_test
+                   (dev_num, if_id, bus_id, 4) == MV_OK)
+                       return MV_OK;
+       }
+
+       /* Set phase (0x0[6-8]) +6 */
+       if (original_phase <= 1) {
+               write_data = (data & ~0x1c0) |
+                            ((original_phase + 6) << 6);
+               ddr3_tip_bus_write(dev_num, ACCESS_TYPE_UNICAST, if_id,
+                                  ACCESS_TYPE_UNICAST, bus_id, DDR_PHY_DATA,
+                                  WL_PHY_REG(effective_cs), write_data);
+               if (ddr3_tip_xsb_compare_test
+                   (dev_num, if_id, bus_id, 6) == MV_OK)
+                       return MV_OK;
+       }
+
+       /* Write original WL result back */
+       ddr3_tip_bus_write(dev_num, ACCESS_TYPE_UNICAST, if_id,
+                          ACCESS_TYPE_UNICAST, bus_id, DDR_PHY_DATA,
+                          WL_PHY_REG(effective_cs), data);
+       wr_supp_res[if_id][bus_id].is_pup_fail = 1;
+
+       return MV_FAIL;
 }
 
 /*
  * Compare Test
  */
 static int ddr3_tip_xsb_compare_test(u32 dev_num, u32 if_id, u32 bus_id,
-                                    u32 edge_offset, u32 bus_id_delta)
+                                    u32 edge_offset)
 {
-       u32 num_of_succ_byte_compare, word_in_pattern, abs_offset;
-       u32 word_offset, i;
+       u32 num_of_succ_byte_compare, word_in_pattern;
+       u32 word_offset, i, num_of_word_mult;
        u32 read_pattern[TEST_PATTERN_LENGTH * 2];
        struct pattern_info *pattern_table = ddr3_tip_get_pattern_table();
        u32 pattern_test_pattern_table[8];
+       struct mv_ddr_topology_map *tm = mv_ddr_topology_map_get();
+
+       /* 3 below for INTERFACE_BUS_MASK_16BIT */
+       num_of_word_mult = (tm->bus_act_mask == 3) ? 1 : 2;
 
        for (i = 0; i < 8; i++) {
                pattern_test_pattern_table[i] =
                        pattern_table_get_word(dev_num, PATTERN_TEST, (u8)i);
        }
 
-       /* extern write, than read and compare */
-       CHECK_STATUS(ddr3_tip_ext_write
-                    (dev_num, if_id,
-                     (pattern_table[PATTERN_TEST].start_addr +
-                      ((SDRAM_CS_SIZE + 1) * effective_cs)), 1,
-                     pattern_test_pattern_table));
+       /* External write, read and compare */
+       CHECK_STATUS(ddr3_tip_load_pattern_to_mem(dev_num, PATTERN_TEST));
 
        CHECK_STATUS(ddr3_tip_reset_fifo_ptr(dev_num));
 
        CHECK_STATUS(ddr3_tip_ext_read
                     (dev_num, if_id,
-                     (pattern_table[PATTERN_TEST].start_addr +
+                     ((pattern_table[PATTERN_TEST].start_addr << 3) +
                       ((SDRAM_CS_SIZE + 1) * effective_cs)), 1, read_pattern));
 
        DEBUG_LEVELING(
                DEBUG_LEVEL_TRACE,
-               ("XSB-compt: IF %d bus_id %d 0x%x 0x%x 0x%x 0x%x 0x%x 0x%x 0x%x 0x%x\n",
-                if_id, bus_id, read_pattern[0], read_pattern[1],
-                read_pattern[2], read_pattern[3], read_pattern[4],
-                read_pattern[5], read_pattern[6], read_pattern[7]));
+               ("XSB-compt CS#%d: IF %d bus_id %d 0x%x 0x%x 0x%x 0x%x 0x%x 0x%x 0x%x 0x%x\n",
+                effective_cs, if_id, bus_id,
+                read_pattern[0], read_pattern[1],
+                read_pattern[2], read_pattern[3],
+                read_pattern[4], read_pattern[5],
+                read_pattern[6], read_pattern[7]));
 
        /* compare byte per pup */
        num_of_succ_byte_compare = 0;
        for (word_in_pattern = start_xsb_offset;
-            word_in_pattern < (TEST_PATTERN_LENGTH * 2); word_in_pattern++) {
-               word_offset = word_in_pattern + edge_offset;
-               if ((word_offset > (TEST_PATTERN_LENGTH * 2 - 1)) ||
-                   (word_offset < 0))
+            word_in_pattern < (TEST_PATTERN_LENGTH * num_of_word_mult);
+            word_in_pattern++) {
+               word_offset = word_in_pattern;
+               if ((word_offset > (TEST_PATTERN_LENGTH * 2 - 1)))
                        continue;
 
                if ((read_pattern[word_in_pattern] & pup_mask_table[bus_id]) ==
@@ -1511,19 +1442,20 @@ static int ddr3_tip_xsb_compare_test(u32 dev_num, u32 if_id, u32 bus_id,
                        num_of_succ_byte_compare++;
        }
 
-       abs_offset = (edge_offset > 0) ? edge_offset : -edge_offset;
-       if (num_of_succ_byte_compare == ((TEST_PATTERN_LENGTH * 2) -
-                                        abs_offset - start_xsb_offset)) {
-               DEBUG_LEVELING(
-                       DEBUG_LEVEL_TRACE,
-                       ("XSB-compt: IF %d bus_id %d num_of_succ_byte_compare %d - Success\n",
-                        if_id, bus_id, num_of_succ_byte_compare));
+       if ((TEST_PATTERN_LENGTH * num_of_word_mult - start_xsb_offset) ==
+           num_of_succ_byte_compare) {
+               wr_supp_res[if_id][bus_id].stage = edge_offset;
+               DEBUG_LEVELING(DEBUG_LEVEL_TRACE,
+                              ("supplementary: shift to %d for if %d pup %d success\n",
+                               edge_offset, if_id, bus_id));
+               wr_supp_res[if_id][bus_id].is_pup_fail = 0;
+
                return MV_OK;
        } else {
                DEBUG_LEVELING(
                        DEBUG_LEVEL_TRACE,
-                       ("XSB-compt: IF %d bus_id %d num_of_succ_byte_compare %d - Fail !\n",
-                        if_id, bus_id, num_of_succ_byte_compare));
+                       ("XSB-compt CS#%d: IF %d bus_id %d num_of_succ_byte_compare %d - Fail!\n",
+                        effective_cs, if_id, bus_id, num_of_succ_byte_compare));
 
                DEBUG_LEVELING(
                        DEBUG_LEVEL_TRACE,
@@ -1544,116 +1476,10 @@ static int ddr3_tip_xsb_compare_test(u32 dev_num, u32 if_id, u32 bus_id,
                         read_pattern[4], read_pattern[5],
                         read_pattern[6], read_pattern[7]));
 
-               DEBUG_LEVELING(
-                       DEBUG_LEVEL_TRACE,
-                       ("XSB-compt: IF %d bus_id %d num_of_succ_byte_compare %d - Fail !\n",
-                        if_id, bus_id, num_of_succ_byte_compare));
-
                return MV_FAIL;
        }
 }
 
-/*
- * Clock error shift - function moves the write leveling delay 1cc forward
- */
-static int ddr3_tip_wl_supp_one_clk_err_shift(u32 dev_num, u32 if_id,
-                                             u32 bus_id, u32 bus_id_delta)
-{
-       int phase, adll;
-       u32 data;
-       DEBUG_LEVELING(DEBUG_LEVEL_TRACE, ("One_clk_err_shift\n"));
-
-       CHECK_STATUS(ddr3_tip_bus_read
-                    (dev_num, if_id, ACCESS_TYPE_UNICAST, bus_id,
-                     DDR_PHY_DATA, WL_PHY_REG, &data));
-       phase = ((data >> 6) & 0x7);
-       adll = data & 0x1f;
-       DEBUG_LEVELING(DEBUG_LEVEL_TRACE,
-                      ("One_clk_err_shift: IF %d bus_id %d phase %d adll %d\n",
-                       if_id, bus_id, phase, adll));
-
-       if ((phase == 0) || (phase == 1)) {
-               CHECK_STATUS(ddr3_tip_bus_read_modify_write
-                            (dev_num, ACCESS_TYPE_UNICAST, if_id, bus_id,
-                             DDR_PHY_DATA, 0, (phase + 2), 0x1f));
-       } else if (phase == 2) {
-               if (adll < 6) {
-                       data = (3 << 6) + (0x1f);
-                       CHECK_STATUS(ddr3_tip_bus_read_modify_write
-                                    (dev_num, ACCESS_TYPE_UNICAST, if_id,
-                                     bus_id, DDR_PHY_DATA, 0, data,
-                                     (0x7 << 6 | 0x1f)));
-                       data = 0x2f;
-                       CHECK_STATUS(ddr3_tip_bus_read_modify_write
-                                    (dev_num, ACCESS_TYPE_UNICAST, if_id,
-                                     bus_id, DDR_PHY_DATA, 1, data, 0x3f));
-               }
-       } else {
-               /* phase 3 */
-               return MV_FAIL;
-       }
-
-       return MV_OK;
-}
-
-/*
- * Align error shift
- */
-static int ddr3_tip_wl_supp_align_err_shift(u32 dev_num, u32 if_id,
-                                           u32 bus_id, u32 bus_id_delta)
-{
-       int phase, adll;
-       u32 data;
-
-       /* Shift WL result 1 phase back */
-       CHECK_STATUS(ddr3_tip_bus_read(dev_num, if_id, ACCESS_TYPE_UNICAST,
-                                      bus_id, DDR_PHY_DATA, WL_PHY_REG,
-                                      &data));
-       phase = ((data >> 6) & 0x7);
-       adll = data & 0x1f;
-       DEBUG_LEVELING(
-               DEBUG_LEVEL_TRACE,
-               ("Wl_supp_align_err_shift: IF %d bus_id %d phase %d adll %d\n",
-                if_id, bus_id, phase, adll));
-
-       if (phase < 2) {
-               if (adll > 0x1a) {
-                       if (phase == 0)
-                               return MV_FAIL;
-
-                       if (phase == 1) {
-                               data = 0;
-                               CHECK_STATUS(ddr3_tip_bus_read_modify_write
-                                            (dev_num, ACCESS_TYPE_UNICAST,
-                                             if_id, bus_id, DDR_PHY_DATA,
-                                             0, data, (0x7 << 6 | 0x1f)));
-                               data = 0xf;
-                               CHECK_STATUS(ddr3_tip_bus_read_modify_write
-                                            (dev_num, ACCESS_TYPE_UNICAST,
-                                             if_id, bus_id, DDR_PHY_DATA,
-                                             1, data, 0x1f));
-                               return MV_OK;
-                       }
-               } else {
-                       return MV_FAIL;
-               }
-       } else if ((phase == 2) || (phase == 3)) {
-               phase = phase - 2;
-               data = (phase << 6) + (adll & 0x1f);
-               CHECK_STATUS(ddr3_tip_bus_read_modify_write
-                            (dev_num, ACCESS_TYPE_UNICAST, if_id, bus_id,
-                             DDR_PHY_DATA, 0, data, (0x7 << 6 | 0x1f)));
-               return MV_OK;
-       } else {
-               DEBUG_LEVELING(DEBUG_LEVEL_ERROR,
-                              ("Wl_supp_align_err_shift: unexpected phase\n"));
-
-               return MV_FAIL;
-       }
-
-       return MV_OK;
-}
-
 /*
  * Dynamic write leveling sequence
  */
@@ -1662,32 +1488,33 @@ static int ddr3_tip_dynamic_write_leveling_seq(u32 dev_num)
        u32 bus_id, dq_id;
        u16 *mask_results_pup_reg_map = ddr3_tip_get_mask_results_pup_reg_map();
        u16 *mask_results_dq_reg_map = ddr3_tip_get_mask_results_dq_reg();
-       struct hws_topology_map *tm = ddr3_get_topology_map();
+       u32 octets_per_if_num = ddr3_tip_dev_attr_get(dev_num, MV_ATTR_OCTET_PER_INTERFACE);
+       struct mv_ddr_topology_map *tm = mv_ddr_topology_map_get();
 
        CHECK_STATUS(ddr3_tip_if_write
                     (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
                      TRAINING_SW_2_REG, 0x1, 0x5));
        CHECK_STATUS(ddr3_tip_if_write
                     (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                     TRAINING_WRITE_LEVELING_REG, 0x50, 0xff));
+                     TRAINING_WL_REG, 0x50, 0xff));
        CHECK_STATUS(ddr3_tip_if_write
                     (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                     TRAINING_WRITE_LEVELING_REG, 0x5c, 0xff));
+                     TRAINING_WL_REG, 0x5c, 0xff));
        CHECK_STATUS(ddr3_tip_if_write
                     (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                     ODPG_TRAINING_CONTROL_REG, 0x381b82, 0x3c3faf));
+                     GENERAL_TRAINING_OPCODE_REG, 0x381b82, 0x3c3faf));
        CHECK_STATUS(ddr3_tip_if_write
                     (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                     ODPG_OBJ1_OPCODE_REG, (0x3 << 25), (0x3ffff << 9)));
+                     OPCODE_REG0_REG(1), (0x3 << 25), (0x3ffff << 9)));
        CHECK_STATUS(ddr3_tip_if_write
                     (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                     ODPG_OBJ1_ITER_CNT_REG, 0x80, 0xffff));
+                     OPCODE_REG1_REG(1), 0x80, 0xffff));
        CHECK_STATUS(ddr3_tip_if_write
                     (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                     ODPG_WRITE_LEVELING_DONE_CNTR_REG, 0x14, 0xff));
+                     WL_DONE_CNTR_REF_REG, 0x14, 0xff));
        CHECK_STATUS(ddr3_tip_if_write
                     (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                     TRAINING_WRITE_LEVELING_REG, 0xff5c, 0xffff));
+                     TRAINING_WL_REG, 0xff5c, 0xffff));
 
        /* mask PBS */
        for (dq_id = 0; dq_id < MAX_DQ_NUM; dq_id++) {
@@ -1698,7 +1525,7 @@ static int ddr3_tip_dynamic_write_leveling_seq(u32 dev_num)
        }
 
        /* Mask all results */
-       for (bus_id = 0; bus_id < tm->num_of_bus_per_interface; bus_id++) {
+       for (bus_id = 0; bus_id < octets_per_if_num; bus_id++) {
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
                              mask_results_pup_reg_map[bus_id], 0x1 << 24,
@@ -1706,8 +1533,8 @@ static int ddr3_tip_dynamic_write_leveling_seq(u32 dev_num)
        }
 
        /* Unmask only wanted */
-       for (bus_id = 0; bus_id < tm->num_of_bus_per_interface; bus_id++) {
-               VALIDATE_ACTIVE(tm->bus_act_mask, bus_id);
+       for (bus_id = 0; bus_id < octets_per_if_num; bus_id++) {
+               VALIDATE_BUS_ACTIVE(tm->bus_act_mask, bus_id);
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
                              mask_results_pup_reg_map[bus_id], 0, 0x1 << 24));
@@ -1715,7 +1542,7 @@ static int ddr3_tip_dynamic_write_leveling_seq(u32 dev_num)
 
        CHECK_STATUS(ddr3_tip_if_write
                     (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
-                     WR_LEVELING_DQS_PATTERN_REG, 0x1, 0x1));
+                     WL_DQS_PATTERN_REG, 0x1, 0x1));
 
        return MV_OK;
 }
@@ -1728,7 +1555,8 @@ static int ddr3_tip_dynamic_read_leveling_seq(u32 dev_num)
        u32 bus_id, dq_id;
        u16 *mask_results_pup_reg_map = ddr3_tip_get_mask_results_pup_reg_map();
        u16 *mask_results_dq_reg_map = ddr3_tip_get_mask_results_dq_reg();
-       struct hws_topology_map *tm = ddr3_get_topology_map();
+       u32 octets_per_if_num = ddr3_tip_dev_attr_get(dev_num, MV_ATTR_OCTET_PER_INTERFACE);
+       struct mv_ddr_topology_map *tm = mv_ddr_topology_map_get();
 
        /* mask PBS */
        for (dq_id = 0; dq_id < MAX_DQ_NUM; dq_id++) {
@@ -1739,7 +1567,7 @@ static int ddr3_tip_dynamic_read_leveling_seq(u32 dev_num)
        }
 
        /* Mask all results */
-       for (bus_id = 0; bus_id < tm->num_of_bus_per_interface; bus_id++) {
+       for (bus_id = 0; bus_id < octets_per_if_num; bus_id++) {
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
                              mask_results_pup_reg_map[bus_id], 0x1 << 24,
@@ -1747,8 +1575,8 @@ static int ddr3_tip_dynamic_read_leveling_seq(u32 dev_num)
        }
 
        /* Unmask only wanted */
-       for (bus_id = 0; bus_id < tm->num_of_bus_per_interface; bus_id++) {
-               VALIDATE_ACTIVE(tm->bus_act_mask, bus_id);
+       for (bus_id = 0; bus_id < octets_per_if_num; bus_id++) {
+               VALIDATE_BUS_ACTIVE(tm->bus_act_mask, bus_id);
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
                              mask_results_pup_reg_map[bus_id], 0, 0x1 << 24));
@@ -1765,7 +1593,8 @@ static int ddr3_tip_dynamic_per_bit_read_leveling_seq(u32 dev_num)
        u32 bus_id, dq_id;
        u16 *mask_results_pup_reg_map = ddr3_tip_get_mask_results_pup_reg_map();
        u16 *mask_results_dq_reg_map = ddr3_tip_get_mask_results_dq_reg();
-       struct hws_topology_map *tm = ddr3_get_topology_map();
+       u32 octets_per_if_num = ddr3_tip_dev_attr_get(dev_num, MV_ATTR_OCTET_PER_INTERFACE);
+       struct mv_ddr_topology_map *tm = mv_ddr_topology_map_get();
 
        /* mask PBS */
        for (dq_id = 0; dq_id < MAX_DQ_NUM; dq_id++) {
@@ -1776,7 +1605,7 @@ static int ddr3_tip_dynamic_per_bit_read_leveling_seq(u32 dev_num)
        }
 
        /* Mask all results */
-       for (bus_id = 0; bus_id < tm->num_of_bus_per_interface; bus_id++) {
+       for (bus_id = 0; bus_id < octets_per_if_num; bus_id++) {
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
                              mask_results_pup_reg_map[bus_id], 0x1 << 24,
@@ -1785,7 +1614,7 @@ static int ddr3_tip_dynamic_per_bit_read_leveling_seq(u32 dev_num)
 
        /* Unmask only wanted */
        for (dq_id = 0; dq_id < MAX_DQ_NUM; dq_id++) {
-               VALIDATE_ACTIVE(tm->bus_act_mask, dq_id / 8);
+               VALIDATE_BUS_ACTIVE(tm->bus_act_mask, dq_id / 8);
                CHECK_STATUS(ddr3_tip_if_write
                             (dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE,
                              mask_results_dq_reg_map[dq_id], 0x0 << 24,
@@ -1801,16 +1630,17 @@ static int ddr3_tip_dynamic_per_bit_read_leveling_seq(u32 dev_num)
 int ddr3_tip_print_wl_supp_result(u32 dev_num)
 {
        u32 bus_id = 0, if_id = 0;
-       struct hws_topology_map *tm = ddr3_get_topology_map();
+       u32 octets_per_if_num = ddr3_tip_dev_attr_get(dev_num, MV_ATTR_OCTET_PER_INTERFACE);
+       struct mv_ddr_topology_map *tm = mv_ddr_topology_map_get();
 
        DEBUG_LEVELING(DEBUG_LEVEL_INFO,
                       ("I/F0 PUP0 Result[0 - success, 1-fail] ...\n"));
 
        for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-               VALIDATE_ACTIVE(tm->if_act_mask, if_id);
-               for (bus_id = 0; bus_id < tm->num_of_bus_per_interface;
+               VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
+               for (bus_id = 0; bus_id < octets_per_if_num;
                     bus_id++) {
-                       VALIDATE_ACTIVE(tm->bus_act_mask, bus_id);
+                       VALIDATE_BUS_ACTIVE(tm->bus_act_mask, bus_id);
                        DEBUG_LEVELING(DEBUG_LEVEL_INFO,
                                       ("%d ,", wr_supp_res[if_id]
                                        [bus_id].is_pup_fail));
@@ -1821,10 +1651,10 @@ int ddr3_tip_print_wl_supp_result(u32 dev_num)
                ("I/F0 PUP0 Stage[0-phase_shift, 1-clock_shift, 2-align_shift] ...\n"));
 
        for (if_id = 0; if_id <= MAX_INTERFACE_NUM - 1; if_id++) {
-               VALIDATE_ACTIVE(tm->if_act_mask, if_id);
-               for (bus_id = 0; bus_id < tm->num_of_bus_per_interface;
+               VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
+               for (bus_id = 0; bus_id < octets_per_if_num;
                     bus_id++) {
-                       VALIDATE_ACTIVE(tm->bus_act_mask, bus_id);
+                       VALIDATE_BUS_ACTIVE(tm->bus_act_mask, bus_id);
                        DEBUG_LEVELING(DEBUG_LEVEL_INFO,
                                       ("%d ,", wr_supp_res[if_id]
                                        [bus_id].stage));
@@ -1833,3 +1663,324 @@ int ddr3_tip_print_wl_supp_result(u32 dev_num)
 
        return MV_OK;
 }
+
+#define RD_FIFO_PTR_LOW_STAT_INDIR_ADDR                0x9a
+#define RD_FIFO_PTR_HIGH_STAT_INDIR_ADDR       0x9b
+/* position of falling dqs edge in fifo; walking 1 */
+#define RD_FIFO_DQS_FALL_EDGE_POS_0            0x1
+#define RD_FIFO_DQS_FALL_EDGE_POS_1            0x2
+#define RD_FIFO_DQS_FALL_EDGE_POS_2            0x4
+#define RD_FIFO_DQS_FALL_EDGE_POS_3            0x8
+#define RD_FIFO_DQS_FALL_EDGE_POS_4            0x10 /* lock */
+/* position of rising dqs edge in fifo; walking 0 */
+#define RD_FIFO_DQS_RISE_EDGE_POS_0            0x1fff
+#define RD_FIFO_DQS_RISE_EDGE_POS_1            0x3ffe
+#define RD_FIFO_DQS_RISE_EDGE_POS_2            0x3ffd
+#define RD_FIFO_DQS_RISE_EDGE_POS_3            0x3ffb
+#define RD_FIFO_DQS_RISE_EDGE_POS_4            0x3ff7 /* lock */
+#define TEST_ADDR              0x8
+#define TAPS_PER_UI            32
+#define UI_PER_RD_SAMPLE       4
+#define TAPS_PER_RD_SAMPLE     ((UI_PER_RD_SAMPLE) * (TAPS_PER_UI))
+#define MAX_RD_SAMPLES         32
+#define MAX_RL_VALUE           ((MAX_RD_SAMPLES) * (TAPS_PER_RD_SAMPLE))
+#define RD_FIFO_DLY            8
+#define STEP_SIZE              64
+#define RL_JITTER_WIDTH_LMT    20
+#define ADLL_TAPS_IN_CYCLE     64
+
+enum rl_dqs_burst_state {
+       RL_AHEAD = 0,
+       RL_INSIDE,
+       RL_BEHIND
+};
+int mv_ddr_rl_dqs_burst(u32 dev_num, u32 if_id, u32 freq)
+{
+       enum rl_dqs_burst_state rl_state[NUM_OF_CS][MAX_BUS_NUM][MAX_INTERFACE_NUM] = { { {0} } };
+       enum hws_ddr_phy subphy_type = DDR_PHY_DATA;
+       struct mv_ddr_topology_map *tm = mv_ddr_topology_map_get();
+       int cl_val = tm->interface_params[0].cas_l;
+       int rl_adll_val, rl_phase_val, sdr_cycle_incr, rd_sample, rd_ready;
+       int final_rd_sample, final_rd_ready;
+       int i, subphy_id, step;
+       int pass_lock_num = 0;
+       int init_pass_lock_num;
+       int phase_delta;
+       int min_phase, max_phase;
+       u32 max_cs = ddr3_tip_max_cs_get(dev_num);
+       u32 rl_values[NUM_OF_CS][MAX_BUS_NUM][MAX_INTERFACE_NUM] = { { {0} } };
+       u32 rl_min_values[NUM_OF_CS][MAX_BUS_NUM][MAX_INTERFACE_NUM] = { { {0} } };
+       u32 rl_max_values[NUM_OF_CS][MAX_BUS_NUM][MAX_INTERFACE_NUM] = { { {0} } };
+       u32 rl_val, rl_min_val[NUM_OF_CS], rl_max_val[NUM_OF_CS];
+       u32 reg_val_low, reg_val_high;
+       u32 reg_val,  reg_mask;
+       uintptr_t test_addr = TEST_ADDR;
+
+       /* initialization */
+       if (ddr3_if_ecc_enabled()) {
+               ddr3_tip_if_read(dev_num, ACCESS_TYPE_UNICAST, if_id, TRAINING_SW_2_REG,
+                                &reg_val, MASK_ALL_BITS);
+               reg_mask = (TRAINING_ECC_MUX_MASK << TRAINING_ECC_MUX_OFFS) |
+                          (TRAINING_SW_OVRD_MASK << TRAINING_SW_OVRD_OFFS);
+               reg_val &= ~reg_mask;
+               reg_val |= (TRAINING_ECC_MUX_DIS << TRAINING_ECC_MUX_OFFS) |
+                          (TRAINING_SW_OVRD_ENA << TRAINING_SW_OVRD_OFFS);
+               ddr3_tip_if_write(0, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE, TRAINING_SW_2_REG,
+                                 reg_val, MASK_ALL_BITS);
+               ddr3_tip_if_read(dev_num, ACCESS_TYPE_UNICAST, if_id, TRAINING_REG,
+                                &reg_val, MASK_ALL_BITS);
+               reg_mask = (TRN_START_MASK << TRN_START_OFFS);
+               reg_val &= ~reg_mask;
+               reg_val |= TRN_START_ENA << TRN_START_OFFS;
+               ddr3_tip_if_write(0, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE, TRAINING_REG,
+                                 reg_val, MASK_ALL_BITS);
+       }
+
+       for (effective_cs = 0; effective_cs < max_cs; effective_cs++)
+               for (subphy_id = 0; subphy_id < MAX_BUS_NUM; subphy_id++)
+                       for (if_id = 0; if_id < MAX_INTERFACE_NUM; if_id++)
+                               if (IS_BUS_ACTIVE(tm->bus_act_mask, subphy_id) == 0)
+                                       pass_lock_num++; /* increment on inactive subphys */
+
+       init_pass_lock_num = pass_lock_num / max_cs;
+       for (effective_cs = 0; effective_cs < max_cs; effective_cs++) {
+               for (if_id = 0; if_id < MAX_INTERFACE_NUM; if_id++) {
+                       VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
+                       training_result[training_stage][if_id] = TEST_SUCCESS;
+               }
+       }
+
+       /* search for dqs edges per subphy */
+       if_id = 0;
+       for (effective_cs = 0; effective_cs < max_cs; effective_cs++) {
+               pass_lock_num = init_pass_lock_num;
+               ddr3_tip_if_write(0, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE, ODPG_DATA_CTRL_REG,
+                                 effective_cs << ODPG_DATA_CS_OFFS,
+                                 ODPG_DATA_CS_MASK << ODPG_DATA_CS_OFFS);
+               rl_min_val[effective_cs] = MAX_RL_VALUE;
+               rl_max_val[effective_cs] = 0;
+               step = STEP_SIZE;
+               for (i = 0; i < MAX_RL_VALUE; i += step) {
+                       rl_val = 0;
+                       sdr_cycle_incr = i / TAPS_PER_RD_SAMPLE; /* sdr cycle increment */
+                       rd_sample = cl_val + 2 * sdr_cycle_incr;
+                       /* fifo out to in delay in search is constant */
+                       rd_ready = rd_sample + RD_FIFO_DLY;
+
+                       ddr3_tip_if_write(0, ACCESS_TYPE_UNICAST, 0, RD_DATA_SMPL_DLYS_REG,
+                                         rd_sample << RD_SMPL_DLY_CS_OFFS(effective_cs),
+                                         RD_SMPL_DLY_CS_MASK << RD_SMPL_DLY_CS_OFFS(effective_cs));
+                       ddr3_tip_if_write(0, ACCESS_TYPE_UNICAST, 0, RD_DATA_RDY_DLYS_REG,
+                                         rd_ready << RD_RDY_DLY_CS_OFFS(effective_cs),
+                                         RD_RDY_DLY_CS_MASK << RD_RDY_DLY_CS_OFFS(effective_cs));
+
+                       /* one sdr (single data rate) cycle incremented on every four phases of ddr clock */
+                       sdr_cycle_incr = i % TAPS_PER_RD_SAMPLE;
+                       rl_adll_val = sdr_cycle_incr % MAX_RD_SAMPLES;
+                       rl_phase_val = sdr_cycle_incr / MAX_RD_SAMPLES;
+                       rl_val = ((rl_adll_val & RL_REF_DLY_MASK) << RL_REF_DLY_OFFS) |
+                                ((rl_phase_val & RL_PH_SEL_MASK) << RL_PH_SEL_OFFS);
+
+                       /* write to all subphys (even to not connected or locked) */
+                       ddr3_tip_bus_write(dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE, ACCESS_TYPE_MULTICAST,
+                                          0, DDR_PHY_DATA, RL_PHY_REG(effective_cs), rl_val);
+
+                       /* reset read fifo assertion */
+                       ddr3_tip_if_write(dev_num, ACCESS_TYPE_MULTICAST, if_id, SDRAM_CFG_REG,
+                                         DATA_PUP_RD_RESET_ENA << DATA_PUP_RD_RESET_OFFS,
+                                         DATA_PUP_RD_RESET_MASK << DATA_PUP_RD_RESET_OFFS);
+
+                       /* reset read fifo deassertion */
+                       ddr3_tip_if_write(dev_num, ACCESS_TYPE_MULTICAST, if_id, SDRAM_CFG_REG,
+                                         DATA_PUP_RD_RESET_DIS << DATA_PUP_RD_RESET_OFFS,
+                                         DATA_PUP_RD_RESET_MASK << DATA_PUP_RD_RESET_OFFS);
+
+                       /* perform one read burst */
+                       if (MV_DDR_IS_64BIT_DRAM_MODE(tm->bus_act_mask))
+                               readq(test_addr);
+                       else
+                               readl(test_addr);
+
+                       /* progress read ptr; decide on rl state per byte */
+                       for (subphy_id = 0; subphy_id < MAX_BUS_NUM; subphy_id++) {
+                               if (rl_state[effective_cs][subphy_id][if_id] == RL_BEHIND)
+                                       continue; /* skip locked subphys */
+                               ddr3_tip_bus_read(dev_num, if_id, ACCESS_TYPE_UNICAST, subphy_id, DDR_PHY_DATA,
+                                                 RD_FIFO_PTR_LOW_STAT_INDIR_ADDR, &reg_val_low);
+                               ddr3_tip_bus_read(dev_num, if_id, ACCESS_TYPE_UNICAST, subphy_id, DDR_PHY_DATA,
+                                                 RD_FIFO_PTR_HIGH_STAT_INDIR_ADDR, &reg_val_high);
+                               DEBUG_LEVELING(DEBUG_LEVEL_TRACE,
+                                              ("%s: cs %d, step %d, subphy %d, state %d, low 0x%04x, high 0x%04x; move to ",
+                                               __func__, effective_cs, i, subphy_id,
+                                               rl_state[effective_cs][subphy_id][if_id],
+                                               reg_val_low, reg_val_high));
+
+                               switch (rl_state[effective_cs][subphy_id][if_id]) {
+                               case RL_AHEAD:
+                                       /* improve search resolution getting closer to the window */
+                                       if (reg_val_low == RD_FIFO_DQS_FALL_EDGE_POS_4 &&
+                                           reg_val_high == RD_FIFO_DQS_RISE_EDGE_POS_4) {
+                                               rl_state[effective_cs][subphy_id][if_id] = RL_INSIDE;
+                                               rl_values[effective_cs][subphy_id][if_id] = i;
+                                               rl_min_values[effective_cs][subphy_id][if_id] = i;
+                                               DEBUG_LEVELING(DEBUG_LEVEL_TRACE,
+                                                              ("new state %d\n",
+                                                               rl_state[effective_cs][subphy_id][if_id]));
+                                       } else if (reg_val_low == RD_FIFO_DQS_FALL_EDGE_POS_3 &&
+                                                  reg_val_high == RD_FIFO_DQS_RISE_EDGE_POS_3) {
+                                               step = (step < 2) ? step : 2;
+                                       } else if (reg_val_low == RD_FIFO_DQS_FALL_EDGE_POS_2 &&
+                                                  reg_val_high == RD_FIFO_DQS_RISE_EDGE_POS_2) {
+                                               step = (step < 16) ? step : 16;
+                                       } else if (reg_val_low == RD_FIFO_DQS_FALL_EDGE_POS_1 &&
+                                                  reg_val_high == RD_FIFO_DQS_RISE_EDGE_POS_1) {
+                                               step = (step < 32) ? step : 32;
+                                       } else if (reg_val_low == RD_FIFO_DQS_FALL_EDGE_POS_0 &&
+                                                  reg_val_high == RD_FIFO_DQS_RISE_EDGE_POS_0) {
+                                               step = (step < 64) ? step : 64;
+                                       } else {
+                                               /* otherwise, step is unchanged */
+                                       }
+                                       break;
+                               case RL_INSIDE:
+                                       if (reg_val_low == RD_FIFO_DQS_FALL_EDGE_POS_4 &&
+                                           reg_val_high == RD_FIFO_DQS_RISE_EDGE_POS_4) {
+                                               rl_max_values[effective_cs][subphy_id][if_id] = i;
+                                               if ((rl_max_values[effective_cs][subphy_id][if_id] -
+                                                    rl_min_values[effective_cs][subphy_id][if_id]) >
+                                                   ADLL_TAPS_IN_CYCLE) {
+                                                       rl_state[effective_cs][subphy_id][if_id] = RL_BEHIND;
+                                                       rl_values[effective_cs][subphy_id][if_id] =
+                                                               (i + rl_values[effective_cs][subphy_id][if_id]) / 2;
+                                                       pass_lock_num++;
+                                                       DEBUG_LEVELING(DEBUG_LEVEL_TRACE,
+                                                                      ("new lock %d\n", pass_lock_num));
+                                                       if (rl_min_val[effective_cs] >
+                                                           rl_values[effective_cs][subphy_id][if_id])
+                                                               rl_min_val[effective_cs] =
+                                                                       rl_values[effective_cs][subphy_id][if_id];
+                                                       if (rl_max_val[effective_cs] <
+                                                           rl_values[effective_cs][subphy_id][if_id])
+                                                               rl_max_val[effective_cs] =
+                                                                       rl_values[effective_cs][subphy_id][if_id];
+                                                       step = 2;
+                                               }
+                                       }
+                                       if (reg_val_low != RD_FIFO_DQS_FALL_EDGE_POS_4 ||
+                                           reg_val_high != RD_FIFO_DQS_RISE_EDGE_POS_4) {
+                                               if ((i - rl_values[effective_cs][subphy_id][if_id]) <
+                                                   RL_JITTER_WIDTH_LMT) {
+                                                       /* inside the jitter; not valid segment */
+                                                       rl_state[effective_cs][subphy_id][if_id] = RL_AHEAD;
+                                                       DEBUG_LEVELING(DEBUG_LEVEL_TRACE,
+                                                                      ("new state %d; jitter on mask\n",
+                                                                       rl_state[effective_cs][subphy_id][if_id]));
+                                               } else { /* finished valid segment */
+                                                       rl_state[effective_cs][subphy_id][if_id] = RL_BEHIND;
+                                                       rl_values[effective_cs][subphy_id][if_id] =
+                                                               (i + rl_values[effective_cs][subphy_id][if_id]) / 2;
+                                                       DEBUG_LEVELING(DEBUG_LEVEL_TRACE,
+                                                                      ("new state %d, solution %d\n",
+                                                                       rl_state[effective_cs][subphy_id][if_id],
+                                                                       rl_values[effective_cs][subphy_id][if_id]));
+                                                       pass_lock_num++;
+                                                       DEBUG_LEVELING(DEBUG_LEVEL_TRACE,
+                                                                      ("new lock %d\n", pass_lock_num));
+                                                       if (rl_min_val[effective_cs] >
+                                                           rl_values[effective_cs][subphy_id][if_id])
+                                                               rl_min_val[effective_cs] =
+                                                                       rl_values[effective_cs][subphy_id][if_id];
+                                                       if (rl_max_val[effective_cs] <
+                                                           rl_values[effective_cs][subphy_id][if_id])
+                                                               rl_max_val[effective_cs] =
+                                                                       rl_values[effective_cs][subphy_id][if_id];
+                                                       step = 2;
+                                               }
+                                       }
+                                       break;
+                               case RL_BEHIND: /* do nothing */
+                                       break;
+                               }
+                               DEBUG_LEVELING(DEBUG_LEVEL_TRACE, ("\n"));
+                       }
+                       DEBUG_LEVELING(DEBUG_LEVEL_TRACE, ("pass_lock_num %d\n", pass_lock_num));
+                       /* exit condition */
+                       if (pass_lock_num == MAX_BUS_NUM)
+                               break;
+               } /* for-loop on i */
+
+               if (pass_lock_num != MAX_BUS_NUM) {
+                       DEBUG_LEVELING(DEBUG_LEVEL_ERROR,
+                                      ("%s: cs %d, pass_lock_num %d, max_bus_num %d, init_pass_lock_num %d\n",
+                                      __func__, effective_cs, pass_lock_num, MAX_BUS_NUM, init_pass_lock_num));
+                       for (subphy_id = 0; subphy_id < MAX_BUS_NUM; subphy_id++) {
+                               VALIDATE_BUS_ACTIVE(tm->bus_act_mask, subphy_id);
+                               DEBUG_LEVELING(DEBUG_LEVEL_ERROR,
+                                              ("%s: subphy %d %s\n",
+                                               __func__, subphy_id,
+                                               (rl_state[effective_cs][subphy_id][if_id] == RL_BEHIND) ?
+                                               "locked" : "not locked"));
+                       }
+               }
+       } /* for-loop on effective_cs */
+
+       /* post-processing read leveling results */
+       if_id = 0;
+       for (effective_cs = 0; effective_cs < max_cs; effective_cs++) {
+               phase_delta = 0;
+               i = rl_min_val[effective_cs];
+               sdr_cycle_incr = i / TAPS_PER_RD_SAMPLE; /* sdr cycle increment */
+               rd_sample = cl_val + 2 * sdr_cycle_incr;
+               rd_ready = rd_sample + RD_FIFO_DLY;
+               min_phase = (rl_min_val[effective_cs] - (sdr_cycle_incr * TAPS_PER_RD_SAMPLE)) % MAX_RD_SAMPLES;
+               max_phase = (rl_max_val[effective_cs] - (sdr_cycle_incr * TAPS_PER_RD_SAMPLE)) % MAX_RD_SAMPLES;
+               final_rd_sample = rd_sample;
+               final_rd_ready = rd_ready;
+
+               ddr3_tip_if_write(0, ACCESS_TYPE_UNICAST, 0, RD_DATA_SMPL_DLYS_REG,
+                                 rd_sample << RD_SMPL_DLY_CS_OFFS(effective_cs),
+                                 RD_SMPL_DLY_CS_MASK << RD_SMPL_DLY_CS_OFFS(effective_cs));
+               ddr3_tip_if_write(0, ACCESS_TYPE_UNICAST, 0, RD_DATA_RDY_DLYS_REG,
+                                 rd_ready << RD_RDY_DLY_CS_OFFS(effective_cs),
+                                 RD_RDY_DLY_CS_MASK << RD_RDY_DLY_CS_OFFS(effective_cs));
+               DEBUG_LEVELING(DEBUG_LEVEL_INFO,
+                              ("%s: cs %d, min phase %d, max phase %d, read sample %d\n",
+                               __func__, effective_cs, min_phase, max_phase, rd_sample));
+
+               for (subphy_id = 0; subphy_id < MAX_BUS_NUM; subphy_id++) {
+                       VALIDATE_BUS_ACTIVE(tm->bus_act_mask, subphy_id);
+                       /* reduce sdr cycle per cs; extract rl adll and phase values */
+                       i = rl_values[effective_cs][subphy_id][if_id] - (sdr_cycle_incr * TAPS_PER_RD_SAMPLE);
+                       rl_adll_val = i % MAX_RD_SAMPLES;
+                       rl_phase_val = i / MAX_RD_SAMPLES;
+                       rl_phase_val -= phase_delta;
+                       DEBUG_LEVELING(DEBUG_LEVEL_INFO,
+                                      ("%s: final results: cs %d, subphy %d, read sample %d read ready %d, rl_phase_val %d, rl_adll_val %d\n",
+                                       __func__, effective_cs, subphy_id, final_rd_sample,
+                                       final_rd_ready, rl_phase_val, rl_adll_val));
+
+                       rl_val = ((rl_adll_val & RL_REF_DLY_MASK) << RL_REF_DLY_OFFS) |
+                                ((rl_phase_val & RL_PH_SEL_MASK) << RL_PH_SEL_OFFS);
+                       ddr3_tip_bus_write(dev_num, ACCESS_TYPE_MULTICAST, PARAM_NOT_CARE, ACCESS_TYPE_UNICAST,
+                                          subphy_id, subphy_type, RL_PHY_REG(effective_cs), rl_val);
+               }
+       } /* for-loop on effective cs */
+
+       for (if_id = 0; if_id < MAX_INTERFACE_NUM; if_id++) {
+               VALIDATE_IF_ACTIVE(tm->if_act_mask, if_id);
+               if (odt_config != 0)
+                       CHECK_STATUS(ddr3_tip_write_additional_odt_setting(dev_num, if_id));
+       }
+
+       /* reset read fifo assertion */
+       ddr3_tip_if_write(dev_num, ACCESS_TYPE_MULTICAST, if_id, SDRAM_CFG_REG,
+                         DATA_PUP_RD_RESET_ENA << DATA_PUP_RD_RESET_OFFS,
+                         DATA_PUP_RD_RESET_MASK << DATA_PUP_RD_RESET_OFFS);
+
+       /* reset read fifo deassertion */
+       ddr3_tip_if_write(dev_num, ACCESS_TYPE_MULTICAST, if_id, SDRAM_CFG_REG,
+                         DATA_PUP_RD_RESET_DIS << DATA_PUP_RD_RESET_OFFS,
+                         DATA_PUP_RD_RESET_MASK << DATA_PUP_RD_RESET_OFFS);
+
+       return MV_OK;
+}