]> git.sur5r.net Git - u-boot/blobdiff - drivers/mtd/cfi_flash.c
cfi_flash: Fix strings split across lines
[u-boot] / drivers / mtd / cfi_flash.c
index a1b217cc0c96129975d95c49a915b59b0f66e2ce..8040e43de7be4202a42364ae71a7cce9f79bbe96 100644 (file)
@@ -230,14 +230,14 @@ static void flash_make_cmd(flash_info_t *info, u32 cmd, void *cmdbuf)
        uchar val;
        uchar *cp = (uchar *) cmdbuf;
 
-       for (i = info->portwidth; i > 0; i--){
-               cword_offset = (info->portwidth-i)%info->chipwidth;
+       for (i = info->portwidth; i > 0; i--) {
+               cword_offset = (info->portwidth - i) % info->chipwidth;
 #if defined(__LITTLE_ENDIAN) || defined(CONFIG_SYS_WRITE_SWAPPED_DATA)
                cp_offset = info->portwidth - i;
-               val = *((uchar*)&cmd_le + cword_offset);
+               val = *((uchar *)&cmd_le + cword_offset);
 #else
                cp_offset = i - 1;
-               val = *((uchar*)&cmd + sizeof(u32) - cword_offset - 1);
+               val = *((uchar *)&cmd + sizeof(u32) - cword_offset - 1);
 #endif
                cp[cp_offset] = (cword_offset >= sizeof(u32)) ? 0x00 : val;
        }
@@ -252,7 +252,7 @@ static void print_longlong(char *str, unsigned long long data)
        int i;
        char *cp;
 
-       cp = (char *) &data;
+       cp = (char *)&data;
        for (i = 0; i < 8; i++)
                sprintf(&str[i * 2], "%2.2x", *cp++);
 }
@@ -269,6 +269,7 @@ static void flash_printqry(struct cfi_qry *qry)
                debug(" ");
                for (y = 0; y < 16; y++) {
                        unsigned char c = p[x + y];
+
                        if (c >= 0x20 && c <= 0x7e)
                                debug("%c", c);
                        else
@@ -279,7 +280,6 @@ static void flash_printqry(struct cfi_qry *qry)
 }
 #endif
 
-
 /*-----------------------------------------------------------------------
  * read a character at a port width address
  */
@@ -311,7 +311,6 @@ static inline ushort flash_read_word(flash_info_t *info, uint offset)
        return retval;
 }
 
-
 /*-----------------------------------------------------------------------
  * read a long word by picking the least significant byte of each maximum
  * port size word. Swap for ppc format.
@@ -330,9 +329,8 @@ static ulong flash_read_long (flash_info_t *info, flash_sect_t sect,
 #ifdef DEBUG
        debug("long addr is at %p info->portwidth = %d\n", addr,
               info->portwidth);
-       for (x = 0; x < 4 * info->portwidth; x++) {
+       for (x = 0; x < 4 * info->portwidth; x++)
                debug("addr[%x] = 0x%x\n", x, flash_read8(addr + x));
-       }
 #endif
 #if defined(__LITTLE_ENDIAN) || defined(CONFIG_SYS_WRITE_SWAPPED_DATA)
        retval = ((flash_read8(addr) << 16) |
@@ -356,7 +354,6 @@ static ulong flash_read_long (flash_info_t *info, flash_sect_t sect,
 static void flash_write_cmd(flash_info_t *info, flash_sect_t sect,
                            uint offset, u32 cmd)
 {
-
        void *addr;
        cfiword_t cword;
 
@@ -494,7 +491,7 @@ static int flash_isset(flash_info_t *info, flash_sect_t sect,
 static int flash_toggle(flash_info_t *info, flash_sect_t sect,
                         uint offset, uchar cmd)
 {
-       void *addr;
+       u8 *addr;
        cfiword_t cword;
        int retval;
 
@@ -511,8 +508,8 @@ static int flash_toggle(flash_info_t *info, flash_sect_t sect,
                retval = flash_read32(addr) != flash_read32(addr);
                break;
        case FLASH_CFI_64BIT:
-               retval = ( (flash_read32( addr ) != flash_read32( addr )) ||
-                          (flash_read32(addr+4) != flash_read32(addr+4)) );
+               retval = ((flash_read32(addr) != flash_read32(addr)) ||
+                          (flash_read32(addr + 4) != flash_read32(addr + 4)));
                break;
        default:
                retval = 0;
@@ -558,7 +555,7 @@ static int flash_is_busy(flash_info_t *info, flash_sect_t sect)
        default:
                retval = 0;
        }
-       debug("flash_is_busy: %d\n", retval);
+       debug("%s: %d\n", __func__, retval);
        return retval;
 }
 
@@ -614,8 +611,8 @@ static int flash_full_status_check(flash_info_t *info, flash_sect_t sector,
        case CFI_CMDSET_INTEL_PROG_REGIONS:
        case CFI_CMDSET_INTEL_EXTENDED:
        case CFI_CMDSET_INTEL_STANDARD:
-               if ((retcode == ERR_OK)
-                   && !flash_isset(info, sector, 0, FLASH_STATUS_DONE)) {
+               if (retcode == ERR_OK &&
+                       !flash_isset(info, sector, 0, FLASH_STATUS_DONE)) {
                        retcode = ERR_INVAL;
                        printf("Flash %s error at address %lx\n", prompt,
                                info->start[sector]);
@@ -761,11 +758,11 @@ static flash_sect_t find_sector(flash_info_t *info, ulong addr)
        static flash_info_t *saved_info; /* previously used flash bank */
        flash_sect_t sector = saved_sector;
 
-       if ((info != saved_info) || (sector >= info->sector_count))
+       if (info != saved_info || sector >= info->sector_count)
                sector = 0;
 
-       while ((info->start[sector] < addr)
-                       && (sector < info->sector_count - 1))
+       while ((info->start[sector] < addr) &&
+               (sector < info->sector_count - 1))
                sector++;
        while ((info->start[sector] > addr) && (sector > 0))
                /*
@@ -875,9 +872,9 @@ static int flash_write_cfibuffer(flash_info_t *info, ulong dest, uchar *cp,
        flash_sect_t sector;
        int cnt;
        int retcode;
-       void *src = cp;
-       void *dst = (void *)dest;
-       void *dst2 = dst;
+       u8 *src = cp;
+       u8 *dst = (u8 *)dest;
+       u8 *dst2 = dst;
        int flag = 1;
        uint offset = 0;
        unsigned int shift;
@@ -949,7 +946,8 @@ static int flash_write_cfibuffer(flash_info_t *info, ulong dest, uchar *cp,
                                              "write to buffer");
                if (retcode == ERR_OK) {
                        /* reduce the number of loops by the width of
-                        * the port */
+                        * the port
+                        */
                        cnt = len >> shift;
                        flash_write_cmd(info, sector, 0, cnt - 1);
                        while (cnt-- > 0) {
@@ -1048,7 +1046,6 @@ out_unmap:
 }
 #endif /* CONFIG_SYS_FLASH_USE_BUFFER_WRITE */
 
-
 /*-----------------------------------------------------------------------
  */
 int flash_erase(flash_info_t *info, int s_first, int s_last)
@@ -1062,17 +1059,15 @@ int flash_erase(flash_info_t *info, int s_first, int s_last)
                puts("Can't erase unknown flash type - aborted\n");
                return 1;
        }
-       if ((s_first < 0) || (s_first > s_last)) {
+       if (s_first < 0 || s_first > s_last) {
                puts("- no sectors to erase\n");
                return 1;
        }
 
        prot = 0;
-       for (sect = s_first; sect <= s_last; ++sect) {
-               if (info->protect[sect]) {
+       for (sect = s_first; sect <= s_last; ++sect)
+               if (info->protect[sect])
                        prot++;
-               }
-       }
        if (prot) {
                printf("- Warning: %d protected sectors will not be erased!\n",
                        prot);
@@ -1080,7 +1075,6 @@ int flash_erase(flash_info_t *info, int s_first, int s_last)
                putc('\n');
        }
 
-
        for (sect = s_first; sect <= s_last; sect++) {
                if (ctrlc()) {
                        printf("\n");
@@ -1146,7 +1140,7 @@ int flash_erase(flash_info_t *info, int s_first, int s_last)
                                break;
 #endif
                        default:
-                               debug("Unkown flash vendor %d\n",
+                               debug("Unknown flash vendor %d\n",
                                       info->vendor);
                                break;
                        }
@@ -1154,15 +1148,18 @@ int flash_erase(flash_info_t *info, int s_first, int s_last)
                        if (use_flash_status_poll(info)) {
                                cfiword_t cword;
                                void *dest;
+
                                cword.w64 = 0xffffffffffffffffULL;
                                dest = flash_map(info, sect, 0);
                                st = flash_status_poll(info, &cword, dest,
                                                       info->erase_blk_tout, "erase");
                                flash_unmap(info, sect, 0, dest);
-                       } else
+                       } else {
                                st = flash_full_status_check(info, sect,
                                                             info->erase_blk_tout,
                                                             "erase");
+                       }
+
                        if (st)
                                rcode = 1;
                        else if (flash_verbose)
@@ -1212,7 +1209,7 @@ void flash_print_info(flash_info_t *info)
        printf("%s flash (%d x %d)",
                info->name,
                (info->portwidth << 3), (info->chipwidth << 3));
-       if (info->size < 1024*1024)
+       if (info->size < 1024 * 1024)
                printf("  Size: %ld kB in %d Sectors\n",
                        info->size >> 10, info->sector_count);
        else
@@ -1220,29 +1217,29 @@ void flash_print_info(flash_info_t *info)
                        info->size >> 20, info->sector_count);
        printf("  ");
        switch (info->vendor) {
-               case CFI_CMDSET_INTEL_PROG_REGIONS:
-                       printf("Intel Prog Regions");
-                       break;
-               case CFI_CMDSET_INTEL_STANDARD:
-                       printf("Intel Standard");
-                       break;
-               case CFI_CMDSET_INTEL_EXTENDED:
-                       printf("Intel Extended");
-                       break;
-               case CFI_CMDSET_AMD_STANDARD:
-                       printf("AMD Standard");
-                       break;
-               case CFI_CMDSET_AMD_EXTENDED:
-                       printf("AMD Extended");
-                       break;
+       case CFI_CMDSET_INTEL_PROG_REGIONS:
+               printf("Intel Prog Regions");
+               break;
+       case CFI_CMDSET_INTEL_STANDARD:
+               printf("Intel Standard");
+               break;
+       case CFI_CMDSET_INTEL_EXTENDED:
+               printf("Intel Extended");
+               break;
+       case CFI_CMDSET_AMD_STANDARD:
+               printf("AMD Standard");
+               break;
+       case CFI_CMDSET_AMD_EXTENDED:
+               printf("AMD Extended");
+               break;
 #ifdef CONFIG_FLASH_CFI_LEGACY
-               case CFI_CMDSET_AMD_LEGACY:
-                       printf("AMD Legacy");
-                       break;
+       case CFI_CMDSET_AMD_LEGACY:
+               printf("AMD Legacy");
+               break;
 #endif
-               default:
-                       printf("Unknown (%d)", info->vendor);
-                       break;
+       default:
+               printf("Unknown (%d)", info->vendor);
+               break;
        }
        printf(" command set, Manufacturer ID: 0x%02X, Device ID: 0x",
                info->manufacturer_id);
@@ -1252,16 +1249,15 @@ void flash_print_info(flash_info_t *info)
                printf(info->chipwidth == FLASH_CFI_16BIT ? "%04X" : "%02X",
                info->device_id2);
        }
-       if ((info->vendor == CFI_CMDSET_AMD_STANDARD) && (info->legacy_unlock))
+       if (info->vendor == CFI_CMDSET_AMD_STANDARD && info->legacy_unlock)
                printf("\n  Advanced Sector Protection (PPB) enabled");
        printf("\n  Erase timeout: %ld ms, write timeout: %ld ms\n",
                info->erase_blk_tout,
                info->write_tout);
        if (info->buffer_size > 1) {
-               printf("  Buffer write timeout: %ld ms, "
-                       "buffer size: %d bytes\n",
-               info->buffer_write_tout,
-               info->buffer_size);
+               printf("  Buffer write timeout: %ld ms, ",
+                       info->buffer_write_tout);
+               printf("buffer size: %d bytes\n", info->buffer_size);
        }
 
        puts("\n  Sector Start Addresses:");
@@ -1283,7 +1279,6 @@ void flash_print_info(flash_info_t *info)
 #endif
        }
        putc('\n');
-       return;
 }
 
 /*-----------------------------------------------------------------------
@@ -1296,7 +1291,7 @@ void flash_print_info(flash_info_t *info)
 #define FLASH_SHOW_PROGRESS(scale, dots, digit, dots_sub) \
        if (flash_verbose) { \
                dots -= dots_sub; \
-               if ((scale > 0) && (dots <= 0)) { \
+               if (scale > 0 && dots <= 0) { \
                        if ((digit % 5) == 0) \
                                printf("%d", digit / 5); \
                        else \
@@ -1343,7 +1338,8 @@ int write_buff(flash_info_t *info, uchar *src, ulong addr, ulong cnt)
        wp = (addr & ~(info->portwidth - 1));
 
        /* handle unaligned start */
-       if ((aln = addr - wp) != 0) {
+       aln = addr - wp;
+       if (aln != 0) {
                cword.w32 = 0;
                p = (uchar *)wp;
                for (i = 0; i < aln; ++i)
@@ -1374,7 +1370,8 @@ int write_buff(flash_info_t *info, uchar *src, ulong addr, ulong cnt)
                        cword.w32 = 0;
                        for (i = 0; i < info->portwidth; i++)
                                flash_add_byte(info, &cword, *src++);
-                       if ((rc = flash_write_cfiword(info, wp, cword)) != 0)
+                       rc = flash_write_cfiword(info, wp, cword);
+                       if (rc != 0)
                                return rc;
                        wp += info->portwidth;
                        cnt -= info->portwidth;
@@ -1385,7 +1382,8 @@ int write_buff(flash_info_t *info, uchar *src, ulong addr, ulong cnt)
                i = buffered_size - (wp % buffered_size);
                if (i > cnt)
                        i = cnt;
-               if ((rc = flash_write_cfibuffer(info, wp, src, i)) != ERR_OK)
+               rc = flash_write_cfibuffer(info, wp, src, i);
+               if (rc != ERR_OK)
                        return rc;
                i -= i & (info->portwidth - 1);
                wp += i;
@@ -1399,10 +1397,10 @@ int write_buff(flash_info_t *info, uchar *src, ulong addr, ulong cnt)
 #else
        while (cnt >= info->portwidth) {
                cword.w32 = 0;
-               for (i = 0; i < info->portwidth; i++) {
+               for (i = 0; i < info->portwidth; i++)
                        flash_add_byte(info, &cword, *src++);
-               }
-               if ((rc = flash_write_cfiword(info, wp, cword)) != 0)
+               rc = flash_write_cfiword(info, wp, cword);
+               if (rc != 0)
                        return rc;
                wp += info->portwidth;
                cnt -= info->portwidth;
@@ -1413,9 +1411,8 @@ int write_buff(flash_info_t *info, uchar *src, ulong addr, ulong cnt)
        }
 #endif /* CONFIG_SYS_FLASH_USE_BUFFER_WRITE */
 
-       if (cnt == 0) {
+       if (cnt == 0)
                return (0);
-       }
 
        /*
         * handle unaligned tail bytes
@@ -1443,8 +1440,8 @@ static inline int manufact_match(flash_info_t *info, u32 manu)
 
 static int cfi_protect_bugfix(flash_info_t *info, long sector, int prot)
 {
-       if (manufact_match(info, INTEL_MANUFACT)
-           && info->device_id == NUMONYX_256MBIT) {
+       if (manufact_match(info, INTEL_MANUFACT) &&
+               info->device_id == NUMONYX_256MBIT) {
                /*
                 * see errata called
                 * "Numonyx Axcell P33/P30 Specification Update" :)
@@ -1480,94 +1477,93 @@ int flash_real_protect(flash_info_t *info, long sector, int prot)
        int retcode = 0;
 
        switch (info->vendor) {
-               case CFI_CMDSET_INTEL_PROG_REGIONS:
-               case CFI_CMDSET_INTEL_STANDARD:
-               case CFI_CMDSET_INTEL_EXTENDED:
-                       if (!cfi_protect_bugfix(info, sector, prot)) {
+       case CFI_CMDSET_INTEL_PROG_REGIONS:
+       case CFI_CMDSET_INTEL_STANDARD:
+       case CFI_CMDSET_INTEL_EXTENDED:
+               if (!cfi_protect_bugfix(info, sector, prot)) {
+                       flash_write_cmd(info, sector, 0,
+                                FLASH_CMD_CLEAR_STATUS);
+                       flash_write_cmd(info, sector, 0,
+                               FLASH_CMD_PROTECT);
+                       if (prot)
                                flash_write_cmd(info, sector, 0,
-                                        FLASH_CMD_CLEAR_STATUS);
+                                       FLASH_CMD_PROTECT_SET);
+                       else
                                flash_write_cmd(info, sector, 0,
-                                       FLASH_CMD_PROTECT);
-                               if (prot)
-                                       flash_write_cmd(info, sector, 0,
-                                               FLASH_CMD_PROTECT_SET);
-                               else
-                                       flash_write_cmd(info, sector, 0,
-                                               FLASH_CMD_PROTECT_CLEAR);
-
+                                       FLASH_CMD_PROTECT_CLEAR);
+               }
+               break;
+       case CFI_CMDSET_AMD_EXTENDED:
+       case CFI_CMDSET_AMD_STANDARD:
+               /* U-Boot only checks the first byte */
+               if (manufact_match(info, ATM_MANUFACT)) {
+                       if (prot) {
+                               flash_unlock_seq(info, 0);
+                               flash_write_cmd(info, 0,
+                                               info->addr_unlock1,
+                                               ATM_CMD_SOFTLOCK_START);
+                               flash_unlock_seq(info, 0);
+                               flash_write_cmd(info, sector, 0,
+                                               ATM_CMD_LOCK_SECT);
+                       } else {
+                               flash_write_cmd(info, 0,
+                                               info->addr_unlock1,
+                                               AMD_CMD_UNLOCK_START);
+                               if (info->device_id == ATM_ID_BV6416)
+                                       flash_write_cmd(info, sector,
+                                               0, ATM_CMD_UNLOCK_SECT);
                        }
-                       break;
-               case CFI_CMDSET_AMD_EXTENDED:
-               case CFI_CMDSET_AMD_STANDARD:
-                       /* U-Boot only checks the first byte */
-                       if (manufact_match(info, ATM_MANUFACT)) {
-                               if (prot) {
-                                       flash_unlock_seq(info, 0);
-                                       flash_write_cmd(info, 0,
-                                                       info->addr_unlock1,
-                                                       ATM_CMD_SOFTLOCK_START);
-                                       flash_unlock_seq(info, 0);
+               }
+               if (info->legacy_unlock) {
+                       int flag = disable_interrupts();
+                       int lock_flag;
+
+                       flash_unlock_seq(info, 0);
+                       flash_write_cmd(info, 0, info->addr_unlock1,
+                                       AMD_CMD_SET_PPB_ENTRY);
+                       lock_flag = flash_isset(info, sector, 0, 0x01);
+                       if (prot) {
+                               if (lock_flag) {
                                        flash_write_cmd(info, sector, 0,
-                                                       ATM_CMD_LOCK_SECT);
-                               } else {
-                                       flash_write_cmd(info, 0,
-                                                       info->addr_unlock1,
-                                                       AMD_CMD_UNLOCK_START);
-                                       if (info->device_id == ATM_ID_BV6416)
-                                               flash_write_cmd(info, sector,
-                                                       0, ATM_CMD_UNLOCK_SECT);
+                                               AMD_CMD_PPB_LOCK_BC1);
+                                       flash_write_cmd(info, sector, 0,
+                                               AMD_CMD_PPB_LOCK_BC2);
                                }
-                       }
-                       if (info->legacy_unlock) {
-                               int flag = disable_interrupts();
-                               int lock_flag;
-
-                               flash_unlock_seq(info, 0);
-                               flash_write_cmd(info, 0, info->addr_unlock1,
-                                               AMD_CMD_SET_PPB_ENTRY);
-                               lock_flag = flash_isset(info, sector, 0, 0x01);
-                               if (prot) {
-                                       if (lock_flag) {
-                                               flash_write_cmd(info, sector, 0,
-                                                       AMD_CMD_PPB_LOCK_BC1);
-                                               flash_write_cmd(info, sector, 0,
-                                                       AMD_CMD_PPB_LOCK_BC2);
-                                       }
-                                       debug("sector %ld %slocked\n", sector,
-                                               lock_flag ? "" : "already ");
-                               } else {
-                                       if (!lock_flag) {
-                                               debug("unlock %ld\n", sector);
-                                               flash_write_cmd(info, 0, 0,
-                                                       AMD_CMD_PPB_UNLOCK_BC1);
-                                               flash_write_cmd(info, 0, 0,
-                                                       AMD_CMD_PPB_UNLOCK_BC2);
-                                       }
-                                       debug("sector %ld %sunlocked\n", sector,
-                                               !lock_flag ? "" : "already ");
+                               debug("sector %ld %slocked\n", sector,
+                                       lock_flag ? "" : "already ");
+                       } else {
+                               if (!lock_flag) {
+                                       debug("unlock %ld\n", sector);
+                                       flash_write_cmd(info, 0, 0,
+                                               AMD_CMD_PPB_UNLOCK_BC1);
+                                       flash_write_cmd(info, 0, 0,
+                                               AMD_CMD_PPB_UNLOCK_BC2);
                                }
-                               if (flag)
-                                       enable_interrupts();
-
-                               if (flash_status_check(info, sector,
-                                               info->erase_blk_tout,
-                                               prot ? "protect" : "unprotect"))
-                                       printf("status check error\n");
-
-                               flash_write_cmd(info, 0, 0,
-                                               AMD_CMD_SET_PPB_EXIT_BC1);
-                               flash_write_cmd(info, 0, 0,
-                                               AMD_CMD_SET_PPB_EXIT_BC2);
+                               debug("sector %ld %sunlocked\n", sector,
+                                       !lock_flag ? "" : "already ");
                        }
-                       break;
+                       if (flag)
+                               enable_interrupts();
+
+                       if (flash_status_check(info, sector,
+                                       info->erase_blk_tout,
+                                       prot ? "protect" : "unprotect"))
+                               printf("status check error\n");
+
+                       flash_write_cmd(info, 0, 0,
+                                       AMD_CMD_SET_PPB_EXIT_BC1);
+                       flash_write_cmd(info, 0, 0,
+                                       AMD_CMD_SET_PPB_EXIT_BC2);
+               }
+               break;
 #ifdef CONFIG_FLASH_CFI_LEGACY
-               case CFI_CMDSET_AMD_LEGACY:
-                       flash_write_cmd(info, sector, 0, FLASH_CMD_CLEAR_STATUS);
-                       flash_write_cmd(info, sector, 0, FLASH_CMD_PROTECT);
-                       if (prot)
-                               flash_write_cmd(info, sector, 0, FLASH_CMD_PROTECT_SET);
-                       else
-                               flash_write_cmd(info, sector, 0, FLASH_CMD_PROTECT_CLEAR);
+       case CFI_CMDSET_AMD_LEGACY:
+               flash_write_cmd(info, sector, 0, FLASH_CMD_CLEAR_STATUS);
+               flash_write_cmd(info, sector, 0, FLASH_CMD_PROTECT);
+               if (prot)
+                       flash_write_cmd(info, sector, 0, FLASH_CMD_PROTECT_SET);
+               else
+                       flash_write_cmd(info, sector, 0, FLASH_CMD_PROTECT_CLEAR);
 #endif
        };
 
@@ -1576,17 +1572,16 @@ int flash_real_protect(flash_info_t *info, long sector, int prot)
         * flash_full_status_check() to work correctly
         */
        flash_write_cmd(info, sector, 0, FLASH_CMD_READ_STATUS);
-       if ((retcode =
-            flash_full_status_check(info, sector, info->erase_blk_tout,
-                                     prot ? "protect" : "unprotect")) == 0) {
-
+       retcode = flash_full_status_check(info, sector, info->erase_blk_tout,
+                                     prot ? "protect" : "unprotect");
+       if (retcode == 0) {
                info->protect[sector] = prot;
 
                /*
                 * On some of Intel's flash chips (marked via legacy_unlock)
                 * unprotect unprotects all locking.
                 */
-               if ((prot == 0) && (info->legacy_unlock)) {
+               if (prot == 0 && info->legacy_unlock) {
                        flash_sect_t i;
 
                        for (i = 0; i < info->sector_count; i++) {
@@ -1645,10 +1640,10 @@ static void cfi_reverse_geometry(struct cfi_qry *qry)
        u32 tmp;
 
        for (i = 0, j = qry->num_erase_regions - 1; i < j; i++, j--) {
-               tmp = get_unaligned(&(qry->erase_region_info[i]));
-               put_unaligned(get_unaligned(&(qry->erase_region_info[j])),
-                             &(qry->erase_region_info[i]));
-               put_unaligned(tmp, &(qry->erase_region_info[j]));
+               tmp = get_unaligned(&qry->erase_region_info[i]);
+               put_unaligned(get_unaligned(&qry->erase_region_info[j]),
+                             &qry->erase_region_info[i]);
+               put_unaligned(tmp, &qry->erase_region_info[j]);
        }
 }
 
@@ -1719,7 +1714,7 @@ static void cmdset_amd_read_jedec_ids(flash_info_t *info)
                info->sr_supported = feature & 0x1;
        }
 
-       switch (info->chipwidth){
+       switch (info->chipwidth) {
        case FLASH_CFI_8BIT:
                info->device_id = flash_read_uchar(info,
                                                FLASH_OFFSET_DEVICE_ID);
@@ -1803,7 +1798,8 @@ static int flash_detect_legacy(phys_addr_t base, int banknum)
 
        if (board_flash_get_legacy(base, banknum, info)) {
                /* board code may have filled info completely. If not, we
-                  use JEDEC ID probing. */
+                * use JEDEC ID probing.
+                */
                if (!info->vendor) {
                        int modes[] = {
                                CFI_CMDSET_AMD_STANDARD,
@@ -1817,8 +1813,8 @@ static int flash_detect_legacy(phys_addr_t base, int banknum)
                                        (ulong)map_physmem(base,
                                                           info->portwidth,
                                                           MAP_NOCACHE);
-                               if (info->portwidth == FLASH_CFI_8BIT
-                                       && info->interface == FLASH_CFI_X8X16) {
+                               if (info->portwidth == FLASH_CFI_8BIT &&
+                                       info->interface == FLASH_CFI_X8X16) {
                                        info->addr_unlock1 = 0x2AAA;
                                        info->addr_unlock2 = 0x5555;
                                } else {
@@ -1832,13 +1828,13 @@ static int flash_detect_legacy(phys_addr_t base, int banknum)
                                                info->device_id2);
                                if (jedec_flash_match(info, info->start[0]))
                                        break;
-                               else
-                                       unmap_physmem((void *)info->start[0],
-                                                     info->portwidth);
+
+                               unmap_physmem((void *)info->start[0],
+                                             info->portwidth);
                        }
                }
 
-               switch(info->vendor) {
+               switch (info->vendor) {
                case CFI_CMDSET_INTEL_PROG_REGIONS:
                case CFI_CMDSET_INTEL_STANDARD:
                case CFI_CMDSET_INTEL_EXTENDED:
@@ -1887,8 +1883,9 @@ static void __flash_cmd_reset(flash_info_t *info)
        udelay(1);
        flash_write_cmd(info, 0, 0, FLASH_CMD_RESET);
 }
+
 void flash_cmd_reset(flash_info_t *info)
-       __attribute__((weak,alias("__flash_cmd_reset")));
+       __attribute__((weak, alias("__flash_cmd_reset")));
 
 static int __flash_detect_cfi(flash_info_t *info, struct cfi_qry *qry)
 {
@@ -1901,9 +1898,9 @@ static int __flash_detect_cfi(flash_info_t *info, struct cfi_qry *qry)
             cfi_offset++) {
                flash_write_cmd(info, 0, flash_offset_cfi[cfi_offset],
                                 FLASH_CMD_CFI);
-               if (flash_isequal(info, 0, FLASH_OFFSET_CFI_RESP, 'Q')
-                   && flash_isequal(info, 0, FLASH_OFFSET_CFI_RESP + 1, 'R')
-                   && flash_isequal(info, 0, FLASH_OFFSET_CFI_RESP + 2, 'Y')) {
+               if (flash_isequal(info, 0, FLASH_OFFSET_CFI_RESP, 'Q') &&
+                       flash_isequal(info, 0, FLASH_OFFSET_CFI_RESP + 1, 'R') &&
+                       flash_isequal(info, 0, FLASH_OFFSET_CFI_RESP + 2, 'Y')) {
                        flash_read_cfi(info, qry, FLASH_OFFSET_CFI_RESP,
                                        sizeof(struct cfi_qry));
                        info->interface = le16_to_cpu(qry->interface_desc);
@@ -1925,13 +1922,12 @@ static int __flash_detect_cfi(flash_info_t *info, struct cfi_qry *qry)
                         * modify the unlock address if we are
                         * in compatibility mode
                         */
-                       if (    /* x8/x16 in x8 mode */
-                               ((info->chipwidth == FLASH_CFI_BY8) &&
-                                       (info->interface == FLASH_CFI_X8X16)) ||
-                               /* x16/x32 in x16 mode */
-                               ((info->chipwidth == FLASH_CFI_BY16) &&
-                                       (info->interface == FLASH_CFI_X16X32)))
-                       {
+                       if (/* x8/x16 in x8 mode */
+                           (info->chipwidth == FLASH_CFI_BY8 &&
+                               info->interface == FLASH_CFI_X8X16) ||
+                           /* x16/x32 in x16 mode */
+                           (info->chipwidth == FLASH_CFI_BY16 &&
+                               info->interface == FLASH_CFI_X16X32)) {
                                info->addr_unlock1 = 0xaaa;
                                info->addr_unlock2 = 0x555;
                        }
@@ -2035,7 +2031,7 @@ static void flash_fixup_sst(flash_info_t *info, struct cfi_qry *qry)
        if (info->device_id == 0x5D23 || /* SST39VF3201B */
            info->device_id == 0x5C23) { /* SST39VF3202B */
                /* set sector granularity to 4KB */
-               info->cmd_erase_sector=0x50;
+               info->cmd_erase_sector = 0x50;
        }
 }
 
@@ -2047,14 +2043,14 @@ static void flash_fixup_num(flash_info_t *info, struct cfi_qry *qry)
         * There's an app note from Numonyx on this issue.
         * So adjust the buffer size for M29EW while operating in 8-bit mode
         */
-       if (((qry->max_buf_write_size) > 0x8) &&
-                       (info->device_id == 0x7E) &&
+       if (qry->max_buf_write_size > 0x8 &&
+                       info->device_id == 0x7E &&
                        (info->device_id2 == 0x2201 ||
                        info->device_id2 == 0x2301 ||
                        info->device_id2 == 0x2801 ||
                        info->device_id2 == 0x4801)) {
-               debug("Adjusted buffer size on Numonyx flash"
-                       " M29EW family in 8 bit mode\n");
+               debug("Adjusted buffer size on Numonyx flash");
+               debug(" M29EW family in 8 bit mode\n");
                qry->max_buf_write_size = 0x8;
        }
 }
@@ -2088,14 +2084,14 @@ ulong flash_get_size(phys_addr_t base, int banknum)
        info->start[0] = (ulong)map_physmem(base, info->portwidth, MAP_NOCACHE);
 
        if (flash_detect_cfi(info, &qry)) {
-               info->vendor = le16_to_cpu(get_unaligned(&(qry.p_id)));
-               info->ext_addr = le16_to_cpu(get_unaligned(&(qry.p_adr)));
+               info->vendor = le16_to_cpu(get_unaligned(&qry.p_id));
+               info->ext_addr = le16_to_cpu(get_unaligned(&qry.p_adr));
                num_erase_regions = qry.num_erase_regions;
 
                if (info->ext_addr) {
-                       info->cfi_version = (ushort) flash_read_uchar(info,
+                       info->cfi_version = (ushort)flash_read_uchar(info,
                                                info->ext_addr + 3) << 8;
-                       info->cfi_version |= (ushort) flash_read_uchar(info,
+                       info->cfi_version |= (ushort)flash_read_uchar(info,
                                                info->ext_addr + 4);
                }
 
@@ -2153,8 +2149,8 @@ ulong flash_get_size(phys_addr_t base, int banknum)
 
                size_ratio = info->portwidth / info->chipwidth;
                /* if the chip is x8/x16 reduce the ratio by half */
-               if ((info->interface == FLASH_CFI_X8X16)
-                   && (info->chipwidth == FLASH_CFI_BY8)) {
+               if (info->interface == FLASH_CFI_X8X16 &&
+                       info->chipwidth == FLASH_CFI_BY8) {
                        size_ratio >>= 1;
                }
                debug("size_ratio %d port %d bits chip %d bits\n",
@@ -2164,7 +2160,7 @@ ulong flash_get_size(phys_addr_t base, int banknum)
                /* multiply the size by the number of chips */
                info->size *= size_ratio;
                max_size = cfi_flash_bank_size(banknum);
-               if (max_size && (info->size > max_size)) {
+               if (max_size && info->size > max_size) {
                        debug("[truncated from %ldMiB]", info->size >> 20);
                        info->size = max_size;
                }
@@ -2179,7 +2175,7 @@ ulong flash_get_size(phys_addr_t base, int banknum)
                        }
 
                        tmp = le32_to_cpu(get_unaligned(
-                                               &(qry.erase_region_info[i])));
+                                               &qry.erase_region_info[i]));
                        debug("erase region %u: 0x%08lx\n", i, tmp);
 
                        erase_region_count = (tmp & 0xffff) + 1;
@@ -2268,8 +2264,8 @@ ulong flash_get_size(phys_addr_t base, int banknum)
                /* round up when converting to ms */
                info->write_tout = (tmp + 999) / 1000;
                info->flash_id = FLASH_MAN_CFI;
-               if ((info->interface == FLASH_CFI_X8X16) &&
-                   (info->chipwidth == FLASH_CFI_BY8)) {
+               if (info->interface == FLASH_CFI_X8X16 &&
+                   info->chipwidth == FLASH_CFI_BY8) {
                        /* XXX - Need to test on x8/x16 in parallel. */
                        info->portwidth >>= 1;
                }
@@ -2370,6 +2366,7 @@ unsigned long flash_init(void)
 #ifdef CONFIG_SYS_FLASH_PROTECTION
        /* read environment from EEPROM */
        char s[64];
+
        env_get_f("unlock", s, sizeof(s));
 #endif
 
@@ -2390,9 +2387,9 @@ unsigned long flash_init(void)
                size += flash_info[i].size;
                if (flash_info[i].flash_id == FLASH_UNKNOWN) {
 #ifndef CONFIG_SYS_FLASH_QUIET_TEST
-                       printf("## Unknown flash on Bank %d "
-                               "- Size = 0x%08lx = %ld MB\n",
-                               i+1, flash_info[i].size,
+                       printf("## Unknown flash on Bank %d ", i + 1);
+                       printf("- Size = 0x%08lx = %ld MB\n",
+                               flash_info[i].size,
                                flash_info[i].size >> 20);
 #endif /* CONFIG_SYS_FLASH_QUIET_TEST */
                }