]> git.sur5r.net Git - u-boot/blobdiff - drivers/mtd/nand/sunxi_nand_spl.c
mtd: nand: mxs_nand: use structure for BCH geometry
[u-boot] / drivers / mtd / nand / sunxi_nand_spl.c
index ac5f56d066fef5245050b4604f84e5155a064732..6cde9814c4f9b246c5d3a987ffd7363c0706c086 100644 (file)
@@ -1,14 +1,15 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * Copyright (c) 2014-2015, Antmicro Ltd <www.antmicro.com>
  * Copyright (c) 2015, AW-SOM Technologies <www.aw-som.com>
- *
- * SPDX-License-Identifier:     GPL-2.0+
  */
 
+#include <asm/arch/clock.h>
+#include <asm/io.h>
 #include <common.h>
 #include <config.h>
-#include <asm/io.h>
 #include <nand.h>
+#include <linux/ctype.h>
 
 /* registers */
 #define NFC_CTL                    0x00000000
@@ -41,6 +42,8 @@
 #define NFC_CTL_EN                 (1 << 0)
 #define NFC_CTL_RESET              (1 << 1)
 #define NFC_CTL_RAM_METHOD         (1 << 14)
+#define NFC_CTL_PAGE_SIZE_MASK     (0xf << 8)
+#define NFC_CTL_PAGE_SIZE(a)       ((fls(a) - 11) << 8)
 
 
 #define NFC_ECC_EN                 (1 << 0)
@@ -52,7 +55,7 @@
 
 
 #define NFC_ADDR_NUM_OFFSET        16
-#define NFC_SEND_AD              (1 << 19)
+#define NFC_SEND_ADDR              (1 << 19)
 #define NFC_ACCESS_DIR             (1 << 20)
 #define NFC_DATA_TRANS             (1 << 21)
 #define NFC_SEND_CMD1              (1 << 22)
 #define NFC_ROW_AUTO_INC           (1 << 27)
 #define NFC_SEND_CMD3              (1 << 28)
 #define NFC_SEND_CMD4              (1 << 29)
+#define NFC_RAW_CMD                (0 << 30)
+#define NFC_ECC_CMD                (1 << 30)
+#define NFC_PAGE_CMD               (2 << 30)
 
-#define NFC_CMD_INT_FLAG           (1 << 1)
+#define NFC_ST_CMD_INT_FLAG        (1 << 1)
+#define NFC_ST_DMA_INT_FLAG        (1 << 2)
+#define NFC_ST_CMD_FIFO_STAT       (1 << 3)
 
 #define NFC_READ_CMD_OFFSET         0
 #define NFC_RANDOM_READ_CMD0_OFFSET 8
 #define NFC_CMD_RNDOUT             0x05
 #define NFC_CMD_READSTART          0x30
 
-
-#define NFC_PAGE_CMD               (2 << 30)
-
-#define SUNXI_DMA_CFG_REG0              0x300
-#define SUNXI_DMA_SRC_START_ADDR_REG0   0x304
-#define SUNXI_DMA_DEST_START_ADDRR_REG0 0x308
-#define SUNXI_DMA_DDMA_BC_REG0          0x30C
-#define SUNXI_DMA_DDMA_PARA_REG0        0x318
-
-#define SUNXI_DMA_DDMA_CFG_REG_LOADING  (1 << 31)
-#define SUNXI_DMA_DDMA_CFG_REG_DMA_DEST_DATA_WIDTH_32 (2 << 25)
-#define SUNXI_DMA_DDMA_CFG_REG_DMA_SRC_DATA_WIDTH_32 (2 << 9)
-#define SUNXI_DMA_DDMA_CFG_REG_DMA_SRC_ADDR_MODE_IO (1 << 5)
-#define SUNXI_DMA_DDMA_CFG_REG_DDMA_SRC_DRQ_TYPE_NFC (3 << 0)
-
-#define SUNXI_DMA_DDMA_PARA_REG_SRC_WAIT_CYC (0x0F << 0)
-#define SUNXI_DMA_DDMA_PARA_REG_SRC_BLK_SIZE (0x7F << 8)
+struct nfc_config {
+       int page_size;
+       int ecc_strength;
+       int ecc_size;
+       int addr_cycles;
+       int nseeds;
+       bool randomize;
+       bool valid;
+};
 
 /* minimal "boot0" style NAND support for Allwinner A20 */
 
-/* temporary buffer in internal ram */
-unsigned char temp_buf[CONFIG_NAND_SUNXI_SPL_ECC_PAGE_SIZE]
-       __aligned(0x10) __section(".text#");
-
 /* random seed used by linux */
 const uint16_t random_seed[128] = {
        0x2b75, 0x0bd0, 0x5ca3, 0x62d1, 0x1c93, 0x07e9, 0x2162, 0x3a72,
@@ -118,236 +114,435 @@ const uint16_t random_seed[128] = {
        0x7c57, 0x0fbe, 0x46ce, 0x4939, 0x6b17, 0x37bb, 0x3e91, 0x76db,
 };
 
-/* random seed used for syndrome calls */
-const uint16_t random_seed_syndrome = 0x4a80;
-
-#define MAX_RETRIES 10
+#define DEFAULT_TIMEOUT_US     100000
 
 static int check_value_inner(int offset, int expected_bits,
-                               int max_number_of_retries, int negation)
+                            int timeout_us, int negation)
 {
-       int retries = 0;
        do {
                int val = readl(offset) & expected_bits;
                if (negation ? !val : val)
                        return 1;
-               mdelay(1);
-               retries++;
-       } while (retries < max_number_of_retries);
+               udelay(1);
+       } while (--timeout_us);
 
        return 0;
 }
 
 static inline int check_value(int offset, int expected_bits,
-                               int max_number_of_retries)
+                             int timeout_us)
 {
-       return check_value_inner(offset, expected_bits,
-                                       max_number_of_retries, 0);
+       return check_value_inner(offset, expected_bits, timeout_us, 0);
 }
 
 static inline int check_value_negated(int offset, int unexpected_bits,
-                                       int max_number_of_retries)
+                                     int timeout_us)
 {
-       return check_value_inner(offset, unexpected_bits,
-                                       max_number_of_retries, 1);
+       return check_value_inner(offset, unexpected_bits, timeout_us, 1);
+}
+
+static int nand_wait_cmd_fifo_empty(void)
+{
+       if (!check_value_negated(SUNXI_NFC_BASE + NFC_ST, NFC_ST_CMD_FIFO_STAT,
+                                DEFAULT_TIMEOUT_US)) {
+               printf("nand: timeout waiting for empty cmd FIFO\n");
+               return -ETIMEDOUT;
+       }
+
+       return 0;
+}
+
+static int nand_wait_int(void)
+{
+       if (!check_value(SUNXI_NFC_BASE + NFC_ST, NFC_ST_CMD_INT_FLAG,
+                        DEFAULT_TIMEOUT_US)) {
+               printf("nand: timeout waiting for interruption\n");
+               return -ETIMEDOUT;
+       }
+
+       return 0;
+}
+
+static int nand_exec_cmd(u32 cmd)
+{
+       int ret;
+
+       ret = nand_wait_cmd_fifo_empty();
+       if (ret)
+               return ret;
+
+       writel(NFC_ST_CMD_INT_FLAG, SUNXI_NFC_BASE + NFC_ST);
+       writel(cmd, SUNXI_NFC_BASE + NFC_CMD);
+
+       return nand_wait_int();
 }
 
 void nand_init(void)
 {
        uint32_t val;
 
+       board_nand_init();
+
        val = readl(SUNXI_NFC_BASE + NFC_CTL);
        /* enable and reset CTL */
        writel(val | NFC_CTL_EN | NFC_CTL_RESET,
               SUNXI_NFC_BASE + NFC_CTL);
 
        if (!check_value_negated(SUNXI_NFC_BASE + NFC_CTL,
-                                NFC_CTL_RESET, MAX_RETRIES)) {
+                                NFC_CTL_RESET, DEFAULT_TIMEOUT_US)) {
                printf("Couldn't initialize nand\n");
        }
+
+       /* reset NAND */
+       nand_exec_cmd(NFC_SEND_CMD1 | NFC_WAIT_FLAG | NAND_CMD_RESET);
 }
 
-static void nand_read_page(unsigned int real_addr, int syndrome,
-                          uint32_t *ecc_errors)
+static void nand_apply_config(const struct nfc_config *conf)
 {
-       uint32_t val;
-       int ecc_off = 0;
-       uint16_t ecc_mode = 0;
-       uint16_t rand_seed;
-       uint32_t page;
-       uint16_t column;
-       uint32_t oob_offset;
-
-       switch (CONFIG_NAND_SUNXI_SPL_ECC_STRENGTH) {
-       case 16:
-               ecc_mode = 0;
-               ecc_off = 0x20;
-               break;
-       case 24:
-               ecc_mode = 1;
-               ecc_off = 0x2e;
-               break;
-       case 28:
-               ecc_mode = 2;
-               ecc_off = 0x32;
-               break;
-       case 32:
-               ecc_mode = 3;
-               ecc_off = 0x3c;
-               break;
-       case 40:
-               ecc_mode = 4;
-               ecc_off = 0x4a;
-               break;
-       case 48:
-               ecc_mode = 4;
-               ecc_off = 0x52;
+       u32 val;
+
+       nand_wait_cmd_fifo_empty();
+
+       val = readl(SUNXI_NFC_BASE + NFC_CTL);
+       val &= ~NFC_CTL_PAGE_SIZE_MASK;
+       writel(val | NFC_CTL_RAM_METHOD | NFC_CTL_PAGE_SIZE(conf->page_size),
+              SUNXI_NFC_BASE + NFC_CTL);
+       writel(conf->ecc_size, SUNXI_NFC_BASE + NFC_CNT);
+       writel(conf->page_size, SUNXI_NFC_BASE + NFC_SPARE_AREA);
+}
+
+static int nand_load_page(const struct nfc_config *conf, u32 offs)
+{
+       int page = offs / conf->page_size;
+
+       writel((NFC_CMD_RNDOUTSTART << NFC_RANDOM_READ_CMD1_OFFSET) |
+              (NFC_CMD_RNDOUT << NFC_RANDOM_READ_CMD0_OFFSET) |
+              (NFC_CMD_READSTART << NFC_READ_CMD_OFFSET),
+              SUNXI_NFC_BASE + NFC_RCMD_SET);
+       writel(((page & 0xFFFF) << 16), SUNXI_NFC_BASE + NFC_ADDR_LOW);
+       writel((page >> 16) & 0xFF, SUNXI_NFC_BASE + NFC_ADDR_HIGH);
+
+       return nand_exec_cmd(NFC_SEND_CMD1 | NFC_SEND_CMD2 | NFC_RAW_CMD |
+                            NFC_SEND_ADDR | NFC_WAIT_FLAG |
+                            ((conf->addr_cycles - 1) << NFC_ADDR_NUM_OFFSET));
+}
+
+static int nand_change_column(u16 column)
+{
+       int ret;
+
+       writel((NFC_CMD_RNDOUTSTART << NFC_RANDOM_READ_CMD1_OFFSET) |
+              (NFC_CMD_RNDOUT << NFC_RANDOM_READ_CMD0_OFFSET) |
+              (NFC_CMD_RNDOUTSTART << NFC_READ_CMD_OFFSET),
+              SUNXI_NFC_BASE + NFC_RCMD_SET);
+       writel(column, SUNXI_NFC_BASE + NFC_ADDR_LOW);
+
+       ret = nand_exec_cmd(NFC_SEND_CMD1 | NFC_SEND_CMD2 | NFC_RAW_CMD |
+                           (1 << NFC_ADDR_NUM_OFFSET) | NFC_SEND_ADDR |
+                           NFC_CMD_RNDOUT);
+       if (ret)
+               return ret;
+
+       /* Ensure tCCS has passed before reading data */
+       udelay(1);
+
+       return 0;
+}
+
+static const int ecc_bytes[] = {32, 46, 54, 60, 74, 88, 102, 110, 116};
+
+static int nand_read_page(const struct nfc_config *conf, u32 offs,
+                         void *dest, int len)
+{
+       int nsectors = len / conf->ecc_size;
+       u16 rand_seed = 0;
+       int oob_chunk_sz = ecc_bytes[conf->ecc_strength];
+       int page = offs / conf->page_size;
+       u32 ecc_st;
+       int i;
+
+       if (offs % conf->page_size || len % conf->ecc_size ||
+           len > conf->page_size || len < 0)
+               return -EINVAL;
+
+       /* Choose correct seed if randomized */
+       if (conf->randomize)
+               rand_seed = random_seed[page % conf->nseeds];
+
+       /* Retrieve data from SRAM (PIO) */
+       for (i = 0; i < nsectors; i++) {
+               int data_off = i * conf->ecc_size;
+               int oob_off = conf->page_size + (i * oob_chunk_sz);
+               u8 *data = dest + data_off;
+
+               /* Clear ECC status and restart ECC engine */
+               writel(0, SUNXI_NFC_BASE + NFC_ECC_ST);
+               writel((rand_seed << 16) | (conf->ecc_strength << 12) |
+                      (conf->randomize ? NFC_ECC_RANDOM_EN : 0) |
+                      (conf->ecc_size == 512 ? NFC_ECC_BLOCK_SIZE : 0) |
+                      NFC_ECC_EN | NFC_ECC_EXCEPTION,
+                      SUNXI_NFC_BASE + NFC_ECC_CTL);
+
+               /* Move the data in SRAM */
+               nand_change_column(data_off);
+               writel(conf->ecc_size, SUNXI_NFC_BASE + NFC_CNT);
+               nand_exec_cmd(NFC_DATA_TRANS);
+
+               /*
+                * Let the ECC engine consume the ECC bytes and possibly correct
+                * the data.
+                */
+               nand_change_column(oob_off);
+               nand_exec_cmd(NFC_DATA_TRANS | NFC_ECC_CMD);
+
+               /* Get the ECC status */
+               ecc_st = readl(SUNXI_NFC_BASE + NFC_ECC_ST);
+
+               /* ECC error detected. */
+               if (ecc_st & 0xffff)
+                       return -EIO;
+
+               /*
+                * Return 1 if the first chunk is empty (needed for
+                * configuration detection).
+                */
+               if (!i && (ecc_st & 0x10000))
+                       return 1;
+
+               /* Retrieve the data from SRAM */
+               memcpy_fromio(data, SUNXI_NFC_BASE + NFC_RAM0_BASE,
+                             conf->ecc_size);
+
+               /* Stop the ECC engine */
+               writel(readl(SUNXI_NFC_BASE + NFC_ECC_CTL) & ~NFC_ECC_EN,
+                      SUNXI_NFC_BASE + NFC_ECC_CTL);
+
+               if (data_off + conf->ecc_size >= len)
+                       break;
+       }
+
+       return 0;
+}
+
+static int nand_max_ecc_strength(struct nfc_config *conf)
+{
+       int max_oobsize, max_ecc_bytes;
+       int nsectors = conf->page_size / conf->ecc_size;
+       int i;
+
+       /*
+        * ECC strength is limited by the size of the OOB area which is
+        * correlated with the page size.
+        */
+       switch (conf->page_size) {
+       case 2048:
+               max_oobsize = 64;
                break;
-       case 56:
-               ecc_mode = 4;
-               ecc_off = 0x60;
+       case 4096:
+               max_oobsize = 256;
                break;
-       case 60:
-               ecc_mode = 4;
-               ecc_off = 0x0;
+       case 8192:
+               max_oobsize = 640;
                break;
-       case 64:
-               ecc_mode = 4;
-               ecc_off = 0x0;
+       case 16384:
+               max_oobsize = 1664;
                break;
        default:
-               ecc_mode = 0;
-               ecc_off = 0;
-       }
-
-       if (ecc_off == 0) {
-               printf("Unsupported ECC strength (%d)!\n",
-                      CONFIG_NAND_SUNXI_SPL_ECC_STRENGTH);
-               return;
+               return -EINVAL;
        }
 
-       /* clear temp_buf */
-       memset(temp_buf, 0, CONFIG_NAND_SUNXI_SPL_ECC_PAGE_SIZE);
-
-       /* set CMD  */
-       writel(NFC_SEND_CMD1 | NFC_WAIT_FLAG | NAND_CMD_RESET,
-              SUNXI_NFC_BASE + NFC_CMD);
+       max_ecc_bytes = max_oobsize / nsectors;
 
-       if (!check_value(SUNXI_NFC_BASE + NFC_ST, NFC_CMD_INT_FLAG,
-                        MAX_RETRIES)) {
-               printf("Error while initilizing command interrupt\n");
-               return;
+       for (i = 0; i < ARRAY_SIZE(ecc_bytes); i++) {
+               if (ecc_bytes[i] > max_ecc_bytes)
+                       break;
        }
 
-       page = real_addr / CONFIG_NAND_SUNXI_SPL_PAGE_SIZE;
-       column = real_addr % CONFIG_NAND_SUNXI_SPL_PAGE_SIZE;
-
-       if (syndrome)
-               column += (column / CONFIG_NAND_SUNXI_SPL_ECC_PAGE_SIZE)
-                       * ecc_off;
+       if (!i)
+               return -EINVAL;
 
-       /* clear ecc status */
-       writel(0, SUNXI_NFC_BASE + NFC_ECC_ST);
+       return i - 1;
+}
 
-       /* Choose correct seed */
-       if (syndrome)
-               rand_seed = random_seed_syndrome;
-       else
-               rand_seed = random_seed[page % 128];
+static int nand_detect_ecc_config(struct nfc_config *conf, u32 offs,
+                                 void *dest)
+{
+       /* NAND with pages > 4k will likely require 1k sector size. */
+       int min_ecc_size = conf->page_size > 4096 ? 1024 : 512;
+       int page = offs / conf->page_size;
+       int ret;
+
+       /*
+        * In most cases, 1k sectors are preferred over 512b ones, start
+        * testing this config first.
+        */
+       for (conf->ecc_size = 1024; conf->ecc_size >= min_ecc_size;
+            conf->ecc_size >>= 1) {
+               int max_ecc_strength = nand_max_ecc_strength(conf);
+
+               nand_apply_config(conf);
+
+               /*
+                * We are starting from the maximum ECC strength because
+                * most of the time NAND vendors provide an OOB area that
+                * barely meets the ECC requirements.
+                */
+               for (conf->ecc_strength = max_ecc_strength;
+                    conf->ecc_strength >= 0;
+                    conf->ecc_strength--) {
+                       conf->randomize = false;
+                       if (nand_change_column(0))
+                               return -EIO;
+
+                       /*
+                        * Only read the first sector to speedup detection.
+                        */
+                       ret = nand_read_page(conf, offs, dest, conf->ecc_size);
+                       if (!ret) {
+                               return 0;
+                       } else if (ret > 0) {
+                               /*
+                                * If page is empty we can't deduce anything
+                                * about the ECC config => stop the detection.
+                                */
+                               return -EINVAL;
+                       }
+
+                       conf->randomize = true;
+                       conf->nseeds = ARRAY_SIZE(random_seed);
+                       do {
+                               if (nand_change_column(0))
+                                       return -EIO;
+
+                               if (!nand_read_page(conf, offs, dest,
+                                                   conf->ecc_size))
+                                       return 0;
+
+                               /*
+                                * Find the next ->nseeds value that would
+                                * change the randomizer seed for the page
+                                * we're trying to read.
+                                */
+                               while (conf->nseeds >= 16) {
+                                       int seed = page % conf->nseeds;
+
+                                       conf->nseeds >>= 1;
+                                       if (seed != page % conf->nseeds)
+                                               break;
+                               }
+                       } while (conf->nseeds >= 16);
+               }
+       }
 
-       writel((rand_seed << 16) | NFC_ECC_RANDOM_EN | NFC_ECC_EN
-               | NFC_ECC_PIPELINE | (ecc_mode << 12),
-               SUNXI_NFC_BASE + NFC_ECC_CTL);
+       return -EINVAL;
+}
 
-       val = readl(SUNXI_NFC_BASE + NFC_CTL);
-       writel(val | NFC_CTL_RAM_METHOD, SUNXI_NFC_BASE + NFC_CTL);
-
-       if (syndrome) {
-               writel(CONFIG_NAND_SUNXI_SPL_ECC_PAGE_SIZE,
-                      SUNXI_NFC_BASE + NFC_SPARE_AREA);
-       } else {
-               oob_offset = CONFIG_NAND_SUNXI_SPL_PAGE_SIZE
-                       + (column / CONFIG_NAND_SUNXI_SPL_ECC_PAGE_SIZE)
-                       * ecc_off;
-               writel(oob_offset, SUNXI_NFC_BASE + NFC_SPARE_AREA);
+static int nand_detect_config(struct nfc_config *conf, u32 offs, void *dest)
+{
+       if (conf->valid)
+               return 0;
+
+       /*
+        * Modern NANDs are more likely than legacy ones, so we start testing
+        * with 5 address cycles.
+        */
+       for (conf->addr_cycles = 5;
+            conf->addr_cycles >= 4;
+            conf->addr_cycles--) {
+               int max_page_size = conf->addr_cycles == 4 ? 2048 : 16384;
+
+               /*
+                * Ignoring 1k pages cause I'm not even sure this case exist
+                * in the real world.
+                */
+               for (conf->page_size = 2048; conf->page_size <= max_page_size;
+                    conf->page_size <<= 1) {
+                       if (nand_load_page(conf, offs))
+                               return -1;
+
+                       if (!nand_detect_ecc_config(conf, offs, dest)) {
+                               conf->valid = true;
+                               return 0;
+                       }
+               }
        }
 
-       /* SUNXI_DMA */
-       writel(0x0, SUNXI_DMA_BASE + SUNXI_DMA_CFG_REG0); /* clr dma cmd */
-       /* read from REG_IO_DATA */
-       writel(SUNXI_NFC_BASE + NFC_IO_DATA,
-              SUNXI_DMA_BASE + SUNXI_DMA_SRC_START_ADDR_REG0);
-       /* read to RAM */
-       writel((uint32_t)temp_buf,
-              SUNXI_DMA_BASE + SUNXI_DMA_DEST_START_ADDRR_REG0);
-       writel(SUNXI_DMA_DDMA_PARA_REG_SRC_WAIT_CYC
-                       | SUNXI_DMA_DDMA_PARA_REG_SRC_BLK_SIZE,
-                       SUNXI_DMA_BASE + SUNXI_DMA_DDMA_PARA_REG0);
-       writel(CONFIG_NAND_SUNXI_SPL_ECC_PAGE_SIZE,
-              SUNXI_DMA_BASE + SUNXI_DMA_DDMA_BC_REG0); /* 1kB */
-       writel(SUNXI_DMA_DDMA_CFG_REG_LOADING
-               | SUNXI_DMA_DDMA_CFG_REG_DMA_DEST_DATA_WIDTH_32
-               | SUNXI_DMA_DDMA_CFG_REG_DMA_SRC_DATA_WIDTH_32
-               | SUNXI_DMA_DDMA_CFG_REG_DMA_SRC_ADDR_MODE_IO
-               | SUNXI_DMA_DDMA_CFG_REG_DDMA_SRC_DRQ_TYPE_NFC,
-               SUNXI_DMA_BASE + SUNXI_DMA_CFG_REG0);
-
-       writel((NFC_CMD_RNDOUTSTART << NFC_RANDOM_READ_CMD1_OFFSET)
-               | (NFC_CMD_RNDOUT << NFC_RANDOM_READ_CMD0_OFFSET)
-               | (NFC_CMD_READSTART | NFC_READ_CMD_OFFSET), SUNXI_NFC_BASE
-                       + NFC_RCMD_SET);
-       writel(1, SUNXI_NFC_BASE + NFC_SECTOR_NUM);
-       writel(((page & 0xFFFF) << 16) | column,
-              SUNXI_NFC_BASE + NFC_ADDR_LOW);
-       writel((page >> 16) & 0xFF, SUNXI_NFC_BASE + NFC_ADDR_HIGH);
-       writel(NFC_SEND_CMD1 | NFC_SEND_CMD2 | NFC_DATA_TRANS |
-               NFC_PAGE_CMD | NFC_WAIT_FLAG | (4 << NFC_ADDR_NUM_OFFSET) |
-               NFC_SEND_ADR | NFC_DATA_SWAP_METHOD | (syndrome ? NFC_SEQ : 0),
-               SUNXI_NFC_BASE + NFC_CMD);
-
-       if (!check_value(SUNXI_NFC_BASE + NFC_ST, (1 << 2),
-                        MAX_RETRIES)) {
-               printf("Error while initializing dma interrupt\n");
-               return;
-       }
+       return -EINVAL;
+}
 
-       if (!check_value_negated(SUNXI_DMA_BASE + SUNXI_DMA_CFG_REG0,
-                                SUNXI_DMA_DDMA_CFG_REG_LOADING, MAX_RETRIES)) {
-               printf("Error while waiting for dma transfer to finish\n");
-               return;
+static int nand_read_buffer(struct nfc_config *conf, uint32_t offs,
+                           unsigned int size, void *dest)
+{
+       int first_seed = 0, page, ret;
+
+       size = ALIGN(size, conf->page_size);
+       page = offs / conf->page_size;
+       if (conf->randomize)
+               first_seed = page % conf->nseeds;
+
+       for (; size; size -= conf->page_size) {
+               if (nand_load_page(conf, offs))
+                       return -1;
+
+               ret = nand_read_page(conf, offs, dest, conf->page_size);
+               /*
+                * The ->nseeds value should be equal to the number of pages
+                * in an eraseblock. Since we don't know this information in
+                * advance we might have picked a wrong value.
+                */
+               if (ret < 0 && conf->randomize) {
+                       int cur_seed = page % conf->nseeds;
+
+                       /*
+                        * We already tried all the seed values => we are
+                        * facing a real corruption.
+                        */
+                       if (cur_seed < first_seed)
+                               return -EIO;
+
+                       /* Try to adjust ->nseeds and read the page again... */
+                       conf->nseeds = cur_seed;
+
+                       if (nand_change_column(0))
+                               return -EIO;
+
+                       /* ... it still fails => it's a real corruption. */
+                       if (nand_read_page(conf, offs, dest, conf->page_size))
+                               return -EIO;
+               } else if (ret && conf->randomize) {
+                       memset(dest, 0xff, conf->page_size);
+               }
+
+               page++;
+               offs += conf->page_size;
+               dest += conf->page_size;
        }
 
-       if (readl(SUNXI_NFC_BASE + NFC_ECC_ST))
-               (*ecc_errors)++;
+       return 0;
 }
 
 int nand_spl_load_image(uint32_t offs, unsigned int size, void *dest)
 {
-       void *current_dest;
-       uint32_t count;
-       uint32_t current_count;
-       uint32_t ecc_errors = 0;
-
-       memset(dest, 0x0, size); /* clean destination memory */
-       for (current_dest = dest;
-                       current_dest < (dest + size);
-                       current_dest += CONFIG_NAND_SUNXI_SPL_ECC_PAGE_SIZE) {
-               nand_read_page(offs, offs
-                               < CONFIG_NAND_SUNXI_SPL_SYNDROME_PARTITIONS_END,
-                              &ecc_errors);
-               count = current_dest - dest;
-
-               if (size - count > CONFIG_NAND_SUNXI_SPL_ECC_PAGE_SIZE)
-                       current_count = CONFIG_NAND_SUNXI_SPL_ECC_PAGE_SIZE;
-               else
-                       current_count = size - count;
-
-               memcpy(current_dest,
-                      temp_buf,
-                      current_count);
-               offs += CONFIG_NAND_SUNXI_SPL_ECC_PAGE_SIZE;
-       }
-       return ecc_errors ? -1 : 0;
+       static struct nfc_config conf = { };
+       int ret;
+
+       ret = nand_detect_config(&conf, offs, dest);
+       if (ret)
+               return ret;
+
+       return nand_read_buffer(&conf, offs, size, dest);
 }
 
-void nand_deselect(void) {}
+void nand_deselect(void)
+{
+       struct sunxi_ccm_reg *const ccm =
+               (struct sunxi_ccm_reg *)SUNXI_CCM_BASE;
+
+       clrbits_le32(&ccm->ahb_gate0, (CLK_GATE_OPEN << AHB_GATE_OFFSET_NAND0));
+#ifdef CONFIG_MACH_SUN9I
+       clrbits_le32(&ccm->ahb_gate1, (1 << AHB_GATE_OFFSET_DMA));
+#else
+       clrbits_le32(&ccm->ahb_gate0, (1 << AHB_GATE_OFFSET_DMA));
+#endif
+       clrbits_le32(&ccm->nand0_clk_cfg, CCM_NAND_CTRL_ENABLE | AHB_DIV_1);
+}