]> git.sur5r.net Git - u-boot/blobdiff - drivers/net/ldpaa_eth/ldpaa_eth.c
driver/ldpaa_eth: Add timeout handling DQRR entry read
[u-boot] / drivers / net / ldpaa_eth / ldpaa_eth.c
index 3bb9e5ecef15b897e4cd2e5a46c5ad6a1332c908..cc949f593ae4a4f8984f18379a9f2c863d9f22d9 100644 (file)
@@ -15,6 +15,7 @@
 
 #include "ldpaa_eth.h"
 
+#undef CONFIG_PHYLIB
 static int init_phy(struct eth_device *dev)
 {
        /*TODO for external PHY */
@@ -33,8 +34,6 @@ static void ldpaa_eth_rx(struct ldpaa_eth_priv *priv,
        struct qbman_release_desc releasedesc;
        struct qbman_swp *swp = dflt_dpio->sw_portal;
 
-       invalidate_dcache_all();
-
        fd_addr = ldpaa_fd_get_addr(fd);
        fd_offset = ldpaa_fd_get_offset(fd);
        fd_length = ldpaa_fd_get_len(fd);
@@ -63,6 +62,7 @@ static void ldpaa_eth_rx(struct ldpaa_eth_priv *priv,
                                    fd_length);
 
 error:
+       flush_dcache_range(fd_addr, fd_addr + LDPAA_ETH_RX_BUFFER_SIZE);
        qbman_release_desc_clear(&releasedesc);
        qbman_release_desc_set_bpid(&releasedesc, dflt_dpbp->dpbp_attr.bpid);
        do {
@@ -78,21 +78,28 @@ static int ldpaa_eth_pull_dequeue_rx(struct eth_device *dev)
        const struct ldpaa_dq *dq;
        const struct dpaa_fd *fd;
        int i = 5, err = 0, status;
+       u32 timeo = (CONFIG_SYS_HZ * 2) / 1000;
+       u32 time_start;
        static struct qbman_pull_desc pulldesc;
        struct qbman_swp *swp = dflt_dpio->sw_portal;
 
-       qbman_pull_desc_clear(&pulldesc);
-       qbman_pull_desc_set_numframes(&pulldesc, 1);
-       qbman_pull_desc_set_fq(&pulldesc, priv->rx_dflt_fqid);
-
        while (--i) {
+               qbman_pull_desc_clear(&pulldesc);
+               qbman_pull_desc_set_numframes(&pulldesc, 1);
+               qbman_pull_desc_set_fq(&pulldesc, priv->rx_dflt_fqid);
+
                err = qbman_swp_pull(swp, &pulldesc);
                if (err < 0) {
                        printf("Dequeue frames error:0x%08x\n", err);
                        continue;
                }
 
-               dq = qbman_swp_dqrr_next(swp);
+               time_start = get_timer(0);
+
+                do {
+                       dq = qbman_swp_dqrr_next(swp);
+               } while (get_timer(time_start) < timeo && !dq);
+
                if (dq) {
                        /* Check for valid frame. If not sent a consume
                         * confirmation to QBMAN otherwise give it to NADK
@@ -114,6 +121,10 @@ static int ldpaa_eth_pull_dequeue_rx(struct eth_device *dev)
                        ldpaa_eth_rx(priv, fd);
                        qbman_swp_dqrr_consume(swp, dq);
                        break;
+               } else {
+                       err = -ENODATA;
+                       debug("No DQRR entries\n");
+                       break;
                }
        }
 
@@ -129,7 +140,6 @@ static void ldpaa_eth_tx_conf(struct ldpaa_eth_priv *priv,
        struct qbman_release_desc releasedesc;
        struct qbman_swp *swp = dflt_dpio->sw_portal;
 
-       invalidate_dcache_all();
        fd_addr = ldpaa_fd_get_addr(fd);
 
 
@@ -147,6 +157,7 @@ static void ldpaa_eth_tx_conf(struct ldpaa_eth_priv *priv,
                }
        }
 
+       flush_dcache_range(fd_addr, fd_addr + LDPAA_ETH_RX_BUFFER_SIZE);
        qbman_release_desc_clear(&releasedesc);
        qbman_release_desc_set_bpid(&releasedesc, dflt_dpbp->dpbp_attr.bpid);
        do {
@@ -161,21 +172,28 @@ static int ldpaa_eth_pull_dequeue_tx_conf(struct ldpaa_eth_priv *priv)
        const struct dpaa_fd *fd;
        int err = 0;
        int i = 5, status;
+       u32 timeo = (CONFIG_SYS_HZ * 10) / 1000;
+       u32 time_start;
        static struct qbman_pull_desc pulldesc;
        struct qbman_swp *swp = dflt_dpio->sw_portal;
 
-       qbman_pull_desc_clear(&pulldesc);
-       qbman_pull_desc_set_numframes(&pulldesc, 1);
-       qbman_pull_desc_set_fq(&pulldesc, priv->tx_conf_fqid);
-
        while (--i) {
+               qbman_pull_desc_clear(&pulldesc);
+               qbman_pull_desc_set_numframes(&pulldesc, 1);
+               qbman_pull_desc_set_fq(&pulldesc, priv->tx_conf_fqid);
+
                err =  qbman_swp_pull(swp, &pulldesc);
                if (err < 0) {
                        printf("Dequeue TX conf frames error:0x%08x\n", err);
                        continue;
                }
 
-               dq = qbman_swp_dqrr_next(swp);
+               time_start = get_timer(0);
+
+                do {
+                       dq = qbman_swp_dqrr_next(swp);
+               } while (get_timer(time_start) < timeo && !dq);
+
                if (dq) {
                        /* Check for valid frame. If not sent a consume
                         * confirmation to QBMAN otherwise give it to NADK
@@ -195,6 +213,10 @@ static int ldpaa_eth_pull_dequeue_tx_conf(struct ldpaa_eth_priv *priv)
                        ldpaa_eth_tx_conf(priv, fd);
                        qbman_swp_dqrr_consume(swp, dq);
                        break;
+               } else {
+                       err = -ENODATA;
+                       debug("No DQRR entries\n");
+                       break;
                }
        }
 
@@ -207,8 +229,11 @@ static int ldpaa_eth_tx(struct eth_device *net_dev, void *buf, int len)
        struct dpaa_fd fd;
        u64 buffer_start;
        int data_offset, err;
+       u32 timeo = (CONFIG_SYS_HZ * 10) / 1000;
+       u32 time_start;
        struct qbman_swp *swp = dflt_dpio->sw_portal;
        struct qbman_eq_desc ed;
+       struct qbman_release_desc releasedesc;
 
        /* Setup the FD fields */
        memset(&fd, 0, sizeof(fd));
@@ -230,7 +255,8 @@ static int ldpaa_eth_tx(struct eth_device *net_dev, void *buf, int len)
 
        memcpy(((uint8_t *)(buffer_start) + data_offset), buf, len);
 
-       flush_dcache_range(buffer_start, LDPAA_ETH_RX_BUFFER_SIZE);
+       flush_dcache_range(buffer_start, buffer_start +
+                                       LDPAA_ETH_RX_BUFFER_SIZE);
 
        ldpaa_fd_set_addr(&fd, (u64)buffer_start);
        ldpaa_fd_set_offset(&fd, (uint16_t)(data_offset));
@@ -243,9 +269,20 @@ static int ldpaa_eth_tx(struct eth_device *net_dev, void *buf, int len)
        qbman_eq_desc_clear(&ed);
        qbman_eq_desc_set_no_orp(&ed, 0);
        qbman_eq_desc_set_qd(&ed, priv->tx_qdid, priv->tx_flow_id, 0);
-       err = qbman_swp_enqueue(swp, &ed, (const struct qbman_fd *)(&fd));
-       if (err < 0)
+
+       time_start = get_timer(0);
+
+       while (get_timer(time_start) < timeo) {
+               err = qbman_swp_enqueue(swp, &ed,
+                               (const struct qbman_fd *)(&fd));
+               if (err != -EBUSY)
+                       break;
+       }
+
+       if (err < 0) {
                printf("error enqueueing Tx frame\n");
+               goto error;
+       }
 
        mdelay(1);
 
@@ -254,6 +291,20 @@ static int ldpaa_eth_tx(struct eth_device *net_dev, void *buf, int len)
                printf("error Tx Conf frame\n");
 
        return err;
+
+error:
+       qbman_release_desc_clear(&releasedesc);
+       qbman_release_desc_set_bpid(&releasedesc, dflt_dpbp->dpbp_attr.bpid);
+       time_start = get_timer(0);
+       do {
+               /* Release buffer into the QBMAN */
+               err = qbman_swp_release(swp, &releasedesc, &buffer_start, 1);
+       } while (get_timer(time_start) < timeo && err == -EBUSY);
+
+       if (err == -EBUSY)
+               printf("TX data: QBMAN buffer release fails\n");
+
+       return err;
 }
 
 static int ldpaa_eth_open(struct eth_device *net_dev, bd_t *bd)
@@ -298,10 +349,10 @@ static int ldpaa_eth_open(struct eth_device *net_dev, bd_t *bd)
 
 #ifdef CONFIG_PHYLIB
        /* TODO Check this path */
-       ret = phy_startup(priv->phydev);
-       if (ret) {
+       err = phy_startup(priv->phydev);
+       if (err) {
                printf("%s: Could not initialize\n", priv->phydev->dev->name);
-               return ret;
+               return err;
        }
 #else
        priv->phydev->speed = SPEED_1000;
@@ -362,7 +413,8 @@ static void ldpaa_eth_stop(struct eth_device *net_dev)
        struct ldpaa_eth_priv *priv = (struct ldpaa_eth_priv *)net_dev->priv;
        int err = 0;
 
-       if (net_dev->state == ETH_STATE_PASSIVE)
+       if ((net_dev->state == ETH_STATE_PASSIVE) ||
+           (net_dev->state == ETH_STATE_INIT))
                return;
        /* Stop Tx and Rx traffic */
        err = dpni_disable(dflt_mc_io, priv->dpni_handle);
@@ -423,6 +475,8 @@ static int ldpaa_bp_add_7(uint16_t bpid)
                        goto err_alloc;
                }
                memset(addr, 0x00, LDPAA_ETH_RX_BUFFER_SIZE);
+               flush_dcache_range((u64)addr,
+                                  (u64)(addr + LDPAA_ETH_RX_BUFFER_SIZE));
 
                buf_array[i] = (uint64_t)addr;
                debug("Release: buffer addr =0x%p\n", addr);
@@ -624,10 +678,7 @@ static int ldpaa_eth_netdev_init(struct eth_device *net_dev)
        int err;
        struct ldpaa_eth_priv *priv = (struct ldpaa_eth_priv *)net_dev->priv;
 
-       if (priv->type == LDPAA_ETH_1G_E)
-               sprintf(net_dev->name, "DTSEC%d", priv->dpni_id);
-       else
-               sprintf(net_dev->name, "TGEC%d", priv->dpni_id);
+       sprintf(net_dev->name, "DPNI%d", priv->dpni_id);
 
        net_dev->iobase = 0;
        net_dev->init = ldpaa_eth_open;