]> git.sur5r.net Git - u-boot/blobdiff - drivers/usb/host/dwc2.c
usb: dwc2: usb chunk_msg() for control transfers too
[u-boot] / drivers / usb / host / dwc2.c
index 2a5bbf5ac0e9be839f19a7cb7149927e0e9a1f30..189f6548f25ff2141d844fde289f169dc7a9fbed 100644 (file)
@@ -503,23 +503,23 @@ static int dwc_otg_submit_rh_msg_in_descriptor(struct usb_device *dev,
        case 0:
                switch (wValue & 0xff00) {
                case 0x0100:    /* device descriptor */
-                       len = min3(txlen, sizeof(root_hub_dev_des), wLength);
+                       len = min3(txlen, (int)sizeof(root_hub_dev_des), (int)wLength);
                        memcpy(buffer, root_hub_dev_des, len);
                        break;
                case 0x0200:    /* configuration descriptor */
-                       len = min3(txlen, sizeof(root_hub_config_des), wLength);
+                       len = min3(txlen, (int)sizeof(root_hub_config_des), (int)wLength);
                        memcpy(buffer, root_hub_config_des, len);
                        break;
                case 0x0300:    /* string descriptors */
                        switch (wValue & 0xff) {
                        case 0x00:
-                               len = min3(txlen, sizeof(root_hub_str_index0),
-                                          wLength);
+                               len = min3(txlen, (int)sizeof(root_hub_str_index0),
+                                          (int)wLength);
                                memcpy(buffer, root_hub_str_index0, len);
                                break;
                        case 0x01:
-                               len = min3(txlen, sizeof(root_hub_str_index1),
-                                          wLength);
+                               len = min3(txlen, (int)sizeof(root_hub_str_index1),
+                                          (int)wLength);
                                memcpy(buffer, root_hub_str_index1, len);
                                break;
                        }
@@ -556,7 +556,7 @@ static int dwc_otg_submit_rh_msg_in_descriptor(struct usb_device *dev,
                        data[10] = data[9];
                }
 
-               len = min3(txlen, data[0], wLength);
+               len = min3(txlen, (int)data[0], (int)wLength);
                memcpy(buffer, data, len);
                break;
        default:
@@ -704,26 +704,60 @@ static int dwc_otg_submit_rh_msg(struct usb_device *dev, unsigned long pipe,
        return stat;
 }
 
-/* U-Boot USB transmission interface */
-int submit_bulk_msg(struct usb_device *dev, unsigned long pipe, void *buffer,
-                   int len)
+int wait_for_chhltd(uint32_t *sub, int *toggle)
+{
+       const uint32_t hcint_comp_hlt_ack = DWC2_HCINT_XFERCOMP |
+               DWC2_HCINT_CHHLTD | DWC2_HCINT_ACK;
+       struct dwc2_hc_regs *hc_regs = &regs->hc_regs[DWC2_HC_CHANNEL];
+       int ret;
+       uint32_t hcint, hctsiz;
+
+       ret = wait_for_bit(&hc_regs->hcint, DWC2_HCINT_CHHLTD, true);
+       if (ret)
+               return ret;
+
+       hcint = readl(&hc_regs->hcint);
+       if (hcint != hcint_comp_hlt_ack) {
+               debug("%s: Error (HCINT=%08x)\n", __func__, hcint);
+               return -EINVAL;
+       }
+
+       hctsiz = readl(&hc_regs->hctsiz);
+       *sub = (hctsiz & DWC2_HCTSIZ_XFERSIZE_MASK) >>
+               DWC2_HCTSIZ_XFERSIZE_OFFSET;
+       if (toggle)
+               *toggle = (hctsiz & DWC2_HCTSIZ_PID_MASK) >>
+                       DWC2_HCTSIZ_PID_OFFSET;
+
+       debug("%s: sub=%u toggle=%d\n", __func__, *sub, toggle ? *toggle : -1);
+
+       return 0;
+}
+
+static int dwc2_eptype[] = {
+       DWC2_HCCHAR_EPTYPE_ISOC,
+       DWC2_HCCHAR_EPTYPE_INTR,
+       DWC2_HCCHAR_EPTYPE_CONTROL,
+       DWC2_HCCHAR_EPTYPE_BULK,
+};
+
+int chunk_msg(struct usb_device *dev, unsigned long pipe, int *pid, int in,
+             void *buffer, int len)
 {
+       struct dwc2_hc_regs *hc_regs = &regs->hc_regs[DWC2_HC_CHANNEL];
        int devnum = usb_pipedevice(pipe);
        int ep = usb_pipeendpoint(pipe);
        int max = usb_maxpacket(dev, pipe);
+       int eptype = dwc2_eptype[usb_pipetype(pipe)];
        int done = 0;
-       uint32_t hctsiz, sub, tmp;
-       struct dwc2_hc_regs *hc_regs = &regs->hc_regs[DWC2_HC_CHANNEL];
-       uint32_t hcint;
+       int ret;
+       uint32_t sub;
        uint32_t xfer_len;
        uint32_t num_packets;
        int stop_transfer = 0;
-       unsigned int timeout = 1000000;
 
-       if (devnum == root_hub_devnum) {
-               dev->status = 0;
-               return -EINVAL;
-       }
+       debug("%s: msg: pipe %lx pid %d in %d len %d\n", __func__, pipe, *pid,
+             in, len);
 
        if (len > DWC2_DATA_BUF_SIZE) {
                printf("%s: %d is more then available buffer size (%d)\n",
@@ -733,10 +767,10 @@ int submit_bulk_msg(struct usb_device *dev, unsigned long pipe, void *buffer,
                return -EINVAL;
        }
 
-       while ((done < len) && !stop_transfer) {
+       do {
                /* Initialize channel */
-               dwc_otg_hc_init(regs, DWC2_HC_CHANNEL, devnum, ep,
-                               usb_pipein(pipe), DWC2_HCCHAR_EPTYPE_BULK, max);
+               dwc_otg_hc_init(regs, DWC2_HC_CHANNEL, devnum, ep, in, eptype,
+                               max);
 
                xfer_len = len - done;
                /* Make sure that xfer_len is a multiple of max packet size. */
@@ -753,13 +787,15 @@ int submit_bulk_msg(struct usb_device *dev, unsigned long pipe, void *buffer,
                        num_packets = 1;
                }
 
-               if (usb_pipein(pipe))
+               if (in)
                        xfer_len = num_packets * max;
 
+               debug("%s: chunk: pid %d xfer_len %u pkts %u\n", __func__,
+                     *pid, xfer_len, num_packets);
+
                writel((xfer_len << DWC2_HCTSIZ_XFERSIZE_OFFSET) |
                       (num_packets << DWC2_HCTSIZ_PKTCNT_OFFSET) |
-                      (bulk_data_toggle[devnum][ep] <<
-                               DWC2_HCTSIZ_PID_OFFSET),
+                      (*pid << DWC2_HCTSIZ_PID_OFFSET),
                       &hc_regs->hctsiz);
 
                memcpy(aligned_buffer, (char *)buffer + done, len - done);
@@ -771,54 +807,21 @@ int submit_bulk_msg(struct usb_device *dev, unsigned long pipe, void *buffer,
                                (1 << DWC2_HCCHAR_MULTICNT_OFFSET) |
                                DWC2_HCCHAR_CHEN);
 
-               while (1) {
-                       hcint = readl(&hc_regs->hcint);
-
-                       if (!(hcint & DWC2_HCINT_CHHLTD))
-                               continue;
-
-                       if (hcint & DWC2_HCINT_XFERCOMP) {
-                               hctsiz = readl(&hc_regs->hctsiz);
-                               done += xfer_len;
-
-                               sub = hctsiz & DWC2_HCTSIZ_XFERSIZE_MASK;
-                               sub >>= DWC2_HCTSIZ_XFERSIZE_OFFSET;
-
-                               if (usb_pipein(pipe)) {
-                                       done -= sub;
-                                       if (hctsiz & DWC2_HCTSIZ_XFERSIZE_MASK)
-                                               stop_transfer = 1;
-                               }
-
-                               tmp = hctsiz & DWC2_HCTSIZ_PID_MASK;
-                               tmp >>= DWC2_HCTSIZ_PID_OFFSET;
-                               if (tmp == DWC2_HC_PID_DATA1) {
-                                       bulk_data_toggle[devnum][ep] =
-                                               DWC2_HC_PID_DATA1;
-                               } else {
-                                       bulk_data_toggle[devnum][ep] =
-                                               DWC2_HC_PID_DATA0;
-                               }
-                               break;
-                       }
-
-                       if (hcint & DWC2_HCINT_STALL) {
-                               puts("DWC OTG: Channel halted\n");
-                               bulk_data_toggle[devnum][ep] =
-                                       DWC2_HC_PID_DATA0;
+               ret = wait_for_chhltd(&sub, pid);
+               if (ret) {
+                       stop_transfer = 1;
+                       break;
+               }
 
+               done += xfer_len;
+               if (in) {
+                       done -= sub;
+                       if (sub)
                                stop_transfer = 1;
-                               break;
-                       }
-
-                       if (!--timeout) {
-                               printf("%s: Timeout!\n", __func__);
-                               break;
-                       }
                }
-       }
+       } while ((done < len) && !stop_transfer);
 
-       if (done && usb_pipein(pipe))
+       if (done && in)
                memcpy(buffer, aligned_buffer, done);
 
        writel(0, &hc_regs->hcintmsk);
@@ -830,20 +833,28 @@ int submit_bulk_msg(struct usb_device *dev, unsigned long pipe, void *buffer,
        return 0;
 }
 
+/* U-Boot USB transmission interface */
+int submit_bulk_msg(struct usb_device *dev, unsigned long pipe, void *buffer,
+                   int len)
+{
+       int devnum = usb_pipedevice(pipe);
+       int ep = usb_pipeendpoint(pipe);
+
+       if (devnum == root_hub_devnum) {
+               dev->status = 0;
+               return -EINVAL;
+       }
+
+       return chunk_msg(dev, pipe, &bulk_data_toggle[devnum][ep],
+                        usb_pipein(pipe), buffer, len);
+}
+
 int submit_control_msg(struct usb_device *dev, unsigned long pipe, void *buffer,
                       int len, struct devrequest *setup)
 {
-       struct dwc2_hc_regs *hc_regs = &regs->hc_regs[DWC2_HC_CHANNEL];
-       int done = 0;
        int devnum = usb_pipedevice(pipe);
        int ep = usb_pipeendpoint(pipe);
-       int max = usb_maxpacket(dev, pipe);
-       uint32_t hctsiz = 0, sub, tmp, ret;
-       uint32_t hcint;
-       const uint32_t hcint_comp_hlt_ack = DWC2_HCINT_XFERCOMP |
-               DWC2_HCINT_CHHLTD | DWC2_HCINT_ACK;
-       unsigned int timeout = 1000000;
-
+       int pid, ret, act_len;
        /* For CONTROL endpoint pid should start with DATA1 */
        int status_direction;
 
@@ -853,112 +864,21 @@ int submit_control_msg(struct usb_device *dev, unsigned long pipe, void *buffer,
                return dwc_otg_submit_rh_msg(dev, pipe, buffer, len, setup);
        }
 
-       if (len > DWC2_DATA_BUF_SIZE) {
-               printf("%s: %d is more then available buffer size(%d)\n",
-                      __func__, len, DWC2_DATA_BUF_SIZE);
-               dev->status = 0;
-               dev->act_len = 0;
-               return -EINVAL;
-       }
-
-       /* Initialize channel, OUT for setup buffer */
-       dwc_otg_hc_init(regs, DWC2_HC_CHANNEL, devnum, ep, 0,
-                       DWC2_HCCHAR_EPTYPE_CONTROL, max);
-
-       /* SETUP stage  */
-       writel((8 << DWC2_HCTSIZ_XFERSIZE_OFFSET) |
-              (1 << DWC2_HCTSIZ_PKTCNT_OFFSET) |
-              (DWC2_HC_PID_SETUP << DWC2_HCTSIZ_PID_OFFSET),
-              &hc_regs->hctsiz);
-
-       writel((uint32_t)setup, &hc_regs->hcdma);
-
-       /* Set host channel enable after all other setup is complete. */
-       clrsetbits_le32(&hc_regs->hcchar, DWC2_HCCHAR_MULTICNT_MASK |
-                       DWC2_HCCHAR_CHEN | DWC2_HCCHAR_CHDIS,
-                       (1 << DWC2_HCCHAR_MULTICNT_OFFSET) | DWC2_HCCHAR_CHEN);
-
-       ret = wait_for_bit(&hc_regs->hcint, DWC2_HCINT_CHHLTD, 1);
+       pid = DWC2_HC_PID_SETUP;
+       ret = chunk_msg(dev, pipe, &pid, 0, setup, 8);
        if (ret)
-               printf("%s: Timeout!\n", __func__);
-
-       hcint = readl(&hc_regs->hcint);
-
-       if (!(hcint & DWC2_HCINT_CHHLTD) || !(hcint & DWC2_HCINT_XFERCOMP)) {
-               printf("%s: Error (HCINT=%08x)\n", __func__, hcint);
-               dev->status = 0;
-               dev->act_len = 0;
-               return -EINVAL;
-       }
-
-       /* Clear interrupts */
-       writel(0, &hc_regs->hcintmsk);
-       writel(0xFFFFFFFF, &hc_regs->hcint);
+               return ret;
 
        if (buffer) {
-               /* DATA stage */
-               dwc_otg_hc_init(regs, DWC2_HC_CHANNEL, devnum, ep,
-                               usb_pipein(pipe),
-                               DWC2_HCCHAR_EPTYPE_CONTROL, max);
-
-               /* TODO: check if len < 64 */
                control_data_toggle[devnum][ep] = DWC2_HC_PID_DATA1;
-               writel((len << DWC2_HCTSIZ_XFERSIZE_OFFSET) |
-                      (1 << DWC2_HCTSIZ_PKTCNT_OFFSET) |
-                      (control_data_toggle[devnum][ep] <<
-                               DWC2_HCTSIZ_PID_OFFSET),
-                      &hc_regs->hctsiz);
-
-               writel((uint32_t)buffer, &hc_regs->hcdma);
-
-               /* Set host channel enable after all other setup is complete */
-               clrsetbits_le32(&hc_regs->hcchar, DWC2_HCCHAR_MULTICNT_MASK |
-                               DWC2_HCCHAR_CHEN | DWC2_HCCHAR_CHDIS,
-                               (1 << DWC2_HCCHAR_MULTICNT_OFFSET) |
-                               DWC2_HCCHAR_CHEN);
-
-               while (1) {
-                       hcint = readl(&hc_regs->hcint);
-                       if (!(hcint & DWC2_HCINT_CHHLTD))
-                               continue;
-
-                       if (hcint & DWC2_HCINT_XFERCOMP) {
-                               hctsiz = readl(&hc_regs->hctsiz);
-                               done = len;
-
-                               sub = hctsiz & DWC2_HCTSIZ_XFERSIZE_MASK;
-                               sub >>= DWC2_HCTSIZ_XFERSIZE_OFFSET;
-
-                               if (usb_pipein(pipe))
-                                       done -= sub;
-                       }
-
-                       if (hcint & DWC2_HCINT_ACK) {
-                               tmp = hctsiz & DWC2_HCTSIZ_PID_MASK;
-                               tmp >>= DWC2_HCTSIZ_PID_OFFSET;
-                               if (tmp == DWC2_HC_PID_DATA0) {
-                                       control_data_toggle[devnum][ep] =
-                                               DWC2_HC_PID_DATA0;
-                               } else {
-                                       control_data_toggle[devnum][ep] =
-                                               DWC2_HC_PID_DATA1;
-                               }
-                       }
-
-                       if (hcint != hcint_comp_hlt_ack) {
-                               printf("%s: Error (HCINT=%08x)\n",
-                                      __func__, hcint);
-                               goto out;
-                       }
-
-                       if (!--timeout) {
-                               printf("%s: Timeout!\n", __func__);
-                               goto out;
-                       }
-
-                       break;
-               }
+               ret = chunk_msg(dev, pipe, &control_data_toggle[devnum][ep],
+                               usb_pipein(pipe), buffer, len);
+               if (ret)
+                       return ret;
+               act_len = dev->act_len;
        } /* End of DATA stage */
+       else
+               act_len = 0;
 
        /* STATUS stage */
        if ((len == 0) || usb_pipeout(pipe))
@@ -966,34 +886,14 @@ int submit_control_msg(struct usb_device *dev, unsigned long pipe, void *buffer,
        else
                status_direction = 0;
 
-       dwc_otg_hc_init(regs, DWC2_HC_CHANNEL, devnum, ep,
-                       status_direction, DWC2_HCCHAR_EPTYPE_CONTROL, max);
-
-       writel((1 << DWC2_HCTSIZ_PKTCNT_OFFSET) |
-              (DWC2_HC_PID_DATA1 << DWC2_HCTSIZ_PID_OFFSET),
-              &hc_regs->hctsiz);
-
-       writel((uint32_t)status_buffer, &hc_regs->hcdma);
-
-       /* Set host channel enable after all other setup is complete. */
-       clrsetbits_le32(&hc_regs->hcchar, DWC2_HCCHAR_MULTICNT_MASK |
-                       DWC2_HCCHAR_CHEN | DWC2_HCCHAR_CHDIS,
-                       (1 << DWC2_HCCHAR_MULTICNT_OFFSET) | DWC2_HCCHAR_CHEN);
-
-       while (1) {
-               hcint = readl(&hc_regs->hcint);
-               if (hcint & DWC2_HCINT_CHHLTD)
-                       break;
-       }
+       pid = DWC2_HC_PID_DATA1;
+       ret = chunk_msg(dev, pipe, &pid, status_direction, status_buffer, 0);
+       if (ret)
+               return ret;
 
-       if (hcint != hcint_comp_hlt_ack)
-               printf("%s: Error (HCINT=%08x)\n", __func__, hcint);
+       dev->act_len = act_len;
 
-out:
-       dev->act_len = done;
-       dev->status = 0;
-
-       return done;
+       return 0;
 }
 
 int submit_int_msg(struct usb_device *dev, unsigned long pipe, void *buffer,