am335x-fb: cosmetic: fix coding style

[u-boot] / drivers / video / am335x-fb.c

diff --git a/drivers/video/am335x-fb.c b/drivers/video/am335x-fb.c
index 6f956499d75332c1185afda7683210a212c7530b..697b701ebcd3e897d78ddb61dbad560a42a560fe 100644 (file)
--- a/drivers/video/am335x-fb.c
+++ b/drivers/video/am335x-fb.c
@@ -1,11 +1,11 @@
 /*
- * Copyright (C) 2013 Hannes Petermaier <oe5hpm@oevsv.at>
- * Bernecker & Rainer Industrieelektronik GmbH - http://www.br-automation.com
+ * Copyright (C) 2013-2018 Hannes Schmelzer <oe5hpm@oevsv.at>
+ * B&R Industrial Automation GmbH - http://www.br-automation.com
  *
  * minimal framebuffer driver for TI's AM335x SoC to be compatible with
  * Wolfgang Denk's LCD-Framework (CONFIG_LCD, common/lcd.c)
  *
- * - supporting only 24bit RGB/TFT raster Mode (not using palette)
+ * - supporting 16/24/32bit RGB/TFT raster Mode (not using palette)
  * - sets up LCD controller as in 'am335x_lcdpanel' struct given
  * - starts output DMA from gd->fb_base buffer
  *
@@ -55,7 +55,7 @@
 /* LCD Raster Ctrl Register */
 #define LCD_TFT_24BPP_MODE                     (1 << 25)
 #define LCD_TFT_24BPP_UNPACK                   (1 << 26)
-#define LCD_PALMODE_RAWDATA                    (0x10 << 20)
+#define LCD_PALMODE_RAWDATA                    (0x02 << 20)
 #define LCD_TFT_MODE                           (0x01 << 7)
 #define LCD_RASTER_ENABLE                      (0x01 << 0)
 
@@ -106,15 +106,32 @@ int lcd_get_size(int *line_length)
 
 int am335xfb_init(struct am335x_lcdpanel *panel)
 {
-       if (0 == gd->fb_base) {
+       u32 raster_ctrl = 0;
+
+       if (gd->fb_base == 0) {
                printf("ERROR: no valid fb_base stored in GLOBAL_DATA_PTR!\n");
                return -1;
        }
-       if (0 == panel) {
+       if (panel == NULL) {
                printf("ERROR: missing ptr to am335x_lcdpanel!\n");
                return -1;
        }
 
+       /* We can already set the bits for the raster_ctrl in this check */
+       switch (panel->bpp) {
+       case 16:
+               break;
+       case 32:
+               raster_ctrl |= LCD_TFT_24BPP_UNPACK;
+               /* fallthrough */
+       case 24:
+               raster_ctrl |= LCD_TFT_24BPP_MODE;
+               break;
+       default:
+               pr_err("am335x-fb: invalid bpp value: %d\n", panel->bpp);
+               return -1;
+       }
+
        debug("setting up LCD-Controller for %dx%dx%d (hfp=%d,hbp=%d,hsw=%d / ",
              panel->hactive, panel->vactive, panel->bpp,
              panel->hfp, panel->hbp, panel->hsw);
@@ -126,9 +143,11 @@ int am335xfb_init(struct am335x_lcdpanel *panel)
        /* palette default entry */
        memset((void *)gd->fb_base, 0, 0x20);
        *(unsigned int *)gd->fb_base = 0x4000;
+       /* point fb behind palette */
+       gd->fb_base += 0x20;
 
        /* turn ON display through powercontrol function if accessible */
-       if (0 != panel->panel_power_ctrl)
+       if (panel->panel_power_ctrl != NULL)
                panel->panel_power_ctrl(1);
 
        debug("am335x-fb: wait for stable power ...\n");
@@ -137,9 +156,9 @@ int am335xfb_init(struct am335x_lcdpanel *panel)
        lcdhw->raster_ctrl = 0;
        lcdhw->ctrl = LCD_CLK_DIVISOR(panel->pxl_clk_div) | LCD_RASTER_MODE;
        lcdhw->lcddma_fb0_base = gd->fb_base;
-       lcdhw->lcddma_fb0_ceiling = gd->fb_base + FBSIZE(panel) + 0x20;
+       lcdhw->lcddma_fb0_ceiling = gd->fb_base + FBSIZE(panel);
        lcdhw->lcddma_fb1_base = gd->fb_base;
-       lcdhw->lcddma_fb1_ceiling = gd->fb_base + FBSIZE(panel) + 0x20;
+       lcdhw->lcddma_fb1_ceiling = gd->fb_base + FBSIZE(panel);
        lcdhw->lcddma_ctrl = LCD_DMA_BURST_SIZE(LCD_DMA_BURST_16);
 
        lcdhw->raster_timing0 = LCD_HORLSB(panel->hactive) |
@@ -157,14 +176,11 @@ int am335xfb_init(struct am335x_lcdpanel *panel)
                                LCD_HBPMSB(panel->hbp) |
                                LCD_HFPMSB(panel->hfp) |
                                0x0000FF00;     /* clk cycles for ac-bias */
-       lcdhw->raster_ctrl =    LCD_TFT_24BPP_MODE |
-                               LCD_TFT_24BPP_UNPACK |
+       lcdhw->raster_ctrl =    raster_ctrl |
                                LCD_PALMODE_RAWDATA |
                                LCD_TFT_MODE |
                                LCD_RASTER_ENABLE;
 
-       gd->fb_base += 0x20;    /* point fb behind palette */
-
        debug("am335x-fb: waiting picture to be stable.\n.");
        mdelay(panel->pon_delay);