-static int MemAccess (CodeSeg* S, unsigned From, unsigned To, const char* Arg)
-/* Checks a range of code entries if there are any memory accesses to Arg.
- * Note: This function is not 100% safe, because there is more than one way
- * to express a memory location ("foo" and "foo+0" comes to mind) and there
- * may be other accesses through pointers. For the code generated by cc65 and
- * for the purpose of the caller (OptPushPop) it is assumed to be safe enough
- * however.
- */
+static int MemAccess (CodeSeg* S, unsigned From, unsigned To, const CodeEntry* N)
+/* Checks a range of code entries if there are any memory accesses to N->Arg */
{
+ /* Get the length of the argument */
+ unsigned NLen = strlen (N->Arg);
+
+ /* What to check for? */
+ enum {
+ None = 0x00,
+ Base = 0x01, /* Check for location without "+1" */
+ Word = 0x02, /* Check for location with "+1" added */
+ } What = None;
+
+
+ /* If the argument of N is a zero page location that ends with "+1", we
+ * must also check for word accesses to the location without +1.
+ */
+ if (N->AM == AM65_ZP && NLen > 2 && strcmp (N->Arg + NLen - 2, "+1") == 0) {
+ What |= Base;
+ }
+
+ /* If the argument is zero page indirect, we must also check for accesses
+ * to "arg+1"
+ */
+ if (N->AM == AM65_ZP_INDY || N->AM == AM65_ZPX_IND || N->AM == AM65_ZP_IND) {
+ What |= Word;
+ }
+
/* Walk over all code entries */
while (From <= To) {
/* Get the next entry */
CodeEntry* E = CS_GetEntry (S, From);
- /* For simplicity, we just check if there is an argument and if this
- * argument equals Arg.
+ /* Check if there is an argument and if this argument equals Arg in
+ * some variants.
*/
- if (E->Arg && strcmp (E->Arg, Arg) == 0) {
- /* Found an access */
- return 1;
+ if (E->Arg[0] != '\0') {
+
+ unsigned ELen;
+
+ if (strcmp (E->Arg, N->Arg) == 0) {
+ /* Found an access */
+ return 1;
+ }
+
+ ELen = strlen (E->Arg);
+ if ((What & Base) != 0) {
+ if (ELen == NLen - 2 && strncmp (E->Arg, N->Arg, NLen-2) == 0) {
+ /* Found an access */
+ return 1;
+ }
+ }
+
+ if ((What & Word) != 0) {
+ if (ELen == NLen + 2 && strncmp (E->Arg, N->Arg, NLen) == 0 &&
+ E->Arg[NLen] == '+' && E->Arg[NLen+1] == '1') {
+ /* Found an access */
+ return 1;
+ }
+ }
}
/* Next entry */
unsigned OptRTSJumps2 (CodeSeg* S)
-/* Replace long conditional jumps to RTS */
+/* Replace long conditional jumps to RTS or to a final target */
{
unsigned Changes = 0;
/* Walk over all entries minus the last one */
unsigned I = 0;
- while (I < CS_GetEntryCount (S)) {
-
- CodeEntry* N;
+ while (I < CS_GetEntryCount (S) - 1) {
/* Get the next entry */
CodeEntry* E = CS_GetEntry (S, I);
- /* Check if it's an unconditional branch to a local target */
+ /* Check if it's an conditional branch to a local target */
if ((E->Info & OF_CBRA) != 0 && /* Conditional branch */
(E->Info & OF_LBRA) != 0 && /* Long branch */
- E->JumpTo != 0 && /* Local label */
- E->JumpTo->Owner->OPC == OP65_RTS && /* Target is an RTS */
- (N = CS_GetNextEntry (S, I)) != 0) { /* There is a next entry */
+ E->JumpTo != 0) { /* Local label */
- CodeEntry* X;
- CodeLabel* LN;
- opc_t NewBranch;
- /* We will create a jump around an RTS instead of the long branch */
- X = NewCodeEntry (OP65_RTS, AM65_IMP, 0, 0, E->JumpTo->Owner->LI);
- CS_InsertEntry (S, X, I+1);
+ /* Get the jump target and the next entry. There's always a next
+ * entry, because we don't cover the last entry in the loop.
+ */
+ CodeEntry* X = 0;
+ CodeEntry* T = E->JumpTo->Owner;
+ CodeEntry* N = CS_GetNextEntry (S, I);
- /* Get the new branch opcode */
- NewBranch = MakeShortBranch (GetInverseBranch (E->OPC));
+ /* Check if it's a jump to an RTS insn */
+ if (T->OPC == OP65_RTS) {
- /* Get the label attached to N, create a new one if needed */
- LN = CS_GenLabel (S, N);
+ /* It's a jump to RTS. Create a conditional branch around an
+ * RTS insn.
+ */
+ X = NewCodeEntry (OP65_RTS, AM65_IMP, 0, 0, T->LI);
- /* Generate the branch */
- X = NewCodeEntry (NewBranch, AM65_BRA, LN->Name, LN, E->LI);
- CS_InsertEntry (S, X, I+1);
+ } else if (T->OPC == OP65_JMP && T->JumpTo == 0) {
- /* Delete the long branch */
- CS_DelEntry (S, I);
+ /* It's a jump to a label outside the function. Create a
+ * conditional branch around a jump to the external label.
+ */
+ X = NewCodeEntry (OP65_JMP, AM65_ABS, T->Arg, T->JumpTo, T->LI);
- /* Remember, we had changes */
- ++Changes;
+ }
+
+ /* If we have a replacement insn, insert it */
+ if (X) {
+
+ CodeLabel* LN;
+ opc_t NewBranch;
+
+ /* Insert the new insn */
+ CS_InsertEntry (S, X, I+1);
+
+ /* Create a conditional branch with the inverse condition
+ * around the replacement insn
+ */
+
+ /* Get the new branch opcode */
+ NewBranch = MakeShortBranch (GetInverseBranch (E->OPC));
+
+ /* Get the label attached to N, create a new one if needed */
+ LN = CS_GenLabel (S, N);
+
+ /* Generate the branch */
+ X = NewCodeEntry (NewBranch, AM65_BRA, LN->Name, LN, E->LI);
+ CS_InsertEntry (S, X, I+1);
+
+ /* Delete the long branch */
+ CS_DelEntry (S, I);
+
+ /* Remember, we had changes */
+ ++Changes;
+ }
}
/* Next entry */
/* Get this entry */
CodeEntry* E = CS_GetEntry (S, I);
- /* Check if it's a branch, if it has a jump label, if this jump
- * label is not attached to the instruction itself, and if the
- * target instruction is itself a branch.
+ /* Check:
+ * - if it's a branch,
+ * - if it has a jump label,
+ * - if this jump label is not attached to the instruction itself,
+ * - if the target instruction is itself a branch,
+ * - if either the first branch is unconditional or the target of
+ * the second branch is internal to the function.
+ * The latter condition will avoid conditional branches to targets
+ * outside of the function (usually incspx), which won't simplify the
+ * code, since conditional far branches are emulated by a short branch
+ * around a jump.
*/
- if ((E->Info & OF_BRA) != 0 &&
- (OldLabel = E->JumpTo) != 0 &&
- (N = OldLabel->Owner) != E &&
- (N->Info & OF_BRA) != 0) {
+ if ((E->Info & OF_BRA) != 0 &&
+ (OldLabel = E->JumpTo) != 0 &&
+ (N = OldLabel->Owner) != E &&
+ (N->Info & OF_BRA) != 0 &&
+ ((E->Info & OF_CBRA) == 0 ||
+ N->JumpTo != 0)) {
/* Check if we can use the final target label. This is the case,
* if the target branch is an absolut branch, or if it is a
/* Get next entry */
E2 = CS_GetNextEntry (S, I);
- /* Check if we have a jump or branch, and a matching label, which
- * is not attached to the jump itself
+ /* Check if we have a jump or branch without a label attached, and
+ * a jump target, which is not attached to the jump itself
*/
- if (E2 != 0 &&
+ if (E2 != 0 &&
(E2->Info & OF_UBRA) != 0 &&
- E2->JumpTo &&
+ !CE_HasLabel (E2) &&
+ E2->JumpTo &&
E2->JumpTo->Owner != E2) {
/* Get the entry preceeding the branch target */
goto NextEntry;
}
+ /* The entry preceeding the branch target may not be the branch
+ * insn.
+ */
+ if (T1 == E2) {
+ goto NextEntry;
+ }
+
/* Get the entry preceeding the jump */
E1 = CS_GetEntry (S, I);
+unsigned OptJumpTarget3 (CodeSeg* S)
+/* Jumps to load instructions of a register, that do already have the matching
+ * register contents may skip the load instruction, since it's job is already
+ * done.
+ */
+{
+ unsigned Changes = 0;
+ unsigned I;
+
+ /* Generate register info for this step */
+ CS_GenRegInfo (S);
+
+ /* Walk over the entries */
+ I = 0;
+ while (I < CS_GetEntryCount (S)) {
+
+ CodeEntry* N;
+
+ /* Get next entry */
+ CodeEntry* E = CS_GetEntry (S, I);
+
+ /* Check if this is a load insn with a label and the next insn is not
+ * a conditional branch that needs the flags from the load.
+ */
+ if ((E->Info & OF_LOAD) != 0 &&
+ CE_IsConstImm (E) &&
+ CE_HasLabel (E) &&
+ (N = CS_GetNextEntry (S, I)) != 0 &&
+ !CE_UseLoadFlags (N)) {
+
+ unsigned J;
+ int K;
+
+ /* New jump label */
+ CodeLabel* LN = 0;
+
+ /* Walk over all insn that jump here */
+ for (J = 0; J < CE_GetLabelCount (E); ++J) {
+
+ /* Get the label */
+ CodeLabel* L = CE_GetLabel (E, J);
+
+ /* Loop over all insn that reference this label. Since we may
+ * eventually remove a reference in the loop, we must loop
+ * from end down to start.
+ */
+ for (K = CL_GetRefCount (L) - 1; K >= 0; --K) {
+
+ /* Get the entry that jumps here */
+ CodeEntry* Jump = CL_GetRef (L, K);
+
+ /* Get the register info from this insn */
+ short Val = RegVal (E->Chg, &Jump->RI->Out2);
+
+ /* Check if the outgoing value is the one thats's loaded */
+ if (Val == (unsigned char) E->Num) {
+
+ /* Ok, skip the insn. First, generate a label for the
+ * next insn after E.
+ */
+ if (LN == 0) {
+ LN = CS_GenLabel (S, N);
+ }
+
+ /* Change the jump target to point to this new label */
+ CS_MoveLabelRef (S, Jump, LN);
+
+ /* Remember that we had changes */
+ ++Changes;
+ }
+ }
+ }
+
+ }
+
+ /* Next entry */
+ ++I;
+ }
+
+ /* Free register info */
+ CS_FreeRegInfo (S);
+
+ /* Return the number of changes made */
+ return Changes;
+}
+
+
+
/*****************************************************************************/
/* Optimize conditional branches */
/*****************************************************************************/
break;
case OP65_STA:
- /* If we store into a known zero page location, and this
+ /* If we store into a known zero page location, and this
* location does already contain the value to be stored,
* remove the store.
*/
* that in the A register, replace the store by a STA. The
* optimizer will then remove the load instruction for Y
* later. If replacement by A is not possible try a
- * replacement by X, but check for invalid addressing modes
+ * replacement by X, but check for invalid addressing modes
* in this case.
*/
} else if (RegValIsKnown (In->RegY)) {
!CE_UseLoadFlags (N)) {
/* Value is identical and not followed by a branch */
Delete = 1;
- }
- break;
+ }
+ break;
- case OP65_TYA:
+ case OP65_TYA:
if (RegValIsKnown (In->RegY) &&
In->RegY == In->RegA &&
- (N = CS_GetNextEntry (S, I)) != 0 &&
+ (N = CS_GetNextEntry (S, I)) != 0 &&
!CE_UseLoadFlags (N)) {
- /* Value is identical and not followed by a branch */
- Delete = 1;
- }
- break;
+ /* Value is identical and not followed by a branch */
+ Delete = 1;
+ }
+ break;
- default:
- break;
+ default:
+ break;
- }
+ }
- /* Delete the entry if requested */
- if (Delete) {
+ /* Delete the entry if requested */
+ if (Delete) {
- /* Register value is not used, remove the load */
- CS_DelEntry (S, I);
+ /* Register value is not used, remove the load */
+ CS_DelEntry (S, I);
- /* Remember, we had changes */
- ++Changes;
+ /* Remember, we had changes */
+ ++Changes;
- } else {
+ } else {
- /* Next entry */
- ++I;
+ /* Next entry */
+ ++I;
- }
+ }
}
StoreEntry->AM == AM65_ZP) &&
(StoreEntry->AM != AM65_ZP ||
(StoreEntry->Chg & UsedRegs) == 0) &&
- !MemAccess (S, Xfer+1, Store-1, StoreEntry->Arg)) {
+ !MemAccess (S, Xfer+1, Store-1, StoreEntry)) {
/* Generate the replacement store insn */
CodeEntry* X = 0;
(LoadEntry->AM == AM65_ABS ||
LoadEntry->AM == AM65_ZP ||
LoadEntry->AM == AM65_IMM) &&
- !MemAccess (S, Load+1, Xfer-1, LoadEntry->Arg)) {
+ !MemAccess (S, Load+1, Xfer-1, LoadEntry)) {
/* Generate the replacement load insn */
CodeEntry* X = 0;
unsigned Changes = 0;
unsigned Push = 0; /* Index of push insn */
unsigned Pop = 0; /* Index of pop insn */
+ unsigned ChgA = 0; /* Flag for A changed */
enum {
Searching,
FoundPush,
if (E->OPC == OP65_PHA) {
/* Found start of sequence */
Push = I;
+ ChgA = 0;
State = FoundPush;
}
break;
if (E->OPC == OP65_PHA) {
/* Inner push/pop, restart */
Push = I;
+ ChgA = 0;
} else if (E->OPC == OP65_PLA) {
/* Found a matching pop */
Pop = I;
/* Go into searching mode again */
State = Searching;
}
+ } else if (E->Chg & REG_A) {
+ ChgA = 1;
}
break;
case FoundPop:
/* We're at the instruction after the PLA.
* Check for the following conditions:
- * - If this instruction is a store of A, and A is not used
- * later, we may replace the PHA by the store and remove
- * pla if several other conditions are met.
+ * - If this instruction is a store of A, does not have a
+ * label, and A is not used later, we may replace the PHA
+ * by the store and remove pla if several other conditions
+ * are met.
* - If this instruction is not a conditional branch, and A
- * is unused later, we may remove PHA and PLA.
+ * is either unused later, or not changed by the code
+ * between push and pop, we may remove PHA and PLA.
*/
if (E->OPC == OP65_STA &&
+ !CE_HasLabel (E) &&
!RegAUsed (S, I+1) &&
- !MemAccess (S, Push+1, Pop-1, E->Arg)) {
+ !MemAccess (S, Push+1, Pop-1, E)) {
/* Insert a STA after the PHA */
X = NewCodeEntry (E->OPC, E->AM, E->Arg, E->JumpTo, E->LI);
++Changes;
} else if ((E->Info & OF_CBRA) == 0 &&
- !RegAUsed (S, I)) {
+ (!RegAUsed (S, I) || !ChgA)) {
/* We can remove the PHA and PLA instructions */
CS_DelEntry (S, Pop);
projects / cc65 / blobdiff