]> git.sur5r.net Git - openocd/blobdiff - src/flash/str7x.c
More robust handling of unknown target state for step/continue packet.
[openocd] / src / flash / str7x.c
index 30b8c07f7596dbfd30c757ed0eb58ba5dd91361f..70f312d359beec3aca6421efad148561eabe0826 100644 (file)
@@ -56,7 +56,6 @@ int str7x_write(struct flash_bank_s *bank, u8 *buffer, u32 offset, u32 count);
 int str7x_probe(struct flash_bank_s *bank);
 int str7x_handle_part_id_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc);
 int str7x_protect_check(struct flash_bank_s *bank);
-int str7x_erase_check(struct flash_bank_s *bank);
 int str7x_info(struct flash_bank_s *bank, char *buf, int buf_size);
 
 int str7x_handle_disable_jtag_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc);
@@ -71,7 +70,7 @@ flash_driver_t str7x_flash =
        .write = str7x_write,
        .probe = str7x_probe,
        .auto_probe = str7x_probe,
-       .erase_check = str7x_erase_check,
+       .erase_check = default_flash_blank_check,
        .protect_check = str7x_protect_check,
        .info = str7x_info
 };
@@ -113,7 +112,7 @@ int str7x_build_block_list(struct flash_bank_s *bank)
                        b0_sectors = 8;
                        break;
                default:
-                       ERROR("BUG: unknown bank->size encountered");
+                       LOG_ERROR("BUG: unknown bank->size encountered");
                        exit(-1);
        }
        
@@ -165,7 +164,7 @@ int str7x_flash_bank_command(struct command_context_s *cmd_ctx, char *cmd, char
        
        if (argc < 7)
        {
-               WARNING("incomplete flash_bank str7x configuration");
+               LOG_WARNING("incomplete flash_bank str7x configuration");
                return ERROR_FLASH_BANK_INVALID;
        }
        
@@ -181,7 +180,7 @@ int str7x_flash_bank_command(struct command_context_s *cmd_ctx, char *cmd, char
        {
                if (bank->base != 0x40000000)
                {
-                       WARNING("overriding flash base address for STR71x device with 0x40000000");
+                       LOG_WARNING("overriding flash base address for STR71x device with 0x40000000");
                        bank->base = 0x40000000;
                }
        }
@@ -192,7 +191,7 @@ int str7x_flash_bank_command(struct command_context_s *cmd_ctx, char *cmd, char
                
                if (bank->base != 0x80000000)
                {
-                       WARNING("overriding flash base address for STR73x device with 0x80000000");
+                       LOG_WARNING("overriding flash base address for STR73x device with 0x80000000");
                        bank->base = 0x80000000;
                }
        }
@@ -202,13 +201,13 @@ int str7x_flash_bank_command(struct command_context_s *cmd_ctx, char *cmd, char
                
                if (bank->base != 0x20000000)
                {
-                       WARNING("overriding flash base address for STR75x device with 0x20000000");
+                       LOG_WARNING("overriding flash base address for STR75x device with 0x20000000");
                        bank->base = 0x20000000;
                }
        }
        else
        {
-               ERROR("unknown STR7x variant: '%s'", args[6]);
+               LOG_ERROR("unknown STR7x variant: '%s'", args[6]);
                free(str7x_info);
                return ERROR_FLASH_BANK_INVALID;
        }
@@ -240,43 +239,6 @@ u32 str7x_result(struct flash_bank_s *bank)
        return retval;
 }
 
-int str7x_blank_check(struct flash_bank_s *bank, int first, int last)
-{
-       target_t *target = bank->target;
-       u8 *buffer;
-       int i;
-       int nBytes;
-       
-       if ((first < 0) || (last > bank->num_sectors))
-               return ERROR_FLASH_SECTOR_INVALID;
-
-       if (bank->target->state != TARGET_HALTED)
-       {
-               return ERROR_TARGET_NOT_HALTED;
-       }
-       
-       buffer = malloc(256);
-       
-       for (i = first; i <= last; i++)
-       {
-               bank->sectors[i].is_erased = 1;
-
-               target->type->read_memory(target, bank->base + bank->sectors[i].offset, 4, 256/4, buffer);
-               
-               for (nBytes = 0; nBytes < 256; nBytes++)
-               {
-                       if (buffer[nBytes] != 0xFF)
-                       {
-                               bank->sectors[i].is_erased = 0;
-                               break;
-                       }
-               }       
-       }
-       
-       free(buffer);
-
-       return ERROR_OK;
-}
 
 int str7x_protect_check(struct flash_bank_s *bank)
 {
@@ -326,12 +288,12 @@ int str7x_erase(struct flash_bank_s *bank, int first, int last)
                else if (str7x_info->sector_bank[i] == 1)
                        b1_sectors |= str7x_info->sector_bits[i];
                else
-                       ERROR("BUG: str7x_info->sector_bank[i] neither 0 nor 1 (%i)", str7x_info->sector_bank[i]);
+                       LOG_ERROR("BUG: str7x_info->sector_bank[i] neither 0 nor 1 (%i)", str7x_info->sector_bank[i]);
        }
        
        if (b0_sectors)
        {
-               DEBUG("b0_sectors: 0x%x", b0_sectors);
+               LOG_DEBUG("b0_sectors: 0x%x", b0_sectors);
                
                /* clear FLASH_ER register */   
                target_write_u32(target, str7x_get_flash_adr(bank, FLASH_ER), 0x0);
@@ -353,14 +315,14 @@ int str7x_erase(struct flash_bank_s *bank, int first, int last)
                
                if (retval)
                {
-                       ERROR("error erasing flash bank, FLASH_ER: 0x%x", retval);
+                       LOG_ERROR("error erasing flash bank, FLASH_ER: 0x%x", retval);
                        return ERROR_FLASH_OPERATION_FAILED;
                }
        }
        
        if (b1_sectors)
        {
-               DEBUG("b1_sectors: 0x%x", b1_sectors);
+               LOG_DEBUG("b1_sectors: 0x%x", b1_sectors);
                
                /* clear FLASH_ER register */   
                target_write_u32(target, str7x_get_flash_adr(bank, FLASH_ER), 0x0);
@@ -382,7 +344,7 @@ int str7x_erase(struct flash_bank_s *bank, int first, int last)
                
                if (retval)
                {
-                       ERROR("error erasing flash bank, FLASH_ER: 0x%x", retval);
+                       LOG_ERROR("error erasing flash bank, FLASH_ER: 0x%x", retval);
                        return ERROR_FLASH_OPERATION_FAILED;
                }
        }
@@ -436,7 +398,7 @@ int str7x_protect(struct flash_bank_s *bank, int set, int first, int last)
        
        retval = str7x_result(bank);
        
-       DEBUG("retval: 0x%8.8x", retval);
+       LOG_DEBUG("retval: 0x%8.8x", retval);
        
        if (retval & FLASH_ERER)
                return ERROR_FLASH_SECTOR_NOT_ERASED;
@@ -486,7 +448,7 @@ int str7x_write_block(struct flash_bank_s *bank, u8 *buffer, u32 offset, u32 cou
        /* flash write code */
        if (target_alloc_working_area(target, 4 * 20, &str7x_info->write_algorithm) != ERROR_OK)
        {
-               WARNING("no working area available, can't do block memory writes");
+               LOG_WARNING("no working area available, can't do block memory writes");
                return ERROR_TARGET_RESOURCE_NOT_AVAILABLE;
        };
        
@@ -502,7 +464,7 @@ int str7x_write_block(struct flash_bank_s *bank, u8 *buffer, u32 offset, u32 cou
                        if (str7x_info->write_algorithm)
                                target_free_working_area(target, str7x_info->write_algorithm);
                        
-                       WARNING("no large enough working area available, can't do block memory writes");
+                       LOG_WARNING("no large enough working area available, can't do block memory writes");
                        return ERROR_TARGET_RESOURCE_NOT_AVAILABLE;
                }
        }
@@ -532,7 +494,7 @@ int str7x_write_block(struct flash_bank_s *bank, u8 *buffer, u32 offset, u32 cou
        
                if ((retval = target->type->run_algorithm(target, 0, NULL, 6, reg_params, str7x_info->write_algorithm->address, str7x_info->write_algorithm->address + (19 * 4), 10000, &armv4_5_info)) != ERROR_OK)
                {
-                       ERROR("error executing str7x flash write algorithm");
+                       LOG_ERROR("error executing str7x flash write algorithm");
                        break;
                }
        
@@ -580,7 +542,7 @@ int str7x_write(struct flash_bank_s *bank, u8 *buffer, u32 offset, u32 count)
 
        if (offset & 0x7)
        {
-               WARNING("offset 0x%x breaks required 8-byte alignment", offset);
+               LOG_WARNING("offset 0x%x breaks required 8-byte alignment", offset);
                return ERROR_FLASH_DST_BREAKS_ALIGNMENT;
        }
        
@@ -616,14 +578,14 @@ int str7x_write(struct flash_bank_s *bank, u8 *buffer, u32 offset, u32 count)
                        {
                                /* if block write failed (no sufficient working area),
                                 * we use normal (slow) single dword accesses */ 
-                               WARNING("couldn't use block writes, falling back to single memory accesses");
+                               LOG_WARNING("couldn't use block writes, falling back to single memory accesses");
                        }
                        else if (retval == ERROR_FLASH_OPERATION_FAILED)
                        {
                                /* if an error occured, we examine the reason, and quit */
                                retval = str7x_result(bank);
                                
-                               ERROR("flash writing failed with error code: 0x%x", retval);
+                               LOG_ERROR("flash writing failed with error code: 0x%x", retval);
                                return ERROR_FLASH_OPERATION_FAILED;
                        }
                }
@@ -729,11 +691,6 @@ int str7x_handle_part_id_command(struct command_context_s *cmd_ctx, char *cmd, c
        return ERROR_OK;
 }
 
-int str7x_erase_check(struct flash_bank_s *bank)
-{
-       return str7x_blank_check(bank, 0, bank->num_sectors - 1);
-}
-
 int str7x_info(struct flash_bank_s *bank, char *buf, int buf_size)
 {
        snprintf(buf, buf_size, "str7x flash driver info" );