Eliminate MixedCaps symbol from public JTAG TAP API:

[openocd] / src / helper / command.c

diff --git a/src/helper/command.c b/src/helper/command.c
index d5be42dfeea02dfc4c4081bf74c594ccc8da8473..a82eb4dae5cdfca911c3a8bb2a744cd5d87ae9d5 100644 (file)
--- a/src/helper/command.c
+++ b/src/helper/command.c
@@ -30,22 +30,19 @@
 #include "config.h"
 #endif
 
-#include "replacements.h"
+#if !BUILD_ECOSBOARD
+/* see Embedder-HOWTO.txt in Jim Tcl project hosted on BerliOS*/
+#define JIM_EMBEDDED
+#endif
+
+// @todo the inclusion of target.h here is a layering violation
 #include "target.h"
 #include "command.h"
 #include "configuration.h"
-
 #include "log.h"
 #include "time_support.h"
 #include "jim-eventloop.h"
 
-#include <stdlib.h>
-#include <string.h>
-#include <ctype.h>
-#include <stdarg.h>
-#include <stdio.h>
-#include <unistd.h>
-#include <errno.h>
 
 int fast_and_dangerous = 0;
 Jim_Interp *interp = NULL;
@@ -224,7 +221,7 @@ command_t* register_command(command_context_t *context, command_t *parent, char
        free((void *)full_name);
 
        /* we now need to add an overrideable proc */
-       const char *override_name=alloc_printf("proc %s%s%s {args} {if {[catch {eval \"ocd_%s%s%s $args\"}]==0} {return \"\"} else { return -code error }", t1, t2, t3, t1, t2, t3);
+       const char *override_name=alloc_printf("proc %s%s%s {args} {if {[catch {eval ocd_%s%s%s $args}]==0} {return \"\"} else { return -code error }", t1, t2, t3, t1, t2, t3);
        Jim_Eval_Named(interp, override_name, __THIS__FILE__, __LINE__ );
        free((void *)override_name);
 
@@ -395,7 +392,7 @@ int run_command(command_context_t *context, command_t *c, char *words[], int num
        if (!((context->mode == COMMAND_CONFIG) || (c->mode == COMMAND_ANY) || (c->mode == context->mode) ))
        {
                /* Config commands can not run after the config stage */
-               LOG_ERROR("Illegal mode for command");
+               LOG_ERROR("Command '%s' only runs during configuration stage", c->name);
                return ERROR_FAIL;
        }
 
@@ -479,19 +476,22 @@ int command_run_line(command_context_t *context, char *line)
                int reslen;
 
                result = Jim_GetString(Jim_GetResult(interp), &reslen);
-               int i;
-               char buff[256+1];
-               for (i = 0; i < reslen; i += 256)
+               if (reslen>0)
                {
-                       int chunk;
-                       chunk = reslen - i;
-                       if (chunk > 256)
-                               chunk = 256;
-                       strncpy(buff, result+i, chunk);
-                       buff[chunk] = 0;
-                       LOG_USER_N("%s", buff);
+                       int i;
+                       char buff[256+1];
+                       for (i = 0; i < reslen; i += 256)
+                       {
+                               int chunk;
+                               chunk = reslen - i;
+                               if (chunk > 256)
+                                       chunk = 256;
+                               strncpy(buff, result+i, chunk);
+                               buff[chunk] = 0;
+                               LOG_USER_N("%s", buff);
+                       }
+                       LOG_USER_N("%s", "\n");
                }
-               LOG_USER_N("%s", "\n");
                retval=ERROR_OK;
        }
        return retval;
@@ -680,7 +680,7 @@ command_context_t* command_init()
        context->output_handler = NULL;
        context->output_handler_priv = NULL;
 
-#ifdef JIM_EMBEDDED
+#if !BUILD_ECOSBOARD
        Jim_InitEmbedded();
        /* Create an interpreter */
        interp = Jim_CreateInterp();
@@ -691,7 +691,7 @@ command_context_t* command_init()
 #if defined( _MSC_VER )
        /* WinXX - is generic, the forward
         * looking problem is this:
-        * 
+        *
         *   "win32" or "win64"
         *
         * "winxx" is generic.
@@ -726,7 +726,7 @@ command_context_t* command_init()
 
        add_default_dirs();
 
-#ifdef JIM_EMBEDDED
+#if !BUILD_ECOSBOARD
        Jim_EventLoopOnLoad(interp);
 #endif
        if (Jim_Eval_Named(interp, startup_tcl, "embedded:startup.tcl",1)==JIM_ERR)
@@ -783,7 +783,7 @@ int handle_sleep_command(struct command_context_s *cmd_ctx, char *cmd, char **ar
        } else
        {
                long long then=timeval_ms();
-               while ((timeval_ms()-then)<duration)
+               while ((timeval_ms()-then)<(long long)duration)
                {
                        target_call_timer_callbacks_now();
                        usleep(1000);
@@ -805,7 +805,7 @@ int handle_fast_command(struct command_context_s *cmd_ctx, char *cmd, char **arg
 
 void process_jim_events(void)
 {
-#ifdef JIM_EMBEDDED
+#if !BUILD_ECOSBOARD
        static int recursion = 0;
 
        if (!recursion)