Factoring of jtag_examine_chain for maintainability:

[openocd] / src / pld / xilinx_bit.c

diff --git a/src/pld/xilinx_bit.c b/src/pld/xilinx_bit.c
index 3c99db0d21350b0eb2c07f74196df8d8fd91a0cf..ef3c1e65df9062768ba3d186f0da7fbcf32bb6bc 100644 (file)
--- a/src/pld/xilinx_bit.c
+++ b/src/pld/xilinx_bit.c
@@ -22,31 +22,22 @@
 #endif
 
 #include "xilinx_bit.h"
-
 #include "pld.h"
 #include "log.h"
 
-#include <stdlib.h>
-#include <unistd.h>
-#include <sys/types.h>
 #include <sys/stat.h>
-#include <fcntl.h>
-#include <string.h>
-#include <errno.h>
 
-#include <sys/time.h>
-#include <time.h>
 
 int read_section(FILE *input_file, int length_size, char section, u32 *buffer_length, u8 **buffer) 
 {
        u8 length_buffer[4];
-       u32 length;
+       int length;
        char section_char;
        int read_count;
        
        if ((length_size != 2) && (length_size != 4))
        {
-               ERROR("BUG: length_size neither 2 nor 4");
+               LOG_ERROR("BUG: length_size neither 2 nor 4");
                return ERROR_PLD_FILE_LOAD_FAILED;
        }
 
@@ -94,30 +85,30 @@ int xilinx_read_bit_file(xilinx_bit_file_t *bit_file, char *filename)
        
        if (stat(filename, &input_stat) == -1)
        {
-               ERROR("couldn't stat() %s: %s", filename, strerror(errno));
+               LOG_ERROR("couldn't stat() %s: %s", filename, strerror(errno));
                return ERROR_PLD_FILE_LOAD_FAILED;
        }
 
        if (S_ISDIR(input_stat.st_mode))
        {
-               ERROR("%s is a directory", filename);
+               LOG_ERROR("%s is a directory", filename);
                return ERROR_PLD_FILE_LOAD_FAILED;
        }
                
        if (input_stat.st_size == 0){
-               ERROR("Empty file %s", filename);
+               LOG_ERROR("Empty file %s", filename);
                return ERROR_PLD_FILE_LOAD_FAILED;
        }
                
        if (!(input_file = fopen(filename, "rb")))
        {
-               ERROR("couldn't open %s: %s", filename, strerror(errno));
+               LOG_ERROR("couldn't open %s: %s", filename, strerror(errno));
                return ERROR_PLD_FILE_LOAD_FAILED;
        }
        
        if ((read_count = fread(bit_file->unknown_header, 1, 13, input_file)) != 13)
        {
-               ERROR("couldn't read unknown_header from file '%s'", filename);
+               LOG_ERROR("couldn't read unknown_header from file '%s'", filename);
                return ERROR_PLD_FILE_LOAD_FAILED;
        }
        
@@ -136,7 +127,7 @@ int xilinx_read_bit_file(xilinx_bit_file_t *bit_file, char *filename)
        if (read_section(input_file, 4, 'e', &bit_file->length, &bit_file->data) != ERROR_OK)
                return ERROR_PLD_FILE_LOAD_FAILED;
        
-       DEBUG("bit_file: %s %s %s,%s %i", bit_file->source_file, bit_file->part_name,
+       LOG_DEBUG("bit_file: %s %s %s,%s %i", bit_file->source_file, bit_file->part_name,
                bit_file->date, bit_file->time, bit_file->length);
        
        fclose(input_file);