]> git.sur5r.net Git - openocd/blobdiff - src/target/image.c
Reset wip. Just adding hooks. This is just to reduce the size of the actual change...
[openocd] / src / target / image.c
index bdd89b1c9e508fa9ff6a96380a1d4c0845fb28f9..1eb956728f58c8b45cbca1162177b8aa627b1e99 100644 (file)
 #include "target.h"
 
 /* convert ELF header field to host endianness */
-#define field16(elf, field)\
-       ((elf->endianness == ELFDATA2LSB)? \
-               le_to_h_u16((u8*)&field) : be_to_h_u16((u8*)&field)) 
+#define field16(elf,field)\
+       ((elf->endianness==ELFDATA2LSB)? \
+               le_to_h_u16((u8*)&field):be_to_h_u16((u8*)&field)) 
 
-#define field32(elf, field)\
-       ((elf->endianness == ELFDATA2LSB)? \
-               le_to_h_u32((u8*)&field) : be_to_h_u32((u8*)&field)) 
+#define field32(elf,field)\
+       ((elf->endianness==ELFDATA2LSB)? \
+               le_to_h_u32((u8*)&field):be_to_h_u32((u8*)&field)) 
 
 static int autodetect_image_type(image_t *image, char *url)
 {
@@ -55,20 +55,14 @@ static int autodetect_image_type(image_t *image, char *url)
        /* read the first 4 bytes of image */
        if ((retval = fileio_open(&fileio, url, FILEIO_READ, FILEIO_BINARY)) != ERROR_OK)
        {
-               snprintf(image->error_str, IMAGE_MAX_ERROR_STRING, "cannot open image: %s", fileio.error_str); 
-               ERROR(image->error_str);
                return retval;
        }
        if ((retval = fileio_read(&fileio, 9, buffer, &read_bytes)) != ERROR_OK)
        {
-               snprintf(image->error_str, IMAGE_MAX_ERROR_STRING, "cannot read image header: %s", fileio.error_str);
-               ERROR(image->error_str);
                return ERROR_FILEIO_OPERATION_FAILED;
        }
        if (read_bytes != 9)
        {
-               snprintf(image->error_str, IMAGE_MAX_ERROR_STRING, "cannot read image, only partially read");
-               ERROR(image->error_str);
                return ERROR_FILEIO_OPERATION_FAILED;
        }
        fileio_close(&fileio);
@@ -76,20 +70,20 @@ static int autodetect_image_type(image_t *image, char *url)
        /* check header against known signatures */
        if (strncmp((char*)buffer,ELFMAG,SELFMAG)==0)
        {
-               DEBUG("ELF image detected.");
+               LOG_DEBUG("ELF image detected.");
                image->type = IMAGE_ELF;
        }
-       else if ((buffer[0] == ':') /* record start byte */
+       else if  ((buffer[0]==':') /* record start byte */
                &&(isxdigit(buffer[1]))
                &&(isxdigit(buffer[2]))
                &&(isxdigit(buffer[3]))
                &&(isxdigit(buffer[4]))
                &&(isxdigit(buffer[5]))
                &&(isxdigit(buffer[6]))
-               &&(buffer[7] == '0') /* record type : 00 -> 05 */
-               &&(buffer[8] >= '0') && (buffer[8] < '6'))
+               &&(buffer[7]=='0') /* record type : 00 -> 05 */
+               &&(buffer[8]>='0')&&(buffer[8]<'6'))
        {
-               DEBUG("IHEX image detected.");
+               LOG_DEBUG("IHEX image detected.");
                image->type = IMAGE_IHEX;
        }
        else if ((buffer[0] == 'S') /* record start byte */
@@ -98,7 +92,7 @@ static int autodetect_image_type(image_t *image, char *url)
                &&(isxdigit(buffer[3]))
                &&(buffer[1] >= '0') && (buffer[1] < '9'))
        {
-               DEBUG("S19 image detected.");
+               LOG_DEBUG("S19 image detected.");
                image->type = IMAGE_SRECORD;
        }
        else
@@ -321,7 +315,7 @@ int image_ihex_buffer_complete(image_t *image)
                }
                else
                {
-                       ERROR("unhandled IHEX record type: %i", record_type);
+                       LOG_ERROR("unhandled IHEX record type: %i", record_type);
                        return ERROR_IMAGE_FORMAT_ERROR;
                }
                
@@ -331,12 +325,12 @@ int image_ihex_buffer_complete(image_t *image)
                if ((u8)checksum != (u8)(~cal_checksum + 1))
                {
                        /* checksum failed */
-                       ERROR("incorrect record checksum found in IHEX file");
+                       LOG_ERROR("incorrect record checksum found in IHEX file");
                        return ERROR_IMAGE_CHECKSUM;
                }
        }
        
-       ERROR("premature end of IHEX file, no end-of-file record found");
+       LOG_ERROR("premature end of IHEX file, no end-of-file record found");
        return ERROR_IMAGE_FORMAT_ERROR;
 }
 
@@ -351,23 +345,23 @@ int image_elf_read_headers(image_t *image)
 
        if ((retval = fileio_read(&elf->fileio, sizeof(Elf32_Ehdr), (u8*)elf->header, &read_bytes)) != ERROR_OK)
        {
-               ERROR("cannot read ELF file header, read failed");
+               LOG_ERROR("cannot read ELF file header, read failed");
                return ERROR_FILEIO_OPERATION_FAILED;
        }
        if (read_bytes != sizeof(Elf32_Ehdr))
        {
-               ERROR("cannot read ELF file header, only partially read");
+               LOG_ERROR("cannot read ELF file header, only partially read");
                return ERROR_FILEIO_OPERATION_FAILED;
        }
 
        if (strncmp((char*)elf->header->e_ident,ELFMAG,SELFMAG)!=0)
        {
-               ERROR("invalid ELF file, bad magic number");
+               LOG_ERROR("invalid ELF file, bad magic number");
                return ERROR_IMAGE_FORMAT_ERROR;
        }
        if (elf->header->e_ident[EI_CLASS]!=ELFCLASS32)
        {
-               ERROR("invalid ELF file, only 32bits files are supported");
+               LOG_ERROR("invalid ELF file, only 32bits files are supported");
                return ERROR_IMAGE_FORMAT_ERROR;
        }
 
@@ -376,42 +370,48 @@ int image_elf_read_headers(image_t *image)
        if ((elf->endianness!=ELFDATA2LSB)
                 &&(elf->endianness!=ELFDATA2MSB))
        {
-               ERROR("invalid ELF file, unknown endianess setting");
+               LOG_ERROR("invalid ELF file, unknown endianess setting");
                return ERROR_IMAGE_FORMAT_ERROR;
        }
 
        elf->segment_count = field16(elf,elf->header->e_phnum);
        if (elf->segment_count==0)
        {
-               ERROR("invalid ELF file, no program headers");
+               LOG_ERROR("invalid ELF file, no program headers");
                return ERROR_IMAGE_FORMAT_ERROR;
        }
 
+       if ((retval = fileio_seek(&elf->fileio, field32(elf,elf->header->e_phoff))) != ERROR_OK)
+       {
+               LOG_ERROR("cannot seek to ELF program header table, read failed");
+               return retval;
+       }
+
        elf->segments = malloc(elf->segment_count*sizeof(Elf32_Phdr));
 
        if ((retval = fileio_read(&elf->fileio, elf->segment_count*sizeof(Elf32_Phdr), (u8*)elf->segments, &read_bytes)) != ERROR_OK)
        {
-               ERROR("cannot read ELF segment headers, read failed");
+               LOG_ERROR("cannot read ELF segment headers, read failed");
                return retval;
        }
        if (read_bytes != elf->segment_count*sizeof(Elf32_Phdr))
        {
-               ERROR("cannot read ELF segment headers, only partially read");
+               LOG_ERROR("cannot read ELF segment headers, only partially read");
                return ERROR_FILEIO_OPERATION_FAILED;
        }
 
        /* count useful segments (loadable), ignore BSS section */
        image->num_sections = 0;
-       for (i = 0; i < elf->segment_count; i++)
+       for (i=0;i<elf->segment_count;i++)
                if ((field32(elf, elf->segments[i].p_type) == PT_LOAD) && (field32(elf, elf->segments[i].p_filesz) != 0))
                        image->num_sections++;
        /* alloc and fill sections array with loadable segments */
        image->sections = malloc(image->num_sections * sizeof(image_section_t));
-       for (i = 0, j = 0; i < elf->segment_count; i++)
+       for (i=0,j=0;i<elf->segment_count;i++)
        {
                if ((field32(elf, elf->segments[i].p_type) == PT_LOAD) && (field32(elf, elf->segments[i].p_filesz) != 0))
                {
-                       image->sections[j].size = field32(elf,elf->segments[i].p_memsz);
+                       image->sections[j].size = field32(elf,elf->segments[i].p_filesz);
                        image->sections[j].base_address = field32(elf,elf->segments[i].p_paddr);
                        image->sections[j].private = &elf->segments[i];
                        image->sections[j].flags = field32(elf,elf->segments[i].p_flags);
@@ -429,29 +429,29 @@ int image_elf_read_section(image_t *image, int section, u32 offset, u32 size, u8
 {
        image_elf_t *elf = image->type_private;
        Elf32_Phdr *segment = (Elf32_Phdr *)image->sections[section].private;
-       u32 read_size, really_read;
+       u32 read_size,really_read;
        int retval;
 
        *size_read = 0;
        
-       DEBUG("load segment %d at 0x%x (sz = 0x%x)", section, offset, size);
+       LOG_DEBUG("load segment %d at 0x%x (sz=0x%x)",section,offset,size);
 
        /* read initialized data in current segment if any */
-       if (offset < field32(elf, segment->p_filesz))
+       if (offset<field32(elf,segment->p_filesz))
        {
                /* maximal size present in file for the current segment */
-               read_size = MIN(size, field32(elf, segment->p_filesz) - offset);
-               DEBUG("read elf: size = 0x%x at 0x%x", read_size,
-                       field32(elf,segment->p_offset) + offset);
+               read_size = MIN(size, field32(elf,segment->p_filesz)-offset);
+               LOG_DEBUG("read elf: size = 0x%x at 0x%x",read_size,
+                       field32(elf,segment->p_offset)+offset);
                /* read initialized area of the segment */
-               if ((retval = fileio_seek(&elf->fileio, field32(elf,segment->p_offset) + offset)) != ERROR_OK)
+               if ((retval = fileio_seek(&elf->fileio, field32(elf,segment->p_offset)+offset)) != ERROR_OK)
                {
-                       ERROR("cannot find ELF segment content, seek failed");
+                       LOG_ERROR("cannot find ELF segment content, seek failed");
                        return retval;
                }
                if ((retval = fileio_read(&elf->fileio, read_size, buffer, &really_read)) != ERROR_OK)
                {
-                       ERROR("cannot read ELF segment content, read failed");
+                       LOG_ERROR("cannot read ELF segment content, read failed");
                        return retval;
                }
                buffer += read_size;
@@ -462,15 +462,6 @@ int image_elf_read_section(image_t *image, int section, u32 offset, u32 size, u8
                if (!size)
                        return ERROR_OK;
        }
-       /* if there is remaining zeroed area in current segment */
-       if (offset < field32(elf, segment->p_memsz))
-       {
-               /* fill zeroed part (BSS) of the segment */
-               read_size = MIN(size, field32(elf, segment->p_memsz) - offset);
-               DEBUG("zero fill: size = 0x%x", read_size);
-               memset(buffer, 0, read_size);
-               *size_read += read_size;
-       }
        
        return ERROR_OK;
 }
@@ -561,6 +552,7 @@ int image_mot_buffer_complete(image_t *image)
                                        bytes_read += 8;
                                        count -=4;
                                        break;
+                       
                        }
                        
                        if (full_address != address)
@@ -621,7 +613,7 @@ int image_mot_buffer_complete(image_t *image)
                }
                else
                {
-                       ERROR("unhandled S19 record type: %i", record_type);
+                       LOG_ERROR("unhandled S19 record type: %i", record_type);
                        return ERROR_IMAGE_FORMAT_ERROR;
                }
                
@@ -633,12 +625,12 @@ int image_mot_buffer_complete(image_t *image)
                if( cal_checksum != 0xFF )
                {
                        /* checksum failed */
-                       ERROR("incorrect record checksum found in S19 file");
+                       LOG_ERROR("incorrect record checksum found in S19 file");
                        return ERROR_IMAGE_CHECKSUM;
                }
        }
        
-       ERROR("premature end of S19 file, no end-of-file record found");
+       LOG_ERROR("premature end of S19 file, no end-of-file record found");
        return ERROR_IMAGE_FORMAT_ERROR;
 }
 
@@ -659,8 +651,6 @@ int image_open(image_t *image, char *url, char *type_string)
                
                if ((retval = fileio_open(&image_binary->fileio, url, FILEIO_READ, FILEIO_BINARY)) != ERROR_OK)
                {
-                       strncpy(image->error_str, image_binary->fileio.error_str, IMAGE_MAX_ERROR_STRING); 
-                       ERROR(image->error_str);
                        return retval;
                }
                
@@ -678,16 +668,12 @@ int image_open(image_t *image, char *url, char *type_string)
                
                if ((retval = fileio_open(&image_ihex->fileio, url, FILEIO_READ, FILEIO_TEXT)) != ERROR_OK)
                {
-                       strncpy(image->error_str, image_ihex->fileio.error_str, IMAGE_MAX_ERROR_STRING); 
-                       ERROR(image->error_str);
                        return retval;
                }
                
                if ((retval = image_ihex_buffer_complete(image)) != ERROR_OK)
                {
-                       snprintf(image->error_str, IMAGE_MAX_ERROR_STRING,
-                               "failed buffering IHEX image, check daemon output for additional information");
-                       ERROR(image->error_str);
+                       LOG_ERROR("failed buffering IHEX image, check daemon output for additional information");
                        fileio_close(&image_ihex->fileio);
                        return retval;
                }
@@ -700,16 +686,11 @@ int image_open(image_t *image, char *url, char *type_string)
                
                if ((retval = fileio_open(&image_elf->fileio, url, FILEIO_READ, FILEIO_BINARY)) != ERROR_OK)
                {
-                       strncpy(image->error_str, image_elf->fileio.error_str, IMAGE_MAX_ERROR_STRING); 
-                       ERROR(image->error_str);
                        return retval;
                }
                
                if ((retval = image_elf_read_headers(image)) != ERROR_OK)
                {
-                       snprintf(image->error_str, IMAGE_MAX_ERROR_STRING,
-                               "failed to read ELF headers, check daemon output for additional information");
-                       ERROR(image->error_str);
                        fileio_close(&image_elf->fileio);
                        return retval;
                }
@@ -738,16 +719,12 @@ int image_open(image_t *image, char *url, char *type_string)
                
                if ((retval = fileio_open(&image_mot->fileio, url, FILEIO_READ, FILEIO_TEXT)) != ERROR_OK)
                {
-                       strncpy(image->error_str, image_mot->fileio.error_str, IMAGE_MAX_ERROR_STRING); 
-                       ERROR(image->error_str);
                        return retval;
                }
                
                if ((retval = image_mot_buffer_complete(image)) != ERROR_OK)
                {
-                       snprintf(image->error_str, IMAGE_MAX_ERROR_STRING,
-                               "failed buffering S19 image, check daemon output for additional information");
-                       ERROR(image->error_str);
+                       LOG_ERROR("failed buffering S19 image, check daemon output for additional information");
                        fileio_close(&image_mot->fileio);
                        return retval;
                }
@@ -763,15 +740,15 @@ int image_open(image_t *image, char *url, char *type_string)
        {
                /* relocate */
                int section;
-               for (section = 0; section < image->num_sections; section++)
+               for (section=0; section < image->num_sections; section++)
                {
-                       image->sections[section].base_address += image->base_address;
+                       image->sections[section].base_address+=image->base_address;
                }
                /* we're done relocating. The two statements below are mainly
                 * for documenation purposes: stop anyone from empirically
                 * thinking they should use these values henceforth. */
-               image->base_address = 0;
-               image->base_address_set = 0;
+               image->base_address=0;
+               image->base_address_set=0;
        }
        
        return retval;
@@ -784,7 +761,7 @@ int image_read_section(image_t *image, int section, u32 offset, u32 size, u8 *bu
        /* don't read past the end of a section */
        if (offset + size > image->sections[section].size)
        {
-               DEBUG("read past end of section: 0x%8.8x + 0x%8.8x > 0x%8.8x",
+               LOG_DEBUG("read past end of section: 0x%8.8x + 0x%8.8x > 0x%8.8x",
                                offset, size, image->sections[section].size);
                return ERROR_INVALID_ARGUMENTS;
        }
@@ -800,14 +777,12 @@ int image_read_section(image_t *image, int section, u32 offset, u32 size, u8 *bu
                /* seek to offset */
                if ((retval = fileio_seek(&image_binary->fileio, offset)) != ERROR_OK)
                {
-                       strncpy(image->error_str, image_binary->fileio.error_str, IMAGE_MAX_ERROR_STRING);
                        return retval;
                }
                
                /* return requested bytes */
                if ((retval = fileio_read(&image_binary->fileio, size, buffer, size_read)) != ERROR_OK)
                {
-                       strncpy(image->error_str, image_binary->fileio.error_str, IMAGE_MAX_ERROR_STRING);
                        return retval;
                }
        }
@@ -815,7 +790,6 @@ int image_read_section(image_t *image, int section, u32 offset, u32 size, u8 *bu
        {
                memcpy(buffer, (u8*)image->sections[section].private + offset, size);
                *size_read = size;
-               image->error_str[0] = '\0';
                
                return ERROR_OK;
        }
@@ -866,7 +840,6 @@ int image_read_section(image_t *image, int section, u32 offset, u32 size, u8 *bu
        {
                memcpy(buffer, (u8*)image->sections[section].private + offset, size);
                *size_read = size;
-               image->error_str[0] = '\0';
                
                return ERROR_OK;
        }
@@ -874,7 +847,6 @@ int image_read_section(image_t *image, int section, u32 offset, u32 size, u8 *bu
        {
                memcpy(buffer, (u8*)image->sections[section].private + offset, size);
                *size_read = size;
-               image->error_str[0] = '\0';
                
                return ERROR_OK;
        }
@@ -944,7 +916,7 @@ int image_close(image_t *image)
                image_elf_t *image_elf = image->type_private;
                
                fileio_close(&image_elf->fileio);
-               
+
                if (image_elf->header)
                {
                        free(image_elf->header);