hla: Make consistent parameter naming

[openocd] / src / target / smp.c

diff --git a/src/target/smp.c b/src/target/smp.c
index 9cd4b013d3ea0a26b1cd3db5257146a921e5d94a..d14ceba962283c2d460db3ccbb84c67c5ef4654e 100644 (file)
--- a/src/target/smp.c
+++ b/src/target/smp.c
@@ -15,7 +15,7 @@
  *   You should have received a copy of the GNU General Public License     *
  *   along with this program; if not, write to the                         *
  *   Free Software Foundation, Inc.,                                       *
- *   59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.             *
+ *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.           *
  ***************************************************************************/
 
 #ifdef HAVE_CONFIG_H
@@ -28,6 +28,7 @@
 
 #include "server/gdb_server.h"
 #include "smp.h"
+#include "helper/binarybuffer.h"
 
 /*  implementation of new packet in gdb interface for smp feature          */
 /*                                                                         */
@@ -53,31 +54,21 @@
 /*  maint packet Jc01                                                      */
 /*  maint packet jc                                                        */
 
-static const char DIGITS[16] = "0123456789abcdef";
-
 /* packet j :smp status request */
 int gdb_read_smp_packet(struct connection *connection,
                char *packet, int packet_size)
 {
        struct target *target = get_target_from_connection(connection);
-       uint32_t len = sizeof(int32_t);
-       uint8_t *buffer;
-       char *hex_buffer;
        int retval = ERROR_OK;
        if (target->smp) {
-               if (strstr(packet, "jc")) {
-                       hex_buffer = malloc(len * 2 + 1);
-                       buffer = (uint8_t *)&target->gdb_service->core[0];
-                       uint32_t i;
-                       for (i = 0; i < 4; i++) {
-                               uint8_t t = buffer[i];
-                               hex_buffer[2 * i] = DIGITS[(t >> 4) & 0xf];
-                               hex_buffer[2 * i + 1] = DIGITS[t & 0xf];
-                       }
-
-                       retval = gdb_put_packet(connection, hex_buffer, len * 2);
+               if (strncmp(packet, "jc", 2) == 0) {
+                       const uint32_t len = sizeof(target->gdb_service->core[0]);
+                       char hex_buffer[len * 2 + 1];
+                       char buffer[len];
+                       buf_set_u32(buffer, 0, len * 8, target->gdb_service->core[0]);
+                       int pkt_len = hexify(hex_buffer, buffer, sizeof(buffer), sizeof(hex_buffer));
 
-                       free(hex_buffer);
+                       retval = gdb_put_packet(connection, hex_buffer, pkt_len);
                }
        } else
                retval = gdb_put_packet(connection, "E01", 3);
@@ -95,7 +86,7 @@ int gdb_write_smp_packet(struct connection *connection,
 
        /* skip command character */
        if (target->smp) {
-               if (strstr(packet, "Jc")) {
+               if (strncmp(packet, "Jc", 2) == 0) {
                        packet += 2;
                        coreid = strtoul(packet, &separator, 16);
                        target->gdb_service->core[1] = coreid;