]> git.sur5r.net Git - u-boot/commit
sf: fix timebase data type in _wait_ready()
authorStephen Warren <swarren@nvidia.com>
Mon, 4 Apr 2016 17:03:52 +0000 (11:03 -0600)
committerTom Rini <trini@konsulko.com>
Mon, 25 Apr 2016 19:10:30 +0000 (15:10 -0400)
commit11b9a4d8d96674a57ff61ce622b0900ebee1392d
treeed069258a2aa831dc44981d239e6163860c26017
parentef5ebe951bec72631cdbc7cef9079e6c684e5d0b
sf: fix timebase data type in _wait_ready()

get_timer() returns an unsigned 64-bit value, but is currently assigned to
a signed 32-bit variable. Due to sign extension and data truncation, this
causes the timeout loop in spi_flash_cmd_wait_ready() to immediately (and
incorrectly) fire for about 50% of all time values, based on whether bit
31 is set. In sandbox at least, this causes the test to pass or fail based
on system uptime, as opposed to time since the U-Boot binary was started.

Fixes: 4efad20a1751 ("sf: Update status reg check in spi_flash_cmd_wait_ready")
Signed-off-by: Stephen Warren <swarren@nvidia.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Jagan Teki <jteki@openedev.com>
drivers/mtd/spi/spi_flash.c