]> git.sur5r.net Git - u-boot/commit
hush: fix segfault on syntax error
authorRabin Vincent <rabin@rab.in>
Wed, 29 Oct 2014 22:21:40 +0000 (23:21 +0100)
committerTom Rini <trini@ti.com>
Fri, 7 Nov 2014 21:27:06 +0000 (16:27 -0500)
commit128059b926b3c34bbb364dcacd8d0511ff906be8
tree5aad33bca41205ea21577dfaddceb01858e87ddb
parent484408fb5194586b6ba6251f15cbae0c445c3bf5
hush: fix segfault on syntax error

Hush segfaults if it sees a syntax error while attempting to parse a
command:

 $ ./u-boot -c "'"
 ...
 syntax error
 Segmentation fault (core dumped)

This is due to a NULL pointer dereference of in_str->p in static_peek().
The problem is that the exit condition for the loop in
parse_stream_outer() checks for rcode not being -1, but rcode is only
ever 0 or 1.

Signed-off-by: Rabin Vincent <rabin@rab.in>
Acked-by: Simon Glass <sjg@chromium.org)
Tested-by: Simon Glass <sjg@chromium.org)
common/cli_hush.c