]> git.sur5r.net Git - u-boot/commit
Fix bad return value checks (detected with Coccinelle)
authorThomas Huth <huth@tuxfamily.org>
Tue, 25 Aug 2015 15:09:40 +0000 (17:09 +0200)
committerTom Rini <trini@konsulko.com>
Sat, 24 Oct 2015 17:50:30 +0000 (13:50 -0400)
commit310ae37edb3becedf5da904201f3439ea42ab12f
tree6d30471b538ed5718134a24220e6b7ccb20c2908
parentbff78567da51eee433e0e76a87edc5f0a03a0d8d
Fix bad return value checks (detected with Coccinelle)

In the "Getting Started with Coccinelle - KVM edition" presentation that
has been held by Julia Lawall at the KVM forum 2015 (see the slides at
http://events.linuxfoundation.org/sites/events/files/slides/tutorial_kvm_0.pdf),
she pointed out some bad return value checks in U-Boot that can be
detected with Coccinelle by using the following config file:

@@
identifier x,y;
identifier f;
statement S;
@@
x = f(...);
(
 if (x < 0) S
|
 if (
-     y
+     x
 < 0) S
)

This patch now fixes these issues.

Signed-off-by: Thomas Huth <huth@tuxfamily.org>
board/samsung/origen/tools/mkorigenspl.c
board/samsung/smdkv310/tools/mksmdkv310spl.c
drivers/hwmon/lm81.c
tools/fit_check_sign.c
tools/mkexynosspl.c