]> git.sur5r.net Git - u-boot/commit
cmd_eeprom: bug fix for i2c read/write
authorKuo-Jung Su <dantesu@faraday-tech.com>
Mon, 2 Dec 2013 08:02:59 +0000 (16:02 +0800)
committerHeiko Schocher <hs@denx.de>
Thu, 5 Dec 2013 11:25:01 +0000 (12:25 +0100)
commit6ca6d080d6c75a88709e8ba8d1e6d776bc01b68d
tree739d9567d9e8c0d6ffa0622174d82e60f4d9612a
parentc727618d2cee0b848e5349ec923a5ef0bc3f0447
cmd_eeprom: bug fix for i2c read/write

The local pointer of address (i.e., addr) only gets
referenced under SPI mode, and it won't be appropriate
to pass only 1-byte addr[1] to i2c_read/i2c_write while
CONFIG_SYS_I2C_EEPROM_ADDR_LEN > 1.

1. In U-boot's I2C model, the address would be re-assembled
   to a byte string in MSB order inside I2C controller drivers.

2. The 'CONFIG_SYS_I2C_EEPROM_ADDR_OVERFLOW' option which could
   be found at soft_i2c.c is always turned on in cmd_eeprom.c,
   the addr[0] always contains the device address with overflowed
   MSB address bits.

Signed-off-by: Kuo-Jung Su <dantesu@faraday-tech.com>
Cc: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
cc: Peter Tyser <ptyser@xes-inc.com>
Cc: Heiko Schocher <hs@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Stefan Roese <sr@denx.de>
Cc: Mischa Jonker <mjonker@synopsys.com>
common/cmd_eeprom.c