]> git.sur5r.net Git - u-boot/commit
sunxi: rsb: Enable R_PIO clock before configuring external pins
authorChen-Yu Tsai <wens@csie.org>
Tue, 23 Jun 2015 11:57:24 +0000 (19:57 +0800)
committerHans de Goede <hdegoede@redhat.com>
Sun, 5 Jul 2015 09:32:11 +0000 (11:32 +0200)
commitdec7c84227339cda4bf6c7d9a411ea189473112d
treee1dbe832018ddbef8df7792ef221c9b5cb588c3c
parent6ad8c743001c1114c5921f78c17e6fb43d4b6ca0
sunxi: rsb: Enable R_PIO clock before configuring external pins

The original code was configuring the external pins after enabling
the R_PIO clock, which meant the configuration never made it to
the pin controller the first time in SPL.

Why this was working before is uncertain. Maybe the state was left
from a previous boot sequence, or RSB just happened to be the default
configuration. However with some A33 chips, SPL failed to configure
the PMIC. This was seen by me and Maxime on the Sinlinx SinA33 dev
board.

Reordering the calls fixed this.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Tested-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
arch/arm/cpu/armv7/sunxi/rsb.c