]> git.sur5r.net Git - openocd/commitdiff
flash/nor/kinetis_ke: fix warning retval set but not used
authorTomas Vanek <vanekt@fbl.cz>
Sun, 21 Jan 2018 09:47:32 +0000 (10:47 +0100)
committerTomas Vanek <vanekt@fbl.cz>
Sun, 4 Feb 2018 21:44:27 +0000 (21:44 +0000)
I see no reason for not returning error from target_run_algorithm()
to higher level.

Reported by Clang static analyzer.

Change-Id: Iaaa8b66e487ecae88c0cf4ae2addba63341c032c
Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-on: http://openocd.zylin.com/4391
Tested-by: jenkins
Reviewed-by: Ivan Meleca <ivan@artekit.eu>
src/flash/nor/kinetis_ke.c

index 636fcc2e9383242cd831e626dd987acfa5b79721..b7a6a1ece15da6e78c79e7776243c1042dbfad93 100644 (file)
@@ -478,14 +478,13 @@ int kinetis_ke_stop_watchdog(struct target *target)
                        watchdog_algorithm->address, 0, 100000, &armv7m_info);
        if (retval != ERROR_OK) {
                LOG_ERROR("Error executing Kinetis KE watchdog algorithm");
-               retval = ERROR_FAIL;
        } else {
                LOG_INFO("Watchdog stopped");
        }
 
        target_free_working_area(target, watchdog_algorithm);
 
-       return ERROR_OK;
+       return retval;
 }
 
 COMMAND_HANDLER(kinetis_ke_disable_wdog_handler)