jtag: drivers: stlink: ignore write verify error

This looks like some inappropriate stlink (mis-)feature and it messes
operations for writing to certain memory-mapped registers.

Discussed at https://forum.sparkfun.com/viewtopic.php?f=18&t=44949 .
Also known to be problematic for working with Kinetis parts.

Reported by robertfoss_ on IRC.

Change-Id: I8633aed13346c596000ba6c377758e1bb96db73f
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Reviewed-on: http://openocd.zylin.com/4368
Tested-by: jenkins
Reviewed-by: Robert Foss <robert.foss@memcpy.io>
Reviewed-by: Andreas Bolsch <hyphen0break@gmail.com>
Reviewed-by: Freddie Chopin <freddie.chopin@gmail.com>

diff --git a/src/jtag/drivers/stlink_usb.c b/src/jtag/drivers/stlink_usb.c
index 6f720b86b3ad2bbecbf224fe216caa0886d1938c..99f96b9c9c9c521678d2835e1a8cd79f866d5f81 100644 (file)
--- a/src/jtag/drivers/stlink_usb.c
+++ b/src/jtag/drivers/stlink_usb.c
@@ -457,8 +457,8 @@ static int stlink_usb_error_check(void *handle)
                        LOG_DEBUG("Write error");
                        return ERROR_FAIL;
                case STLINK_JTAG_WRITE_VERIF_ERROR:
-                       LOG_DEBUG("Verify error");
-                       return ERROR_FAIL;
+                       LOG_DEBUG("Write verify error, ignoring");
+                       return ERROR_OK;
                case STLINK_SWD_AP_FAULT:
                        /* git://git.ac6.fr/openocd commit 657e3e885b9ee10
                         * returns ERROR_OK with the comment: