dm: scsi: Adjust the 'scsi' command to use blk_common_cmd()

Instead of having separate code in the 'scsi' command, adjust it to use
the common function.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

diff --git a/cmd/scsi.c b/cmd/scsi.c
index 8e36de107e9a91a01376164accfdb96c4fd235a0..b9d086fb6b1943130193d02b20aef5d4905286f5 100644 (file)
--- a/cmd/scsi.c
+++ b/cmd/scsi.c
@@ -29,11 +29,7 @@ static int do_scsi(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
 {
        int ret;
 
-       switch (argc) {
-       case 0:
-       case 1:
-               return CMD_RET_USAGE;
-       case 2:
+       if (argc == 2) {
                if (strncmp(argv[1], "res", 3) == 0) {
                        printf("\nReset SCSI\n");
 #ifndef CONFIG_DM_SCSI
@@ -44,84 +40,15 @@ static int do_scsi(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
                                return CMD_RET_FAILURE;
                        return ret;
                }
-               if (strncmp(argv[1], "inf", 3) == 0) {
-                       blk_list_devices(IF_TYPE_SCSI);
-                       return 0;
-               }
-               if (strncmp(argv[1], "dev", 3) == 0) {
-                       if (blk_print_device_num(IF_TYPE_SCSI, scsi_curr_dev)) {
-                               printf("\nno SCSI devices available\n");
-                               return CMD_RET_FAILURE;
-                       }
-
-                       return 0;
-               }
                if (strncmp(argv[1], "scan", 4) == 0) {
                        ret = scsi_scan(true);
                        if (ret)
                                return CMD_RET_FAILURE;
                        return ret;
                }
-               if (strncmp(argv[1], "part", 4) == 0) {
-                       if (blk_list_part(IF_TYPE_SCSI))
-                               printf("\nno SCSI devices available\n");
-                       return 0;
-               }
-               return CMD_RET_USAGE;
-       case 3:
-               if (strncmp(argv[1], "dev", 3) == 0) {
-                       int dev = (int)simple_strtoul(argv[2], NULL, 10);
+       }
 
-                       if (!blk_show_device(IF_TYPE_SCSI, dev)) {
-                               scsi_curr_dev = dev;
-                               printf("... is now current device\n");
-                       } else {
-                               return CMD_RET_FAILURE;
-                       }
-                       return 0;
-               }
-               if (strncmp(argv[1], "part", 4) == 0) {
-                       int dev = (int)simple_strtoul(argv[2], NULL, 10);
-
-                       if (blk_print_part_devnum(IF_TYPE_SCSI, dev)) {
-                               printf("\nSCSI device %d not available\n",
-                                      dev);
-                               return CMD_RET_FAILURE;
-                       }
-                       return 0;
-               }
-               return CMD_RET_USAGE;
-       default:
-               /* at least 4 args */
-               if (strcmp(argv[1], "read") == 0) {
-                       ulong addr = simple_strtoul(argv[2], NULL, 16);
-                       ulong blk  = simple_strtoul(argv[3], NULL, 16);
-                       ulong cnt  = simple_strtoul(argv[4], NULL, 16);
-                       ulong n;
-
-                       printf("\nSCSI read: device %d block # %ld, count %ld ... ",
-                              scsi_curr_dev, blk, cnt);
-                       n = blk_read_devnum(IF_TYPE_SCSI, scsi_curr_dev, blk,
-                                           cnt, (ulong *)addr);
-                       printf("%ld blocks read: %s\n", n,
-                              n == cnt ? "OK" : "ERROR");
-                       return 0;
-               } else if (strcmp(argv[1], "write") == 0) {
-                       ulong addr = simple_strtoul(argv[2], NULL, 16);
-                       ulong blk = simple_strtoul(argv[3], NULL, 16);
-                       ulong cnt = simple_strtoul(argv[4], NULL, 16);
-                       ulong n;
-
-                       printf("\nSCSI write: device %d block # %ld, count %ld ... ",
-                              scsi_curr_dev, blk, cnt);
-                       n = blk_write_devnum(IF_TYPE_SCSI, scsi_curr_dev, blk,
-                                            cnt, (ulong *)addr);
-                       printf("%ld blocks written: %s\n", n,
-                              n == cnt ? "OK" : "ERROR");
-                       return 0;
-               }
-       } /* switch */
-       return CMD_RET_USAGE;
+       return blk_common_cmd(argc, argv, IF_TYPE_SCSI, &scsi_curr_dev);
 }
 
 U_BOOT_CMD(