spl: spl_mmc: MMC boot mode provisions checks

This allows using only one of either raw or fs mode for SPL mmc boot, without
the need to have provisions for the other. In particular, a device may have
U-Boot installed on a file system on the mmc, without ever needing to read
U-Boot from raw memory. Thus, there is no reason to provide a sector or
partition for raw mode. This allows this behaviour and still provides a robust
fallback mechanism in case provisions for both modes are defined.

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>

diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c
index f5ac844c0a3a0bf95e8413960eeab3311f0b6289..552f80d1e3dd761dd3101e66f6d01d97bf683004 100644 (file)
--- a/common/spl/spl_mmc.c
+++ b/common/spl/spl_mmc.c
@@ -130,19 +130,21 @@ void spl_mmc_load_image(void)
                                return;
                }
 #endif
-#ifdef CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION
+#if defined(CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION)
                err = mmc_load_image_raw_partition(mmc,
                        CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION);
-#else
+               if (!err)
+                       return;
+#elif defined(CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR)
                err = mmc_load_image_raw_sector(mmc,
                        CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR);
-#endif
                if (!err)
                        return;
-#if defined(CONFIG_SPL_FAT_SUPPORT) || defined(CONFIG_SPL_EXT_SUPPORT)
+#endif
        case MMCSD_MODE_FS:
                debug("spl: mmc boot mode: fs\n");
 
+#ifdef CONFIG_SYS_MMCSD_FS_BOOT_PARTITION
 #ifdef CONFIG_SPL_FAT_SUPPORT
 #ifdef CONFIG_SPL_OS_BOOT
                if (!spl_start_uboot()) {
@@ -152,12 +154,14 @@ void spl_mmc_load_image(void)
                                return;
                }
 #endif
+#ifdef CONFIG_SPL_FS_LOAD_PAYLOAD_NAME
                err = spl_load_image_fat(&mmc->block_dev,
                                         CONFIG_SYS_MMCSD_FS_BOOT_PARTITION,
                                         CONFIG_SPL_FS_LOAD_PAYLOAD_NAME);
                if (!err)
                        return;
 #endif
+#endif
 #ifdef CONFIG_SPL_EXT_SUPPORT
 #ifdef CONFIG_SPL_OS_BOOT
                if (!spl_start_uboot()) {
@@ -167,6 +171,7 @@ void spl_mmc_load_image(void)
                                return;
                }
 #endif
+#ifdef CONFIG_SPL_FS_LOAD_PAYLOAD_NAME
                err = spl_load_image_ext(&mmc->block_dev,
                                         CONFIG_SYS_MMCSD_FS_BOOT_PARTITION,
                                         CONFIG_SPL_FS_LOAD_PAYLOAD_NAME);
@@ -174,6 +179,7 @@ void spl_mmc_load_image(void)
                        return;
 #endif
 #endif
+#endif
 #ifdef CONFIG_SUPPORT_EMMC_BOOT
        case MMCSD_MODE_EMMCBOOT:
                /*
@@ -200,15 +206,17 @@ void spl_mmc_load_image(void)
                                return;
                }
 #endif
-#ifdef CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION
+#if defined(CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION)
                err = mmc_load_image_raw_partition(mmc,
                        CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION);
-#else
+               if (!err)
+                       return;
+#elif defined(CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR)
                err = mmc_load_image_raw_sector(mmc,
                        CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR);
-#endif
                if (!err)
                        return;
+#endif
 #endif
        case MMCSD_MODE_UNDEFINED:
        default: