]> git.sur5r.net Git - u-boot/commitdiff
test: bus: Add a check that dev is not NULL
authorSimon Glass <sjg@chromium.org>
Wed, 7 Jun 2017 16:28:44 +0000 (10:28 -0600)
committerTom Rini <trini@konsulko.com>
Mon, 12 Jun 2017 12:38:10 +0000 (08:38 -0400)
We know that uclass_get_device() and device_find_child_by_of_offset() do
not return NULL for dev when they succeeds but coverity does not. Add an
extra check to hopefully keep it happy.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reported-by: Coverity (CID: 163246)
Fixes: 0753bc2 (dm: Simple Watchdog uclass)
test/dm/bus.c

index 8ba75d4b7d31db1fb8cd7918ff870b27a6933474..7006d4163db832632662c9214333d2cc939b46af 100644 (file)
@@ -171,13 +171,16 @@ static int dm_test_bus_children_of_offset(struct unit_test_state *uts)
        int node;
 
        ut_assertok(uclass_get_device(UCLASS_TEST_BUS, 0, &bus));
+       ut_assertnonnull(bus);
 
        /* Find a valid child */
        node = fdt_path_offset(blob, "/some-bus/c-test@1");
        ut_assert(node > 0);
        ut_assertok(device_find_child_by_of_offset(bus, node, &dev));
+       ut_assertnonnull(dev);
        ut_assert(!(dev->flags & DM_FLAG_ACTIVATED));
        ut_assertok(device_get_child_by_of_offset(bus, node, &dev));
+       ut_assertnonnull(dev);
        ut_assert(dev->flags & DM_FLAG_ACTIVATED);
 
        return 0;