]> git.sur5r.net Git - u-boot/commitdiff
Merge branch 'master' of git://git.denx.de/u-boot-ppc4xx
authorWolfgang Denk <wd@denx.de>
Mon, 13 Jul 2009 21:34:30 +0000 (23:34 +0200)
committerWolfgang Denk <wd@denx.de>
Mon, 13 Jul 2009 21:34:30 +0000 (23:34 +0200)
15 files changed:
common/cmd_ubi.c
common/cmd_ubifs.c
cpu/mpc83xx/cpu_init.c
drivers/usb/host/Makefile
drivers/usb/host/ehci-fsl.c
drivers/usb/host/ehci-hcd.c
drivers/usb/host/ehci-kirkwood.c [new file with mode: 0644]
drivers/usb/musb/musb_core.h
drivers/usb/musb/musb_hcd.c
drivers/usb/musb/musb_hcd.h
include/configs/blackstamp.h
include/configs/cm-bf561.h
include/usb/ehci-fsl.h
lib_blackfin/Makefile
lib_blackfin/cmd_cache_dump.c [new file with mode: 0644]

index bbca3892c93830b8a5cbf101ef77ca05355d398d..05893f5be57fa7c93e1e5c920295f092a92bc3fe 100644 (file)
@@ -395,11 +395,13 @@ static int ubi_volume_read(char *volume, char *buf, size_t size)
        return err ? err : count_save - size;
 }
 
-static int ubi_dev_scan(struct mtd_info *info, char *ubidev)
+static int ubi_dev_scan(struct mtd_info *info, char *ubidev,
+               const char *vid_header_offset)
 {
        struct mtd_device *dev;
        struct part_info *part;
        struct mtd_partition mtd_part;
+       char ubi_mtd_param_buffer[80];
        u8 pnum;
        int err;
 
@@ -413,7 +415,11 @@ static int ubi_dev_scan(struct mtd_info *info, char *ubidev)
        mtd_part.offset = part->offset;
        add_mtd_partitions(info, &mtd_part, 1);
 
-       err = ubi_mtd_param_parse(buffer, NULL);
+       strcpy(ubi_mtd_param_buffer, buffer);
+       if (vid_header_offset)
+               sprintf(ubi_mtd_param_buffer, "mtd=%d,%s", pnum,
+                               vid_header_offset);
+       err = ubi_mtd_param_parse(ubi_mtd_param_buffer, NULL);
        if (err) {
                del_mtd_partitions(info);
                return err;
@@ -450,6 +456,7 @@ static int do_ubi(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                char mtd_dev[16];
                struct mtd_device *dev;
                struct part_info *part;
+               const char *vid_header_offset = NULL;
                u8 pnum;
 
                /* Print current partition */
@@ -497,8 +504,11 @@ static int do_ubi(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
 
                ubi_dev.selected = 1;
 
+               if (argc > 3)
+                       vid_header_offset = argv[3];
                strcpy(ubi_dev.part_name, argv[2]);
-               err = ubi_dev_scan(ubi_dev.mtd_info, ubi_dev.part_name);
+               err = ubi_dev_scan(ubi_dev.mtd_info, ubi_dev.part_name,
+                               vid_header_offset);
                if (err) {
                        printf("UBI init error %d\n", err);
                        ubi_dev.selected = 0;
@@ -594,8 +604,9 @@ static int do_ubi(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
 
 U_BOOT_CMD(ubi, 6, 1, do_ubi,
        "ubi commands",
-       "part [part]"
-               " - Show or set current partition\n"
+       "part [part] [offset]\n"
+               " - Show or set current partition (with optional VID"
+               " header offset)\n"
        "ubi info [l[ayout]]"
                " - Display volume and ubi layout information\n"
        "ubi create[vol] volume [size] [type]"
index d9f60d51edb0a83b3ec69d96b96ff440e3d6996d..ed0e9db2ac27577ff12e7ca673f027bb60b57856 100644 (file)
@@ -47,6 +47,10 @@ int do_ubifs_mount(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
        char *vol_name;
        int ret;
 
+       if (argc != 2) {
+               cmd_usage(cmdtp);
+               return 1;
+       }
        vol_name = argv[1];
        debug("Using volume %s\n", vol_name);
 
@@ -88,6 +92,7 @@ int do_ubifs_ls(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 int do_ubifs_load(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 {
        char *filename;
+       char *endp;
        int ret;
        u32 addr;
        u32 size = 0;
@@ -98,15 +103,25 @@ int do_ubifs_load(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
        }
 
        if (argc < 3) {
-               printf("Usage:\n%s\n", cmdtp->usage);
+               cmd_usage(cmdtp);
                return -1;
        }
 
-       addr = simple_strtoul(argv[1], NULL, 16);
+       addr = simple_strtoul(argv[1], &endp, 16);
+       if (endp == argv[1]) {
+               cmd_usage(cmdtp);
+               return 1;
+       }
+
        filename = argv[2];
 
-       if (argc == 4)
-               size = simple_strtoul(argv[3], NULL, 16);
+       if (argc == 4) {
+               size = simple_strtoul(argv[3], &endp, 16);
+               if (endp == argv[3]) {
+                       cmd_usage(cmdtp);
+                       return 1;
+               }
+       }
        debug("Loading file '%s' to address 0x%08x (size %d)\n", filename, addr, size);
 
        ret = ubifs_load(filename, addr, size);
@@ -119,7 +134,8 @@ int do_ubifs_load(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 U_BOOT_CMD(
        ubifsmount, 2, 0, do_ubifs_mount,
        "mount UBIFS volume",
-       ""
+       "<volume-name>\n"
+       "    - mount 'volume-name' volume"
 );
 
 U_BOOT_CMD(ubifsls, 2, 0, do_ubifs_ls,
index 414565cb65bb94e477ae1798851a1b154f8cb68d..03b6c86349cc795299dbeb174e9e97e53943ab4e 100644 (file)
@@ -303,11 +303,11 @@ void cpu_init_f (volatile immap_t * im)
        struct usb_ehci *ehci = (struct usb_ehci *)CONFIG_SYS_MPC8xxx_USB_ADDR;
 
        /* Configure interface. */
-       setbits_be32((void *)ehci->control, REFSEL_16MHZ | UTMI_PHY_EN);
+       setbits_be32(&ehci->control, REFSEL_16MHZ | UTMI_PHY_EN);
 
        /* Wait for clock to stabilize */
        do {
-               temp = in_be32((void *)ehci->control);
+               temp = in_be32(&ehci->control);
                udelay(1000);
        } while (!(temp & PHY_CLK_VALID));
 #endif
index ec1d689b3558f3f54b2269da3158c8baa6d749b2..940d4a8b91c62ac418159468f6f701de06ad5886 100644 (file)
@@ -37,6 +37,7 @@ COBJS-$(CONFIG_USB_SL811HS) += sl811-hcd.o
 COBJS-$(CONFIG_USB_EHCI) += ehci-hcd.o
 COBJS-$(CONFIG_USB_EHCI_FSL) += ehci-fsl.o
 COBJS-$(CONFIG_USB_EHCI_IXP4XX) += ehci-ixp.o
+COBJS-$(CONFIG_USB_EHCI_KIRKWOOD) += ehci-kirkwood.o
 COBJS-$(CONFIG_USB_EHCI_PCI) += ehci-pci.o
 COBJS-$(CONFIG_USB_EHCI_VCT) += ehci-vct.o
 
index bf148c4e2429e588641739edd6a4518f46260ba6..c674929725230a9bb94b9bbe07a802ea56b7611b 100644 (file)
@@ -41,15 +41,15 @@ int ehci_hcd_init(void)
        struct usb_ehci *ehci;
 
        ehci = (struct usb_ehci *)CONFIG_SYS_MPC8xxx_USB_ADDR;
-       hccr = (struct ehci_hccr *)((uint32_t)ehci->caplength);
+       hccr = (struct ehci_hccr *)((uint32_t)&ehci->caplength);
        hcor = (struct ehci_hcor *)((uint32_t) hccr +
                        HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
 
        /* Set to Host mode */
-       setbits_le32((void *)ehci->usbmode, CM_HOST);
+       setbits_le32(&ehci->usbmode, CM_HOST);
 
-       out_be32((void *)ehci->snoop1, SNOOP_SIZE_2GB);
-       out_be32((void *)ehci->snoop2, 0x80000000 | SNOOP_SIZE_2GB);
+       out_be32(&ehci->snoop1, SNOOP_SIZE_2GB);
+       out_be32(&ehci->snoop2, 0x80000000 | SNOOP_SIZE_2GB);
 
        /* Init phy */
        if (!strcmp(getenv("usb_phy_type"), "utmi"))
@@ -58,13 +58,13 @@ int ehci_hcd_init(void)
                out_le32(&(hcor->or_portsc[0]), PORT_PTS_ULPI);
 
        /* Enable interface. */
-       setbits_be32((void *)ehci->control, USB_EN);
+       setbits_be32(&ehci->control, USB_EN);
 
-       out_be32((void *)ehci->prictrl, 0x0000000c);
-       out_be32((void *)ehci->age_cnt_limit, 0x00000040);
-       out_be32((void *)ehci->sictrl, 0x00000001);
+       out_be32(&ehci->prictrl, 0x0000000c);
+       out_be32(&ehci->age_cnt_limit, 0x00000040);
+       out_be32(&ehci->sictrl, 0x00000001);
 
-       in_le32((void *)ehci->usbmode);
+       in_le32(&ehci->usbmode);
 
        return 0;
 }
index bbd547b3e357fb8011702d34d9a26c9b546e5a27..423ea5d814f72db68a097c2f377ca8bf234fb0c4 100644 (file)
@@ -716,7 +716,7 @@ ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer,
                        goto unknown;
                }
                /* unblock posted writes */
-               ehci_readl(&hcor->or_usbcmd);
+               (void) ehci_readl(&hcor->or_usbcmd);
                break;
        case USB_REQ_CLEAR_FEATURE | ((USB_DIR_OUT | USB_RT_PORT) << 8):
                reg = ehci_readl(status_reg);
@@ -745,7 +745,7 @@ ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer,
                }
                ehci_writel(status_reg, reg);
                /* unblock posted write */
-               ehci_readl(&hcor->or_usbcmd);
+               (void) ehci_readl(&hcor->or_usbcmd);
                break;
        default:
                debug("Unknown request\n");
diff --git a/drivers/usb/host/ehci-kirkwood.c b/drivers/usb/host/ehci-kirkwood.c
new file mode 100644 (file)
index 0000000..64997b8
--- /dev/null
@@ -0,0 +1,108 @@
+/*
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Written-by: Prafulla Wadaskar <prafulla@marvell.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#include <common.h>
+#include <asm/io.h>
+#include <usb.h>
+#include "ehci.h"
+#include "ehci-core.h"
+#include <asm/arch/kirkwood.h>
+
+#define rdl(off)       readl(KW_USB20_BASE + (off))
+#define wrl(off, val)  writel((val), KW_USB20_BASE + (off))
+
+#define USB_WINDOW_CTRL(i)     (0x320 + ((i) << 4))
+#define USB_WINDOW_BASE(i)     (0x324 + ((i) << 4))
+#define USB_TARGET_DRAM                0x0
+
+/*
+ * USB 2.0 Bridge Address Decoding registers setup
+ */
+static void usb_brg_adrdec_setup(void)
+{
+       int i;
+       u32 size, attrib;
+
+       for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
+
+               /* Enable DRAM bank */
+               switch (i) {
+               case 0:
+                       attrib = KWCPU_ATTR_DRAM_CS0;
+                       break;
+               case 1:
+                       attrib = KWCPU_ATTR_DRAM_CS1;
+                       break;
+               case 2:
+                       attrib = KWCPU_ATTR_DRAM_CS2;
+                       break;
+               case 3:
+                       attrib = KWCPU_ATTR_DRAM_CS3;
+                       break;
+               default:
+                       /* invalide bank, disable access */
+                       attrib = 0;
+                       break;
+               }
+
+               size = kw_sdram_bs(i);
+               if ((size) && (attrib))
+                       wrl(USB_WINDOW_CTRL(i),
+                               KWCPU_WIN_CTRL_DATA(size, USB_TARGET_DRAM,
+                                       attrib, KWCPU_WIN_ENABLE));
+               else
+                       wrl(USB_WINDOW_CTRL(i), KWCPU_WIN_DISABLE);
+
+               wrl(USB_WINDOW_BASE(i), kw_sdram_bar(i));
+       }
+}
+
+/*
+ * Create the appropriate control structures to manage
+ * a new EHCI host controller.
+ */
+int ehci_hcd_init(void)
+{
+       usb_brg_adrdec_setup();
+
+       hccr = (struct ehci_hccr *)(KW_USB20_BASE + 0x100);
+       hcor = (struct ehci_hcor *)((uint32_t) hccr
+                       + HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
+
+       debug("Kirkwood-ehci: init hccr %x and hcor %x hc_length %d\n",
+               (uint32_t)hccr, (uint32_t)hcor,
+               (uint32_t)HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
+
+       return 0;
+}
+
+/*
+ * Destroy the appropriate control structures corresponding
+ * the the EHCI host controller.
+ */
+int ehci_hcd_stop(void)
+{
+       return 0;
+}
+
index b81c5365ec1d72bf5daa52b28c77f77c4df29969..f9da3f0b29b28766c37ee468ba917a52124d466b 100644 (file)
@@ -307,10 +307,4 @@ extern void musb_configure_ep(struct musb_epinfo *epinfo, u8 cnt);
 extern void write_fifo(u8 ep, u32 length, void *fifo_data);
 extern void read_fifo(u8 ep, u32 length, void *fifo_data);
 
-/* extern functions */
-extern inline void musb_writew(u32 offset, u16 value);
-extern inline void musb_writeb(u32 offset, u8 value);
-extern inline u16 musb_readw(u32 offset);
-extern inline u8 musb_readb(u32 offset);
-
 #endif /* __MUSB_HDRC_DEFS_H__ */
index 352a0d4eb084851c8e7a6c65c76f5fc1a762b108..19d978b245a0f82367d9fa2fa2c53085e6a63be7 100644 (file)
@@ -111,6 +111,7 @@ static int wait_until_ep0_ready(struct usb_device *dev, u32 bit_mask)
 {
        u16 csr;
        int result = 1;
+       int timeout = CONFIG_MUSB_TIMEOUT;
 
        while (result > 0) {
                csr = readw(&musbr->txcsr);
@@ -152,7 +153,17 @@ static int wait_until_ep0_ready(struct usb_device *dev, u32 bit_mask)
                        }
                        break;
                }
+
+               /* Check the timeout */
+               if (--timeout)
+                       udelay(1);
+               else {
+                       dev->status = USB_ST_CRC_ERR;
+                       result = -1;
+                       break;
+               }
        }
+
        return result;
 }
 
@@ -162,6 +173,7 @@ static int wait_until_ep0_ready(struct usb_device *dev, u32 bit_mask)
 static u8 wait_until_txep_ready(struct usb_device *dev, u8 ep)
 {
        u16 csr;
+       int timeout = CONFIG_MUSB_TIMEOUT;
 
        do {
                if (check_stall(ep, 1)) {
@@ -174,6 +186,15 @@ static u8 wait_until_txep_ready(struct usb_device *dev, u8 ep)
                        dev->status = USB_ST_CRC_ERR;
                        return 0;
                }
+
+               /* Check the timeout */
+               if (--timeout)
+                       udelay(1);
+               else {
+                       dev->status = USB_ST_CRC_ERR;
+                       return -1;
+               }
+
        } while (csr & MUSB_TXCSR_TXPKTRDY);
        return 1;
 }
@@ -184,6 +205,7 @@ static u8 wait_until_txep_ready(struct usb_device *dev, u8 ep)
 static u8 wait_until_rxep_ready(struct usb_device *dev, u8 ep)
 {
        u16 csr;
+       int timeout = CONFIG_MUSB_TIMEOUT;
 
        do {
                if (check_stall(ep, 0)) {
@@ -196,6 +218,15 @@ static u8 wait_until_rxep_ready(struct usb_device *dev, u8 ep)
                        dev->status = USB_ST_CRC_ERR;
                        return 0;
                }
+
+               /* Check the timeout */
+               if (--timeout)
+                       udelay(1);
+               else {
+                       dev->status = USB_ST_CRC_ERR;
+                       return -1;
+               }
+
        } while (!(csr & MUSB_RXCSR_RXPKTRDY));
        return 1;
 }
index bb83311b0142c4fdb9a7ade8591574626a5ca6e1..b7f571d03771753895b473c41af8b4cacfe03a60 100644 (file)
 extern unsigned char new[];
 #endif
 
+#ifndef CONFIG_MUSB_TIMEOUT
+# define CONFIG_MUSB_TIMEOUT 100000
+#endif
+
 /* This defines the endpoint number used for control transfers */
 #define MUSB_CONTROL_EP 0
 
index 1e4c716139a00be920bc1cbed98bd7574d5770c1..887f3fb3a348338c445f0f7bb9515ffb3c89e553 100644 (file)
 #endif
 
 #define CONFIG_ENV_IS_IN_SPI_FLASH
-#define CONFIG_ENV_OFFSET      0x4000
+#define CONFIG_ENV_OFFSET      0x40000
 #define CONFIG_ENV_SIZE                0x2000
 #define CONFIG_ENV_SECT_SIZE   0x40000
-#define ENV_IS_EMBEDDED_CUSTOM
 
 /*
  * SDRAM settings & memory map
  * Serial Flash Infomation
  */
 #define CONFIG_BFIN_SPI
-/* For the M25P64 SCK Should be Kept < 20Mhz */
-#define CONFIG_ENV_SPI_MAX_HZ  20000000
-#define CONFIG_SF_DEFAULT_SPEED        20000000
+/* For the M25P64 SCK Should be Kept < 15Mhz */
+#define CONFIG_ENV_SPI_MAX_HZ  15000000
+#define CONFIG_SF_DEFAULT_SPEED        15000000
 #define CONFIG_SPI_FLASH
 #define CONFIG_SPI_FLASH_STMICRO
 
index 53a25807aef4f748e3470e0a13258b6ef9218341..1153f111d34aefd89dbd8657a7559db0bc1d262c 100644 (file)
  * Network Settings
  */
 #define ADI_CMDS_NETWORK       1
+/* The next 2 lines are for use with DEV-BF5xx */
 #define CONFIG_DRIVER_SMC91111 1
 #define CONFIG_SMC91111_BASE   0x28000300
+/* The next 3 lines are for use with EXT-BF5xx-USB-ETH2 */
+/* #define CONFIG_DRIVER_SMC911X 1 */
+/* #define CONFIG_DRIVER_SMC911X_BASE 0x24080000 // AMS1 */
+/* #define CONFIG_DRIVER_SMC911X_32_BIT 1 */
 #define CONFIG_HOSTNAME                cm-bf561
 /* Uncomment next line to use fixed MAC address */
 /* #define CONFIG_ETHADDR      02:80:ad:20:31:cf */
index 114056177c2768eae173cee7f5bcd374f8950fd4..3b99456227303da3dab3925203b0e1c911dcd8e4 100644 (file)
@@ -85,7 +85,7 @@
 #define MPC83XX_SCCR_USB_DRCM_01       0x00100000
 #define MPC83XX_SCCR_USB_DRCM_10       0x00200000
 
-#if defined(CONFIG_MPC83XX)
+#if defined(CONFIG_MPC83xx)
 #define CONFIG_SYS_MPC8xxx_USB_ADDR CONFIG_SYS_MPC83xx_USB_ADDR
 #elif defined(CONFIG_MPC85xx)
 #define CONFIG_SYS_MPC8xxx_USB_ADDR CONFIG_SYS_MPC85xx_USB_ADDR
index e32ecc92d355c84ca3084eedff882f9459324d61..4bdf6d34ce87e3d4dba96d178c7df607a3cc6f5b 100644 (file)
@@ -40,6 +40,7 @@ COBJS-y       += board.o
 COBJS-y        += boot.o
 COBJS-y        += cache.o
 COBJS-y        += clocks.o
+COBJS-$(CONFIG_CMD_CACHE_DUMP) += cmd_cache_dump.o
 COBJS-y        += muldi3.o
 COBJS-$(CONFIG_POST) += post.o tests.o
 COBJS-y        += string.o
diff --git a/lib_blackfin/cmd_cache_dump.c b/lib_blackfin/cmd_cache_dump.c
new file mode 100644 (file)
index 0000000..de5840e
--- /dev/null
@@ -0,0 +1,145 @@
+/*
+ * U-boot - cmd_cache_dump.c
+ *
+ * Copyright (c) 2007-2008 Analog Devices Inc.
+ *
+ * Licensed under the GPL-2 or later.
+ */
+
+#include <config.h>
+#include <common.h>
+#include <command.h>
+
+#include <asm/blackfin.h>
+#include <asm/mach-common/bits/mpu.h>
+
+static int check_limit(const char *type, size_t start_limit, size_t end_limit, size_t start, size_t end)
+{
+       if (start >= start_limit && start <= end_limit && \
+           end <= end_limit && end >= start_limit && \
+           start <= end)
+               return 0;
+
+       printf("%s limit violation: %zu <= (user:%zu) <= (user:%zu) <= %zu\n",
+               type, start_limit, start, end, end_limit);
+       return 1;
+}
+
+int do_icache_dump(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+{
+       int cache_status = icache_status();
+
+       if (cache_status)
+               icache_disable();
+
+       uint32_t cmd_base, tag, cache_upper, cache_lower;
+
+       size_t way, way_start = 0, way_end = 3;
+       size_t sbnk, sbnk_start = 0, sbnk_end = 3;
+       size_t set, set_start = 0, set_end = 31;
+       size_t dw;
+
+       if (argc > 1) {
+               way_start = way_end = simple_strtoul(argv[1], NULL, 10);
+               if (argc > 2) {
+                       sbnk_start = sbnk_end = simple_strtoul(argv[2], NULL, 10);
+                       if (argc > 3)
+                               set_start = set_end = simple_strtoul(argv[3], NULL, 10);
+               }
+       }
+
+       if (check_limit("way", 0, 3, way_start, way_end) || \
+           check_limit("subbank", 0, 3, sbnk_start, sbnk_end) || \
+           check_limit("set", 0, 31, set_start, set_end))
+               return 1;
+
+       puts("Way:Subbank:Set: [valid-tag lower upper] {invalid-tag lower upper}...\n");
+
+       for (way = way_start; way <= way_end; ++way) {
+               for (sbnk = sbnk_start; sbnk <= sbnk_end; ++sbnk) {
+                       for (set = set_start; set <= set_end; ++set) {
+                               printf("%zu:%zu:%2zu: ", way, sbnk, set);
+                               for (dw = 0; dw < 4; ++dw) {
+                                       if (ctrlc())
+                                               return 1;
+
+                                       cmd_base = \
+                                               (way  << 26) | \
+                                               (sbnk << 16) | \
+                                               (set  <<  5) | \
+                                               (dw   <<  3);
+
+                                       /* first read the tag */
+                                       bfin_write_ITEST_COMMAND(cmd_base | 0x0);
+                                       SSYNC();
+                                       tag = bfin_read_ITEST_DATA0();
+                                       printf("%c%08x ", (tag & 0x1 ? ' ' : '{'), tag);
+
+                                       /* grab the data at this loc */
+                                       bfin_write_ITEST_COMMAND(cmd_base | 0x4);
+                                       SSYNC();
+                                       cache_lower = bfin_read_ITEST_DATA0();
+                                       cache_upper = bfin_read_ITEST_DATA1();
+                                       printf("%08x %08x%c ", cache_lower, cache_upper, (tag & 0x1 ? ' ' : '}'));
+                               }
+                               puts("\n");
+                       }
+               }
+       }
+
+       if (cache_status)
+               icache_enable();
+
+       return 0;
+}
+
+U_BOOT_CMD(icache_dump, 4, 0, do_icache_dump,
+       "icache_dump - dump current instruction cache\n",
+       "[way] [subbank] [set]");
+
+int do_dcache_dump(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+{
+       u32 way, bank, subbank, set;
+       u32 status, addr;
+       u32 dmem_ctl = bfin_read_DMEM_CONTROL();
+
+       for (bank = 0; bank < 2; ++bank) {
+               if (!(dmem_ctl & (1 << (DMC1_P - bank))))
+                       continue;
+
+               for (way = 0; way < 2; ++way)
+                       for (subbank = 0; subbank < 4; ++subbank) {
+                               printf("%i:%i:%i:\t", bank, way, subbank);
+                               for (set = 0; set < 64; ++set) {
+
+                                       if (ctrlc())
+                                               return 1;
+
+                                       /* retrieve a cache tag */
+                                       bfin_write_DTEST_COMMAND(
+                                               way << 26 |
+                                               bank << 23 |
+                                               subbank << 16 |
+                                               set << 5
+                                       );
+                                       CSYNC();
+                                       status = bfin_read_DTEST_DATA0();
+
+                                       /* construct the address using the tag */
+                                       addr = (status & 0xFFFFC800) | (subbank << 12) | (set << 5);
+
+                                       /* show it */
+                                       if (set && !(set % 4))
+                                               puts("\n\t");
+                                       printf("%c%08x%c%08x%c ", (status & 0x1 ? '[' : '{'), status, (status & 0x2 ? 'd' : ' '), addr, (status & 0x1 ? ']' : '}'));
+                               }
+                               puts("\n");
+                       }
+       }
+
+       return 0;
+}
+
+U_BOOT_CMD(dcache_dump, 4, 0, do_dcache_dump,
+       "dcache_dump - dump current data cache\n",
+       "[bank] [way] [subbank] [set]");