]> git.sur5r.net Git - u-boot/commitdiff
fsl-ddr: Fix two bugs in the ddr infrastructure
authorDave Liu <daveliu@freescale.com>
Sat, 14 Mar 2009 04:48:19 +0000 (12:48 +0800)
committerKumar Gala <galak@kernel.crashing.org>
Mon, 30 Mar 2009 18:33:50 +0000 (13:33 -0500)
1. wr_lat
   UM said the total write latency for DDR2 is equal to
   WR_LAT + ADD_LAT, the write latency is CL + ADD_LAT - 1.
   so, the WR_LAT = CL - 1;
2. rd_to_pre
   we missed to add the ADD_LAT for DDR2 case.

Reported-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Signed-off-by: Dave Liu <daveliu@freescale.com>
cpu/mpc8xxx/ddr/ctrl_regs.c

index 292980d0b073a885a440fd683a61161d0017f7e2..4c1498c8c6e7877bf6a6bfe7384e4f6369844cc2 100644 (file)
@@ -302,12 +302,15 @@ static void set_timing_cfg_2(fsl_ddr_cfg_regs_t *ddr,
         */
        wr_lat = 0;
 #elif defined(CONFIG_FSL_DDR2)
-       wr_lat = cas_latency + additive_latency - 1;
+       wr_lat = cas_latency - 1;
 #else
 #error "Fix WR_LAT for DDR3"
 #endif
 
        rd_to_pre = picos_to_mclk(common_dimm->tRTP_ps);
+#if defined(CONFIG_FSL_DDR2)
+       rd_to_pre += additive_latency;
+#endif
        wr_data_delay = popts->write_data_delay;
        cke_pls = picos_to_mclk(popts->tCKE_clock_pulse_width_ps);
        four_act = picos_to_mclk(popts->tFAW_window_four_activates_ps);