]> git.sur5r.net Git - u-boot/commitdiff
itest: add missing break statements to evalexp()
authorStephen Warren <swarren@nvidia.com>
Tue, 17 Nov 2015 17:29:08 +0000 (10:29 -0700)
committerTom Rini <trini@konsulko.com>
Wed, 18 Nov 2015 20:29:00 +0000 (15:29 -0500)
The commit mentioned below replaced return statements inside a switch so
that other code could be called after the switch. However, it didn't add
any break statements, causing the cases to run together. Fix this.

Reported-by: Coverity (CID 132282, 132283)
Fixes: 7861204c9af7 ("itest: make memory access work under sandbox")
Signed-off-by: Stephen Warren <swarren@nvidia.com>
common/cmd_itest.c

index 596341c9635ac6c1777c171fbda01186e23e02a3..91ae5c2704c882be8d4457d67d5f8488b19d2f1c 100644 (file)
@@ -64,9 +64,15 @@ static long evalexp(char *s, int w)
                        return 0;
                }
                switch (w) {
-               case 1: l = (long)(*(unsigned char *)buf);
-               case 2: l = (long)(*(unsigned short *)buf);
-               case 4: l = (long)(*(unsigned long *)buf);
+               case 1:
+                       l = (long)(*(unsigned char *)buf);
+                       break;
+               case 2:
+                       l = (long)(*(unsigned short *)buf);
+                       break;
+               case 4:
+                       l = (long)(*(unsigned long *)buf);
+                       break;
                }
                unmap_physmem(buf, w);
                return l;