]> git.sur5r.net Git - u-boot/commitdiff
rockchip: clk: rk3399: change extract_bits to bitfield_extract
authorPhilipp Tomsich <philipp.tomsich@theobroma-systems.com>
Wed, 22 Nov 2017 18:45:04 +0000 (19:45 +0100)
committerPhilipp Tomsich <philipp.tomsich@theobroma-systems.com>
Sat, 25 Nov 2017 23:39:08 +0000 (00:39 +0100)
The RK3399 clk driver still has a left-over use of extract_bits, which
can be replaced by using bitfield_extract from include/bitfield.h.
This rewrites the invocation to use the shared function.

Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
drivers/clk/rockchip/clk_rk3399.c

index e21d056efb24fe45a30dd89ebdc0562821f959b1..2e85ac7df2ce2980841b5b9a2439e78a289b89f7 100644 (file)
@@ -569,11 +569,6 @@ static const struct spi_clkreg spi_clkregs[] = {
                .sel_shift = CLK_SPI5_PLL_SEL_SHIFT, },
 };
 
-static inline u32 extract_bits(u32 val, unsigned width, unsigned shift)
-{
-       return (val >> shift) & ((1 << width) - 1);
-}
-
 static ulong rk3399_spi_get_clk(struct rk3399_cru *cru, ulong clk_id)
 {
        const struct spi_clkreg *spiclk = NULL;
@@ -590,7 +585,8 @@ static ulong rk3399_spi_get_clk(struct rk3399_cru *cru, ulong clk_id)
        }
 
        val = readl(&cru->clksel_con[spiclk->reg]);
-       div = extract_bits(val, CLK_SPI_PLL_DIV_CON_WIDTH, spiclk->div_shift);
+       div = bitfield_extract(val, spiclk->div_shift,
+                              CLK_SPI_PLL_DIV_CON_WIDTH);
 
        return DIV_TO_RATE(GPLL_HZ, div);
 }