miiphy: miiphyutil.c: fix compile warning

Fix warning introduced while recent PHY Lib changes:

miiphyutil.c: In function 'miiphy_read':
miiphyutil.c:304: warning: comparison is always false due to limited range of data type

Signed-off-by: Anatolij Gustschin <agust@denx.de>
Cc: Andy Fleming <afleming@freescale.com>

diff --git a/common/miiphyutil.c b/common/miiphyutil.c
index 243cae97a468111c68b3b155541b73a13e00877d..bcab74e73a9d769d9631310aea0791a834d447bc 100644 (file)
--- a/common/miiphyutil.c
+++ b/common/miiphyutil.c
@@ -294,14 +294,18 @@ int miiphy_read(const char *devname, unsigned char addr, unsigned char reg,
                 unsigned short *value)
 {
        struct mii_dev *bus;
+       int ret;
 
        bus = miiphy_get_active_dev(devname);
-       if (bus)
-               *value = bus->read(bus, addr, MDIO_DEVAD_NONE, reg);
-       else
+       if (!bus)
                return 1;
 
-       return (*value < 0) ? 1 : 0;
+       ret = bus->read(bus, addr, MDIO_DEVAD_NONE, reg);
+       if (ret < 0)
+               return 1;
+
+       *value = (unsigned short)ret;
+       return 0;
 }
 
 /*****************************************************************************