]> git.sur5r.net Git - u-boot/commitdiff
i2c: cmd: Relocate subcommands when MANUAL_RELOC
authorMichal Simek <michal.simek@xilinx.com>
Fri, 4 Dec 2015 15:56:57 +0000 (16:56 +0100)
committerMichal Simek <michal.simek@xilinx.com>
Mon, 7 Dec 2015 09:14:30 +0000 (10:14 +0100)
Subcommands contain pointers to functions which are not updated when
MANUAL_RELOC is enabled. This patch fix it.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Acked-by: Heiko Schocher <hs@denx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
common/cmd_i2c.c

index 3d0de81c32f8fa55df2a6a304a8d5d2516484295..552c875f62ddba9a083d686fca9d84b44fbec26c 100644 (file)
@@ -1944,11 +1944,15 @@ static cmd_tbl_t cmd_i2c_sub[] = {
        U_BOOT_CMD_MKENT(speed, 1, 1, do_i2c_bus_speed, "", ""),
 };
 
-#ifdef CONFIG_NEEDS_MANUAL_RELOC
-void i2c_reloc(void) {
-       fixup_cmdtable(cmd_i2c_sub, ARRAY_SIZE(cmd_i2c_sub));
+static __maybe_unused void i2c_reloc(void)
+{
+       static int relocated;
+
+       if (!relocated) {
+               fixup_cmdtable(cmd_i2c_sub, ARRAY_SIZE(cmd_i2c_sub));
+               relocated = 1;
+       };
 }
-#endif
 
 /**
  * do_i2c() - Handle the "i2c" command-line command
@@ -1964,6 +1968,10 @@ static int do_i2c(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
 {
        cmd_tbl_t *c;
 
+#ifdef CONFIG_NEEDS_MANUAL_RELOC
+       i2c_reloc();
+#endif
+
        if (argc < 2)
                return CMD_RET_USAGE;