]> git.sur5r.net Git - glabels/commitdiff
2009-09-21 Jim Evins <evins@snaught.com>
authorJim Evins <evins@snaught.com>
Mon, 21 Sep 2009 21:02:45 +0000 (21:02 +0000)
committerJim Evins <evins@snaught.com>
Mon, 21 Sep 2009 21:02:45 +0000 (21:02 +0000)
* po/POTFILES.in:
* data/builder/Makefile.am:
* data/builder/new-label-dialog.builder:
Removed trivial builder file for new label dialog.
* data/builder/wdgt-media-select.builder:
Changed focus behavior of widgets.
* src/new-label-dialog.c: (gl_new_label_dialog_init),
(gl_new_label_dialog_construct):
- Removed use of trivial builder file -- populate explicitely.
- Moved population code to init.
- OK button now has default focus.
- Some formatting cleanup.

git-svn-id: https://glabels.svn.sourceforge.net/svnroot/glabels/trunk@893 f5e0f49d-192f-0410-a22d-a8d8700d0965

glabels2/ChangeLog
glabels2/data/builder/Makefile.am
glabels2/data/builder/new-label-dialog.builder [deleted file]
glabels2/data/builder/wdgt-media-select.builder
glabels2/po/POTFILES.in
glabels2/src/new-label-dialog.c

index 332e78352319de8d6f3c86f6c6aa82065e955059..bda4f565c0e4f26cf227f6ad1cedeb808cde11c7 100644 (file)
@@ -1,3 +1,18 @@
+2009-09-21  Jim Evins  <evins@snaught.com>
+
+       * po/POTFILES.in:
+       * data/builder/Makefile.am:
+       * data/builder/new-label-dialog.builder:
+               Removed trivial builder file for new label dialog.
+       * data/builder/wdgt-media-select.builder:
+               Changed focus behavior of widgets.
+       * src/new-label-dialog.c: (gl_new_label_dialog_init),
+       (gl_new_label_dialog_construct):
+               - Removed use of trivial builder file -- populate explicitely.
+               - Moved population code to init.
+               - OK button now has default focus.
+               - Some formatting cleanup.
+
 2009-09-19  Jim Evins  <evins@snaught.com>
 
        * COPYING:
index 1f05775331c75c181a8d7d2c68d4ed732564f75a..9279a65b2c7e6faa1ae48f2372694adacb890a78 100644 (file)
@@ -7,7 +7,6 @@ builder_DATA = \
        print-op-dialog-custom-widget.builder   \
        wdgt-media-select.builder       \
        merge-properties-dialog.builder \
-       new-label-dialog.builder        \
        template-designer.builder       \
        prefs-dialog.builder            \
        object-editor.builder
diff --git a/glabels2/data/builder/new-label-dialog.builder b/glabels2/data/builder/new-label-dialog.builder
deleted file mode 100644 (file)
index e46715a..0000000
+++ /dev/null
@@ -1,78 +0,0 @@
-<?xml version="1.0"?>
-<interface>
-  <requires lib="gtk+" version="2.16"/>
-  <!-- interface-naming-policy toplevel-contextual -->
-  <object class="GtkWindow" id="window1">
-    <property name="visible">True</property>
-    <property name="title" translatable="yes">window1</property>
-    <child>
-      <object class="GtkVBox" id="new_label_dialog_vbox">
-        <property name="visible">True</property>
-        <property name="border_width">12</property>
-        <property name="spacing">12</property>
-        <child>
-          <object class="GtkFrame" id="frame1">
-            <property name="visible">True</property>
-            <property name="label_xalign">0</property>
-            <property name="shadow_type">none</property>
-            <child>
-              <object class="GtkAlignment" id="alignment1">
-                <property name="visible">True</property>
-                <property name="left_padding">12</property>
-                <child>
-                  <object class="GtkVBox" id="media_select_vbox">
-                    <property name="visible">True</property>
-                    <child>
-                      <placeholder/>
-                    </child>
-                  </object>
-                </child>
-              </object>
-            </child>
-            <child type="label">
-              <object class="GtkLabel" id="label1">
-                <property name="visible">True</property>
-                <property name="label" translatable="yes">&lt;b&gt;Media type&lt;/b&gt;</property>
-                <property name="use_markup">True</property>
-              </object>
-            </child>
-          </object>
-          <packing>
-            <property name="position">0</property>
-          </packing>
-        </child>
-        <child>
-          <object class="GtkFrame" id="frame2">
-            <property name="visible">True</property>
-            <property name="label_xalign">0</property>
-            <property name="shadow_type">none</property>
-            <child>
-              <object class="GtkAlignment" id="alignment2">
-                <property name="visible">True</property>
-                <property name="left_padding">12</property>
-                <child>
-                  <object class="GtkVBox" id="rotate_label_vbox">
-                    <property name="visible">True</property>
-                    <child>
-                      <placeholder/>
-                    </child>
-                  </object>
-                </child>
-              </object>
-            </child>
-            <child type="label">
-              <object class="GtkLabel" id="label2">
-                <property name="visible">True</property>
-                <property name="label" translatable="yes">&lt;b&gt;Label orientation&lt;/b&gt;</property>
-                <property name="use_markup">True</property>
-              </object>
-            </child>
-          </object>
-          <packing>
-            <property name="position">1</property>
-          </packing>
-        </child>
-      </object>
-    </child>
-  </object>
-</interface>
index 1a41a4e27746a4f1ee3030b43d697ea38fa6dab0..80ab2f1fbe8ca42c07f5cd61459680ef700d6d21 100644 (file)
@@ -11,7 +11,6 @@
         <child>
           <object class="GtkNotebook" id="notebook">
             <property name="visible">True</property>
-            <property name="can_focus">True</property>
             <property name="border_width">12</property>
             <child>
               <object class="GtkVBox" id="recent_tab_vbox">
@@ -29,7 +28,6 @@
                     <child>
                       <object class="GtkTreeView" id="recent_treeview">
                         <property name="visible">True</property>
-                        <property name="can_focus">True</property>
                         <property name="headers_visible">False</property>
                       </object>
                     </child>
@@ -75,6 +73,7 @@
                         <child>
                           <object class="GtkComboBox" id="brand_combo">
                             <property name="visible">True</property>
+                            <property name="focus_on_click">False</property>
                           </object>
                           <packing>
                             <property name="expand">False</property>
                         <child>
                           <object class="GtkComboBox" id="page_size_combo">
                             <property name="visible">True</property>
+                            <property name="focus_on_click">False</property>
                           </object>
                           <packing>
                             <property name="expand">False</property>
                         <child>
                           <object class="GtkComboBox" id="category_combo">
                             <property name="visible">True</property>
+                            <property name="focus_on_click">False</property>
                           </object>
                           <packing>
                             <property name="expand">False</property>
                     <child>
                       <object class="GtkTreeView" id="search_all_treeview">
                         <property name="visible">True</property>
-                        <property name="can_focus">True</property>
                         <property name="headers_visible">False</property>
                       </object>
                     </child>
index 9790b336d0a479a2ea7b301b4250f1aeb838c258..adfdd1d0559bb704ea2f4dd7980411c94e230c62 100644 (file)
@@ -160,7 +160,6 @@ libglabels/xml-template.c
 libglabels/xml-template.h
 
 [type: gettext/glade]data/builder/merge-properties-dialog.builder
-[type: gettext/glade]data/builder/new-label-dialog.builder
 [type: gettext/glade]data/builder/object-editor.builder
 [type: gettext/glade]data/builder/prefs-dialog.builder
 [type: gettext/glade]data/builder/property-bar.builder
index afaa5a18e8eee9913c82bdbe012acf497c148007..8e850c743278991dcdac39ed98c5a449aea127f1 100644 (file)
@@ -39,8 +39,6 @@
 
 struct _glNewLabelDialogPrivate {
 
-        GtkBuilder *builder;
-
        GtkWidget  *media_select;
        GtkWidget  *rotate_label;
 
@@ -58,9 +56,6 @@ struct _glNewLabelDialogPrivate {
 
 static void       gl_new_label_dialog_finalize        (GObject               *object);
 
-static void       gl_new_label_dialog_construct       (glNewLabelDialog      *dialog,
-                                                      GtkWindow             *win);
-
 static void       template_changed_cb                 (glWdgtMediaSelect     *select,
                                                       gpointer               data);
 
@@ -71,6 +66,9 @@ static void       template_changed_cb                 (glWdgtMediaSelect     *se
 G_DEFINE_TYPE (glNewLabelDialog, gl_new_label_dialog, GTK_TYPE_DIALOG);
 
 
+/*****************************************************************************/
+/* Class Init Function.                                                      */
+/*****************************************************************************/
 static void
 gl_new_label_dialog_class_init (glNewLabelDialogClass *class)
 {
@@ -84,29 +82,69 @@ gl_new_label_dialog_class_init (glNewLabelDialogClass *class)
 }
 
 
+/*****************************************************************************/
+/* Object Instance Init Function.                                            */
+/*****************************************************************************/
 static void
 gl_new_label_dialog_init (glNewLabelDialog *dialog)
 {
+       GtkWidget    *label;
+       GtkWidget    *frame;
+       gchar        *name;
+
        gl_debug (DEBUG_FILE, "START");
 
        g_return_if_fail (GL_IS_NEW_LABEL_DIALOG (dialog));
 
        dialog->priv = g_new0 (glNewLabelDialogPrivate, 1);
 
-       gtk_container_set_border_width (GTK_CONTAINER(dialog), GL_HIG_PAD2);
+       gtk_container_set_border_width (GTK_CONTAINER (dialog), GL_HIG_PAD1);
 
-       gtk_dialog_set_has_separator (GTK_DIALOG(dialog), FALSE);
-       gtk_dialog_add_buttons (GTK_DIALOG(dialog),
-                               GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
-                               GTK_STOCK_OK, GTK_RESPONSE_OK,
-                               NULL);
+       gtk_dialog_set_has_separator (GTK_DIALOG (dialog), FALSE);
+       gtk_dialog_add_buttons (GTK_DIALOG (dialog),
+                                GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
+                                GTK_STOCK_OK, GTK_RESPONSE_OK,
+                                NULL);
+        gtk_dialog_set_default_response (GTK_DIALOG (dialog), GTK_RESPONSE_OK);
        gtk_window_set_destroy_with_parent (GTK_WINDOW (dialog), TRUE);
        gtk_window_set_modal (GTK_WINDOW (dialog), TRUE);
 
+
+        label = gtk_label_new (_("<b>Media type</b>"));
+        gtk_label_set_use_markup (GTK_LABEL (label), TRUE);
+        frame = gtk_frame_new ("");
+        gtk_frame_set_label_widget (GTK_FRAME (frame), label);
+        gtk_frame_set_shadow_type (GTK_FRAME (frame), GTK_SHADOW_NONE);
+       gtk_box_pack_start (GTK_BOX( GTK_DIALOG (dialog)->vbox), frame, FALSE, FALSE, GL_HIG_PAD1);
+
+       dialog->priv->media_select = gl_wdgt_media_select_new ();
+        gtk_container_add (GTK_CONTAINER (frame), dialog->priv->media_select);
+
+        label = gtk_label_new (_("<b>Label orientation</b>"));
+        gtk_label_set_use_markup (GTK_LABEL (label), TRUE);
+        frame = gtk_frame_new ("");
+        gtk_frame_set_label_widget (GTK_FRAME (frame), label);
+        gtk_frame_set_shadow_type (GTK_FRAME (frame), GTK_SHADOW_NONE);
+       gtk_box_pack_start (GTK_BOX( GTK_DIALOG (dialog)->vbox), frame, FALSE, FALSE, 0);
+
+       dialog->priv->rotate_label = gl_rotate_label_button_new ();
+        gtk_container_add (GTK_CONTAINER (frame), dialog->priv->rotate_label);
+
+       /* Sync template name from media select with rotate widget. */
+       name = gl_wdgt_media_select_get_name (GL_WDGT_MEDIA_SELECT (dialog->priv->media_select));
+       gl_rotate_label_button_set_template_name (GL_ROTATE_LABEL_BUTTON (dialog->priv->rotate_label),
+                                                  name);
+
+       g_signal_connect (G_OBJECT (dialog->priv->media_select), "changed",
+                         G_CALLBACK (template_changed_cb), dialog);
+
        gl_debug (DEBUG_FILE, "END");
 }
 
 
+/*****************************************************************************/
+/* Finalize Function.                                                        */
+/*****************************************************************************/
 static void 
 gl_new_label_dialog_finalize (GObject *object)
 {
@@ -118,10 +156,6 @@ gl_new_label_dialog_finalize (GObject *object)
        g_return_if_fail (GL_IS_NEW_LABEL_DIALOG (dialog));
        g_return_if_fail (dialog->priv != NULL);
 
-        if (dialog->priv->builder)
-        {
-                g_object_unref (dialog->priv->builder);
-        }
        g_free (dialog->priv);
 
        G_OBJECT_CLASS (gl_new_label_dialog_parent_class)->finalize (object);
@@ -143,66 +177,9 @@ gl_new_label_dialog_new (GtkWindow    *win)
 
        dialog = GTK_WIDGET (g_object_new (GL_TYPE_NEW_LABEL_DIALOG, NULL));
 
-       gl_new_label_dialog_construct (GL_NEW_LABEL_DIALOG(dialog), win);
-
-       return dialog;
-}
-
-
-/*--------------------------------------------------------------------------*/
-/* PRIVATE.  Construct dialog.                                              */
-/*--------------------------------------------------------------------------*/
-static void
-gl_new_label_dialog_construct (glNewLabelDialog   *dialog,
-                              GtkWindow          *win)
-{
-        GtkBuilder   *builder;
-        static gchar *object_ids[] = { "new_label_dialog_vbox", NULL };
-        GError       *error = NULL;
-       GtkWidget    *vbox, *media_select_vbox, *rotate_label_vbox;
-       gchar        *name;
-
-       gl_debug (DEBUG_FILE, "START");
-
        gtk_window_set_transient_for (GTK_WINDOW (dialog), win);
 
-        builder = gtk_builder_new ();
-        gtk_builder_add_objects_from_file (builder,
-                                           GLABELS_BUILDER_DIR "new-label-dialog.builder",
-                                           object_ids,
-                                           &error);
-       if (error) {
-               g_critical ("%s\n\ngLabels may not be installed correctly!", error->message);
-                g_error_free (error);
-               return;
-       }
-
-        gl_util_get_builder_widgets (builder,
-                                     "new_label_dialog_vbox", &vbox,
-                                     "media_select_vbox",     &media_select_vbox,
-                                     "rotate_label_vbox",     &rotate_label_vbox,
-                                     NULL);
-
-       gtk_box_pack_start (GTK_BOX( GTK_DIALOG (dialog)->vbox), vbox, FALSE, FALSE, 0);
-        dialog->priv->builder = builder;
-
-       dialog->priv->media_select = gl_wdgt_media_select_new ();
-       gtk_box_pack_start (GTK_BOX (media_select_vbox),
-                           dialog->priv->media_select, FALSE, FALSE, 0);
-
-       dialog->priv->rotate_label = gl_rotate_label_button_new ();
-       gtk_box_pack_start (GTK_BOX (rotate_label_vbox),
-                           dialog->priv->rotate_label, FALSE, FALSE, 0);
-
-       /* Sync template name from media select with rotate widget. */
-       name = gl_wdgt_media_select_get_name (GL_WDGT_MEDIA_SELECT (dialog->priv->media_select));
-       gl_rotate_label_button_set_template_name (GL_ROTATE_LABEL_BUTTON (dialog->priv->rotate_label),
-                                              name);
-
-       g_signal_connect (G_OBJECT (dialog->priv->media_select), "changed",
-                         G_CALLBACK (template_changed_cb), dialog);
-
-       gl_debug (DEBUG_FILE, "END");
+       return dialog;
 }