Remove redundant NULL check

copy has been used before this point - so it is too late to be concerned
about a NULL pointer now.

This is OK as sstrdup() calls err() on NULL return from the underlying
strdup() call.

Raised by cppcheck.

diff --git a/libi3/mkdirp.c b/libi3/mkdirp.c
index 1fc8c34607222ad381b269fad2fed20e1ad81bdc..f5281bd74164c5e1268a2cd3f3925ff1a9d28063 100644 (file)
--- a/libi3/mkdirp.c
+++ b/libi3/mkdirp.c
@@ -44,10 +44,7 @@ int mkdirp(const char *path, mode_t mode) {
 
     char *sep = strrchr(copy, '/');
     if (sep == NULL) {
 
     char *sep = strrchr(copy, '/');
     if (sep == NULL) {

-        if (copy != NULL) {
-            free(copy);
-            copy = NULL;
-        }
+        free(copy);

         return -1;
     }
     *sep = '\0';
         return -1;
     }
     *sep = '\0';