fake_outputs: Don't read past the end of string

fake_outputs_init would unconditionally increase the string read
pointer variable (walk) by one character more than the number of
characters that have been read, to skip past the character delimiting
records (a comma). However, when the input string was not terminated
by a comma, it would cause the function to read past the null
terminator instead.

Avoid this by explicitly checking for the expected delimiter.

diff --git a/src/fake_outputs.c b/src/fake_outputs.c
index 447409d2a024503f6f83cd6d494070349b66d88a..64c3e20c7866145497a2a23f9a5bf0ea4adc1b51 100644 (file)
--- a/src/fake_outputs.c
+++ b/src/fake_outputs.c
@@ -68,7 +68,9 @@ void fake_outputs_init(const char *output_spec) {
             num_screens++;
         }
 
-        walk += chars_consumed + 1;
+        walk += chars_consumed;
+        if (*walk == ',')
+            walk++;
     }
 
     if (num_screens == 0) {