root_atom_contents: properly clean up in all cases

diff --git a/libi3/root_atom_contents.c b/libi3/root_atom_contents.c
index d91f1e15b4ba10f21cc122c3798746354bae9476..8d26c307048d81a9827a1118a4195b64fb979592 100644 (file)
--- a/libi3/root_atom_contents.c
+++ b/libi3/root_atom_contents.c
@@ -31,14 +31,15 @@
 char *root_atom_contents(const char *atomname, xcb_connection_t *provided_conn, int screen) {
     xcb_intern_atom_cookie_t atom_cookie;
     xcb_intern_atom_reply_t *atom_reply;
-    char *content;
+    char *content = NULL;
     size_t content_max_words = 256;
     xcb_connection_t *conn = provided_conn;
 
     if (provided_conn == NULL &&
         ((conn = xcb_connect(NULL, &screen)) == NULL ||
-         xcb_connection_has_error(conn)))
+         xcb_connection_has_error(conn))) {
         return NULL;
+    }
 
     atom_cookie = xcb_intern_atom(conn, 0, strlen(atomname), atomname);
 
@@ -46,8 +47,9 @@ char *root_atom_contents(const char *atomname, xcb_connection_t *provided_conn,
     xcb_window_t root = root_screen->root;
 
     atom_reply = xcb_intern_atom_reply(conn, atom_cookie, NULL);
-    if (atom_reply == NULL)
-        return NULL;
+    if (atom_reply == NULL) {
+        goto out_conn;
+    }
 
     xcb_get_property_cookie_t prop_cookie;
     xcb_get_property_reply_t *prop_reply;
@@ -55,8 +57,7 @@ char *root_atom_contents(const char *atomname, xcb_connection_t *provided_conn,
                                              XCB_GET_PROPERTY_TYPE_ANY, 0, content_max_words);
     prop_reply = xcb_get_property_reply(conn, prop_cookie, NULL);
     if (prop_reply == NULL) {
-        free(atom_reply);
-        return NULL;
+        goto out_atom;
     }
     if (xcb_get_property_value_length(prop_reply) > 0 && prop_reply->bytes_after > 0) {
         /* We received an incomplete value. Ask again but with a properly
@@ -68,14 +69,11 @@ char *root_atom_contents(const char *atomname, xcb_connection_t *provided_conn,
                                                  XCB_GET_PROPERTY_TYPE_ANY, 0, content_max_words);
         prop_reply = xcb_get_property_reply(conn, prop_cookie, NULL);
         if (prop_reply == NULL) {
-            free(atom_reply);
-            return NULL;
+            goto out_atom;
         }
     }
     if (xcb_get_property_value_length(prop_reply) == 0) {
-        free(atom_reply);
-        free(prop_reply);
-        return NULL;
+        goto out;
     }
     if (prop_reply->type == XCB_ATOM_CARDINAL) {
         /* We treat a CARDINAL as a >= 32-bit unsigned int. The only CARDINAL
@@ -85,9 +83,13 @@ char *root_atom_contents(const char *atomname, xcb_connection_t *provided_conn,
         sasprintf(&content, "%.*s", xcb_get_property_value_length(prop_reply),
                   (char *)xcb_get_property_value(prop_reply));
     }
+
+out:
+    free(prop_reply);
+out_atom:
+    free(atom_reply);
+out_conn:
     if (provided_conn == NULL)
         xcb_disconnect(conn);
-    free(atom_reply);
-    free(prop_reply);
     return content;
 }