Avoid recreating recent item labels when there's no change

diff --git a/src/searchview.cpp b/src/searchview.cpp
index 60cc7a40e7f644bc0aba56a420602156787b9410..f72751bbafa9e50abcef4af389b8ebeedaed5561 100644 (file)
--- a/src/searchview.cpp
+++ b/src/searchview.cpp
@@ -214,6 +214,11 @@ void SearchView::disappear() {
 }
 
 void SearchView::updateRecentKeywords() {
+    // load
+    QSettings settings;
+    QStringList keywords = settings.value(recentKeywordsKey).toStringList();
+    if (keywords == recentKeywords) return;
+    recentKeywords = keywords;
 
     // cleanup
     QLayoutItem *item;
@@ -222,9 +227,6 @@ void SearchView::updateRecentKeywords() {
         delete item;
     }
 
-    // load
-    QSettings settings;
-    QStringList keywords = settings.value(recentKeywordsKey).toStringList();
     recentKeywordsLabel->setVisible(!keywords.isEmpty());
     The::globalActions()->value("clearRecentKeywords")->setEnabled(!keywords.isEmpty());
 
@@ -262,6 +264,11 @@ void SearchView::updateRecentKeywords() {
 }
 
 void SearchView::updateRecentChannels() {
+    // load
+    QSettings settings;
+    QStringList keywords = settings.value(recentChannelsKey).toStringList();
+    if (keywords == recentChannels) return;
+    recentChannels = keywords;
 
     // cleanup
     QLayoutItem *item;
@@ -270,9 +277,6 @@ void SearchView::updateRecentChannels() {
         delete item;
     }
 
-    // load
-    QSettings settings;
-    QStringList keywords = settings.value(recentChannelsKey).toStringList();
     recentChannelsLabel->setVisible(!keywords.isEmpty());
     // TODO The::globalActions()->value("clearRecentKeywords")->setEnabled(!keywords.isEmpty());
 

diff --git a/src/searchview.h b/src/searchview.h
index 3e818791aa696680f0d1051ea3c3b2e1a8d78b4b..e8751a61904f01cdf22c28c974fdcab501868cb7 100644 (file)
--- a/src/searchview.h
+++ b/src/searchview.h
@@ -74,6 +74,8 @@ private:
     QLabel *message;
     QPushButton *watchButton;
 
+    QStringList recentKeywords;
+    QStringList recentChannels;
 };
 
 #endif // __SEARCHVIEW_H__