]> git.sur5r.net Git - openldap/blob - servers/slapd/back-mdb/modify.c
7bfdb5cd58a557b2d9fdcdcb205ea5a5880727eb
[openldap] / servers / slapd / back-mdb / modify.c
1 /* modify.c - mdb backend modify routine */
2 /* $OpenLDAP$ */
3 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
4  *
5  * Copyright 2000-2017 The OpenLDAP Foundation.
6  * All rights reserved.
7  *
8  * Redistribution and use in source and binary forms, with or without
9  * modification, are permitted only as authorized by the OpenLDAP
10  * Public License.
11  *
12  * A copy of this license is available in the file LICENSE in the
13  * top-level directory of the distribution or, alternatively, at
14  * <http://www.OpenLDAP.org/license.html>.
15  */
16
17 #include "portable.h"
18
19 #include <stdio.h>
20 #include <ac/string.h>
21 #include <ac/time.h>
22
23 #include "back-mdb.h"
24
25 static struct berval scbva[] = {
26         BER_BVC("glue"),
27         BER_BVNULL
28 };
29
30 static void
31 mdb_modify_idxflags(
32         Operation *op,
33         AttributeDescription *desc,
34         int got_delete,
35         Attribute *newattrs,
36         Attribute *oldattrs )
37 {
38         struct berval   ix_at;
39         AttrInfo        *ai;
40
41         /* check if modified attribute was indexed
42          * but not in case of NOOP... */
43         ai = mdb_index_mask( op->o_bd, desc, &ix_at );
44         if ( ai ) {
45                 if ( got_delete ) {
46                         Attribute       *ap;
47                         struct berval   ix2;
48
49                         ap = attr_find( oldattrs, desc );
50                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXDEL;
51
52                         /* ITS#8678 FIXME
53                          * If using 32bit hashes, or substring index, must account for
54                          * possible index collisions. If no substring index, and using
55                          * 64bit hashes, assume we don't need to check for collisions.
56                          *
57                          * In 2.5 use refcounts and avoid all of this mess.
58                          */
59                         if (!slap_hash64(-1) || (ai->ai_indexmask & SLAP_INDEX_SUBSTR)) {
60                                 /* Find all other attrs that index to same slot */
61                                 for ( ap = newattrs; ap; ap = ap->a_next ) {
62                                         ai = mdb_index_mask( op->o_bd, ap->a_desc, &ix2 );
63                                         if ( ai && ix2.bv_val == ix_at.bv_val )
64                                                 ap->a_flags |= SLAP_ATTR_IXADD;
65                                 }
66                         }
67
68                 } else {
69                         Attribute       *ap;
70
71                         ap = attr_find( newattrs, desc );
72                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXADD;
73                 }
74         }
75 }
76
77 int mdb_modify_internal(
78         Operation *op,
79         MDB_txn *tid,
80         Modifications *modlist,
81         Entry *e,
82         const char **text,
83         char *textbuf,
84         size_t textlen )
85 {
86         struct mdb_info *mdb = (struct mdb_info *) op->o_bd->be_private;
87         int rc, err;
88         Modification    *mod;
89         Modifications   *ml;
90         Attribute       *save_attrs;
91         Attribute       *ap, *aold, *anew;
92         int                     glue_attr_delete = 0;
93         int                     softop, chkpresent;
94         int                     got_delete;
95         int                     a_flags;
96         MDB_cursor      *mvc = NULL;
97
98         Debug( LDAP_DEBUG_TRACE, "mdb_modify_internal: 0x%08lx: %s\n",
99                 e->e_id, e->e_dn, 0);
100
101         if ( !acl_check_modlist( op, e, modlist )) {
102                 return LDAP_INSUFFICIENT_ACCESS;
103         }
104
105         /* save_attrs will be disposed of by caller */
106         save_attrs = e->e_attrs;
107         e->e_attrs = attrs_dup( e->e_attrs );
108
109         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
110                 int match;
111                 mod = &ml->sml_mod;
112                 switch( mod->sm_op ) {
113                 case LDAP_MOD_ADD:
114                 case LDAP_MOD_REPLACE:
115                         if ( mod->sm_desc == slap_schema.si_ad_structuralObjectClass ) {
116                                 value_match( &match, slap_schema.si_ad_structuralObjectClass,
117                                         slap_schema.si_ad_structuralObjectClass->
118                                                 ad_type->sat_equality,
119                                         SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX,
120                                         &mod->sm_values[0], &scbva[0], text );
121                                 if ( !match ) glue_attr_delete = 1;
122                         }
123                 }
124                 if ( glue_attr_delete )
125                         break;
126         }
127
128         if ( glue_attr_delete ) {
129                 Attribute       **app = &e->e_attrs;
130                 while ( *app != NULL ) {
131                         if ( !is_at_operational( (*app)->a_desc->ad_type )) {
132                                 Attribute *save = *app;
133                                 *app = (*app)->a_next;
134                                 attr_free( save );
135                                 continue;
136                         }
137                         app = &(*app)->a_next;
138                 }
139         }
140
141         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
142                 mod = &ml->sml_mod;
143                 got_delete = 0;
144
145                 aold = attr_find( e->e_attrs, mod->sm_desc );
146                 if (aold)
147                         a_flags = aold->a_flags;
148                 else
149                         a_flags = 0;
150
151                 switch ( mod->sm_op ) {
152                 case LDAP_MOD_ADD:
153                         softop = 0;
154                         chkpresent = 0;
155                         Debug(LDAP_DEBUG_ARGS,
156                                 "mdb_modify_internal: add %s\n",
157                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
158
159 do_add:
160                         err = modify_add_values( e, mod, get_permissiveModify(op),
161                                 text, textbuf, textlen );
162
163                         if( softop ) {
164                                 mod->sm_op = SLAP_MOD_SOFTADD;
165                                 if ( err == LDAP_TYPE_OR_VALUE_EXISTS )
166                                         err = LDAP_SUCCESS;
167                         }
168                         if( chkpresent ) {
169                                 mod->sm_op = SLAP_MOD_ADD_IF_NOT_PRESENT;
170                         }
171
172                         if( err != LDAP_SUCCESS ) {
173                                 Debug(LDAP_DEBUG_ARGS, "mdb_modify_internal: %d %s\n",
174                                         err, *text, 0);
175                         } else {
176                                 if (!aold)
177                                         anew = attr_find( e->e_attrs, mod->sm_desc );
178                                 else
179                                         anew = aold;
180                                 /* check for big multivalued attrs */
181                                 if ( anew->a_numvals > mdb->mi_multi_hi )
182                                         anew->a_flags |= SLAP_ATTR_BIG_MULTI;
183                                 if ( anew->a_flags & SLAP_ATTR_BIG_MULTI ) {
184                                         if (!mvc) {
185                                                 err = mdb_cursor_open( tid, mdb->mi_dbis[MDB_ID2VAL], &mvc );
186                                                 if (err)
187                                                         break;
188                                         }
189                                         /* if prev was set, just add new values */
190                                         if (a_flags & SLAP_ATTR_BIG_MULTI ) {
191                                                 anew = (Attribute *)mod;
192                                                 /* Tweak nvals */
193                                                 if (!anew->a_nvals)
194                                                         anew->a_nvals = anew->a_vals;
195                                         }
196                                         err = mdb_mval_put(op, mvc, e->e_id, anew);
197                                         if (a_flags & SLAP_ATTR_BIG_MULTI ) {
198                                                 /* Undo nvals tweak */
199                                                 if (anew->a_nvals == anew->a_vals)
200                                                         anew->a_nvals = NULL;
201                                         }
202                                 }
203                         }
204                         break;
205
206                 case LDAP_MOD_DELETE:
207                         if ( glue_attr_delete ) {
208                                 err = LDAP_SUCCESS;
209                                 break;
210                         }
211
212                         softop = 0;
213                         Debug(LDAP_DEBUG_ARGS,
214                                 "mdb_modify_internal: delete %s\n",
215                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
216 do_del:
217                         err = modify_delete_values( e, mod, get_permissiveModify(op),
218                                 text, textbuf, textlen );
219
220                         if (softop) {
221                                 mod->sm_op = SLAP_MOD_SOFTDEL;
222                                 if ( err == LDAP_NO_SUCH_ATTRIBUTE ) {
223                                         err = LDAP_SUCCESS;
224                                         softop = 2;
225                                 }
226                         }
227
228                         if( err != LDAP_SUCCESS ) {
229                                 Debug(LDAP_DEBUG_ARGS, "mdb_modify_internal: %d %s\n",
230                                         err, *text, 0);
231                         } else {
232                                 if (softop != 2)
233                                         got_delete = 1;
234                                 /* check for big multivalued attrs */
235                                 if (a_flags & SLAP_ATTR_BIG_MULTI) {
236                                         Attribute a_dummy;
237                                         if (!mvc) {
238                                                 err = mdb_cursor_open( tid, mdb->mi_dbis[MDB_ID2VAL], &mvc );
239                                                 if (err)
240                                                         break;
241                                         }
242                                         if ( mod->sm_numvals ) {
243                                                 anew = attr_find( e->e_attrs, mod->sm_desc );
244                                                 if ( anew ) {
245                                                         if ( anew->a_numvals < mdb->mi_multi_lo ) {
246                                                                 anew->a_flags ^= SLAP_ATTR_BIG_MULTI;
247                                                                 anew = NULL;
248                                                         } else {
249                                                                 anew = (Attribute *)mod;
250                                                         }
251                                                 }
252                                         } else {
253                                                 anew = NULL;
254                                         }
255                                         if (!anew) {
256                                         /* delete all values */
257                                                 anew = &a_dummy;
258                                                 anew->a_desc = mod->sm_desc;
259                                                 anew->a_numvals = 0;
260                                         }
261                                         err = mdb_mval_del( op, mvc, e->e_id, anew );
262                                 }
263                         }
264                         break;
265
266                 case LDAP_MOD_REPLACE:
267                         Debug(LDAP_DEBUG_ARGS,
268                                 "mdb_modify_internal: replace %s\n",
269                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
270                         err = modify_replace_values( e, mod, get_permissiveModify(op),
271                                 text, textbuf, textlen );
272                         if( err != LDAP_SUCCESS ) {
273                                 Debug(LDAP_DEBUG_ARGS, "mdb_modify_internal: %d %s\n",
274                                         err, *text, 0);
275                         } else {
276                                 got_delete = 1;
277                                 if (a_flags & SLAP_ATTR_BIG_MULTI) {
278                                         Attribute a_dummy;
279                                         if (!mvc) {
280                                                 err = mdb_cursor_open( tid, mdb->mi_dbis[MDB_ID2VAL], &mvc );
281                                                 if (err)
282                                                         break;
283                                         }
284                                         /* delete all values */
285                                         anew = &a_dummy;
286                                         anew->a_desc = mod->sm_desc;
287                                         anew->a_numvals = 0;
288                                         err = mdb_mval_del( op, mvc, e->e_id, anew );
289                                         if (err)
290                                                 break;
291                                 }
292                                 anew = attr_find( e->e_attrs, mod->sm_desc );
293                                 if (mod->sm_numvals >= mdb->mi_multi_lo) {
294                                         anew->a_flags |= SLAP_ATTR_BIG_MULTI;
295                                         if (!mvc) {
296                                                 err = mdb_cursor_open( tid, mdb->mi_dbis[MDB_ID2VAL], &mvc );
297                                                 if (err)
298                                                         break;
299                                         }
300                                         err = mdb_mval_put(op, mvc, e->e_id, anew);
301                                 } else if (anew) {
302                                         /* revert back to normal attr */
303                                         anew->a_flags &= ~SLAP_ATTR_BIG_MULTI;
304                                 }
305                         }
306                         break;
307
308                 case LDAP_MOD_INCREMENT:
309                         Debug(LDAP_DEBUG_ARGS,
310                                 "mdb_modify_internal: increment %s\n",
311                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
312                         err = modify_increment_values( e, mod, get_permissiveModify(op),
313                                 text, textbuf, textlen );
314                         if( err != LDAP_SUCCESS ) {
315                                 Debug(LDAP_DEBUG_ARGS,
316                                         "mdb_modify_internal: %d %s\n",
317                                         err, *text, 0);
318                         } else {
319                                 got_delete = 1;
320                         }
321                         break;
322
323                 case SLAP_MOD_SOFTADD:
324                         Debug(LDAP_DEBUG_ARGS,
325                                 "mdb_modify_internal: softadd %s\n",
326                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
327                         /* Avoid problems in index_add_mods()
328                          * We need to add index if necessary.
329                          */
330                         mod->sm_op = LDAP_MOD_ADD;
331                         softop = 1;
332                         chkpresent = 0;
333                         goto do_add;
334
335                 case SLAP_MOD_SOFTDEL:
336                         Debug(LDAP_DEBUG_ARGS,
337                                 "mdb_modify_internal: softdel %s\n",
338                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
339                         /* Avoid problems in index_delete_mods()
340                          * We need to add index if necessary.
341                          */
342                         mod->sm_op = LDAP_MOD_DELETE;
343                         softop = 1;
344                         goto do_del;
345
346                 case SLAP_MOD_ADD_IF_NOT_PRESENT:
347                         if ( attr_find( e->e_attrs, mod->sm_desc ) != NULL ) {
348                                 /* skip */
349                                 err = LDAP_SUCCESS;
350                                 break;
351                         }
352
353                         Debug(LDAP_DEBUG_ARGS,
354                                 "mdb_modify_internal: add_if_not_present %s\n",
355                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
356                         /* Avoid problems in index_add_mods()
357                          * We need to add index if necessary.
358                          */
359                         mod->sm_op = LDAP_MOD_ADD;
360                         softop = 0;
361                         chkpresent = 1;
362                         goto do_add;
363
364                 default:
365                         Debug(LDAP_DEBUG_ANY, "mdb_modify_internal: invalid op %d\n",
366                                 mod->sm_op, 0, 0);
367                         *text = "Invalid modify operation";
368                         err = LDAP_OTHER;
369                         Debug(LDAP_DEBUG_ARGS, "mdb_modify_internal: %d %s\n",
370                                 err, *text, 0);
371                 }
372
373                 if ( err != LDAP_SUCCESS ) {
374                         attrs_free( e->e_attrs );
375                         e->e_attrs = save_attrs;
376                         /* unlock entry, delete from cache */
377                         return err; 
378                 }
379
380                 /* If objectClass was modified, reset the flags */
381                 if ( mod->sm_desc == slap_schema.si_ad_objectClass ) {
382                         e->e_ocflags = 0;
383                 }
384
385                 if ( glue_attr_delete ) e->e_ocflags = 0;
386
387
388                 /* check if modified attribute was indexed
389                  * but not in case of NOOP... */
390                 if ( !op->o_noop ) {
391                         mdb_modify_idxflags( op, mod->sm_desc, got_delete, e->e_attrs, save_attrs );
392                 }
393         }
394
395         /* check that the entry still obeys the schema */
396         ap = NULL;
397         rc = entry_schema_check( op, e, save_attrs, get_relax(op), 0, &ap,
398                 text, textbuf, textlen );
399         if ( rc != LDAP_SUCCESS || op->o_noop ) {
400                 attrs_free( e->e_attrs );
401                 /* clear the indexing flags */
402                 for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
403                         ap->a_flags &= ~(SLAP_ATTR_IXADD|SLAP_ATTR_IXDEL);
404                 }
405                 e->e_attrs = save_attrs;
406
407                 if ( rc != LDAP_SUCCESS ) {
408                         Debug( LDAP_DEBUG_ANY,
409                                 "entry failed schema check: %s\n",
410                                 *text, 0, 0 );
411                 }
412
413                 /* if NOOP then silently revert to saved attrs */
414                 return rc;
415         }
416
417         /* structuralObjectClass modified! */
418         if ( ap ) {
419                 assert( ap->a_desc == slap_schema.si_ad_structuralObjectClass );
420                 if ( !op->o_noop ) {
421                         mdb_modify_idxflags( op, slap_schema.si_ad_structuralObjectClass,
422                                 1, e->e_attrs, save_attrs );
423                 }
424         }
425
426         /* update the indices of the modified attributes */
427
428         /* start with deleting the old index entries */
429         for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
430                 if ( ap->a_flags & SLAP_ATTR_IXDEL ) {
431                         struct berval *vals;
432                         Attribute *a2;
433                         ap->a_flags &= ~SLAP_ATTR_IXDEL;
434                         a2 = attr_find( e->e_attrs, ap->a_desc );
435                         if ( a2 ) {
436                                 /* need to detect which values were deleted */
437                                 int i, j;
438                                 /* let add know there were deletes */
439                                 if ( a2->a_flags & SLAP_ATTR_IXADD )
440                                         a2->a_flags |= SLAP_ATTR_IXDEL;
441                                 vals = op->o_tmpalloc( (ap->a_numvals + 1) *
442                                         sizeof(struct berval), op->o_tmpmemctx );
443                                 j = 0;
444                                 for ( i=0; i < ap->a_numvals; i++ ) {
445                                         rc = attr_valfind( a2, SLAP_MR_ASSERTED_VALUE_NORMALIZED_MATCH,
446                                                 &ap->a_nvals[i], NULL, op->o_tmpmemctx );
447                                         /* Save deleted values */
448                                         if ( rc == LDAP_NO_SUCH_ATTRIBUTE )
449                                                 vals[j++] = ap->a_nvals[i];
450                                 }
451                                 BER_BVZERO(vals+j);
452                         } else {
453                                 /* attribute was completely deleted */
454                                 vals = ap->a_nvals;
455                         }
456                         rc = 0;
457                         if ( !BER_BVISNULL( vals )) {
458                                 rc = mdb_index_values( op, tid, ap->a_desc,
459                                         vals, e->e_id, SLAP_INDEX_DELETE_OP );
460                                 if ( rc != LDAP_SUCCESS ) {
461                                         Debug( LDAP_DEBUG_ANY,
462                                                 "%s: attribute \"%s\" index delete failure\n",
463                                                 op->o_log_prefix, ap->a_desc->ad_cname.bv_val, 0 );
464                                         attrs_free( e->e_attrs );
465                                         e->e_attrs = save_attrs;
466                                 }
467                         }
468                         if ( vals != ap->a_nvals )
469                                 op->o_tmpfree( vals, op->o_tmpmemctx );
470                         if ( rc ) return rc;
471                 }
472         }
473
474         /* add the new index entries */
475         for ( ap = e->e_attrs; ap != NULL; ap = ap->a_next ) {
476                 if (ap->a_flags & SLAP_ATTR_IXADD) {
477                         ap->a_flags &= ~SLAP_ATTR_IXADD;
478                         if ( ap->a_flags & SLAP_ATTR_IXDEL ) {
479                                 /* if any values were deleted, we must readd index
480                                  * for all remaining values.
481                                  */
482                                 ap->a_flags &= ~SLAP_ATTR_IXDEL;
483                                 rc = mdb_index_values( op, tid, ap->a_desc,
484                                         ap->a_nvals,
485                                         e->e_id, SLAP_INDEX_ADD_OP );
486                         } else {
487                                 int found = 0;
488                                 /* if this was only an add, we only need to index
489                                  * the added values.
490                                  */
491                                 for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
492                                         struct berval *vals;
493                                         if ( ml->sml_desc != ap->a_desc || !ml->sml_numvals )
494                                                 continue;
495                                         found = 1;
496                                         switch( ml->sml_op ) {
497                                         case LDAP_MOD_ADD:
498                                         case LDAP_MOD_REPLACE:
499                                         case LDAP_MOD_INCREMENT:
500                                         case SLAP_MOD_SOFTADD:
501                                         case SLAP_MOD_ADD_IF_NOT_PRESENT:
502                                                 if ( ml->sml_op == LDAP_MOD_INCREMENT )
503                                                         vals = ap->a_nvals;
504                                                 else if ( ml->sml_nvalues )
505                                                         vals = ml->sml_nvalues;
506                                                 else
507                                                         vals = ml->sml_values;
508                                                 rc = mdb_index_values( op, tid, ap->a_desc,
509                                                         vals, e->e_id, SLAP_INDEX_ADD_OP );
510                                                 break;
511                                         }
512                                         if ( rc )
513                                                 break;
514                                 }
515                                 /* This attr was affected by a modify of a subtype, so
516                                  * there was no direct match in the modlist. Just readd
517                                  * all of its values.
518                                  */
519                                 if ( !found ) {
520                                         rc = mdb_index_values( op, tid, ap->a_desc,
521                                                 ap->a_nvals,
522                                                 e->e_id, SLAP_INDEX_ADD_OP );
523                                 }
524                         }
525                         if ( rc != LDAP_SUCCESS ) {
526                                 Debug( LDAP_DEBUG_ANY,
527                                        "%s: attribute \"%s\" index add failure\n",
528                                         op->o_log_prefix, ap->a_desc->ad_cname.bv_val, 0 );
529                                 attrs_free( e->e_attrs );
530                                 e->e_attrs = save_attrs;
531                                 return rc;
532                         }
533                 }
534         }
535
536         return rc;
537 }
538
539
540 int
541 mdb_modify( Operation *op, SlapReply *rs )
542 {
543         struct mdb_info *mdb = (struct mdb_info *) op->o_bd->be_private;
544         Entry           *e = NULL;
545         int             manageDSAit = get_manageDSAit( op );
546         char textbuf[SLAP_TEXT_BUFLEN];
547         size_t textlen = sizeof textbuf;
548         MDB_txn *txn = NULL;
549         mdb_op_info opinfo = {{{ 0 }}}, *moi = &opinfo;
550         Entry           dummy = {0};
551
552         LDAPControl **preread_ctrl = NULL;
553         LDAPControl **postread_ctrl = NULL;
554         LDAPControl *ctrls[SLAP_MAX_RESPONSE_CONTROLS];
555         int num_ctrls = 0;
556         int numads = mdb->mi_numads;
557
558         Debug( LDAP_DEBUG_ARGS, LDAP_XSTRING(mdb_modify) ": %s\n",
559                 op->o_req_dn.bv_val, 0, 0 );
560
561 #ifdef LDAP_X_TXN
562         if( op->o_txnSpec && txn_preop( op, rs ))
563                 return rs->sr_err;
564 #endif
565
566         ctrls[num_ctrls] = NULL;
567
568         /* begin transaction */
569         rs->sr_err = mdb_opinfo_get( op, mdb, 0, &moi );
570         rs->sr_text = NULL;
571         if( rs->sr_err != 0 ) {
572                 Debug( LDAP_DEBUG_TRACE,
573                         LDAP_XSTRING(mdb_modify) ": txn_begin failed: "
574                         "%s (%d)\n", mdb_strerror(rs->sr_err), rs->sr_err, 0 );
575                 rs->sr_err = LDAP_OTHER;
576                 rs->sr_text = "internal error";
577                 goto return_results;
578         }
579         txn = moi->moi_txn;
580
581         /* Don't touch the opattrs, if this is a contextCSN update
582          * initiated from updatedn */
583         if ( !be_isupdate(op) || !op->orm_modlist || op->orm_modlist->sml_next ||
584                  op->orm_modlist->sml_desc != slap_schema.si_ad_contextCSN ) {
585
586                 slap_mods_opattrs( op, &op->orm_modlist, 1 );
587         }
588
589         /* get entry or ancestor */
590         rs->sr_err = mdb_dn2entry( op, txn, NULL, &op->o_req_ndn, &e, NULL, 1 );
591
592         if ( rs->sr_err != 0 ) {
593                 Debug( LDAP_DEBUG_TRACE,
594                         LDAP_XSTRING(mdb_modify) ": dn2entry failed (%d)\n",
595                         rs->sr_err, 0, 0 );
596                 switch( rs->sr_err ) {
597                 case MDB_NOTFOUND:
598                         break;
599                 case LDAP_BUSY:
600                         rs->sr_text = "ldap server busy";
601                         goto return_results;
602                 default:
603                         rs->sr_err = LDAP_OTHER;
604                         rs->sr_text = "internal error";
605                         goto return_results;
606                 }
607         }
608
609         /* acquire and lock entry */
610         /* FIXME: dn2entry() should return non-glue entry */
611         if (( rs->sr_err == MDB_NOTFOUND ) ||
612                 ( !manageDSAit && e && is_entry_glue( e )))
613         {
614                 if ( e != NULL ) {
615                         rs->sr_matched = ch_strdup( e->e_dn );
616                         if ( is_entry_referral( e )) {
617                                 BerVarray ref = get_entry_referrals( op, e );
618                                 rs->sr_ref = referral_rewrite( ref, &e->e_name,
619                                         &op->o_req_dn, LDAP_SCOPE_DEFAULT );
620                                 ber_bvarray_free( ref );
621                         } else {
622                                 rs->sr_ref = NULL;
623                         }
624                         mdb_entry_return( op, e );
625                         e = NULL;
626
627                 } else {
628                         rs->sr_ref = referral_rewrite( default_referral, NULL,
629                                 &op->o_req_dn, LDAP_SCOPE_DEFAULT );
630                 }
631
632                 rs->sr_flags = REP_MATCHED_MUSTBEFREED | REP_REF_MUSTBEFREED;
633                 rs->sr_err = LDAP_REFERRAL;
634                 send_ldap_result( op, rs );
635                 goto done;
636         }
637
638         if ( !manageDSAit && is_entry_referral( e ) ) {
639                 /* entry is a referral, don't allow modify */
640                 rs->sr_ref = get_entry_referrals( op, e );
641
642                 Debug( LDAP_DEBUG_TRACE,
643                         LDAP_XSTRING(mdb_modify) ": entry is referral\n",
644                         0, 0, 0 );
645
646                 rs->sr_err = LDAP_REFERRAL;
647                 rs->sr_matched = e->e_name.bv_val;
648                 rs->sr_flags = REP_REF_MUSTBEFREED;
649                 send_ldap_result( op, rs );
650                 rs->sr_matched = NULL;
651                 goto done;
652         }
653
654         if ( get_assert( op ) &&
655                 ( test_filter( op, e, get_assertion( op )) != LDAP_COMPARE_TRUE ))
656         {
657                 rs->sr_err = LDAP_ASSERTION_FAILED;
658                 goto return_results;
659         }
660
661         if( op->o_preread ) {
662                 if( preread_ctrl == NULL ) {
663                         preread_ctrl = &ctrls[num_ctrls++];
664                         ctrls[num_ctrls] = NULL;
665                 }
666                 if ( slap_read_controls( op, rs, e,
667                         &slap_pre_read_bv, preread_ctrl ) )
668                 {
669                         Debug( LDAP_DEBUG_TRACE,
670                                 "<=- " LDAP_XSTRING(mdb_modify) ": pre-read "
671                                 "failed!\n", 0, 0, 0 );
672                         if ( op->o_preread & SLAP_CONTROL_CRITICAL ) {
673                                 /* FIXME: is it correct to abort
674                                  * operation if control fails? */
675                                 goto return_results;
676                         }
677                 }
678         }
679
680         /* Modify the entry */
681         dummy = *e;
682         rs->sr_err = mdb_modify_internal( op, txn, op->orm_modlist,
683                 &dummy, &rs->sr_text, textbuf, textlen );
684
685         if( rs->sr_err != LDAP_SUCCESS ) {
686                 Debug( LDAP_DEBUG_TRACE,
687                         LDAP_XSTRING(mdb_modify) ": modify failed (%d)\n",
688                         rs->sr_err, 0, 0 );
689                 /* Only free attrs if they were dup'd.  */
690                 if ( dummy.e_attrs == e->e_attrs ) dummy.e_attrs = NULL;
691                 goto return_results;
692         }
693
694         /* change the entry itself */
695         rs->sr_err = mdb_id2entry_update( op, txn, NULL, &dummy );
696         if ( rs->sr_err != 0 ) {
697                 Debug( LDAP_DEBUG_TRACE,
698                         LDAP_XSTRING(mdb_modify) ": id2entry update failed " "(%d)\n",
699                         rs->sr_err, 0, 0 );
700                 if ( rs->sr_err == LDAP_ADMINLIMIT_EXCEEDED ) {
701                         rs->sr_text = "entry too big";
702                 } else {
703                         rs->sr_err = LDAP_OTHER;
704                         rs->sr_text = "entry update failed";
705                 }
706                 goto return_results;
707         }
708
709         if( op->o_postread ) {
710                 if( postread_ctrl == NULL ) {
711                         postread_ctrl = &ctrls[num_ctrls++];
712                         ctrls[num_ctrls] = NULL;
713                 }
714                 if( slap_read_controls( op, rs, &dummy,
715                         &slap_post_read_bv, postread_ctrl ) )
716                 {
717                         Debug( LDAP_DEBUG_TRACE,
718                                 "<=- " LDAP_XSTRING(mdb_modify)
719                                 ": post-read failed!\n", 0, 0, 0 );
720                         if ( op->o_postread & SLAP_CONTROL_CRITICAL ) {
721                                 /* FIXME: is it correct to abort
722                                  * operation if control fails? */
723                                 goto return_results;
724                         }
725                 }
726         }
727
728         /* Only free attrs if they were dup'd.  */
729         if ( dummy.e_attrs == e->e_attrs ) dummy.e_attrs = NULL;
730         if( moi == &opinfo ) {
731                 LDAP_SLIST_REMOVE( &op->o_extra, &opinfo.moi_oe, OpExtra, oe_next );
732                 opinfo.moi_oe.oe_key = NULL;
733                 if( op->o_noop ) {
734                         mdb->mi_numads = numads;
735                         mdb_txn_abort( txn );
736                         rs->sr_err = LDAP_X_NO_OPERATION;
737                         txn = NULL;
738                         goto return_results;
739                 } else {
740                         rs->sr_err = mdb_txn_commit( txn );
741                         if ( rs->sr_err )
742                                 mdb->mi_numads = numads;
743                         txn = NULL;
744                 }
745         }
746
747         if( rs->sr_err != 0 ) {
748                 Debug( LDAP_DEBUG_ANY,
749                         LDAP_XSTRING(mdb_modify) ": txn_%s failed: %s (%d)\n",
750                         op->o_noop ? "abort (no-op)" : "commit",
751                         mdb_strerror(rs->sr_err), rs->sr_err );
752                 rs->sr_err = LDAP_OTHER;
753                 rs->sr_text = "commit failed";
754
755                 goto return_results;
756         }
757
758         Debug( LDAP_DEBUG_TRACE,
759                 LDAP_XSTRING(mdb_modify) ": updated%s id=%08lx dn=\"%s\"\n",
760                 op->o_noop ? " (no-op)" : "",
761                 dummy.e_id, op->o_req_dn.bv_val );
762
763         rs->sr_err = LDAP_SUCCESS;
764         rs->sr_text = NULL;
765         if( num_ctrls ) rs->sr_ctrls = ctrls;
766
767 return_results:
768         if( dummy.e_attrs ) {
769                 attrs_free( dummy.e_attrs );
770         }
771         send_ldap_result( op, rs );
772
773 #if 0
774         if( rs->sr_err == LDAP_SUCCESS && mdb->bi_txn_cp_kbyte ) {
775                 TXN_CHECKPOINT( mdb->bi_dbenv,
776                         mdb->bi_txn_cp_kbyte, mdb->bi_txn_cp_min, 0 );
777         }
778 #endif
779
780 done:
781         slap_graduate_commit_csn( op );
782
783         if( moi == &opinfo ) {
784                 if( txn != NULL ) {
785                         mdb->mi_numads = numads;
786                         mdb_txn_abort( txn );
787                 }
788                 if ( opinfo.moi_oe.oe_key ) {
789                         LDAP_SLIST_REMOVE( &op->o_extra, &opinfo.moi_oe, OpExtra, oe_next );
790                 }
791         } else {
792                 moi->moi_ref--;
793         }
794
795         if( e != NULL ) {
796                 mdb_entry_return( op, e );
797         }
798
799         if( preread_ctrl != NULL && (*preread_ctrl) != NULL ) {
800                 slap_sl_free( (*preread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
801                 slap_sl_free( *preread_ctrl, op->o_tmpmemctx );
802         }
803         if( postread_ctrl != NULL && (*postread_ctrl) != NULL ) {
804                 slap_sl_free( (*postread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
805                 slap_sl_free( *postread_ctrl, op->o_tmpmemctx );
806         }
807
808         rs->sr_text = NULL;
809
810         return rs->sr_err;
811 }