]> git.sur5r.net Git - openldap/commitdiff
ITS#7736 fix regression in ITS#7733 patch
authorHoward Chu <hyc@openldap.org>
Thu, 31 Oct 2013 23:01:04 +0000 (16:01 -0700)
committerQuanah Gibson-Mount <quanah@openldap.org>
Thu, 31 Oct 2013 23:10:20 +0000 (16:10 -0700)
In d8eccb353b1be7f07e74149dde9a41bb199d74e8

libraries/liblmdb/mdb.c

index ff4c12441bad9eb987dbb9eb61777df8efc35298..9ade333ed951e459ce623b1c1ca0b29169494cf9 100644 (file)
@@ -6079,8 +6079,7 @@ mdb_cursor_del(MDB_cursor *mc, unsigned int flags)
        if (!(mc->mc_flags & C_INITIALIZED))
                return EINVAL;
 
-       mp = mc->mc_pg[mc->mc_top];
-       if (mc->mc_ki[mc->mc_top] >= NUMKEYS(mp))
+       if (mc->mc_ki[mc->mc_top] >= NUMKEYS(mc->mc_pg[mc->mc_top]))
                return MDB_NOTFOUND;
 
        if (!(flags & MDB_NOSPILL) && (rc = mdb_page_spill(mc, NULL, NULL)))
@@ -6090,6 +6089,7 @@ mdb_cursor_del(MDB_cursor *mc, unsigned int flags)
        if (rc)
                return rc;
 
+       mp = mc->mc_pg[mc->mc_top];
        leaf = NODEPTR(mp, mc->mc_ki[mc->mc_top]);
 
        if (!IS_LEAF2(mp) && F_ISSET(leaf->mn_flags, F_DUPDATA)) {
@@ -6107,13 +6107,13 @@ mdb_cursor_del(MDB_cursor *mc, unsigned int flags)
                                } else {
                                        MDB_cursor *m2;
                                        /* shrink fake page */
-                                       mdb_node_shrink(mc->mc_pg[mc->mc_top], mc->mc_ki[mc->mc_top]);
-                                       leaf = NODEPTR(mc->mc_pg[mc->mc_top], mc->mc_ki[mc->mc_top]);
+                                       mdb_node_shrink(mp, mc->mc_ki[mc->mc_top]);
+                                       leaf = NODEPTR(mp, mc->mc_ki[mc->mc_top]);
                                        mc->mc_xcursor->mx_cursor.mc_pg[0] = NODEDATA(leaf);
                                        /* fix other sub-DB cursors pointed at this fake page */
                                        for (m2 = mc->mc_txn->mt_cursors[mc->mc_dbi]; m2; m2=m2->mc_next) {
                                                if (m2 == mc || m2->mc_snum < mc->mc_snum) continue;
-                                               if (m2->mc_pg[mc->mc_top] == mc->mc_pg[mc->mc_top] &&
+                                               if (m2->mc_pg[mc->mc_top] == mp &&
                                                        m2->mc_ki[mc->mc_top] == mc->mc_ki[mc->mc_top])
                                                        m2->mc_xcursor->mx_cursor.mc_pg[0] = NODEDATA(leaf);
                                        }