]> git.sur5r.net Git - openocd/commitdiff
breakpoints: simplify the test to find a breakpoint
authorAntonio Borneo <borneo.antonio@gmail.com>
Thu, 22 Jan 2015 15:22:07 +0000 (23:22 +0800)
committerMatthias Welwarsky <matthias@welwarsky.de>
Mon, 4 Jun 2018 08:17:14 +0000 (09:17 +0100)
The test is overly complicated and unreadable.
Simplify it while keeping the exact same behaviour.

Change-Id: I6b22291ca454e1eddeeab4024d3983dc4c603d3a
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/4512
Tested-by: jenkins
Reviewed-by: Christopher Head <chead@zaber.com>
Reviewed-by: Matthias Welwarsky <matthias@welwarsky.de>
src/target/breakpoints.c

index 7cf4a6957e13e082114a4f03ca788ed808431dc7..58bcc8615906d59de807ba6c192b522dbcb6d86a 100644 (file)
@@ -315,11 +315,8 @@ int breakpoint_remove_internal(struct target *target, target_addr_t address)
        struct breakpoint *breakpoint = target->breakpoints;
 
        while (breakpoint) {
-               if ((breakpoint->address == address) && (breakpoint->asid == 0))
-                       break;
-               else if ((breakpoint->address == 0) && (breakpoint->asid == address))
-                       break;
-               else if ((breakpoint->address == address) && (breakpoint->asid != 0))
+               if ((breakpoint->address == address) ||
+                   (breakpoint->address == 0 && breakpoint->asid == address))
                        break;
                breakpoint = breakpoint->next;
        }