]> git.sur5r.net Git - bacula/bacula/blobdiff - bacula/src/dird/dird_conf.c
This commit was manufactured by cvs2svn to create tag
[bacula/bacula] / bacula / src / dird / dird_conf.c
index f9684021d74ef7fac1519f2877d6dd9468615364..687ab5523cff266e39c1d0f34d40db61e04b8f6e 100644 (file)
@@ -1,7 +1,7 @@
 /*
  *   Main configuration file parser for Bacula Directors,
  *    some parts may be split into separate files such as
- *    the schedule configuration (sch_config.c).
+ *    the schedule configuration (run_config.c).
  *
  *   Note, the configuration file parser consists of three parts
  *
@@ -50,6 +50,7 @@
  */
 int r_first = R_FIRST;
 int r_last  = R_LAST;
+
 pthread_mutex_t res_mutex =  PTHREAD_MUTEX_INITIALIZER;
 
 /* Imported subroutines */
@@ -94,7 +95,7 @@ static struct res_items dir_items[] = {
    {"queryfile",   store_dir,      ITEM(res_dir.query_file), 0, ITEM_REQUIRED, 0},
    {"workingdirectory", store_dir, ITEM(res_dir.working_directory), 0, ITEM_REQUIRED, 0},
    {"piddirectory",store_dir,     ITEM(res_dir.pid_directory), 0, ITEM_REQUIRED, 0},
-   {"subsysdirectory", store_dir,  ITEM(res_dir.subsys_directory), 0, ITEM_REQUIRED, 0},
+   {"subsysdirectory", store_dir,  ITEM(res_dir.subsys_directory), 0, 0, 0},
    {"requiressl",  store_yesno,    ITEM(res_dir.require_ssl), 1, ITEM_DEFAULT, 0},
    {"enablessl",   store_yesno,    ITEM(res_dir.enable_ssl), 1, ITEM_DEFAULT, 0},
    {"maximumconcurrentjobs", store_pint, ITEM(res_dir.MaxConcurrentJobs), 0, ITEM_DEFAULT, 1},
@@ -128,8 +129,10 @@ static struct res_items cli_items[] = {
    {"name",     store_name,       ITEM(res_client.hdr.name), 0, ITEM_REQUIRED, 0},
    {"description", store_str,     ITEM(res_client.hdr.desc), 0, 0, 0},
    {"address",  store_str,        ITEM(res_client.address),  0, ITEM_REQUIRED, 0},
+   {"fdaddress",  store_str,      ITEM(res_client.address),  0, 0, 0},
    {"fdport",   store_pint,       ITEM(res_client.FDport),   0, ITEM_DEFAULT, 9102},
    {"password", store_password,   ITEM(res_client.password), 0, ITEM_REQUIRED, 0},
+   {"fdpassword", store_password,   ITEM(res_client.password), 0, 0, 0},
    {"catalog",  store_res,        ITEM(res_client.catalog),  R_CATALOG, 0, 0},
    {"fileretention", store_time,  ITEM(res_client.FileRetention), 0, ITEM_DEFAULT, 60*60*24*60},
    {"jobretention",  store_time,  ITEM(res_client.JobRetention),  0, ITEM_DEFAULT, 60*60*24*180},
@@ -144,17 +147,20 @@ static struct res_items cli_items[] = {
  *   name         handler     value                 code flags    default_value
  */
 static struct res_items store_items[] = {
-   {"name",      store_name,     ITEM(res_store.hdr.name),   0, ITEM_REQUIRED, 0},
-   {"description", store_str,    ITEM(res_store.hdr.desc),   0, 0, 0},
-   {"sdport",    store_pint,     ITEM(res_store.SDport),     0, ITEM_DEFAULT, 9103},
-   {"sddport",   store_pint,     ITEM(res_store.SDDport),    0, 0, 0}, /* deprecated */
-   {"address",   store_str,      ITEM(res_store.address),    0, ITEM_REQUIRED, 0},
-   {"password",  store_password, ITEM(res_store.password),   0, ITEM_REQUIRED, 0},
-   {"device",    store_strname,  ITEM(res_store.dev_name),   0, ITEM_REQUIRED, 0},
-   {"mediatype", store_strname,  ITEM(res_store.media_type), 0, ITEM_REQUIRED, 0},
-   {"autochanger", store_yesno,  ITEM(res_store.autochanger), 1, ITEM_DEFAULT, 0},
-   {"enablessl", store_yesno,    ITEM(res_store.enable_ssl),  1, ITEM_DEFAULT, 0},
+   {"name",        store_name,     ITEM(res_store.hdr.name),   0, ITEM_REQUIRED, 0},
+   {"description", store_str,      ITEM(res_store.hdr.desc),   0, 0, 0},
+   {"sdport",      store_pint,     ITEM(res_store.SDport),     0, ITEM_DEFAULT, 9103},
+   {"address",     store_str,      ITEM(res_store.address),    0, ITEM_REQUIRED, 0},
+   {"sdaddress",   store_str,      ITEM(res_store.address),    0, 0, 0},
+   {"password",    store_password, ITEM(res_store.password),   0, ITEM_REQUIRED, 0},
+   {"sdpassword",  store_password, ITEM(res_store.password),   0, 0, 0},
+   {"device",      store_strname,  ITEM(res_store.dev_name),   0, ITEM_REQUIRED, 0},
+   {"sddevicename", store_strname, ITEM(res_store.dev_name),   0, 0, 0},
+   {"mediatype",   store_strname,  ITEM(res_store.media_type), 0, ITEM_REQUIRED, 0},
+   {"autochanger", store_yesno,    ITEM(res_store.autochanger), 1, ITEM_DEFAULT, 0},
+   {"enablessl",   store_yesno,    ITEM(res_store.enable_ssl),  1, ITEM_DEFAULT, 0},
    {"maximumconcurrentjobs", store_pint, ITEM(res_store.MaxConcurrentJobs), 0, ITEM_DEFAULT, 1},
+   {"sddport", store_pint, ITEM(res_store.SDDport), 0, 0, 0}, /* deprecated */
    {NULL, NULL, NULL, 0, 0, 0} 
 };
 
@@ -171,6 +177,7 @@ static struct res_items cat_items[] = {
    {"dbport",   store_pint,     ITEM(res_cat.db_port),      0, 0, 0},
    /* keep this password as store_str for the moment */
    {"password", store_str,      ITEM(res_cat.db_password), 0, 0, 0},
+   {"dbpassword", store_str,    ITEM(res_cat.db_password), 0, 0, 0},
    {"user",     store_str,      ITEM(res_cat.db_user),     0, 0, 0},
    {"dbname",   store_str,      ITEM(res_cat.db_name),     0, ITEM_REQUIRED, 0},
    {"dbsocket", store_str,      ITEM(res_cat.db_socket),   0, 0, 0}, 
@@ -196,8 +203,9 @@ static struct res_items job_items[] = {
    {"pool",     store_res,     ITEM(res_job.pool),     R_POOL, 0, 0},
    {"client",   store_res,     ITEM(res_job.client),   R_CLIENT, 0, 0},
    {"fileset",  store_res,     ITEM(res_job.fileset),  R_FILESET, 0, 0},
+   {"verifyjob",  store_res,   ITEM(res_job.verify_job), R_JOB, 0, 0},
    {"where",    store_dir,     ITEM(res_job.RestoreWhere), 0, 0, 0},
-   {"replace",  store_replace, ITEM(res_job.replace), REPLACE_ALWAYS, ITEM_DEFAULT, 0},
+   {"replace",  store_replace, ITEM(res_job.replace), 0, ITEM_DEFAULT, REPLACE_ALWAYS},
    {"bootstrap",store_dir,     ITEM(res_job.RestoreBootstrap), 0, 0, 0},
    {"maxruntime", store_time,  ITEM(res_job.MaxRunTime), 0, 0, 0},
    {"maxstartdelay", store_time,ITEM(res_job.MaxStartDelay), 0, 0, 0},
@@ -207,9 +215,17 @@ static struct res_items job_items[] = {
    {"prunevolumes", store_yesno, ITEM(res_job.PruneVolumes), 1, ITEM_DEFAULT, 0},
    {"runbeforejob", store_str,  ITEM(res_job.RunBeforeJob), 0, 0, 0},
    {"runafterjob",  store_str,  ITEM(res_job.RunAfterJob),  0, 0, 0},
+   {"runafterfailedjob",  store_str,  ITEM(res_job.RunAfterFailedJob),  0, 0, 0},
+   {"clientrunbeforejob", store_str,  ITEM(res_job.ClientRunBeforeJob), 0, 0, 0},
+   {"clientrunafterjob",  store_str,  ITEM(res_job.ClientRunAfterJob),  0, 0, 0},
    {"spoolattributes", store_yesno, ITEM(res_job.SpoolAttributes), 1, ITEM_DEFAULT, 0},
    {"writebootstrap", store_dir, ITEM(res_job.WriteBootstrap), 0, 0, 0},
    {"maximumconcurrentjobs", store_pint, ITEM(res_job.MaxConcurrentJobs), 0, ITEM_DEFAULT, 1},
+   {"rescheduleonerror", store_yesno, ITEM(res_job.RescheduleOnError), 1, ITEM_DEFAULT, 0},
+   {"rescheduleinterval", store_time, ITEM(res_job.RescheduleInterval), 0, ITEM_DEFAULT, 60 * 30},
+   {"rescheduletimes", store_pint, ITEM(res_job.RescheduleTimes), 0, 0, 0},
+   {"priority",   store_pint, ITEM(res_job.Priority), 0, ITEM_DEFAULT, 10},
+   {"jobretention",  store_time,  ITEM(res_job.JobRetention),  0, 0, 0},
    {NULL, NULL, NULL, 0, 0, 0} 
 };
 
@@ -220,10 +236,8 @@ static struct res_items job_items[] = {
 static struct res_items fs_items[] = {
    {"name",        store_name, ITEM(res_fs.hdr.name), 0, ITEM_REQUIRED, 0},
    {"description", store_str,  ITEM(res_fs.hdr.desc), 0, 0, 0},
-   {"include",     store_inc,  NULL,                  0, 0, 0},
-   {"finclude",    store_finc, NULL,                  0, ITEM_NO_EQUALS, 0},
-   {"exclude",     store_inc,  NULL,                  1, 0, 0},
-   {"fexclude",    store_finc, NULL,                  1, ITEM_NO_EQUALS, 0},
+   {"include",     store_inc,  NULL,                  0, ITEM_NO_EQUALS, 0},
+   {"exclude",     store_inc,  NULL,                  1, ITEM_NO_EQUALS, 0},
    {NULL,         NULL,       NULL,                  0, 0, 0} 
 };
 
@@ -261,7 +275,9 @@ static struct res_items pool_items[] = {
    {"cleaningprefix",  store_strname, ITEM(res_pool.cleaning_prefix),  0, 0,     0},
    {"usecatalog",      store_yesno, ITEM(res_pool.use_catalog),     1, ITEM_DEFAULT,  1},
    {"usevolumeonce",   store_yesno, ITEM(res_pool.use_volume_once), 1, 0,        0},
+   {"purgeoldestvolume", store_yesno, ITEM(res_pool.purge_oldest_volume), 1, 0, 0},
    {"recycleoldestvolume", store_yesno, ITEM(res_pool.recycle_oldest_volume), 1, 0, 0},
+   {"recyclecurrentvolume", store_yesno, ITEM(res_pool.recycle_current_volume), 1, 0, 0},
    {"maximumvolumes",  store_pint,  ITEM(res_pool.max_volumes),     0, 0,        0},
    {"maximumvolumejobs", store_pint,  ITEM(res_pool.MaxVolJobs),    0, 0,       0},
    {"maximumvolumefiles", store_pint, ITEM(res_pool.MaxVolFiles),   0, 0,       0},
@@ -284,8 +300,8 @@ static struct res_items counter_items[] = {
    {"description",     store_str,     ITEM(res_counter.hdr.desc),        0, 0,     0},
    {"minimum",         store_int,     ITEM(res_counter.MinValue),        0, ITEM_DEFAULT, 0},
    {"maximum",         store_pint,    ITEM(res_counter.MaxValue),        0, ITEM_DEFAULT, INT32_MAX},
-   {"global",          store_yesno,   ITEM(res_counter.Global),          0, ITEM_DEFAULT, 0},
-   {"wrapcounter",     store_strname, ITEM(res_counter.WrapCounter),     0, 0, 0},
+   {"wrapcounter",     store_res,     ITEM(res_counter.WrapCounter),     R_COUNTER, 0, 0},
+   {"catalog",         store_res,     ITEM(res_counter.Catalog),         R_CATALOG, 0, 0},
    {NULL, NULL, NULL, 0, 0, 0} 
 };
 
@@ -297,11 +313,13 @@ extern struct res_items msgs_items[];
  * This is the master resource definition.  
  * It must have one item for each of the resources.
  *
+ *  NOTE!!! keep it in the same order as the R_codes
+ *    or eliminate all resources[rindex].name
+ *
  *  name            items        rcode        res_head
  */
 struct s_res resources[] = {
    {"director",      dir_items,   R_DIRECTOR,  NULL},
-   {"console",       con_items,   R_CONSOLE,   NULL},
    {"client",        cli_items,   R_CLIENT,    NULL},
    {"job",           job_items,   R_JOB,       NULL},
    {"storage",       store_items, R_STORAGE,   NULL},
@@ -312,6 +330,7 @@ struct s_res resources[] = {
    {"pool",          pool_items,  R_POOL,      NULL},
    {"messages",      msgs_items,  R_MSGS,      NULL},
    {"counter",       counter_items, R_COUNTER, NULL},
+   {"console",       con_items,   R_CONSOLE,   NULL},
    {NULL,           NULL,        0,           NULL}
 };
 
@@ -322,13 +341,17 @@ struct s_res resources[] = {
  */
 struct s_jl joblevels[] = {
    {"Full",          L_FULL,            JT_BACKUP},
+   {"Base",          L_BASE,            JT_BACKUP},
    {"Incremental",   L_INCREMENTAL,     JT_BACKUP},
    {"Differential",  L_DIFFERENTIAL,    JT_BACKUP},
    {"Since",         L_SINCE,           JT_BACKUP},
    {"Catalog",       L_VERIFY_CATALOG,  JT_VERIFY},
-   {"Initcatalog",   L_VERIFY_INIT,     JT_VERIFY},
+   {"InitCatalog",   L_VERIFY_INIT,     JT_VERIFY},
    {"VolumeToCatalog", L_VERIFY_VOLUME_TO_CATALOG,   JT_VERIFY},
+   {"DiskToCatalog", L_VERIFY_DISK_TO_CATALOG,   JT_VERIFY},
    {"Data",          L_VERIFY_DATA,     JT_VERIFY},
+   {" ",             L_NONE,            JT_ADMIN},
+   {" ",             L_NONE,            JT_RESTORE},
    {NULL,           0}
 };
 
@@ -393,7 +416,8 @@ char *level_to_str(int level)
 void dump_resource(int type, RES *reshdr, void sendit(void *sock, char *fmt, ...), void *sock)
 {
    URES *res = (URES *)reshdr;
-   int recurse = 1;
+   bool recurse = true;
+   char ed1[100], ed2[100];
 
    if (res == NULL) {
       sendit(sock, "No %s resource defined\n", res_to_str(type));
@@ -401,221 +425,262 @@ void dump_resource(int type, RES *reshdr, void sendit(void *sock, char *fmt, ...
    }
    if (type < 0) {                   /* no recursion */
       type = - type;
-      recurse = 0;
+      recurse = false;
    }
    switch (type) {
-      case R_DIRECTOR:
-        char ed1[30], ed2[30];
-         sendit(sock, "Director: name=%s MaxJobs=%d FDtimeout=%s SDtimeout=%s\n", 
-           reshdr->name, res->res_dir.MaxConcurrentJobs, 
-           edit_uint64(res->res_dir.FDConnectTimeout, ed1),
-           edit_uint64(res->res_dir.SDConnectTimeout, ed2));
-        if (res->res_dir.query_file) {
-            sendit(sock, "   query_file=%s\n", res->res_dir.query_file);
-        }
-        if (res->res_dir.messages) {
-            sendit(sock, "  --> ");
-           dump_resource(-R_MSGS, (RES *)res->res_dir.messages, sendit, sock);
-        }
-        break;
-      case R_CONSOLE:
-         sendit(sock, "Console name=%s SSL=%d\n", 
-           res->res_con.hdr.name, res->res_con.enable_ssl);
-        break;
-      case R_CLIENT:
-         sendit(sock, "Client: name=%s address=%s FDport=%d MaxJobs=%u\n",
-           res->res_client.hdr.name, res->res_client.address, res->res_client.FDport,
-           res->res_client.MaxConcurrentJobs);
-         sendit(sock, "      JobRetention=%" lld " FileRetention=%" lld " AutoPrune=%d\n",
-           res->res_client.JobRetention, res->res_client.FileRetention,
-           res->res_client.AutoPrune);
-        if (res->res_client.catalog) {
-            sendit(sock, "  --> ");
-           dump_resource(-R_CATALOG, (RES *)res->res_client.catalog, sendit, sock);
-        }
-        break;
-      case R_STORAGE:
-         sendit(sock, "Storage: name=%s address=%s SDport=%d MaxJobs=%u\n\
-         DeviceName=%s MediaType=%s\n",
-           res->res_store.hdr.name, res->res_store.address, res->res_store.SDport,
-           res->res_store.MaxConcurrentJobs,
-           res->res_store.dev_name, res->res_store.media_type);
-        break;
-      case R_CATALOG:
-         sendit(sock, "Catalog: name=%s address=%s DBport=%d db_name=%s\n\
-         db_user=%s\n",
-           res->res_cat.hdr.name, NPRT(res->res_cat.db_address),
-           res->res_cat.db_port, res->res_cat.db_name, NPRT(res->res_cat.db_user));
-        break;
-      case R_JOB:
-         sendit(sock, "Job: name=%s JobType=%d level=%s MaxJobs=%u\n", 
-           res->res_job.hdr.name, res->res_job.JobType, 
-           level_to_str(res->res_job.level), res->res_job.MaxConcurrentJobs);
-        if (res->res_job.client) {
-            sendit(sock, "  --> ");
-           dump_resource(-R_CLIENT, (RES *)res->res_job.client, sendit, sock);
-        }
-        if (res->res_job.fileset) {
-            sendit(sock, "  --> ");
-           dump_resource(-R_FILESET, (RES *)res->res_job.fileset, sendit, sock);
+   case R_DIRECTOR:
+      sendit(sock, "Director: name=%s MaxJobs=%d FDtimeout=%s SDtimeout=%s\n", 
+        reshdr->name, res->res_dir.MaxConcurrentJobs, 
+        edit_uint64(res->res_dir.FDConnectTimeout, ed1),
+        edit_uint64(res->res_dir.SDConnectTimeout, ed2));
+      if (res->res_dir.query_file) {
+         sendit(sock, "   query_file=%s\n", res->res_dir.query_file);
+      }
+      if (res->res_dir.messages) {
+         sendit(sock, "  --> ");
+        dump_resource(-R_MSGS, (RES *)res->res_dir.messages, sendit, sock);
+      }
+      break;
+   case R_CONSOLE:
+      sendit(sock, "Console: name=%s SSL=%d\n", 
+        res->res_con.hdr.name, res->res_con.enable_ssl);
+      break;
+   case R_COUNTER:
+      if (res->res_counter.WrapCounter) {
+         sendit(sock, "Counter: name=%s min=%d max=%d cur=%d wrapcntr=%s\n",
+           res->res_counter.hdr.name, res->res_counter.MinValue, 
+           res->res_counter.MaxValue, res->res_counter.CurrentValue,
+           res->res_counter.WrapCounter->hdr.name);
+      } else {
+         sendit(sock, "Counter: name=%s min=%d max=%d\n",
+           res->res_counter.hdr.name, res->res_counter.MinValue, 
+           res->res_counter.MaxValue);
+      }
+      if (res->res_counter.Catalog) {
+         sendit(sock, "  --> ");
+        dump_resource(-R_CATALOG, (RES *)res->res_counter.Catalog, sendit, sock);
+      }
+      break;
+
+   case R_CLIENT:
+      sendit(sock, "Client: name=%s address=%s FDport=%d MaxJobs=%u\n",
+        res->res_client.hdr.name, res->res_client.address, res->res_client.FDport,
+        res->res_client.MaxConcurrentJobs);
+      sendit(sock, "      JobRetention=%s FileRetention=%s AutoPrune=%d\n",
+        edit_utime(res->res_client.JobRetention, ed1), 
+        edit_utime(res->res_client.FileRetention, ed2),
+        res->res_client.AutoPrune);
+      if (res->res_client.catalog) {
+         sendit(sock, "  --> ");
+        dump_resource(-R_CATALOG, (RES *)res->res_client.catalog, sendit, sock);
+      }
+      break;
+   case R_STORAGE:
+      sendit(sock, "Storage: name=%s address=%s SDport=%d MaxJobs=%u\n\
+      DeviceName=%s MediaType=%s\n",
+        res->res_store.hdr.name, res->res_store.address, res->res_store.SDport,
+        res->res_store.MaxConcurrentJobs,
+        res->res_store.dev_name, res->res_store.media_type);
+      break;
+   case R_CATALOG:
+      sendit(sock, "Catalog: name=%s address=%s DBport=%d db_name=%s\n\
+      db_user=%s\n",
+        res->res_cat.hdr.name, NPRT(res->res_cat.db_address),
+        res->res_cat.db_port, res->res_cat.db_name, NPRT(res->res_cat.db_user));
+      break;
+   case R_JOB:
+      sendit(sock, "%s: name=%s JobType=%d level=%s Priority=%d MaxJobs=%u\n", 
+         type == R_JOB ? "Job" : "JobDefs",
+        res->res_job.hdr.name, res->res_job.JobType, 
+        level_to_str(res->res_job.level), res->res_job.Priority,
+        res->res_job.MaxConcurrentJobs);
+      sendit(sock, "     Resched=%d Times=%d Interval=%s\n",
+         res->res_job.RescheduleOnError, res->res_job.RescheduleTimes,
+         edit_uint64_with_commas(res->res_job.RescheduleInterval, ed1));
+      if (res->res_job.client) {
+         sendit(sock, "  --> ");
+        dump_resource(-R_CLIENT, (RES *)res->res_job.client, sendit, sock);
+      }
+      if (res->res_job.fileset) {
+         sendit(sock, "  --> ");
+        dump_resource(-R_FILESET, (RES *)res->res_job.fileset, sendit, sock);
+      }
+      if (res->res_job.schedule) {
+         sendit(sock, "  --> ");
+        dump_resource(-R_SCHEDULE, (RES *)res->res_job.schedule, sendit, sock);
+      }
+      if (res->res_job.RestoreWhere) {
+         sendit(sock, "  --> Where=%s\n", NPRT(res->res_job.RestoreWhere));
+      }
+      if (res->res_job.RestoreBootstrap) {
+         sendit(sock, "  --> Bootstrap=%s\n", NPRT(res->res_job.RestoreBootstrap));
+      }
+      if (res->res_job.RunBeforeJob) {
+         sendit(sock, "  --> RunBefore=%s\n", NPRT(res->res_job.RunBeforeJob));
+      }
+      if (res->res_job.RunAfterJob) {
+         sendit(sock, "  --> RunAfter=%s\n", NPRT(res->res_job.RunAfterJob));
+      }
+      if (res->res_job.RunAfterFailedJob) {
+         sendit(sock, "  --> RunAfterFailed=%s\n", NPRT(res->res_job.RunAfterFailedJob));
+      }
+      if (res->res_job.WriteBootstrap) {
+         sendit(sock, "  --> WriteBootstrap=%s\n", NPRT(res->res_job.WriteBootstrap));
+      }
+      if (res->res_job.storage) {
+         sendit(sock, "  --> ");
+        dump_resource(-R_STORAGE, (RES *)res->res_job.storage, sendit, sock);
+      }
+      if (res->res_job.pool) {
+         sendit(sock, "  --> ");
+        dump_resource(-R_POOL, (RES *)res->res_job.pool, sendit, sock);
+      } else {
+         sendit(sock, "!!! No Pool resource\n");
+      }
+      if (res->res_job.verify_job) {
+         sendit(sock, "  --> ");
+        dump_resource(-type, (RES *)res->res_job.verify_job, sendit, sock);
+      }
+      break;
+      if (res->res_job.messages) {
+         sendit(sock, "  --> ");
+        dump_resource(-R_MSGS, (RES *)res->res_job.messages, sendit, sock);
+      }
+      break;
+   case R_FILESET:
+      sendit(sock, "FileSet: name=%s\n", res->res_fs.hdr.name);
+      for (int i=0; i<res->res_fs.num_includes; i++) {
+        INCEXE *incexe = res->res_fs.include_items[i];
+        for (int j=0; j<incexe->name_list.size(); j++) {
+            sendit(sock, "      Inc: %s\n", incexe->name_list.get(j));
         }
-        if (res->res_job.schedule) {
-            sendit(sock, "  --> ");
-           dump_resource(-R_SCHEDULE, (RES *)res->res_job.schedule, sendit, sock);
+      }
+      for (int i=0; i<res->res_fs.num_excludes; i++) {
+        INCEXE *incexe = res->res_fs.exclude_items[i];
+        for (int j=0; j<incexe->name_list.size(); j++) {
+            sendit(sock, "      Exc: %s\n", incexe->name_list.get(j));
         }
-        if (res->res_job.RestoreWhere) {
-            sendit(sock, "  --> Where=%s\n", NPRT(res->res_job.RestoreWhere));
+      }
+      break;
+   case R_SCHEDULE:
+      if (res->res_sch.run) {
+        int i;
+        RUN *run = res->res_sch.run;
+        char buf[1000], num[10];
+         sendit(sock, "Schedule: name=%s\n", res->res_sch.hdr.name);
+        if (!run) {
+           break;
         }
-        if (res->res_job.RestoreBootstrap) {
-            sendit(sock, "  --> Bootstrap=%s\n", NPRT(res->res_job.RestoreBootstrap));
+next_run:
+         sendit(sock, "  --> Run Level=%s\n", level_to_str(run->level));
+         bstrncpy(buf, "      hour=", sizeof(buf));
+        for (i=0; i<24; i++) {
+           if (bit_is_set(i, run->hour)) {
+               sprintf(num, "%d ", i);
+              bstrncat(buf, num, sizeof(buf));
+           }
         }
-        if (res->res_job.RunBeforeJob) {
-            sendit(sock, "  --> RunBefore=%s\n", NPRT(res->res_job.RunBeforeJob));
+         bstrncat(buf, "\n", sizeof(buf));
+        sendit(sock, buf);
+         bstrncpy(buf, "      mday=", sizeof(buf));
+        for (i=0; i<31; i++) {
+           if (bit_is_set(i, run->mday)) {
+               sprintf(num, "%d ", i+1);
+              bstrncat(buf, num, sizeof(buf));
+           }
         }
-        if (res->res_job.RunAfterJob) {
-            sendit(sock, "  --> RunAfter=%s\n", NPRT(res->res_job.RunAfterJob));
+         bstrncat(buf, "\n", sizeof(buf));
+        sendit(sock, buf);
+         bstrncpy(buf, "      month=", sizeof(buf));
+        for (i=0; i<12; i++) {
+           if (bit_is_set(i, run->month)) {
+               sprintf(num, "%d ", i+1);
+              bstrncat(buf, num, sizeof(buf));
+           }
         }
-        if (res->res_job.WriteBootstrap) {
-            sendit(sock, "  --> WriteBootstrap=%s\n", NPRT(res->res_job.WriteBootstrap));
+         bstrncat(buf, "\n", sizeof(buf));
+        sendit(sock, buf);
+         bstrncpy(buf, "      wday=", sizeof(buf));
+        for (i=0; i<7; i++) {
+           if (bit_is_set(i, run->wday)) {
+               sprintf(num, "%d ", i+1);
+              bstrncat(buf, num, sizeof(buf));
+           }
         }
-        if (res->res_job.storage) {
-            sendit(sock, "  --> ");
-           dump_resource(-R_STORAGE, (RES *)res->res_job.storage, sendit, sock);
+         bstrncat(buf, "\n", sizeof(buf));
+        sendit(sock, buf);
+         bstrncpy(buf, "      wom=", sizeof(buf));
+        for (i=0; i<5; i++) {
+           if (bit_is_set(i, run->wom)) {
+               sprintf(num, "%d ", i+1);
+              bstrncat(buf, num, sizeof(buf));
+           }
         }
-        if (res->res_job.pool) {
-            sendit(sock, "  --> ");
-           dump_resource(-R_POOL, (RES *)res->res_job.pool, sendit, sock);
-        } else {
-            sendit(sock, "!!! No Pool resource\n");
+         bstrncat(buf, "\n", sizeof(buf));
+        sendit(sock, buf);
+         bstrncpy(buf, "      woy=", sizeof(buf));
+        for (i=0; i<54; i++) {
+           if (bit_is_set(i, run->woy)) {
+               sprintf(num, "%d ", i);
+              bstrncat(buf, num, sizeof(buf));
+           }
         }
-        if (res->res_job.messages) {
-            sendit(sock, "  --> ");
-           dump_resource(-R_MSGS, (RES *)res->res_job.messages, sendit, sock);
+         bstrncat(buf, "\n", sizeof(buf));
+        sendit(sock, buf);
+         sendit(sock, "      mins=%d\n", run->minute);
+        if (run->pool) {
+            sendit(sock, "     --> ");
+           dump_resource(-R_POOL, (RES *)run->pool, sendit, sock);
         }
-        break;
-      case R_FILESET:
-         sendit(sock, "FileSet: name=%s\n", res->res_fs.hdr.name);
-        for (int i=0; i<res->res_fs.num_includes; i++) {
-           INCEXE *incexe = res->res_fs.include_items[i];
-           for (int j=0; j<incexe->num_names; j++) {
-               sendit(sock, "      Inc: %s\n", incexe->name_list[j]);
-           }
+        if (run->storage) {
+            sendit(sock, "     --> ");
+           dump_resource(-R_STORAGE, (RES *)run->storage, sendit, sock);
         }
-        for (int i=0; i<res->res_fs.num_excludes; i++) {
-           INCEXE *incexe = res->res_fs.exclude_items[i];
-           for (int j=0; j<incexe->num_names; j++) {
-               sendit(sock, "      Exc: %s\n", incexe->name_list[j]);
-           }
+        if (run->msgs) {
+            sendit(sock, "     --> ");
+           dump_resource(-R_MSGS, (RES *)run->msgs, sendit, sock);
         }
-        break;
-      case R_SCHEDULE:
-        if (res->res_sch.run) {
-           int i;
-           RUN *run = res->res_sch.run;
-           char buf[1000], num[10];
-            sendit(sock, "Schedule: name=%s\n", res->res_sch.hdr.name);
-           if (!run) {
-              break;
-           }
-next_run:
-            sendit(sock, "  --> Run Level=%s\n", level_to_str(run->level));
-            strcpy(buf, "      hour=");
-           for (i=0; i<24; i++) {
-              if (bit_is_set(i, run->hour)) {
-                  sprintf(num, "%d ", i);
-                 strcat(buf, num);
-              }
-           }
-            strcat(buf, "\n");
-           sendit(sock, buf);
-            strcpy(buf, "      mday=");
-           for (i=0; i<31; i++) {
-              if (bit_is_set(i, run->mday)) {
-                  sprintf(num, "%d ", i+1);
-                 strcat(buf, num);
-              }
-           }
-            strcat(buf, "\n");
-           sendit(sock, buf);
-            strcpy(buf, "      month=");
-           for (i=0; i<12; i++) {
-              if (bit_is_set(i, run->month)) {
-                  sprintf(num, "%d ", i+1);
-                 strcat(buf, num);
-              }
-           }
-            strcat(buf, "\n");
-           sendit(sock, buf);
-            strcpy(buf, "      wday=");
-           for (i=0; i<7; i++) {
-              if (bit_is_set(i, run->wday)) {
-                  sprintf(num, "%d ", i+1);
-                 strcat(buf, num);
-              }
-           }
-            strcat(buf, "\n");
-           sendit(sock, buf);
-            strcpy(buf, "      wpos=");
-           for (i=0; i<5; i++) {
-              if (bit_is_set(i, run->wpos)) {
-                  sprintf(num, "%d ", i+1);
-                 strcat(buf, num);
-              }
-           }
-            strcat(buf, "\n");
-           sendit(sock, buf);
-            sendit(sock, "      mins=%d\n", run->minute);
-           if (run->pool) {
-               sendit(sock, "     --> ");
-              dump_resource(-R_POOL, (RES *)run->pool, sendit, sock);
-           }
-           if (run->storage) {
-               sendit(sock, "     --> ");
-              dump_resource(-R_STORAGE, (RES *)run->storage, sendit, sock);
-           }
-           if (run->msgs) {
-               sendit(sock, "     --> ");
-              dump_resource(-R_MSGS, (RES *)run->msgs, sendit, sock);
-           }
-           /* If another Run record is chained in, go print it */
-           if (run->next) {
-              run = run->next;
-              goto next_run;
-           }
-        } else {
-            sendit(sock, "Schedule: name=%s\n", res->res_sch.hdr.name);
+        /* If another Run record is chained in, go print it */
+        if (run->next) {
+           run = run->next;
+           goto next_run;
         }
-        break;
-      case R_GROUP:
-         sendit(sock, "Group: name=%s\n", res->res_group.hdr.name);
-        break;
-      case R_POOL:
-         sendit(sock, "Pool: name=%s PoolType=%s\n", res->res_pool.hdr.name,
-                res->res_pool.pool_type);
-         sendit(sock, "      use_cat=%d use_once=%d acpt_any=%d cat_files=%d\n",
-                res->res_pool.use_catalog, res->res_pool.use_volume_once,
-                res->res_pool.accept_any_volume, res->res_pool.catalog_files);
-         sendit(sock, "      max_vols=%d auto_prune=%d VolRetention=%" lld "\n",
-                res->res_pool.max_volumes, res->res_pool.AutoPrune,
-                res->res_pool.VolRetention);
-         sendit(sock, "      recycle=%d LabelFormat=%s\n", res->res_pool.Recycle,
-                NPRT(res->res_pool.label_format));
-         sendit(sock, "      CleaningPrefix=%s\n",
-                NPRT(res->res_pool.cleaning_prefix));
-         sendit(sock, "      recyleOldest=%d MaxVolJobs=%d MaxVolFiles=%d\n",
-                res->res_pool.recycle_oldest_volume, 
-                res->res_pool.MaxVolJobs, res->res_pool.MaxVolFiles);
-        break;
-      case R_MSGS:
-         sendit(sock, "Messages: name=%s\n", res->res_msgs.hdr.name);
-        if (res->res_msgs.mail_cmd) 
-            sendit(sock, "      mailcmd=%s\n", res->res_msgs.mail_cmd);
-        if (res->res_msgs.operator_cmd) 
-            sendit(sock, "      opcmd=%s\n", res->res_msgs.operator_cmd);
-        break;
-      default:
-         sendit(sock, "Unknown resource type %d in dump_resource.\n", type);
-        break;
+      } else {
+         sendit(sock, "Schedule: name=%s\n", res->res_sch.hdr.name);
+      }
+      break;
+   case R_GROUP:
+      sendit(sock, "Group: name=%s\n", res->res_group.hdr.name);
+      break;
+   case R_POOL:
+      sendit(sock, "Pool: name=%s PoolType=%s\n", res->res_pool.hdr.name,
+             res->res_pool.pool_type);
+      sendit(sock, "      use_cat=%d use_once=%d acpt_any=%d cat_files=%d\n",
+             res->res_pool.use_catalog, res->res_pool.use_volume_once,
+             res->res_pool.accept_any_volume, res->res_pool.catalog_files);
+      sendit(sock, "      max_vols=%d auto_prune=%d VolRetention=%s\n",
+             res->res_pool.max_volumes, res->res_pool.AutoPrune,
+             edit_utime(res->res_pool.VolRetention, ed1));
+      sendit(sock, "      VolUse=%s recycle=%d LabelFormat=%s\n", 
+             edit_utime(res->res_pool.VolUseDuration, ed1),
+             res->res_pool.Recycle,
+             NPRT(res->res_pool.label_format));
+      sendit(sock, "      CleaningPrefix=%s\n",
+             NPRT(res->res_pool.cleaning_prefix));
+      sendit(sock, "      recyleOldest=%d MaxVolJobs=%d MaxVolFiles=%d\n",
+             res->res_pool.purge_oldest_volume, 
+             res->res_pool.MaxVolJobs, res->res_pool.MaxVolFiles);
+      break;
+   case R_MSGS:
+      sendit(sock, "Messages: name=%s\n", res->res_msgs.hdr.name);
+      if (res->res_msgs.mail_cmd) 
+         sendit(sock, "      mailcmd=%s\n", res->res_msgs.mail_cmd);
+      if (res->res_msgs.operator_cmd) 
+         sendit(sock, "      opcmd=%s\n", res->res_msgs.operator_cmd);
+      break;
+   default:
+      sendit(sock, "Unknown resource type %d in dump_resource.\n", type);
+      break;
    }
    if (recurse && res->res_dir.hdr.next) {
       dump_resource(type, res->res_dir.hdr.next, sendit, sock);
@@ -627,23 +692,11 @@ next_run:
  */
 static void free_incexe(INCEXE *incexe)
 {
-   for (int i=0; i<incexe->num_names; i++) {
-      free(incexe->name_list[i]);
-   }
-   if (incexe->name_list) {
-      free(incexe->name_list);
-   }
+   incexe->name_list.destroy();
    for (int i=0; i<incexe->num_opts; i++) {
       FOPTS *fopt = incexe->opts_list[i];
-      if (fopt->match) {
-        free(fopt->match);
-      }
-      for (int j=0; j<fopt->num_base; j++) {
-        free(fopt->base_list[j]);
-      }
-      if (fopt->base_list) {
-        free(fopt->base_list);
-      }
+      fopt->match.destroy();
+      fopt->base_list.destroy();
       free(fopt);
    }
    if (incexe->opts_list) {
@@ -681,137 +734,150 @@ void free_resource(int type)
    }
 
    switch (type) {
-      case R_DIRECTOR:
-        if (res->res_dir.working_directory) {
-           free(res->res_dir.working_directory);
-        }
-        if (res->res_dir.pid_directory) {
-           free(res->res_dir.pid_directory);
-        }
-        if (res->res_dir.subsys_directory) {
-           free(res->res_dir.subsys_directory);
-        }
-        if (res->res_dir.password) {
-           free(res->res_dir.password);
-        }
-        if (res->res_dir.query_file) {
-           free(res->res_dir.query_file);
-        }
-        if (res->res_dir.DIRaddr) {
-           free(res->res_dir.DIRaddr);
-        }
-        break;
-      case R_CONSOLE:
-        if (res->res_con.password) {
-           free(res->res_con.password);
-        }
-        break;
-      case R_CLIENT:
-        if (res->res_client.address) {
-           free(res->res_client.address);
-        }
-        if (res->res_client.password) {
-           free(res->res_client.password);
-        }
-        break;
-      case R_STORAGE:
-        if (res->res_store.address) {
-           free(res->res_store.address);
-        }
-        if (res->res_store.password) {
-           free(res->res_store.password);
-        }
-        if (res->res_store.media_type) {
-           free(res->res_store.media_type);
-        }
-        if (res->res_store.dev_name) {
-           free(res->res_store.dev_name);
-        }
-        break;
-      case R_CATALOG:
-        if (res->res_cat.db_address) {
-           free(res->res_cat.db_address);
-        }
-        if (res->res_cat.db_socket) {
-           free(res->res_cat.db_socket);
-        }
-        if (res->res_cat.db_user) {
-           free(res->res_cat.db_user);
-        }
-        if (res->res_cat.db_name) {
-           free(res->res_cat.db_name);
-        }
-        if (res->res_cat.db_password) {
-           free(res->res_cat.db_password);
-        }
-        break;
-      case R_FILESET:
-        if ((num=res->res_fs.num_includes)) {
-           while (--num >= 0) {   
-              free_incexe(res->res_fs.include_items[num]);
-           }
-           free(res->res_fs.include_items);
-        }
-        res->res_fs.num_includes = 0;
-        if ((num=res->res_fs.num_excludes)) {
-           while (--num >= 0) {   
-              free_incexe(res->res_fs.exclude_items[num]);
-           }
-           free(res->res_fs.exclude_items);
-        }
-        res->res_fs.num_excludes = 0;
-        break;
-      case R_POOL:
-        if (res->res_pool.pool_type) {
-           free(res->res_pool.pool_type);
-        }
-        if (res->res_pool.label_format) {
-           free(res->res_pool.label_format);
-        }
-        if (res->res_pool.cleaning_prefix) {
-           free(res->res_pool.cleaning_prefix);
-        }
-        break;
-      case R_SCHEDULE:
-        if (res->res_sch.run) {
-           RUN *nrun, *next;
-           nrun = res->res_sch.run;
-           while (nrun) {
-              next = nrun->next;
-              free(nrun);
-              nrun = next;
-           }
-        }
-        break;
-      case R_JOB:
-        if (res->res_job.RestoreWhere) {
-           free(res->res_job.RestoreWhere);
-        }
-        if (res->res_job.RestoreBootstrap) {
-           free(res->res_job.RestoreBootstrap);
-        }
-        if (res->res_job.WriteBootstrap) {
-           free(res->res_job.WriteBootstrap);
+   case R_DIRECTOR:
+      if (res->res_dir.working_directory) {
+        free(res->res_dir.working_directory);
+      }
+      if (res->res_dir.pid_directory) {
+        free(res->res_dir.pid_directory);
+      }
+      if (res->res_dir.subsys_directory) {
+        free(res->res_dir.subsys_directory);
+      }
+      if (res->res_dir.password) {
+        free(res->res_dir.password);
+      }
+      if (res->res_dir.query_file) {
+        free(res->res_dir.query_file);
+      }
+      if (res->res_dir.DIRaddr) {
+        free(res->res_dir.DIRaddr);
+      }
+      break;
+   case R_COUNTER:
+       break;
+   case R_CONSOLE:
+      if (res->res_con.password) {
+        free(res->res_con.password);
+      }
+      break;
+   case R_CLIENT:
+      if (res->res_client.address) {
+        free(res->res_client.address);
+      }
+      if (res->res_client.password) {
+        free(res->res_client.password);
+      }
+      break;
+   case R_STORAGE:
+      if (res->res_store.address) {
+        free(res->res_store.address);
+      }
+      if (res->res_store.password) {
+        free(res->res_store.password);
+      }
+      if (res->res_store.media_type) {
+        free(res->res_store.media_type);
+      }
+      if (res->res_store.dev_name) {
+        free(res->res_store.dev_name);
+      }
+      break;
+   case R_CATALOG:
+      if (res->res_cat.db_address) {
+        free(res->res_cat.db_address);
+      }
+      if (res->res_cat.db_socket) {
+        free(res->res_cat.db_socket);
+      }
+      if (res->res_cat.db_user) {
+        free(res->res_cat.db_user);
+      }
+      if (res->res_cat.db_name) {
+        free(res->res_cat.db_name);
+      }
+      if (res->res_cat.db_password) {
+        free(res->res_cat.db_password);
+      }
+      break;
+   case R_FILESET:
+      if ((num=res->res_fs.num_includes)) {
+        while (--num >= 0) {   
+           free_incexe(res->res_fs.include_items[num]);
         }
-        if (res->res_job.RunBeforeJob) {
-           free(res->res_job.RunBeforeJob);
+        free(res->res_fs.include_items);
+      }
+      res->res_fs.num_includes = 0;
+      if ((num=res->res_fs.num_excludes)) {
+        while (--num >= 0) {   
+           free_incexe(res->res_fs.exclude_items[num]);
         }
-        if (res->res_job.RunAfterJob) {
-           free(res->res_job.RunAfterJob);
+        free(res->res_fs.exclude_items);
+      }
+      res->res_fs.num_excludes = 0;
+      break;
+   case R_POOL:
+      if (res->res_pool.pool_type) {
+        free(res->res_pool.pool_type);
+      }
+      if (res->res_pool.label_format) {
+        free(res->res_pool.label_format);
+      }
+      if (res->res_pool.cleaning_prefix) {
+        free(res->res_pool.cleaning_prefix);
+      }
+      break;
+   case R_SCHEDULE:
+      if (res->res_sch.run) {
+        RUN *nrun, *next;
+        nrun = res->res_sch.run;
+        while (nrun) {
+           next = nrun->next;
+           free(nrun);
+           nrun = next;
         }
-        break;
-      case R_MSGS:
-        if (res->res_msgs.mail_cmd)
-           free(res->res_msgs.mail_cmd);
-        if (res->res_msgs.operator_cmd)
-           free(res->res_msgs.operator_cmd);
-        free_msgs_res((MSGS *)res);  /* free message resource */
-        res = NULL;
-        break;
-      case R_GROUP:
-        break;
-      default:
-         printf("Unknown resource type %d in free_resource.\n", type);
+      }
+      break;
+   case R_JOB:
+      if (res->res_job.RestoreWhere) {
+        free(res->res_job.RestoreWhere);
+      }
+      if (res->res_job.RestoreBootstrap) {
+        free(res->res_job.RestoreBootstrap);
+      }
+      if (res->res_job.WriteBootstrap) {
+        free(res->res_job.WriteBootstrap);
+      }
+      if (res->res_job.RunBeforeJob) {
+        free(res->res_job.RunBeforeJob);
+      }
+      if (res->res_job.RunAfterJob) {
+        free(res->res_job.RunAfterJob);
+      }
+      if (res->res_job.RunAfterFailedJob) {
+        free(res->res_job.RunAfterFailedJob);
+      }
+      if (res->res_job.ClientRunBeforeJob) {
+        free(res->res_job.ClientRunBeforeJob);
+      }
+      if (res->res_job.ClientRunAfterJob) {
+        free(res->res_job.ClientRunAfterJob);
+      }
+      break;
+   case R_MSGS:
+      if (res->res_msgs.mail_cmd) {
+        free(res->res_msgs.mail_cmd);
+      }
+      if (res->res_msgs.operator_cmd) {
+        free(res->res_msgs.operator_cmd);
+      }
+      free_msgs_res((MSGS *)res);  /* free message resource */
+      res = NULL;
+      break;
+   case R_GROUP:
+      break;
+   default:
+      printf("Unknown resource type %d in free_resource.\n", type);
    }
    /* Common stuff again -- free the resource, recurse to next one */
    if (res) {
@@ -859,72 +925,82 @@ void save_resource(int type, struct res_items *items, int pass)
     */
    if (pass == 2) {
       switch (type) {
-        /* Resources not containing a resource */
-        case R_CONSOLE:
-        case R_CATALOG:
-        case R_STORAGE:
-        case R_GROUP:
-        case R_POOL:
-        case R_MSGS:
-        case R_FILESET:
-           break;
+      /* Resources not containing a resource */
+      case R_CONSOLE:
+      case R_CATALOG:
+      case R_STORAGE:
+      case R_GROUP:
+      case R_POOL:
+      case R_MSGS:
+      case R_FILESET:
+        break;
 
-        /* Resources containing another resource */
-        case R_DIRECTOR:
-           if ((res = (URES *)GetResWithName(R_DIRECTOR, res_all.res_dir.hdr.name)) == NULL) {
-               Emsg1(M_ERROR_TERM, 0, "Cannot find Director resource %s\n", res_all.res_dir.hdr.name);
-           }
-           res->res_dir.messages = res_all.res_dir.messages;
-           break;
-        case R_JOB:
-           if ((res = (URES *)GetResWithName(R_JOB, res_all.res_dir.hdr.name)) == NULL) {
-               Emsg1(M_ERROR_TERM, 0, "Cannot find Job resource %s\n", res_all.res_dir.hdr.name);
-           }
-           res->res_job.messages = res_all.res_job.messages;
-           res->res_job.schedule = res_all.res_job.schedule;
-           res->res_job.client   = res_all.res_job.client;
-           res->res_job.fileset  = res_all.res_job.fileset;
-           res->res_job.storage  = res_all.res_job.storage;
-           res->res_job.pool     = res_all.res_job.pool;
-           if (res->res_job.JobType == 0) {
-               Emsg1(M_ERROR_TERM, 0, "Job Type not defined for Job resource %s\n", res_all.res_dir.hdr.name);
-           }
-           if (res->res_job.level != 0) {
-              int i;
-              for (i=0; joblevels[i].level_name; i++) {
-                 if (joblevels[i].level == res->res_job.level &&
-                     joblevels[i].job_type == res->res_job.JobType) {
-                    i = 0;
-                    break;
-                 }
-              }
-              if (i != 0) {
-                  Emsg1(M_ERROR_TERM, 0, "Inappropriate level specified in Job resource %s\n", 
-                    res_all.res_dir.hdr.name);
+      /* Resources containing another resource */
+      case R_DIRECTOR:
+        if ((res = (URES *)GetResWithName(R_DIRECTOR, res_all.res_dir.hdr.name)) == NULL) {
+            Emsg1(M_ERROR_TERM, 0, "Cannot find Director resource %s\n", res_all.res_dir.hdr.name);
+        }
+        res->res_dir.messages = res_all.res_dir.messages;
+        break;
+      case R_JOB:
+        if ((res = (URES *)GetResWithName(type, res_all.res_dir.hdr.name)) == NULL) {
+            Emsg1(M_ERROR_TERM, 0, "Cannot find Job resource %s\n", 
+                 res_all.res_dir.hdr.name);
+        }
+        res->res_job.messages   = res_all.res_job.messages;
+        res->res_job.schedule   = res_all.res_job.schedule;
+        res->res_job.client     = res_all.res_job.client;
+        res->res_job.fileset    = res_all.res_job.fileset;
+        res->res_job.storage    = res_all.res_job.storage;
+        res->res_job.pool       = res_all.res_job.pool;
+        res->res_job.verify_job = res_all.res_job.verify_job;
+        if (res->res_job.JobType == 0) {
+            Emsg1(M_ERROR_TERM, 0, "Job Type not defined for Job resource %s\n", res_all.res_dir.hdr.name);
+        }
+        if (res->res_job.level != 0) {
+           int i;
+           for (i=0; joblevels[i].level_name; i++) {
+              if (joblevels[i].level == res->res_job.level &&
+                  joblevels[i].job_type == res->res_job.JobType) {
+                 i = 0;
+                 break;
               }
            }
-           break;
-        case R_CLIENT:
-           if ((res = (URES *)GetResWithName(R_CLIENT, res_all.res_client.hdr.name)) == NULL) {
-               Emsg1(M_ERROR_TERM, 0, "Cannot find Client resource %s\n", res_all.res_client.hdr.name);
+           if (i != 0) {
+               Emsg1(M_ERROR_TERM, 0, "Inappropriate level specified in Job resource %s\n", 
+                 res_all.res_dir.hdr.name);
            }
-           res->res_client.catalog = res_all.res_client.catalog;
-           break;
-        case R_SCHEDULE:
-           /* Schedule is a bit different in that it contains a RUN record
-             * chain which isn't a "named" resource. This chain was linked
-            * in by run_conf.c during pass 2, so here we jam the pointer 
-            * into the Schedule resource.                         
-            */
-           if ((res = (URES *)GetResWithName(R_SCHEDULE, res_all.res_client.hdr.name)) == NULL) {
-               Emsg1(M_ERROR_TERM, 0, "Cannot find Schedule resource %s\n", res_all.res_client.hdr.name);
-           }
-           res->res_sch.run = res_all.res_sch.run;
-           break;
-        default:
-            Emsg1(M_ERROR, 0, "Unknown resource type %d in save_resource.\n", type);
-           error = 1;
-           break;
+        }
+        break;
+      case R_COUNTER:
+        if ((res = (URES *)GetResWithName(R_COUNTER, res_all.res_counter.hdr.name)) == NULL) {
+            Emsg1(M_ERROR_TERM, 0, "Cannot find Counter resource %s\n", res_all.res_counter.hdr.name);
+        }
+        res->res_counter.Catalog = res_all.res_counter.Catalog;
+        res->res_counter.WrapCounter = res_all.res_counter.WrapCounter;
+        break;
+
+      case R_CLIENT:
+        if ((res = (URES *)GetResWithName(R_CLIENT, res_all.res_client.hdr.name)) == NULL) {
+            Emsg1(M_ERROR_TERM, 0, "Cannot find Client resource %s\n", res_all.res_client.hdr.name);
+        }
+        res->res_client.catalog = res_all.res_client.catalog;
+        break;
+      case R_SCHEDULE:
+        /* Schedule is a bit different in that it contains a RUN record
+          * chain which isn't a "named" resource. This chain was linked
+         * in by run_conf.c during pass 2, so here we jam the pointer 
+         * into the Schedule resource.                         
+         */
+        if ((res = (URES *)GetResWithName(R_SCHEDULE, res_all.res_client.hdr.name)) == NULL) {
+            Emsg1(M_ERROR_TERM, 0, "Cannot find Schedule resource %s\n", res_all.res_client.hdr.name);
+        }
+        res->res_sch.run = res_all.res_sch.run;
+        break;
+      default:
+         Emsg1(M_ERROR, 0, "Unknown resource type %d in save_resource.\n", type);
+        error = 1;
+        break;
       }
       /* Note, the resource name was already saved during pass 1,
        * so here, we can just release it.
@@ -940,49 +1016,51 @@ void save_resource(int type, struct res_items *items, int pass)
       return;
    }
 
-   /* The following code is only executed for pass 1 */
+   /*
+    * The following code is only executed during pass 1   
+    */
    switch (type) {
-      case R_DIRECTOR:
-        size = sizeof(DIRRES);
-        break;
-      case R_CONSOLE:
-        size = sizeof(CONRES);
-        break;
-      case R_CLIENT:
-        size =sizeof(CLIENT);
-        break;
-      case R_STORAGE:
-        size = sizeof(STORE); 
-        break;
-      case R_CATALOG:
-        size = sizeof(CAT);
-        break;
-      case R_JOB:
-        size = sizeof(JOB);
-        break;
-      case R_FILESET:
-        size = sizeof(FILESET);
-        break;
-      case R_SCHEDULE:
-        size = sizeof(SCHED);
-        break;
-      case R_GROUP:
-        size = sizeof(GROUP);
-        break;
-      case R_POOL:
-        size = sizeof(POOL);
-        break;
-      case R_MSGS:
-        size = sizeof(MSGS);
-        break;
-      case R_COUNTER:
-        size = sizeof(COUNTER);
-        break;
-      default:
-         printf("Unknown resource type %d in save_resrouce.\n", type);
-        error = 1;
-        size = 1;
-        break;
+   case R_DIRECTOR:
+      size = sizeof(DIRRES);
+      break;
+   case R_CONSOLE:
+      size = sizeof(CONRES);
+      break;
+   case R_CLIENT:
+      size =sizeof(CLIENT);
+      break;
+   case R_STORAGE:
+      size = sizeof(STORE); 
+      break;
+   case R_CATALOG:
+      size = sizeof(CAT);
+      break;
+   case R_JOB:
+      size = sizeof(JOB);
+      break;
+   case R_FILESET:
+      size = sizeof(FILESET);
+      break;
+   case R_SCHEDULE:
+      size = sizeof(SCHED);
+      break;
+   case R_GROUP:
+      size = sizeof(GROUP);
+      break;
+   case R_POOL:
+      size = sizeof(POOL);
+      break;
+   case R_MSGS:
+      size = sizeof(MSGS);
+      break;
+   case R_COUNTER:
+      size = sizeof(COUNTER);
+      break;
+   default:
+      printf("Unknown resource type %d in save_resrouce.\n", type);
+      error = 1;
+      size = 1;
+      break;
    }
    /* Common */
    if (!error) {
@@ -995,11 +1073,16 @@ void save_resource(int type, struct res_items *items, int pass)
       } else {
         RES *next;
         /* Add new res to end of chain */
-        for (next=resources[rindex].res_head; next->next; next=next->next)
-           { }
+        for (next=resources[rindex].res_head; next->next; next=next->next) {
+           if (strcmp(next->name, res->res_dir.hdr.name) == 0) {
+              Emsg2(M_ERROR_TERM, 0,
+                  _("Attempt to define second %s resource named \"%s\" is not permitted.\n"),
+                 resources[rindex].name, res->res_dir.hdr.name);
+           }
+        }
         next->next = (RES *)res;
-         Dmsg3(200, "Inserting %s res: %s index=%d\n", res_to_str(type),
-              res->res_dir.hdr.name, rindex);
+         Dmsg4(200, "Inserting %s res: %s index=%d pass=%d\n", res_to_str(type),
+              res->res_dir.hdr.name, rindex, pass);
       }
    }
 }
@@ -1089,7 +1172,7 @@ static void store_backup(LEX *lc, struct res_items *item, int index, int pass)
    
    ((JOB *)(item->value))->JobType = item->code;
    while ((token = lex_get_token(lc, T_ALL)) != T_EOL) {
-      int found;
+      bool found = false;
 
       Dmsg1(150, "store_backup got token=%s\n", lex_tok_to_str(token));
       
@@ -1097,52 +1180,51 @@ static void store_backup(LEX *lc, struct res_items *item, int index, int pass)
          scan_err1(lc, "Expected a backup/verify keyword, got: %s", lc->str);
       }
       Dmsg1(190, "Got keyword: %s\n", lc->str);
-      found = FALSE;
       for (i=0; BakVerFields[i].name; i++) {
         if (strcasecmp(lc->str, BakVerFields[i].name) == 0) {
-           found = TRUE;
+           found = true;
            if (lex_get_token(lc, T_ALL) != T_EQUALS) {
                scan_err1(lc, "Expected an equals, got: %s", lc->str);
            }
            token = lex_get_token(lc, T_NAME);
             Dmsg1(190, "Got value: %s\n", lc->str);
            switch (BakVerFields[i].token) {
-               case 'C':
-                 /* Find Client Resource */
-                 if (pass == 2) {
-                    res = GetResWithName(R_CLIENT, lc->str);
-                    if (res == NULL) {
-                        scan_err1(lc, "Could not find specified Client Resource: %s",
-                                  lc->str);
-                    }
-                    res_all.res_job.client = (CLIENT *)res;
+            case 'C':
+              /* Find Client Resource */
+              if (pass == 2) {
+                 res = GetResWithName(R_CLIENT, lc->str);
+                 if (res == NULL) {
+                     scan_err1(lc, "Could not find specified Client Resource: %s",
+                               lc->str);
                  }
-                 break;
-               case 'F':
-                 /* Find FileSet Resource */
-                 if (pass == 2) {
-                    res = GetResWithName(R_FILESET, lc->str);
-                    if (res == NULL) {
-                        scan_err1(lc, "Could not find specified FileSet Resource: %s\n",
-                                   lc->str);
-                    }
-                    res_all.res_job.fileset = (FILESET *)res;
-                 }
-                 break;
-               case 'L':
-                 /* Get level */
-                 for (i=0; joblevels[i].level_name; i++) {
-                    if (joblevels[i].job_type == item->code && 
-                         strcasecmp(lc->str, joblevels[i].level_name) == 0) {
-                       ((JOB *)(item->value))->level = joblevels[i].level;
-                       i = 0;
-                       break;
-                    }
+                 res_all.res_job.client = (CLIENT *)res;
+              }
+              break;
+            case 'F':
+              /* Find FileSet Resource */
+              if (pass == 2) {
+                 res = GetResWithName(R_FILESET, lc->str);
+                 if (res == NULL) {
+                     scan_err1(lc, "Could not find specified FileSet Resource: %s\n",
+                                lc->str);
                  }
-                 if (i != 0) {
-                     scan_err1(lc, "Expected a Job Level keyword, got: %s", lc->str);
+                 res_all.res_job.fileset = (FILESET *)res;
+              }
+              break;
+            case 'L':
+              /* Get level */
+              for (i=0; joblevels[i].level_name; i++) {
+                 if (joblevels[i].job_type == item->code && 
+                      strcasecmp(lc->str, joblevels[i].level_name) == 0) {
+                    ((JOB *)(item->value))->level = joblevels[i].level;
+                    i = 0;
+                    break;
                  }
-                 break;
+              }
+              if (i != 0) {
+                  scan_err1(lc, "Expected a Job Level keyword, got: %s", lc->str);
+              }
+              break;
            } /* end switch */
            break;
         } /* end if strcmp() */
@@ -1173,91 +1255,90 @@ static void store_restore(LEX *lc, struct res_items *item, int index, int pass)
    
    ((JOB *)(item->value))->JobType = item->code;
    while ((token = lex_get_token(lc, T_ALL)) != T_EOL) {
-      int found; 
+      bool found = false;
 
       if (token != T_IDENTIFIER && token != T_UNQUOTED_STRING && token != T_QUOTED_STRING) {
          scan_err1(lc, "expected a name, got: %s", lc->str);
       }
-      found = FALSE;
       for (i=0; RestoreFields[i].name; i++) {
          Dmsg1(190, "Restore kw=%s\n", lc->str);
         if (strcasecmp(lc->str, RestoreFields[i].name) == 0) {
-           found = TRUE;
+           found = true;
            if (lex_get_token(lc, T_ALL) != T_EQUALS) {
                scan_err1(lc, "Expected an equals, got: %s", lc->str);
            }
            token = lex_get_token(lc, T_ALL);
             Dmsg1(190, "Restore value=%s\n", lc->str);
            switch (RestoreFields[i].token) {
-               case 'B':
-                 /* Bootstrap */
-                 if (token != T_IDENTIFIER && token != T_UNQUOTED_STRING && token != T_QUOTED_STRING) {
-                     scan_err1(lc, "Expected a Restore bootstrap file, got: %s", lc->str);
-                 }
-                 if (pass == 1) {
-                    res_all.res_job.RestoreBootstrap = bstrdup(lc->str);
-                 }
-                 break;
-               case 'C':
-                 /* Find Client Resource */
-                 if (pass == 2) {
-                    res = GetResWithName(R_CLIENT, lc->str);
-                    if (res == NULL) {
-                        scan_err1(lc, "Could not find specified Client Resource: %s",
-                                  lc->str);
-                    }
-                    res_all.res_job.client = (CLIENT *)res;
-                 }
-                 break;
-               case 'F':
-                 /* Find FileSet Resource */
-                 if (pass == 2) {
-                    res = GetResWithName(R_FILESET, lc->str);
-                    if (res == NULL) {
-                        scan_err1(lc, "Could not find specified FileSet Resource: %s\n",
-                                   lc->str);
-                    }
-                    res_all.res_job.fileset = (FILESET *)res;
-                 }
-                 break;
-               case 'J':
-                 /* JobId */
-                 if (token != T_NUMBER) {
-                     scan_err1(lc, "expected an integer number, got: %s", lc->str);
-                 }
-                 errno = 0;
-                 res_all.res_job.RestoreJobId = strtol(lc->str, NULL, 0);
-                  Dmsg1(190, "RestorJobId=%d\n", res_all.res_job.RestoreJobId);
-                 if (errno != 0) {
-                     scan_err1(lc, "expected an integer number, got: %s", lc->str);
-                 }
-                 break;
-               case 'W':
-                 /* Where */
-                 if (token != T_IDENTIFIER && token != T_UNQUOTED_STRING && token != T_QUOTED_STRING) {
-                     scan_err1(lc, "Expected a Restore root directory, got: %s", lc->str);
-                 }
-                 if (pass == 1) {
-                    res_all.res_job.RestoreWhere = bstrdup(lc->str);
-                 }
-                 break;
-               case 'R':
-                 /* Replacement options */
-                 if (token != T_IDENTIFIER && token != T_UNQUOTED_STRING && token != T_QUOTED_STRING) {
-                     scan_err1(lc, "Expected a keyword name, got: %s", lc->str);
+            case 'B':
+              /* Bootstrap */
+              if (token != T_IDENTIFIER && token != T_UNQUOTED_STRING && token != T_QUOTED_STRING) {
+                  scan_err1(lc, "Expected a Restore bootstrap file, got: %s", lc->str);
+              }
+              if (pass == 1) {
+                 res_all.res_job.RestoreBootstrap = bstrdup(lc->str);
+              }
+              break;
+            case 'C':
+              /* Find Client Resource */
+              if (pass == 2) {
+                 res = GetResWithName(R_CLIENT, lc->str);
+                 if (res == NULL) {
+                     scan_err1(lc, "Could not find specified Client Resource: %s",
+                               lc->str);
                  }
-                 /* Fix to scan Replacement options */
-                 for (i=0; ReplaceOptions[i].name; i++) {
-                    if (strcasecmp(lc->str, ReplaceOptions[i].name) == 0) {
-                        ((JOB *)(item->value))->replace = ReplaceOptions[i].token;
-                       i = 0;
-                       break;
-                    }
+                 res_all.res_job.client = (CLIENT *)res;
+              }
+              break;
+            case 'F':
+              /* Find FileSet Resource */
+              if (pass == 2) {
+                 res = GetResWithName(R_FILESET, lc->str);
+                 if (res == NULL) {
+                     scan_err1(lc, "Could not find specified FileSet Resource: %s\n",
+                                lc->str);
                  }
-                 if (i != 0) {
-                     scan_err1(lc, "Expected a Restore replacement option, got: %s", lc->str);
+                 res_all.res_job.fileset = (FILESET *)res;
+              }
+              break;
+            case 'J':
+              /* JobId */
+              if (token != T_NUMBER) {
+                  scan_err1(lc, "expected an integer number, got: %s", lc->str);
+              }
+              errno = 0;
+              res_all.res_job.RestoreJobId = strtol(lc->str, NULL, 0);
+               Dmsg1(190, "RestorJobId=%d\n", res_all.res_job.RestoreJobId);
+              if (errno != 0) {
+                  scan_err1(lc, "expected an integer number, got: %s", lc->str);
+              }
+              break;
+            case 'W':
+              /* Where */
+              if (token != T_IDENTIFIER && token != T_UNQUOTED_STRING && token != T_QUOTED_STRING) {
+                  scan_err1(lc, "Expected a Restore root directory, got: %s", lc->str);
+              }
+              if (pass == 1) {
+                 res_all.res_job.RestoreWhere = bstrdup(lc->str);
+              }
+              break;
+            case 'R':
+              /* Replacement options */
+              if (token != T_IDENTIFIER && token != T_UNQUOTED_STRING && token != T_QUOTED_STRING) {
+                  scan_err1(lc, "Expected a keyword name, got: %s", lc->str);
+              }
+              /* Fix to scan Replacement options */
+              for (i=0; ReplaceOptions[i].name; i++) {
+                 if (strcasecmp(lc->str, ReplaceOptions[i].name) == 0) {
+                     ((JOB *)(item->value))->replace = ReplaceOptions[i].token;
+                    i = 0;
+                    break;
                  }
-                 break;
+              }
+              if (i != 0) {
+                  scan_err1(lc, "Expected a Restore replacement option, got: %s", lc->str);
+              }
+              break;
            } /* end switch */
            break;
         } /* end if strcmp() */