]> git.sur5r.net Git - bacula/bacula/blobdiff - bacula/src/dird/ua_run.c
Add heap stats to Dir and SD -- eliminate #ifdefs
[bacula/bacula] / bacula / src / dird / ua_run.c
index 1e21b3a23590f75f4815bc66b94279e744ada1a5..6fdd3478474202b50e6bc3c868f1e028481f0f85 100644 (file)
@@ -8,7 +8,7 @@
  */
 
 /*
-   Copyright (C) 2001-2003 Kern Sibbald and John Walker
+   Copyright (C) 2001-2004 Kern Sibbald and John Walker
 
    This program is free software; you can redistribute it and/or
    modify it under the terms of the GNU General Public License as
 #include "dird.h"
 
 /* Imported subroutines */
-extern void run_job(JCR *jcr);
 
 /* Imported variables */
-extern struct s_jl joblevels[];
 extern struct s_kw ReplaceOptions[];
 
 /*
@@ -45,32 +43,44 @@ extern struct s_kw ReplaceOptions[];
  *     run <job-name> jobid=nn
  *
  */
-int runcmd(UAContext *ua, char *cmd)
+int run_cmd(UAContext *ua, const char *cmd)
 {
    JCR *jcr;
    char *job_name, *level_name, *jid, *store_name, *pool_name;
-   char *where, *fileset_name, *client_name, *bootstrap, *replace;
-   char *when;
-   int i, j, found, opt;
+   char *where, *fileset_name, *client_name, *bootstrap;
+   const char *replace;
+   char *when, *verify_job_name;
+   int Priority = 0;
+   int i, j, opt, files = 0;
+   bool kw_ok;
    JOB *job = NULL;
+   JOB *verify_job = NULL;
    STORE *store = NULL;
    CLIENT *client = NULL;
    FILESET *fileset = NULL;
    POOL *pool = NULL;
-   static char *kw[] = {
-      N_("job"),
-      N_("jobid"),
-      N_("client"),
-      N_("fileset"),
-      N_("level"),
-      N_("storage"),
-      N_("pool"), 
-      N_("where"),
-      N_("bootstrap"),
-      N_("replace"),
-      N_("when"),
+   static const char *kw[] = {       /* command line arguments */
+      N_("job"),                      /*  Used in a switch() */
+      N_("jobid"),                    /* 1 */
+      N_("client"),                   /* 2 */
+      N_("fd"), 
+      N_("fileset"),                  /* 4 */
+      N_("level"),                    /* 5 */
+      N_("storage"),                  /* 6 */
+      N_("sd"),                       /* 7 */
+      N_("pool"),                     /* 8 */
+      N_("where"),                    /* 9 */
+      N_("bootstrap"),                /* 10 */
+      N_("replace"),                  /* 11 */
+      N_("when"),                     /* 12 */
+      N_("priority"),                 /* 13 */
+      N_("yes"),          /* 14 -- if you change this change YES_POS too */
+      N_("verifyjob"),                /* 15 */
+      N_("files"),                    /* 16 number of files to restore */
       NULL};
 
+#define YES_POS 14
+
    if (!open_db(ua)) {
       return 1;
    }
@@ -86,112 +96,148 @@ int runcmd(UAContext *ua, char *cmd)
    fileset_name = NULL;
    bootstrap = NULL;
    replace = NULL;
+   verify_job_name = NULL;
 
    for (i=1; i<ua->argc; i++) {
-      found = False;
       Dmsg2(200, "Doing arg %d = %s\n", i, ua->argk[i]);
-      for (j=0; !found && kw[j]; j++) {
+      kw_ok = false;
+      /* Keep looking until we find a good keyword */
+      for (j=0; !kw_ok && kw[j]; j++) {
         if (strcasecmp(ua->argk[i], _(kw[j])) == 0) {
-           if (!ua->argv[i]) {
+           /* Note, yes and run have no value, so do not err */
+           if (!ua->argv[i] && j != YES_POS /*yes*/) {  
                bsendmsg(ua, _("Value missing for keyword %s\n"), ua->argk[i]);
               return 1;
            }
             Dmsg1(200, "Got keyword=%s\n", kw[j]);
            switch (j) {
-              case 0: /* job */
-                 if (job_name) {
-                     bsendmsg(ua, _("Job name specified twice.\n"));
-                    return 1;
-                 }
-                 job_name = ua->argv[i];
-                 found = True;
-                 break;
-              case 1: /* JobId */
-                 if (jid) {
-                     bsendmsg(ua, _("JobId specified twice.\n"));
-                    return 1;
-                 }
-                 jid = ua->argv[i];
-                 found = True;
-                 break;
-              case 2: /* client */
-                 if (client_name) {
-                     bsendmsg(ua, _("Client specified twice.\n"));
-                    return 1;
-                 }
-                 client_name = ua->argv[i];
-                 found = True;
-                 break;
-              case 3: /* fileset */
-                 if (fileset_name) {
-                     bsendmsg(ua, _("FileSet specified twice.\n"));
-                    return 1;
-                 }
-                 fileset_name = ua->argv[i];
-                 found = True;
-                 break;
-              case 4: /* level */
-                 if (level_name) {
-                     bsendmsg(ua, _("Level specified twice.\n"));
-                    return 1;
-                 }
-                 level_name = ua->argv[i];
-                 found = True;
-                 break;
-              case 5: /* storage */
-                 if (store_name) {
-                     bsendmsg(ua, _("Storage specified twice.\n"));
-                    return 1;
-                 }
-                 store_name = ua->argv[i];
-                 found = True;
-                 break;
-              case 6: /* pool */
-                 if (pool_name) {
-                     bsendmsg(ua, _("Pool specified twice.\n"));
-                    return 1;
-                 }
-                 pool_name = ua->argv[i];
-                 found = True;
-                 break;
-              case 7: /* where */
-                 if (where) {
-                     bsendmsg(ua, _("Where specified twice.\n"));
-                    return 1;
-                 }
-                 where = ua->argv[i];
-                 found = True;
-                 break;
-              case 8: /* bootstrap */
-                 if (bootstrap) {
-                     bsendmsg(ua, _("Bootstrap specified twice.\n"));
-                    return 1;
-                 }
-                 bootstrap = ua->argv[i];
-                 found = True;
-                 break;
-              case 9: /* replace */
-                 if (replace) {
-                     bsendmsg(ua, _("Replace specified twice.\n"));
-                    return 1;
-                 }
-                 replace = ua->argv[i];
-                 found = True;
-                 break;
-              case 10: /* When */
-                 if (when) {
-                     bsendmsg(ua, _("When specified twice.\n"));
-                    return 1;
-                 }
-                 when = ua->argv[i];
-                 found = True;
-                 break;
-              default:
-                 break;
+           case 0: /* job */
+              if (job_name) {
+                  bsendmsg(ua, _("Job name specified twice.\n"));
+                 return 1;
+              }
+              job_name = ua->argv[i];
+              kw_ok = true;
+              break;
+           case 1: /* JobId */
+              if (jid) {
+                  bsendmsg(ua, _("JobId specified twice.\n"));
+                 return 1;
+              }
+              jid = ua->argv[i];
+              kw_ok = true;
+              break;
+           case 2: /* client */
+           case 3: /* fd */
+              if (client_name) {
+                  bsendmsg(ua, _("Client specified twice.\n"));
+                 return 1;
+              }
+              client_name = ua->argv[i];
+              kw_ok = true;
+              break;
+           case 4: /* fileset */
+              if (fileset_name) {
+                  bsendmsg(ua, _("FileSet specified twice.\n"));
+                 return 1;
+              }
+              fileset_name = ua->argv[i];
+              kw_ok = true;
+              break;
+           case 5: /* level */
+              if (level_name) {
+                  bsendmsg(ua, _("Level specified twice.\n"));
+                 return 1;
+              }
+              level_name = ua->argv[i];
+              kw_ok = true;
+              break;
+           case 6: /* storage */
+           case 7: /* sd */
+              if (store_name) {
+                  bsendmsg(ua, _("Storage specified twice.\n"));
+                 return 1;
+              }
+              store_name = ua->argv[i];
+              kw_ok = true;
+              break;
+           case 8: /* pool */
+              if (pool_name) {
+                  bsendmsg(ua, _("Pool specified twice.\n"));
+                 return 1;
+              }
+              pool_name = ua->argv[i];
+              kw_ok = true;
+              break;
+           case 9: /* where */
+              if (where) {
+                  bsendmsg(ua, _("Where specified twice.\n"));
+                 return 1;
+              }
+              where = ua->argv[i];
+              kw_ok = true;
+              break;
+           case 10: /* bootstrap */
+              if (bootstrap) {
+                  bsendmsg(ua, _("Bootstrap specified twice.\n"));
+                 return 1;
+              }
+              bootstrap = ua->argv[i];
+              kw_ok = true;
+              break;
+           case 11: /* replace */
+              if (replace) {
+                  bsendmsg(ua, _("Replace specified twice.\n"));
+                 return 1;
+              }
+              replace = ua->argv[i];
+              kw_ok = true;
+              break;
+           case 12: /* When */
+              if (when) {
+                  bsendmsg(ua, _("When specified twice.\n"));
+                 return 1;
+              }
+              when = ua->argv[i];
+              kw_ok = true;
+              break;
+           case 13:  /* Priority */
+              if (Priority) {
+                  bsendmsg(ua, _("Priority specified twice.\n"));
+                 return 1;
+              }
+              Priority = atoi(ua->argv[i]);
+              if (Priority <= 0) {
+                  bsendmsg(ua, _("Priority must be positive nonzero setting it to 10.\n"));
+                 Priority = 10;
+              }
+              kw_ok = true;
+              break;
+           case 14: /* yes */
+              kw_ok = true;
+              break;
+           case 15: /* Verify Job */
+              if (verify_job_name) {
+                  bsendmsg(ua, _("Verify Job specified twice.\n"));
+                 return 1;
+              }
+              verify_job_name = ua->argv[i];
+              kw_ok = true;
+              break;
+           case 16: /* files */
+              files = atoi(ua->argv[i]);
+              kw_ok = true;
+              break;
+
+           default:
+              break;
            }
         } /* end strcase compare */
       } /* end keyword loop */
-      if (!found) {
+      /*
+       * End of keyword for loop -- if not found, we got a bogus keyword
+       */
+      if (!kw_ok) {
          Dmsg1(200, "%s not found\n", ua->argk[i]);
         /*
          * Special case for Job Name, it can be the first
@@ -209,13 +255,13 @@ int runcmd(UAContext *ua, char *cmd)
             
    Dmsg0(200, "Done scan.\n");
 
-
-
    if (job_name) {
       /* Find Job */
       job = (JOB *)GetResWithName(R_JOB, job_name);
       if (!job) {
-         bsendmsg(ua, _("Job \"%s\" not found\n"), job_name);
+        if (*job_name != 0) {
+            bsendmsg(ua, _("Job \"%s\" not found\n"), job_name);
+        }
         job = select_job_resource(ua);
       } else {
          Dmsg1(200, "Found job=%s\n", job_name);
@@ -231,7 +277,9 @@ int runcmd(UAContext *ua, char *cmd)
    if (store_name) {
       store = (STORE *)GetResWithName(R_STORAGE, store_name);
       if (!store) {
-         bsendmsg(ua, _("Storage \"%s\" not found.\n"), store_name);
+        if (*store_name != 0) {
+            bsendmsg(ua, _("Storage \"%s\" not found.\n"), store_name);
+        }
         store = select_storage_resource(ua);
       }
    } else {
@@ -245,17 +293,24 @@ int runcmd(UAContext *ua, char *cmd)
    if (pool_name) {
       pool = (POOL *)GetResWithName(R_POOL, pool_name);
       if (!pool) {
-         bsendmsg(ua, _("Pool \"%s\" not found.\n"), pool_name);
-        pool = get_pool_resource(ua);
+        if (*pool_name != 0) {
+            bsendmsg(ua, _("Pool \"%s\" not found.\n"), pool_name);
+        }
+        pool = select_pool_resource(ua);
       }
    } else {
       pool = job->pool;            /* use default */
    }
+   if (!pool) {
+      return 1;
+   }
 
    if (client_name) {
       client = (CLIENT *)GetResWithName(R_CLIENT, client_name);
       if (!client) {
-         bsendmsg(ua, _("Client \"%s\" not found.\n"), client_name);
+        if (*client_name != 0) {
+            bsendmsg(ua, _("Client \"%s\" not found.\n"), client_name);
+        }
         client = select_client_resource(ua);
       }
    } else {
@@ -278,8 +333,20 @@ int runcmd(UAContext *ua, char *cmd)
       return 1;
    }
 
+   if (verify_job_name) {
+      verify_job = (JOB *)GetResWithName(R_JOB, verify_job_name);
+      if (!verify_job) {
+         bsendmsg(ua, _("Verify Job \"%s\" not found.\n"), verify_job_name);
+        verify_job = select_job_resource(ua);
+      }
+   } else {
+      verify_job = job->verify_job;
+   }
 
-   /* Create JCR to run job */
+   /*
+    * Create JCR to run job.  NOTE!!! after this point, free_jcr()
+    *  before returning.
+    */
    jcr = new_jcr(sizeof(JCR), dird_free_jcr);
    set_jcr_defaults(jcr, job);
 
@@ -287,11 +354,12 @@ int runcmd(UAContext *ua, char *cmd)
    jcr->client = client;
    jcr->fileset = fileset;
    jcr->pool = pool;
+   jcr->ExpectedFiles = files;
    if (where) {
-      if (jcr->RestoreWhere) {
-        free(jcr->RestoreWhere);
+      if (jcr->where) {
+        free(jcr->where);
       }
-      jcr->RestoreWhere = bstrdup(where);
+      jcr->where = bstrdup(where);
    }
 
    if (when) {
@@ -318,7 +386,7 @@ int runcmd(UAContext *ua, char *cmd)
       }
       if (!jcr->replace) {
          bsendmsg(ua, _("Invalid replace option: %s\n"), replace);
-        return 0;
+        goto bail_out;
       }
    } else if (job->replace) {
       jcr->replace = job->replace;
@@ -326,6 +394,10 @@ int runcmd(UAContext *ua, char *cmd)
       jcr->replace = REPLACE_ALWAYS;
    }
 
+   if (Priority) {
+      jcr->JobPriority = Priority;
+   }
+
 try_again:
    replace = ReplaceOptions[0].name;
    for (i=0; ReplaceOptions[i].name; i++) {
@@ -333,44 +405,53 @@ try_again:
         replace = ReplaceOptions[i].name;
       }
    }
+   if (level_name) {
+      if (!get_level_from_name(jcr, level_name)) {
+         bsendmsg(ua, _("Level %s not valid.\n"), level_name);
+        goto bail_out;
+      }
+   }
+   if (jid) {
+      jcr->RestoreJobId = atoi(jid);
+   }
+
+   /* Run without prompting? */
+   if (find_arg(ua, _("yes")) > 0) {
+      Dmsg1(200, "Calling run_job job=%x\n", jcr->job);
+      run_job(jcr);
+      free_jcr(jcr);                 /* release jcr */
+      bsendmsg(ua, _("Run command submitted.\n"));
+      return 1;
+   }
+
+   /*  
+    * Prompt User to see if all run job parameters are correct, and
+    *  allow him to modify them.
+    */
    Dmsg1(20, "JobType=%c\n", jcr->JobType);
    switch (jcr->JobType) {
       char ec1[30];
       char dt[MAX_TIME_LENGTH];
-      case JT_ADMIN:
+   case JT_ADMIN:
          bsendmsg(ua, _("Run %s job\n\
 JobName:  %s\n\
 FileSet:  %s\n\
 Client:   %s\n\
 Storage:  %s\n\
-When:     %s\n"),
+When:     %s\n\
+Priority: %d\n"),
                  _("Admin"),
                 job->hdr.name,
                 jcr->fileset->hdr.name,
                 NPRT(jcr->client->hdr.name),
                 NPRT(jcr->store->hdr.name), 
-                bstrutime(dt, sizeof(dt), jcr->sched_time));
-        jcr->JobLevel = L_FULL;
-        break;
-      case JT_BACKUP:
-      case JT_VERIFY:
-        if (level_name) {
-           /* Look up level name and pull code */
-           found = 0;
-           for (i=0; joblevels[i].level_name; i++) {
-              if (strcasecmp(level_name, _(joblevels[i].level_name)) == 0) {
-                 jcr->JobLevel = joblevels[i].level;
-                 found = 1;
-                 break;
-              }
-           }
-           if (!found) { 
-               bsendmsg(ua, _("Level %s not valid.\n"), level_name);
-              free_jcr(jcr);
-              return 1;
-           }
-        }
-        level_name = NULL;
+                bstrutime(dt, sizeof(dt), jcr->sched_time), 
+                jcr->JobPriority);
+      jcr->JobLevel = L_FULL;
+      break;
+   case JT_BACKUP:
+   case JT_VERIFY:
+      if (jcr->JobType == JT_BACKUP) {
          bsendmsg(ua, _("Run %s job\n\
 JobName:  %s\n\
 FileSet:  %s\n\
@@ -378,30 +459,80 @@ Level:    %s\n\
 Client:   %s\n\
 Storage:  %s\n\
 Pool:     %s\n\
-When:     %s\n"),
-                 jcr->JobType==JT_BACKUP?_("Backup"):_("Verify"),
+When:     %s\n\
+Priority: %d\n"),
+                 _("Backup"),
                 job->hdr.name,
                 jcr->fileset->hdr.name,
                 level_to_str(jcr->JobLevel),
                 jcr->client->hdr.name,
                 jcr->store->hdr.name,
                 NPRT(jcr->pool->hdr.name), 
-                bstrutime(dt, sizeof(dt), jcr->sched_time));
-        break;
-      case JT_RESTORE:
-        if (jcr->RestoreJobId == 0 && !jcr->RestoreBootstrap) {
-           if (jid) {
-              jcr->RestoreJobId = atoi(jid);
-           } else {
-               if (!get_pint(ua, _("Please enter a JobId for restore: "))) {
-                 free_jcr(jcr);
-                 return 1;
-              }  
-              jcr->RestoreJobId = ua->pint32_val;
-           }
+                bstrutime(dt, sizeof(dt), jcr->sched_time),
+                jcr->JobPriority);
+      } else { /* JT_VERIFY */
+        const char *Name;
+        if (jcr->job->verify_job) {
+           Name = jcr->job->verify_job->hdr.name;
+        } else {
+            Name = "";
+        }
+         bsendmsg(ua, _("Run %s job\n\
+JobName:     %s\n\
+FileSet:     %s\n\
+Level:       %s\n\
+Client:      %s\n\
+Storage:     %s\n\
+Pool:        %s\n\
+Verify Job:  %s\n\
+When:        %s\n\
+Priority:    %d\n"),
+              _("Verify"),
+             job->hdr.name,
+             jcr->fileset->hdr.name,
+             level_to_str(jcr->JobLevel),
+             jcr->client->hdr.name,
+             jcr->store->hdr.name,
+             NPRT(jcr->pool->hdr.name), 
+             Name,            
+             bstrutime(dt, sizeof(dt), jcr->sched_time),
+             jcr->JobPriority);
+      }
+      break;
+   case JT_RESTORE:
+      if (jcr->RestoreJobId == 0 && !jcr->RestoreBootstrap) {
+        if (jid) {
+           jcr->RestoreJobId = atoi(jid);
+        } else {
+            if (!get_pint(ua, _("Please enter a JobId for restore: "))) {
+              goto bail_out;
+           }  
+           jcr->RestoreJobId = ua->pint32_val;
         }
-        jcr->JobLevel = L_FULL;      /* default level */
-         Dmsg1(20, "JobId to restore=%d\n", jcr->RestoreJobId);
+      }
+      jcr->JobLevel = L_FULL;     /* default level */
+      Dmsg1(20, "JobId to restore=%d\n", jcr->RestoreJobId);
+      if (jcr->RestoreJobId == 0) {
+         bsendmsg(ua, _("Run Restore job\n\
+JobName:    %s\n\
+Bootstrap:  %s\n\
+Where:      %s\n\
+Replace:    %s\n\
+FileSet:    %s\n\
+Client:     %s\n\
+Storage:    %s\n\
+When:       %s\n\
+Priority:   %d\n"),
+             job->hdr.name,
+             NPRT(jcr->RestoreBootstrap),
+             jcr->where?jcr->where:NPRT(job->RestoreWhere),
+             replace,
+             jcr->fileset->hdr.name,
+             jcr->client->hdr.name,
+             jcr->store->hdr.name, 
+             bstrutime(dt, sizeof(dt), jcr->sched_time),
+             jcr->JobPriority);
+      } else {
          bsendmsg(ua, _("Run Restore job\n\
 JobName:    %s\n\
 Bootstrap:  %s\n\
@@ -411,33 +542,34 @@ FileSet:    %s\n\
 Client:     %s\n\
 Storage:    %s\n\
 JobId:      %s\n\
-When:       %s\n"),
-                job->hdr.name,
-                NPRT(jcr->RestoreBootstrap),
-                jcr->RestoreWhere?jcr->RestoreWhere:NPRT(job->RestoreWhere),
-                replace,
-                jcr->fileset->hdr.name,
-                jcr->client->hdr.name,
-                jcr->store->hdr.name, 
-                 jcr->RestoreJobId==0?"*None*":edit_uint64(jcr->RestoreJobId, ec1), 
-                bstrutime(dt, sizeof(dt), jcr->sched_time));
-        break;
-      default:
-         bsendmsg(ua, _("Unknown Job Type=%d\n"), jcr->JobType);
-        free_jcr(jcr);
-        return 0;
+When:       %s\n\
+Priority:   %d\n"),
+             job->hdr.name,
+             NPRT(jcr->RestoreBootstrap),
+             jcr->where?jcr->where:NPRT(job->RestoreWhere),
+             replace,
+             jcr->fileset->hdr.name,
+             jcr->client->hdr.name,
+             jcr->store->hdr.name, 
+              jcr->RestoreJobId==0?"*None*":edit_uint64(jcr->RestoreJobId, ec1), 
+             bstrutime(dt, sizeof(dt), jcr->sched_time),
+             jcr->JobPriority);
+      }
+      break;
+   default:
+      bsendmsg(ua, _("Unknown Job Type=%d\n"), jcr->JobType);
+      goto bail_out;
    }
+
+
    if (!get_cmd(ua, _("OK to run? (yes/mod/no): "))) {
-      free_jcr(jcr);
-      return 0;                      /* do not run */
+      goto bail_out;
    }
    /*
     * At user request modify parameters of job to be run.
     */
    if (ua->cmd[0] == 0) {
-      bsendmsg(ua, _("Job not run.\n"));
-      free_jcr(jcr);
-      return 0;                      /* do not run */
+      goto bail_out;
    }
    if (strncasecmp(ua->cmd, _("mod"), strlen(ua->cmd)) == 0) {
       FILE *fd;
@@ -449,16 +581,20 @@ When:       %s\n"),
       add_prompt(ua, _("FileSet"));          /* 3 */
       add_prompt(ua, _("Client"));           /* 4 */
       add_prompt(ua, _("When"));             /* 5 */
+      add_prompt(ua, _("Priority"));         /* 6 */
       if (jcr->JobType == JT_BACKUP ||
          jcr->JobType == JT_VERIFY) {
-         add_prompt(ua, _("Pool"));          /* 6 */
+         add_prompt(ua, _("Pool"));          /* 7 */
+        if (jcr->JobType == JT_VERIFY) {
+            add_prompt(ua, _("Verify Job"));  /* 8 */
+        }
       } else if (jcr->JobType == JT_RESTORE) {
-         add_prompt(ua, _("Bootstrap"));     /* 6 */
-         add_prompt(ua, _("Where"));         /* 7 */
-         add_prompt(ua, _("Replace"));       /* 8 */
-         add_prompt(ua, _("JobId"));         /* 9 */
+         add_prompt(ua, _("Bootstrap"));     /* 7 */
+         add_prompt(ua, _("Where"));         /* 8 */
+         add_prompt(ua, _("Replace"));       /* 9 */
+         add_prompt(ua, _("JobId"));         /* 10 */
       }
-      switch (do_prompt(ua, _("Select parameter to modify"), NULL, 0)) {
+      switch (do_prompt(ua, "", _("Select parameter to modify"), NULL, 0)) {
       case 0:
         /* Level */
         if (jcr->JobType == JT_BACKUP) {
@@ -468,7 +604,7 @@ When:       %s\n"),
             add_prompt(ua, _("Incremental"));
             add_prompt(ua, _("Differential"));
             add_prompt(ua, _("Since"));
-            switch (do_prompt(ua, _("Select level"), NULL, 0)) {
+            switch (do_prompt(ua, "", _("Select level"), NULL, 0)) {
            case 0:
               jcr->JobLevel = L_BASE;
               break;
@@ -492,9 +628,10 @@ When:       %s\n"),
             start_prompt(ua, _("Levels:\n"));
             add_prompt(ua, _("Initialize Catalog"));
             add_prompt(ua, _("Verify Catalog"));
-            add_prompt(ua, _("Verify Volume"));
-            add_prompt(ua, _("Verify Volume Data"));
-            switch (do_prompt(ua, _("Select level"), NULL, 0)) {
+            add_prompt(ua, _("Verify Volume to Catalog"));
+            add_prompt(ua, _("Verify Disk to Catalog"));
+            add_prompt(ua, _("Verify Volume Data (not yet implemented)"));
+            switch (do_prompt(ua, "",  _("Select level"), NULL, 0)) {
            case 0:
               jcr->JobLevel = L_VERIFY_INIT;
               break;
@@ -505,6 +642,9 @@ When:       %s\n"),
               jcr->JobLevel = L_VERIFY_VOLUME_TO_CATALOG;
               break;
            case 3:
+              jcr->JobLevel = L_VERIFY_DISK_TO_CATALOG;
+              break;
+           case 4:
               jcr->JobLevel = L_VERIFY_DATA;
               break;
            default:
@@ -550,7 +690,7 @@ When:       %s\n"),
         break;
       case 5:
         /* When */
-         if (!get_cmd(ua, _("Please enter scheduled start time (return for now): "))) {
+         if (!get_cmd(ua, _("Please enter desired start time as YYYY-MM-DD HH:MM:SS (return for now): "))) {
            break;
         }
         if (ua->cmd[0] == 0) {
@@ -564,6 +704,18 @@ When:       %s\n"),
         }
         goto try_again;
       case 6:
+        /* Priority */
+         if (!get_pint(ua, _("Enter new Priority: "))) {
+           break;
+        }
+        if (ua->pint32_val == 0) {
+            bsendmsg(ua, _("Priority must be a positive integer.\n"));
+        } else {
+           jcr->JobPriority = ua->pint32_val;
+        }
+        goto try_again;
+      case 7:
+        /* Pool or Bootstrap depending on JobType */
         if (jcr->JobType == JT_BACKUP ||
             jcr->JobType == JT_VERIFY) {      /* Pool */
            pool = select_pool_resource(ua);
@@ -595,32 +747,42 @@ When:       %s\n"),
            }
         }
         goto try_again;
-      case 7:
+      case 8:
+        /* Verify Job */
+        if (jcr->JobType == JT_VERIFY) {
+           JOB *job = select_job_resource(ua);
+           if (job) {
+              jcr->job->verify_job = job;
+           } else {
+              jcr->job->verify_job = NULL;
+           }
+           goto try_again;
+        }
         /* Where */
          if (!get_cmd(ua, _("Please enter path prefix for restore (/ for none): "))) {
            break;
         }
-        if (jcr->RestoreWhere) {
-           free(jcr->RestoreWhere);
-           jcr->RestoreWhere = NULL;
+        if (jcr->where) {
+           free(jcr->where);
+           jcr->where = NULL;
         }
          if (ua->cmd[0] == '/' && ua->cmd[1] == 0) {
            ua->cmd[0] = 0;
         }
-        jcr->RestoreWhere = bstrdup(ua->cmd);
+        jcr->where = bstrdup(ua->cmd);
         goto try_again;
-      case 8:
+      case 9:
         /* Replace */
          start_prompt(ua, _("Replace:\n"));
         for (i=0; ReplaceOptions[i].name; i++) {
            add_prompt(ua, ReplaceOptions[i].name);
         }
-         opt = do_prompt(ua, _("Select replace option"), NULL, 0);
+         opt = do_prompt(ua, "", _("Select replace option"), NULL, 0);
         if (opt >=  0) {
            jcr->replace = ReplaceOptions[opt].token;
         }
         goto try_again;
-      case 9:
+      case 10:
         /* JobId */
         jid = NULL;                  /* force reprompt */
         jcr->RestoreJobId = 0;
@@ -631,19 +793,19 @@ When:       %s\n"),
       default: 
         goto try_again;
       }
-      bsendmsg(ua, _("Job not run.\n"));
-      free_jcr(jcr);
-      return 0;                      /* error do no run Job */
+      goto bail_out;
    }
+
    if (strncasecmp(ua->cmd, _("yes"), strlen(ua->cmd)) == 0) {
       Dmsg1(200, "Calling run_job job=%x\n", jcr->job);
       run_job(jcr);
-      bsendmsg(ua, _("Run Job command submitted.\n"));
+      free_jcr(jcr);                 /* release jcr */
+      bsendmsg(ua, _("Run command submitted.\n"));
       return 1;
    }
 
+bail_out:
    bsendmsg(ua, _("Job not run.\n"));
    free_jcr(jcr);
    return 0;                      /* do not run */
-
 }