* - Tru64 (Extended Attributes)
*
* Written by Marco van Wieringen, November 2008
- * Major overhaul January 2012
+ * Major overhaul January 2012 + June 2012
*/
#include "bacula.h"
static bxattr_exit_code aix_xattr_build_streams(JCR *jcr, FF_PKT *ff_pkt)
{
+ char *bp;
bool skip_xattr;
- char *xattr_list, *bp;
+ char *xattr_list = NULL;
int cnt, xattr_count = 0;
uint32_t name_length;
int32_t xattr_list_len,
xattr_value_len;
uint32_t expected_serialize_len = 0;
- xattr_t *current_xattr = NULL;
+ xattr_t *current_xattr;
alist *xattr_value_list = NULL;
bxattr_exit_code retval = bxattr_exit_error;
switch (errno) {
case ENOENT:
case EFORMAT:
- return bxattr_exit_ok;
+ retval = bxattr_exit_ok;
+ goto bail_out;
case ENOTSUP:
/*
* If the filesystem reports it doesn't support XATTRs we clear the
* when we change from one filesystem to an other.
*/
jcr->xattr_data->flags &= ~BXATTR_FLAG_SAVE_NATIVE;
- return bxattr_exit_ok;
+ retval = bxattr_exit_ok;
+ goto bail_out;
default:
Mmsg2(jcr->errmsg,
_("llistea error on file \"%s\": ERR=%s\n"),
jcr->last_fname, be.bstrerror());
Dmsg2(100, "llistea error file=%s ERR=%s\n",
jcr->last_fname, be.bstrerror());
- return bxattr_exit_error;
+ goto bail_out;
}
break;
}
case 0:
- return bxattr_exit_ok;
+ retval = bxattr_exit_ok;
+ goto bail_out;
default:
break;
}
* Walk the list of extended attributes names and retrieve the data.
* We already count the bytes needed for serializing the stream later on.
*/
- bp = xattr_list;
- while ((bp - xattr_list) + 1 < xattr_list_len) {
+ for (bp = xattr_list;
+ (bp - xattr_list) + 1 < xattr_list_len;
+ bp = strchr(bp, '\0') + 1) {
skip_xattr = false;
/*
name_length = strlen(bp);
if (skip_xattr || name_length == 0) {
Dmsg1(100, "Skipping xattr named %s\n", bp);
- bp = strchr(bp, '\0') + 1;
continue;
}
- /*
- * Each xattr valuepair starts with a magic so we can parse it easier.
- */
- current_xattr = (xattr_t *)malloc(sizeof(xattr_t));
- current_xattr->magic = XATTR_MAGIC;
- expected_serialize_len += sizeof(current_xattr->magic);
-
- /*
- * Allocate space for storing the name.
- */
- current_xattr->name_length = name_length;
- current_xattr->name = (char *)malloc(current_xattr->name_length);
- memcpy(current_xattr->name, bp, current_xattr->name_length);
-
- expected_serialize_len += sizeof(current_xattr->name_length) +
- current_xattr->name_length;
-
/*
* First see how long the value is for the extended attribute.
*/
}
break;
}
+ default:
+ break;
+ }
+
+ /*
+ * Each xattr valuepair starts with a magic so we can parse it easier.
+ */
+ current_xattr = (xattr_t *)malloc(sizeof(xattr_t));
+ current_xattr->magic = XATTR_MAGIC;
+ expected_serialize_len += sizeof(current_xattr->magic);
+
+ /*
+ * Allocate space for storing the name.
+ */
+ current_xattr->name_length = name_length;
+ current_xattr->name = (char *)malloc(current_xattr->name_length);
+ memcpy(current_xattr->name, bp, current_xattr->name_length);
+
+ expected_serialize_len += sizeof(current_xattr->name_length) +
+ current_xattr->name_length;
+
+ switch (xattr_value_len) {
case 0:
current_xattr->value = NULL;
current_xattr->value_length = 0;
case ENOENT:
case EFORMAT:
retval = bxattr_exit_ok;
- goto bail_out;
+ break;
default:
Mmsg2(jcr->errmsg,
_("lgetea error on file \"%s\": ERR=%s\n"),
jcr->last_fname, be.bstrerror());
Dmsg2(100, "lgetea error file=%s ERR=%s\n",
jcr->last_fname, be.bstrerror());
- goto bail_out;
+ break;
}
+
+ /*
+ * Default failure path out when retrieval of attr fails.
+ */
+ free(current_xattr->value);
+ free(current_xattr->name);
+ free(current_xattr);
+ goto bail_out;
}
/*
* Store the actual length of the value.
current_xattr->value_length = xattr_value_len;
expected_serialize_len += sizeof(current_xattr->value_length) +
current_xattr->value_length;
-
- /*
- * Protect ourself against things getting out of hand.
- */
- if (expected_serialize_len >= MAX_XATTR_STREAM) {
- Mmsg2(jcr->errmsg,
- _("Xattr stream on file \"%s\" exceeds maximum size of %d bytes\n"),
- jcr->last_fname, MAX_XATTR_STREAM);
- goto bail_out;
- }
break;
}
}
xattr_value_list->append(current_xattr);
- current_xattr = NULL;
xattr_count++;
- bp = strchr(bp, '\0') + 1;
+
+ /*
+ * Protect ourself against things getting out of hand.
+ */
+ if (expected_serialize_len >= MAX_XATTR_STREAM) {
+ Mmsg2(jcr->errmsg,
+ _("Xattr stream on file \"%s\" exceeds maximum size of %d bytes\n"),
+ jcr->last_fname, MAX_XATTR_STREAM);
+ goto bail_out;
+ }
}
free(xattr_list);
}
bail_out:
- if (current_xattr != NULL) {
- if (current_xattr->value != NULL) {
- free(current_xattr->value);
- }
- if (current_xattr->name != NULL) {
- free(current_xattr->name);
- }
- free(current_xattr);
- }
if (xattr_list != NULL) {
free(xattr_list);
}
if (xattr_value_list != NULL) {
xattr_drop_internal_table(xattr_value_list);
}
+
return retval;
}
{
xattr_t *current_xattr;
alist *xattr_value_list;
+ bxattr_exit_code retval = bxattr_exit_error;
xattr_value_list = New(alist(10, not_owned_by_alist));
content,
content_length,
xattr_value_list) != bxattr_exit_ok) {
- xattr_drop_internal_table(xattr_value_list);
- return bxattr_exit_error;
+ goto bail_out;
}
foreach_alist(current_xattr, xattr_value_list) {
}
}
- xattr_drop_internal_table(xattr_value_list);
- return bxattr_exit_ok;
+ retval = bxattr_exit_ok;
bail_out:
xattr_drop_internal_table(xattr_value_list);
- return bxattr_exit_error;
+
+ return retval;
}
/*
static bxattr_exit_code irix_xattr_build_streams(JCR *jcr, FF_PKT *ff_pkt)
{
+ char dummy[32];
int cnt, length, xattr_count = 0;
attrlist_cursor_t cursor;
attrlist_t *attrlist;
attrlist_ent_t *attrlist_ent;
- xattr_t *current_xattr = NULL;
+ xattr_t *current_xattr;
alist *xattr_value_list = NULL;
uint32_t expected_serialize_len = 0;
bxattr_exit_code retval = bxattr_exit_error;
for (cnt = 0; cnt < attrlist->al_count; cnt++) {
attrlist_ent = ATTR_ENTRY(xattrbuf, cnt);
+ /*
+ * First determine if we can retrieve the xattr and how big it really is.
+ */
+ length = sizeof(dummy);
+ if (attr_get(jcr->last_fname, attrlist_ent->a_name, dummy,
+ &length, xattr_naming_spaces[cnt].flags) != 0) {
+ berrno be;
+
+ switch (errno) {
+ case ENOENT:
+ case ENOATTR:
+ retval = bxattr_exit_ok;
+ goto bail_out;
+ case E2BIG:
+ /*
+ * Size of the xattr is bigger then the 32 bytes dummy which is
+ * likely. As length now contains its actual length we can allocate
+ * a properly size buffer for the real retrieval.
+ */
+ break;
+ default:
+ Mmsg2(jcr->errmsg,
+ _("attr_list error on file \"%s\": ERR=%s\n"),
+ jcr->last_fname, be.bstrerror());
+ Dmsg2(100, "attr_list error file=%s ERR=%s\n",
+ jcr->last_fname, be.bstrerror());
+ goto bail_out;
+ }
+ }
+
/*
* Each xattr valuepair starts with a magic so we can parse it easier.
*/
expected_serialize_len += sizeof(current_xattr->name_length) +
current_xattr->name_length;
- current_xattr->value_length = attrlist_ent->a_valuelen;
+ current_xattr->value_length = length;
current_xattr->value = (char *)malloc(current_xattr->value_length);
/*
case ENOENT:
case ENOATTR:
retval = bxattr_exit_ok;
- goto bail_out;
+ break;
case E2BIG:
/*
* The buffer for the xattr isn't big enough. the value of
* current_xattr->value_length is updated with the actual size
* of the xattr. So we free the old buffer and create a new one
- * and try again.
+ * and try again. Normally this cannot happen as we size the
+ * buffer using a call to attr_get before but in case of an
+ * race condition it might happen.
*/
free(current_xattr->value);
- current_xattr->value = (char *)malloc(current_xattr->value_length);
+ current_xattr->value = (char *)malloc(length);
if (attr_get(jcr->last_fname, attrlist_ent->a_name, current_xattr->value,
&length, xattr_naming_spaces[cnt].flags) != 0) {
switch (errno) {
case ENOENT:
case ENOATTR:
retval = bxattr_exit_ok;
- goto bail_out;
+ break;
default:
Mmsg2(jcr->errmsg,
_("attr_list error on file \"%s\": ERR=%s\n"),
jcr->last_fname, be.bstrerror(errno));
Dmsg2(100, "attr_list error file=%s ERR=%s\n",
jcr->last_fname, be.bstrerror());
- goto bail_out;
+ break;
}
} else {
- current_xattr->value_length = length;
+ goto ok_continue;
}
break;
default:
jcr->last_fname, be.bstrerror());
Dmsg2(100, "attr_list error file=%s ERR=%s\n",
jcr->last_fname, be.bstrerror());
- goto bail_out;
+ break;
}
- } else {
- current_xattr->value_length = length;
+
+ /*
+ * Default failure path out when retrieval of attr fails.
+ */
+ free(current_xattr->value);
+ free(current_xattr->name);
+ free(current_xattr);
+ goto bail_out;
}
+ok_continue:
+ current_xattr->value_length = length;
expected_serialize_len += sizeof(current_xattr->value_length) +
current_xattr->value_length;
+ if (xattr_value_list == NULL) {
+ xattr_value_list = New(alist(10, not_owned_by_alist));
+ }
+
+ xattr_value_list->append(current_xattr);
+ xattr_count++;
+
/*
* Protect ourself against things getting out of hand.
*/
jcr->last_fname, MAX_XATTR_STREAM);
goto bail_out;
}
-
- if (xattr_value_list == NULL) {
- xattr_value_list = New(alist(10, not_owned_by_alist));
- }
-
- xattr_value_list->append(current_xattr);
- current_xattr = NULL;
- xattr_count++;
}
/*
}
bail_out:
- if (current_xattr != NULL) {
- if (current_xattr->value != NULL) {
- free(current_xattr->value);
- }
- if (current_xattr->name != NULL) {
- free(current_xattr->name);
- }
- free(current_xattr);
- }
free_pool_memory(xattrbuf);
if (xattr_value_list != NULL) {
xattr_drop_internal_table(xattr_value_list);
}
+
return retval;
}
content,
content_length,
xattr_value_list) != bxattr_exit_ok) {
- xattr_drop_internal_table(xattr_value_list);
- return bxattr_exit_error;
+ goto bail_out;
}
foreach_alist(current_xattr, xattr_value_list) {
}
}
- xattr_drop_internal_table(xattr_value_list);
- return bxattr_exit_ok;
+ retval = bxattr_exit_ok;
bail_out:
xattr_drop_internal_table(xattr_value_list);
- return bxattr_exit_error;
+
+ return retval;
}
/*
static bxattr_exit_code generic_xattr_build_streams(JCR *jcr, FF_PKT *ff_pkt)
{
+ char *bp;
bool skip_xattr;
- char *xattr_list, *bp;
+ char *xattr_list = NULL;
int cnt, xattr_count = 0;
uint32_t name_length;
int32_t xattr_list_len,
xattr_value_len;
uint32_t expected_serialize_len = 0;
- xattr_t *current_xattr = NULL;
+ xattr_t *current_xattr;
alist *xattr_value_list = NULL;
bxattr_exit_code retval = bxattr_exit_error;
switch (errno) {
case ENOENT:
- return bxattr_exit_ok;
+ retval = bxattr_exit_ok;
+ goto bail_out;
case BXATTR_ENOTSUP:
/*
* If the filesystem reports it doesn't support XATTRs we clear
* change from one filesystem to an other.
*/
jcr->xattr_data->flags &= ~BXATTR_FLAG_SAVE_NATIVE;
- return bxattr_exit_ok;
+ retval = bxattr_exit_ok;
+ goto bail_out;
default:
Mmsg2(jcr->errmsg,
_("llistxattr error on file \"%s\": ERR=%s\n"),
jcr->last_fname, be.bstrerror());
Dmsg2(100, "llistxattr error file=%s ERR=%s\n",
jcr->last_fname, be.bstrerror());
- return bxattr_exit_error;
+ goto bail_out;
}
break;
}
case 0:
- return bxattr_exit_ok;
+ retval = bxattr_exit_ok;
+ goto bail_out;
default:
break;
}
* Walk the list of extended attributes names and retrieve the data.
* We already count the bytes needed for serializing the stream later on.
*/
- bp = xattr_list;
- while ((bp - xattr_list) + 1 < xattr_list_len) {
+ for (bp = xattr_list;
+ (bp - xattr_list) + 1 < xattr_list_len;
+ bp = strchr(bp, '\0') + 1) {
skip_xattr = false;
/*
name_length = strlen(bp);
if (skip_xattr || name_length == 0) {
Dmsg1(100, "Skipping xattr named %s\n", bp);
- bp = strchr(bp, '\0') + 1;
continue;
}
- /*
- * Each xattr valuepair starts with a magic so we can parse it easier.
- */
- current_xattr = (xattr_t *)malloc(sizeof(xattr_t));
- current_xattr->magic = XATTR_MAGIC;
- expected_serialize_len += sizeof(current_xattr->magic);
-
- /*
- * Allocate space for storing the name.
- */
- current_xattr->name_length = name_length;
- current_xattr->name = (char *)malloc(current_xattr->name_length);
- memcpy(current_xattr->name, bp, current_xattr->name_length);
-
- expected_serialize_len += sizeof(current_xattr->name_length) + current_xattr->name_length;
-
/*
* First see how long the value is for the extended attribute.
*/
}
break;
}
+ default:
+ break;
+ }
+
+ /*
+ * Each xattr valuepair starts with a magic so we can parse it easier.
+ */
+ current_xattr = (xattr_t *)malloc(sizeof(xattr_t));
+ current_xattr->magic = XATTR_MAGIC;
+ current_xattr->value = NULL;
+ expected_serialize_len += sizeof(current_xattr->magic);
+
+ /*
+ * Allocate space for storing the name.
+ */
+ current_xattr->name_length = name_length;
+ current_xattr->name = (char *)malloc(current_xattr->name_length);
+ memcpy(current_xattr->name, bp, current_xattr->name_length);
+
+ expected_serialize_len += sizeof(current_xattr->name_length) + current_xattr->name_length;
+
+ switch (xattr_value_len) {
case 0:
current_xattr->value = NULL;
current_xattr->value_length = 0;
switch (errno) {
case ENOENT:
retval = bxattr_exit_ok;
- goto bail_out;
+ break;
default:
Mmsg2(jcr->errmsg,
_("lgetxattr error on file \"%s\": ERR=%s\n"),
jcr->last_fname, be.bstrerror());
Dmsg2(100, "lgetxattr error file=%s ERR=%s\n",
jcr->last_fname, be.bstrerror());
- goto bail_out;
+ break;
}
+
+ /*
+ * Default failure path out when retrieval of attr fails.
+ */
+ free(current_xattr->value);
+ free(current_xattr->name);
+ free(current_xattr);
+ goto bail_out;
}
+
/*
* Store the actual length of the value.
*/
current_xattr->value_length = xattr_value_len;
expected_serialize_len += sizeof(current_xattr->value_length) + current_xattr->value_length;
-
- /*
- * Protect ourself against things getting out of hand.
- */
- if (expected_serialize_len >= MAX_XATTR_STREAM) {
- Mmsg2(jcr->errmsg,
- _("Xattr stream on file \"%s\" exceeds maximum size of %d bytes\n"),
- jcr->last_fname, MAX_XATTR_STREAM);
- goto bail_out;
- }
+ break;
}
if (xattr_value_list == NULL) {
}
xattr_value_list->append(current_xattr);
- current_xattr = NULL;
xattr_count++;
- bp = strchr(bp, '\0') + 1;
- break;
+
+ /*
+ * Protect ourself against things getting out of hand.
+ */
+ if (expected_serialize_len >= MAX_XATTR_STREAM) {
+ Mmsg2(jcr->errmsg,
+ _("Xattr stream on file \"%s\" exceeds maximum size of %d bytes\n"),
+ jcr->last_fname, MAX_XATTR_STREAM);
+ goto bail_out;
+ }
}
free(xattr_list);
}
bail_out:
- if (current_xattr != NULL) {
- if (current_xattr->value != NULL) {
- free(current_xattr->value);
- }
- if (current_xattr->name != NULL) {
- free(current_xattr->name);
- }
- free(current_xattr);
- }
if (xattr_list != NULL) {
free(xattr_list);
}
if (xattr_value_list != NULL) {
xattr_drop_internal_table(xattr_value_list);
}
+
return retval;
}
{
xattr_t *current_xattr;
alist *xattr_value_list;
+ bxattr_exit_code retval = bxattr_exit_error;
xattr_value_list = New(alist(10, not_owned_by_alist));
content,
content_length,
xattr_value_list) != bxattr_exit_ok) {
- xattr_drop_internal_table(xattr_value_list);
- return bxattr_exit_error;
+ goto bail_out;
}
foreach_alist(current_xattr, xattr_value_list) {
}
}
- xattr_drop_internal_table(xattr_value_list);
- return bxattr_exit_ok;
+ retval = bxattr_exit_ok;
bail_out:
xattr_drop_internal_table(xattr_value_list);
- return bxattr_exit_error;
+
+ return retval;
}
/*
static bxattr_exit_code bsd_build_xattr_streams(JCR *jcr, FF_PKT *ff_pkt)
{
bool skip_xattr;
- char *xattr_list;
+ char *xattr_list = NULL;
int cnt, index, xattr_count = 0;
int32_t xattr_list_len,
xattr_value_len;
int attrnamespace;
char *current_attrnamespace = NULL;
char current_attrname[XATTR_BUFSIZ], current_attrtuple[XATTR_BUFSIZ];
- xattr_t *current_xattr = NULL;
+ xattr_t *current_xattr;
alist *xattr_value_list = NULL;
bxattr_exit_code retval = bxattr_exit_error;
continue;
}
- /*
- * Each xattr valuepair starts with a magic so we can parse it easier.
- */
- current_xattr = (xattr_t *)malloc(sizeof(xattr_t));
- current_xattr->magic = XATTR_MAGIC;
- expected_serialize_len += sizeof(current_xattr->magic);
-
- /*
- * Allocate space for storing the name.
- */
- current_xattr->name_length = strlen(current_attrtuple);
- current_xattr->name = (char *)malloc(current_xattr->name_length);
- memcpy(current_xattr->name, current_attrtuple, current_xattr->name_length);
-
- expected_serialize_len += sizeof(current_xattr->name_length) +
- current_xattr->name_length;
-
/*
* First see how long the value is for the extended attribute.
*/
}
break;
}
+ default:
+ break;
+ }
+
+ /*
+ * Each xattr valuepair starts with a magic so we can parse it easier.
+ */
+ current_xattr = (xattr_t *)malloc(sizeof(xattr_t));
+ current_xattr->magic = XATTR_MAGIC;
+ current_xattr->value = NULL;
+ expected_serialize_len += sizeof(current_xattr->magic);
+
+ /*
+ * Allocate space for storing the name.
+ */
+ current_xattr->name_length = strlen(current_attrtuple);
+ current_xattr->name = (char *)malloc(current_xattr->name_length);
+ memcpy(current_xattr->name, current_attrtuple, current_xattr->name_length);
+
+ expected_serialize_len += sizeof(current_xattr->name_length) +
+ current_xattr->name_length;
+
+ switch (xattr_value_len) {
case 0:
current_xattr->value = NULL;
current_xattr->value_length = 0;
switch (errno) {
case ENOENT:
retval = bxattr_exit_ok;
- goto bail_out;
+ break;
default:
Mmsg2(jcr->errmsg,
_("extattr_get_link error on file \"%s\": ERR=%s\n"),
jcr->last_fname, be.bstrerror());
Dmsg2(100, "extattr_get_link error file=%s ERR=%s\n",
jcr->last_fname, be.bstrerror());
- goto bail_out;
+ break;
}
+
+ /*
+ * Default failure path out when retrieval of attr fails.
+ */
+ free(current_xattr->value);
+ free(current_xattr->name);
+ free(current_xattr);
+ goto bail_out;
}
/*
current_xattr->value_length = xattr_value_len;
expected_serialize_len += sizeof(current_xattr->value_length) +
current_xattr->value_length;
-
- /*
- * Protect ourself against things getting out of hand.
- */
- if (expected_serialize_len >= MAX_XATTR_STREAM) {
- Mmsg2(jcr->errmsg,
- _("Xattr stream on file \"%s\" exceeds maximum size of %d bytes\n"),
- jcr->last_fname, MAX_XATTR_STREAM);
- goto bail_out;
- }
break;
}
}
xattr_value_list->append(current_xattr);
- current_xattr = NULL;
xattr_count++;
+ /*
+ * Protect ourself against things getting out of hand.
+ */
+ if (expected_serialize_len >= MAX_XATTR_STREAM) {
+ Mmsg2(jcr->errmsg,
+ _("Xattr stream on file \"%s\" exceeds maximum size of %d bytes\n"),
+ jcr->last_fname, MAX_XATTR_STREAM);
+ goto bail_out;
+ }
}
/*
if (current_attrnamespace != NULL) {
actuallyfree(current_attrnamespace);
}
- if (current_xattr != NULL) {
- if (current_xattr->value != NULL) {
- free(current_xattr->value);
- }
- if (current_xattr->name != NULL) {
- free(current_xattr->name);
- }
- free(current_xattr);
- }
if (xattr_list != NULL) {
free(xattr_list);
}
if (xattr_value_list != NULL) {
xattr_drop_internal_table(xattr_value_list);
}
+
return retval;
}
alist *xattr_value_list;
int current_attrnamespace, cnt;
char *attrnamespace, *attrname;
+ bxattr_exit_code retval = bxattr_exit_error;
xattr_value_list = New(alist(10, not_owned_by_alist));
content,
content_length,
xattr_value_list) != bxattr_exit_ok) {
- xattr_drop_internal_table(xattr_value_list);
- return bxattr_exit_error;
+ goto bail_out;
}
foreach_alist(current_xattr, xattr_value_list) {
}
}
- xattr_drop_internal_table(xattr_value_list);
- return bxattr_exit_ok;
+ retval = bxattr_exit_ok;
bail_out:
xattr_drop_internal_table(xattr_value_list);
- return bxattr_exit_error;
+
+ return retval;
}
/*
xattrbuf_size,
xattrbuf_min_size;
uint32_t expected_serialize_len = 0;
- xattr_t *current_xattr = NULL;
+ xattr_t *current_xattr;
alist *xattr_value_list = NULL;
struct proplistname_args prop_args;
bxattr_exit_code retval = bxattr_exit_error;
expected_serialize_len += sizeof(current_xattr->value_length) +
current_xattr->value_length;
+ if (xattr_value_list == NULL) {
+ xattr_value_list = New(alist(10, not_owned_by_alist));
+ }
+
+ xattr_value_list->append(current_xattr);
+ xattr_count++;
+
/*
* Protect ourself against things getting out of hand.
*/
jcr->last_fname, MAX_XATTR_STREAM);
goto bail_out;
}
-
- if (xattr_value_list == NULL) {
- xattr_value_list = New(alist(10, not_owned_by_alist));
- }
-
- xattr_value_list->append(current_xattr);
- current_xattr = NULL;
- xattr_count++;
}
/*
}
bail_out:
- if (current_xattr != NULL) {
- if (current_xattr->value != NULL) {
- free(current_xattr->value);
- }
- if (current_xattr->name != NULL) {
- free(current_xattr->name);
- }
- free(current_xattr);
- }
if (xattr_value_list != NULL) {
xattr_drop_internal_table(xattr_value_list);
}
content,
content_length,
xattr_value_list) != bxattr_exit_ok) {
- xattr_drop_internal_table(xattr_value_list);
- return bxattr_exit_error;
+ goto bail_out;
}
/*
break;
}
- free(xattrbuf);
-
- xattr_drop_internal_table(xattr_value_list);
- return bxattr_exit_ok;
+ retval = bxattr_exit_ok;
bail_out:
if (xattrbuf) {
free(xattrbuf);
}
xattr_drop_internal_table(xattr_value_list);
- return bxattr_exit_error;
+
+ return retval;
}
/*
* This code creates a temporary cache with entries for each xattr which has
* a link count > 1 (which indicates it has one or more hard linked counterpart(s))
*/
-static xattr_link_cache_entry_t *find_xattr_link_cache_entry(JCR *jcr, ino_t inum)
+static inline xattr_link_cache_entry_t *find_xattr_link_cache_entry(JCR *jcr, ino_t inum)
{
xattr_link_cache_entry_t *ptr;
return NULL;
}
-static void add_xattr_link_cache_entry(JCR *jcr, ino_t inum, char *target)
+static inline void add_xattr_link_cache_entry(JCR *jcr, ino_t inum, char *target)
{
xattr_link_cache_entry_t *ptr;
ptr = (xattr_link_cache_entry_t *)malloc(sizeof(xattr_link_cache_entry_t));
memset(ptr, 0, sizeof(xattr_link_cache_entry_t));
ptr->inum = inum;
- bstrncpy(ptr->target, target, sizeof(ptr->target));
+ ptr->target = bstrdup(target);
if (!jcr->xattr_data->u.build->link_cache) {
jcr->xattr_data->u.build->link_cache = New(alist(10, not_owned_by_alist));
jcr->xattr_data->u.build->link_cache->append(ptr);
}
+static inline void drop_xattr_link_cache(JCR *jcr)
+{
+ xattr_link_cache_entry_t *ptr;
+
+ /*
+ * Walk the list of xattr link cache entries and free allocated memory on traversing.
+ */
+ foreach_alist(ptr, jcr->xattr_data->u.build->link_cache) {
+ free(ptr->target);
+ free(ptr);
+ }
+
+ delete jcr->xattr_data->u.build->link_cache;
+ jcr->xattr_data->u.build->link_cache = NULL;
+}
+
#if defined(HAVE_SYS_NVPAIR_H) && defined(_PC_SATTR_ENABLED)
/*
* This function returns true if a non default extended system attribute
static bxattr_exit_code solaris_save_xattr_acl(JCR *jcr, int fd, const char *attrname, char **acl_text)
{
+ bxattr_exit_code retval = bxattr_exit_error;
#ifdef HAVE_ACL
#ifdef HAVE_EXTENDED_ACL
int flags;
switch (errno) {
case ENOENT:
- return bxattr_exit_ok;
+ retval = bxattr_exit_ok;
+ goto bail_out;
default:
Mmsg3(jcr->errmsg,
_("Unable to get acl on xattr %s on file \"%s\": ERR=%s\n"),
attrname, jcr->last_fname, be.bstrerror());
Dmsg3(100, "facl_get/acl_get of xattr %s on \"%s\" failed: ERR=%s\n",
attrname, jcr->last_fname, be.bstrerror());
- return bxattr_exit_error;
+ goto bail_out;
}
}
} else {
*acl_text = NULL;
}
- return bxattr_exit_ok;
+ retval = bxattr_exit_ok;
#else /* HAVE_EXTENDED_ACL */
int n;
aclent_t *acls = NULL;
switch (errno) {
case ENOENT:
free(acls);
- return bxattr_exit_ok;
+ retval = bxattr_exit_ok;
+ goto bail_out;
default:
Mmsg3(jcr->errmsg,
_("Unable to get acl on xattr %s on file \"%s\": ERR=%s\n"),
Dmsg3(100, "facl/acl of xattr %s on \"%s\" failed: ERR=%s\n",
attrname, jcr->last_fname, be.bstrerror());
free(acls);
- return bxattr_exit_error;
+ goto bail_out;
}
}
Dmsg3(100, "acltotext of xattr %s on \"%s\" failed: ERR=%s\n",
attrname, jcr->last_fname, be.bstrerror());
free(acls);
- return bxattr_exit_error;
+ goto bail_out;
}
} else {
*acl_text = NULL;
} else {
*acl_text = NULL;
}
- return bxattr_exit_ok;
+ retval = bxattr_exit_ok;
#endif /* HAVE_EXTENDED_ACL */
#else /* HAVE_ACL */
- return bxattr_exit_ok;
+ retval = bxattr_exit_ok;
#endif /* HAVE_ACL */
+
+bail_out:
+ return retval;
}
/*
retval = solaris_save_xattrs(jcr, NULL, NULL);
chdir(cwd);
if (jcr->xattr_data->u.build->link_cache) {
- delete jcr->xattr_data->u.build->link_cache;
- jcr->xattr_data->u.build->link_cache = NULL;
+ drop_xattr_link_cache(jcr);
}
}
return retval;
{
char cwd[PATH_MAX];
bool is_extensible = false;
- bxattr_exit_code retval;
+ bxattr_exit_code retval = bxattr_exit_error;
/*
* First make sure we can restore xattr on the filesystem.
jcr->last_fname);
Dmsg1(100, "Unable to restore extensible attributes on file \"%s\", filesystem doesn't support this\n",
jcr->last_fname);
- return bxattr_exit_error;
+ goto bail_out;
}
is_extensible = true;
jcr->last_fname);
Dmsg1(100, "Unable to restore extended attributes on file \"%s\", filesystem doesn't support this\n",
jcr->last_fname);
- return bxattr_exit_error;
+ goto bail_out;
}
break;
default:
- return bxattr_exit_error;
+ goto bail_out;
}
/*
getcwd(cwd, sizeof(cwd));
retval = solaris_restore_xattrs(jcr, is_extensible, content, content_length);
chdir(cwd);
+
+bail_out:
return retval;
}
int ret;
struct stat st;
unsigned int cnt;
+ bxattr_exit_code retval = bxattr_exit_error;
/*
* See if we are changing from one device to an other.
switch (errno) {
case ENOENT:
- return bxattr_exit_ok;
+ retval = bxattr_exit_ok;
+ goto bail_out;
default:
Mmsg2(jcr->errmsg,
_("Unable to stat file \"%s\": ERR=%s\n"),
jcr->last_fname, be.bstrerror());
Dmsg2(100, "Unable to stat file \"%s\": ERR=%s\n",
jcr->last_fname, be.bstrerror());
- return bxattr_exit_error;
+ goto bail_out;
}
break;
}
*/
for (cnt = 0; cnt < sizeof(os_default_xattr_streams) / sizeof(int); cnt++) {
if (os_default_xattr_streams[cnt] == stream) {
- return os_parse_xattr_streams(jcr, stream, content, content_length);
+ retval = os_parse_xattr_streams(jcr, stream, content, content_length);
+ goto bail_out;
}
}
} else {
* Increment error count but don't log an error again for the same filesystem.
*/
jcr->xattr_data->u.parse->nr_errors++;
- return bxattr_exit_ok;
+ retval = bxattr_exit_ok;
+ goto bail_out;
}
/*
* Issue a warning and discard the message. But pretend the restore was ok.
*/
Jmsg2(jcr, M_WARNING, 0,
- _("Can't restore Extended Attributes of %s - incompatible xattr stream encountered - %d\n"),
- jcr->last_fname, stream);
- return bxattr_exit_error;
+ _("Can't restore Extended Attributes of %s - incompatible xattr stream encountered - %d\n"),
+ jcr->last_fname, stream);
+
+bail_out:
+ return retval;
}
#endif
projects / bacula / bacula / blobdiff