Update doc

[bacula/bacula] / bacula / src / findlib / create_file.c

diff --git a/bacula/src/findlib/create_file.c b/bacula/src/findlib/create_file.c
index c947cecf1c7d8e7da5b90d4b16e64f08e236d59c..500061d25a1eb343516d9ed41e8f5213d93467b3 100644 (file)
--- a/bacula/src/findlib/create_file.c
+++ b/bacula/src/findlib/create_file.c
@@ -7,7 +7,7 @@
  *
  */
 /*
-   Copyright (C) 2000-2003 Kern Sibbald and John Walker
+   Copyright (C) 2000-2004 Kern Sibbald and John Walker
 
    This program is free software; you can redistribute it and/or
    modify it under the terms of the GNU General Public License as
@@ -39,7 +39,7 @@
 #endif
 
 static int separate_path_and_file(JCR *jcr, char *fname, char *ofile);
-static int path_already_seen(char *path, int pnl);
+static int path_already_seen(JCR *jcr, char *path, int pnl);
 
 
 /*
@@ -144,7 +144,7 @@ int create_file(JCR *jcr, ATTR *attr, BFILE *bfd, int replace)
         savechr = attr->ofname[pnl];
         attr->ofname[pnl] = 0;                 /* terminate path */
 
-        if (!path_already_seen(attr->ofname, pnl)) {
+        if (!path_already_seen(jcr, attr->ofname, pnl)) {
             Dmsg1(50, "Make path %s\n", attr->ofname);
            /*
             * If we need to make the directory, ensure that it is with
@@ -170,14 +170,16 @@ int create_file(JCR *jcr, ATTR *attr, BFILE *bfd, int replace)
            mode |= O_CTG;               /* set contiguous bit if needed */
         }
          Dmsg1(50, "Create file: %s\n", attr->ofname);
+        if (is_bopen(bfd)) {
+            Jmsg1(jcr, M_ERROR, 0, "bpkt already open fid=%d\n", bfd->fid);
+        }
         if ((bopen(bfd, attr->ofname, mode, S_IRUSR | S_IWUSR)) < 0) {
-            Jmsg2(jcr, M_ERROR, 0, _("Could not create %s: %d ERR=%s\n"), 
+            Jmsg2(jcr, M_ERROR, 0, _("Could not create %s: ERR=%s\n"), 
                  attr->ofname, berror(bfd));
-
            return CF_ERROR;
         }
         return CF_EXTRACT;
-
+#ifndef HAVE_WIN32  // none of these exists on MS Windows
       case FT_RAW:                   /* Bacula raw device e.g. /dev/sda1 */
       case FT_FIFO:                  /* Bacula fifo to save data */
       case FT_SPEC:                     
@@ -197,7 +199,7 @@ int create_file(JCR *jcr, ATTR *attr, BFILE *bfd, int replace)
            }
         }       
         if (attr->type == FT_RAW || attr->type == FT_FIFO) {
-           btimer_id tid;
+           btimer_t *tid;
             Dmsg1(200, "FT_RAW|FT_FIFO %s\n", attr->ofname);
            mode =  O_WRONLY | O_BINARY;
            /* Timeout open() in 60 seconds */
@@ -206,6 +208,9 @@ int create_file(JCR *jcr, ATTR *attr, BFILE *bfd, int replace)
            } else {
               tid = NULL;
            }
+           if (is_bopen(bfd)) {
+               Jmsg1(jcr, M_ERROR, 0, "bpkt already open fid=%d\n", bfd->fid);
+           }
            if ((bopen(bfd, attr->ofname, mode, 0)) < 0) {
                Jmsg2(jcr, M_ERROR, 0, _("Could not open %s: ERR=%s\n"), 
                     attr->ofname, berror(bfd));
@@ -235,7 +240,7 @@ int create_file(JCR *jcr, ATTR *attr, BFILE *bfd, int replace)
            return CF_ERROR;
         }
         return CF_CREATED;
-
+#endif
       } /* End inner switch */
 
    case FT_DIR:
@@ -249,6 +254,9 @@ int create_file(JCR *jcr, ATTR *attr, BFILE *bfd, int replace)
        *   and saved.
        */
       if (!is_portable_backup(bfd)) {
+        if (is_bopen(bfd)) {
+            Jmsg1(jcr, M_ERROR, 0, "bpkt already open fid=%d\n", bfd->fid);
+        }
         if ((bopen(bfd, attr->ofname, O_WRONLY|O_BINARY, 0)) < 0) {
             Jmsg2(jcr, M_ERROR, 0, _("Could not open %s: ERR=%s\n"), 
                  attr->ofname, berror(bfd));
@@ -310,26 +318,19 @@ static int separate_path_and_file(JCR *jcr, char *fname, char *ofile)
    return pnl;
 }
 
-static pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER;
-
 /* 
  * Primitive caching of path to prevent recreating a pathname 
  *   each time as long as we remain in the same directory.
  */
-static int path_already_seen(char *path, int pnl)
+static int path_already_seen(JCR *jcr, char *path, int pnl)
 {
-   static int cached_pnl = 0;
-   static char cached_path[1000];
-
-   P(mutex);
-   if (cached_pnl == pnl && strcmp(path, cached_path) == 0) {
-      V(mutex);
-      return 1;
+   if (!jcr->cached_path) {
+      jcr->cached_path = get_pool_memory(PM_FNAME);
    }
-   if (pnl < (int)(sizeof(cached_path)-1)) {
-      strcpy(cached_path, path);
-      cached_pnl = pnl;
+   if (jcr->cached_pnl == pnl && strcmp(path, jcr->cached_path) == 0) {
+      return 1;
    }
-   V(mutex);
+   pm_strcpy(&jcr->cached_path, path);
+   jcr->cached_pnl = pnl;
    return 0;
 }