Fix get_basename() -- rewrite

[bacula/bacula] / bacula / src / lib / fnmatch.c

diff --git a/bacula/src/lib/fnmatch.c b/bacula/src/lib/fnmatch.c
index 73396b91880ea58a941800def9a130e18e8821c4..b395b11e242b7c7838df6d08fefa295ead4a596d 100644 (file)
--- a/bacula/src/lib/fnmatch.c
+++ b/bacula/src/lib/fnmatch.c
@@ -56,20 +56,41 @@
 #define RANGE_NOMATCH   0
 #define RANGE_ERROR     (-1)
 
+/* Limit of recursion during matching attempts. */
+#define FNM_MAX_RECUR 64
+
 #define ISSET(x, y) ((x) & (y))
 #define FOLD(c) ((flags & FNM_CASEFOLD) && B_ISUPPER(c) ? tolower(c) : (c))
 
 static int rangematch(const char *, char, int, char **);
+static int r_fnmatch(const char *, const char *, int, int);
 
 #ifdef SYS 
 int xfnmatch(const char *pattern, const char *string, int flags)
 #else
 int fnmatch(const char *pattern, const char *string, int flags)
 #endif
+{
+   int e;
+
+   e = r_fnmatch(pattern, string, flags, FNM_MAX_RECUR);
+   if (e == -1) {               /* Too much recursion */
+      e = FNM_NOMATCH;
+   }
+   return (e);
+}
+
+static 
+int r_fnmatch(const char *pattern, const char *string, int flags, int recur)
 {
    const char *stringstart;
    char *newp;
    char c, test;
+   int e;
+
+   if (recur-- <= 0) {
+      return (-1);
+   }
 
    stringstart = string;
    for ( ;; ) {
@@ -81,7 +102,7 @@ int fnmatch(const char *pattern, const char *string, int flags)
       case '?':
          if (*string == EOS)
             return (FNM_NOMATCH);
-         if (*string == '/' && ISSET(flags, FNM_PATHNAME))
+         if (IsPathSeparator(*string) && ISSET(flags, FNM_PATHNAME))
             return (FNM_NOMATCH);
          if (*string == '.' && ISSET(flags, FNM_PERIOD) &&
              (string == stringstart ||
@@ -92,22 +113,25 @@ int fnmatch(const char *pattern, const char *string, int flags)
       case '*':
          c = *pattern;
          /* Collapse multiple stars. */
-         while (c == '*')
+         while (c == '*') {
             c = *++pattern;
+         }
 
          if (*string == '.' && ISSET(flags, FNM_PERIOD) &&
              (string == stringstart ||
-              (ISSET(flags, FNM_PATHNAME) && IsPathSeparator(*(string - 1)))))
+              (ISSET(flags, FNM_PATHNAME) && IsPathSeparator(*(string - 1))))) {
             return (FNM_NOMATCH);
+         }
 
          /* Optimize for pattern with * at end or before /. */
          if (c == EOS) {
-            if (ISSET(flags, FNM_PATHNAME))
+            if (ISSET(flags, FNM_PATHNAME)) {
                return (ISSET(flags, FNM_LEADING_DIR) ||
                        strchr(string, '/') == NULL ? 0 : FNM_NOMATCH);
-            else
+            } else {
                return (0);
-         } else if (c == '/' && ISSET(flags, FNM_PATHNAME)) {
+            }
+         } else if (IsPathSeparator(c) && ISSET(flags, FNM_PATHNAME)) {
             if ((string = strchr(string, '/')) == NULL)
                return (FNM_NOMATCH);
             break;
@@ -115,10 +139,13 @@ int fnmatch(const char *pattern, const char *string, int flags)
 
          /* General case, use recursion. */
          while ((test = *string) != EOS) {
-            if (!fnmatch(pattern, string, flags & ~FNM_PERIOD))
-               return (0);
-            if (test == '/' && ISSET(flags, FNM_PATHNAME))
+            e = r_fnmatch(pattern, string, flags & ~FNM_PERIOD, recur);
+            if (e != FNM_NOMATCH) { /* can be NOMATCH, -1 or MATCH */
+               return (e);
+            }
+            if (test == '/' && ISSET(flags, FNM_PATHNAME)) {
                break;
+            }
             ++string;
          }
          return (FNM_NOMATCH);
@@ -144,6 +171,7 @@ int fnmatch(const char *pattern, const char *string, int flags)
          }
          ++string;
          break;
+
       case '\\':
          if (!ISSET(flags, FNM_NOESCAPE)) {
             if ((c = *pattern++) == EOS) {
@@ -153,7 +181,7 @@ int fnmatch(const char *pattern, const char *string, int flags)
          }
          /* FALLTHROUGH */
       default:
-       normal:
+normal:
          if (FOLD(c) != FOLD(*string)) {
             return (FNM_NOMATCH);
          }
@@ -230,18 +258,18 @@ struct test {
  *  me know.
  */
 static struct test tests[] = {
-/*1*/  {"x", "x", FNM_FILE_NAME | FNM_LEADING_DIR, 0},
-       {"x", "x/y", FNM_FILE_NAME | FNM_LEADING_DIR, 0},
-       {"x", "x/y/z", FNM_FILE_NAME | FNM_LEADING_DIR, 0},
-       {"*", "x", FNM_FILE_NAME | FNM_LEADING_DIR, 0},
-/*5*/  {"*", "x/y", FNM_FILE_NAME | FNM_LEADING_DIR, 0},
-       {"*", "x/y/z", FNM_FILE_NAME | FNM_LEADING_DIR, 0},
-       {"*x", "x", FNM_FILE_NAME | FNM_LEADING_DIR, 0},
-       {"*x", "x/y", FNM_FILE_NAME | FNM_LEADING_DIR, 0},
-       {"*x", "x/y/z", FNM_FILE_NAME | FNM_LEADING_DIR, 0},
-/*10*/ {"x*", "x", FNM_FILE_NAME | FNM_LEADING_DIR, 0},
-       {"x*", "x/y", FNM_FILE_NAME | FNM_LEADING_DIR, 0},
-       {"x*", "x/y/z", FNM_FILE_NAME | FNM_LEADING_DIR, 0},
+/*1*/  {"x", "x", FNM_PATHNAME | FNM_LEADING_DIR, 0},
+       {"x", "x/y", FNM_PATHNAME | FNM_LEADING_DIR, 0},
+       {"x", "x/y/z", FNM_PATHNAME | FNM_LEADING_DIR, 0},
+       {"*", "x", FNM_PATHNAME | FNM_LEADING_DIR, 0},
+/*5*/  {"*", "x/y", FNM_PATHNAME | FNM_LEADING_DIR, 0},
+       {"*", "x/y/z", FNM_PATHNAME | FNM_LEADING_DIR, 0},
+       {"*x", "x", FNM_PATHNAME | FNM_LEADING_DIR, 0},
+       {"*x", "x/y", FNM_PATHNAME | FNM_LEADING_DIR, 0},
+       {"*x", "x/y/z", FNM_PATHNAME | FNM_LEADING_DIR, 0},
+/*10*/ {"x*", "x", FNM_PATHNAME | FNM_LEADING_DIR, 0},
+       {"x*", "x/y", FNM_PATHNAME | FNM_LEADING_DIR, 0},
+       {"x*", "x/y/z", FNM_PATHNAME | FNM_LEADING_DIR, 0},
        {"a*b/*", "abbb/.x", FNM_PATHNAME|FNM_PERIOD, FNM_NOMATCH},
        {"a*b/*", "abbb/xy", FNM_PATHNAME|FNM_PERIOD, 0},
 /*15*/ {"[A-[]", "A", 0, 0},
@@ -255,31 +283,32 @@ static struct test tests[] = {
        { "*LIB*", "lib", FNM_PERIOD, FNM_NOMATCH },
        { "*LIB*", "lib", FNM_CASEFOLD, 0},
 /*25*/ { "a[/]b", "a/b", 0, 0},
-       { "a[/]b", "a/b", FNM_FILE_NAME, FNM_NOMATCH },
+       { "a[/]b", "a/b", FNM_PATHNAME, FNM_NOMATCH },
        { "[a-z]/[a-z]", "a/b", 0, 0 },
-       { "a/b", "*", FNM_FILE_NAME, FNM_NOMATCH },
-       { "*", "a/b", FNM_FILE_NAME, FNM_NOMATCH },
-       { "*[/]b", "a/b", FNM_FILE_NAME, FNM_NOMATCH },
+       { "a/b", "*", FNM_PATHNAME, FNM_NOMATCH },
+       { "*", "a/b", FNM_PATHNAME, FNM_NOMATCH },
+       { "*[/]b", "a/b", FNM_PATHNAME, FNM_NOMATCH },
 /*30*/ { "\\[/b", "[/b", 0, 0 },
        { "?\?/b", "aa/b", 0, 0 },
        { "???b", "aa/b", 0, 0 },
-       { "???b", "aa/b", FNM_FILE_NAME, FNM_NOMATCH },
-       { "?a/b", ".a/b", FNM_FILE_NAME|FNM_PERIOD, FNM_NOMATCH },
-/*35*/ { "a/?b", "a/.b", FNM_FILE_NAME|FNM_PERIOD, FNM_NOMATCH },
-       { "*a/b", ".a/b", FNM_FILE_NAME|FNM_PERIOD, FNM_NOMATCH },
-       { "a/*b", "a/.b", FNM_FILE_NAME|FNM_PERIOD, FNM_NOMATCH },
-       { "[.]a/b", ".a/b", FNM_FILE_NAME|FNM_PERIOD, FNM_NOMATCH },
-       { "a/[.]b", "a/.b", FNM_FILE_NAME|FNM_PERIOD, FNM_NOMATCH },
-/*40*/ { "*/?", "a/b", FNM_FILE_NAME|FNM_PERIOD, 0 },
-       { "?/*", "a/b", FNM_FILE_NAME|FNM_PERIOD, 0 },
-       { ".*/?", ".a/b", FNM_FILE_NAME|FNM_PERIOD, 0 },
-       { "*/.?", "a/.b", FNM_FILE_NAME|FNM_PERIOD, 0 },
-       { "*/*", "a/.b", FNM_FILE_NAME|FNM_PERIOD, FNM_NOMATCH },
-/*45*/ { "*[.]/b", "a./b", FNM_FILE_NAME|FNM_PERIOD, 0 },
-       { "a?b", "a.b", FNM_FILE_NAME|FNM_PERIOD, 0 },
-       { "a*b", "a.b", FNM_FILE_NAME|FNM_PERIOD, 0 },
-       { "a[.]b", "a.b", FNM_FILE_NAME|FNM_PERIOD, 0 },
-/*49*/ { "*a*", "a/b", FNM_FILE_NAME|FNM_LEADING_DIR, 0 },
+       { "???b", "aa/b", FNM_PATHNAME, FNM_NOMATCH },
+       { "?a/b", ".a/b", FNM_PATHNAME|FNM_PERIOD, FNM_NOMATCH },
+/*35*/ { "a/?b", "a/.b", FNM_PATHNAME|FNM_PERIOD, FNM_NOMATCH },
+       { "*a/b", ".a/b", FNM_PATHNAME|FNM_PERIOD, FNM_NOMATCH },
+       { "a/*b", "a/.b", FNM_PATHNAME|FNM_PERIOD, FNM_NOMATCH },
+       { "[.]a/b", ".a/b", FNM_PATHNAME|FNM_PERIOD, FNM_NOMATCH },
+       { "a/[.]b", "a/.b", FNM_PATHNAME|FNM_PERIOD, FNM_NOMATCH },
+/*40*/ { "*/?", "a/b", FNM_PATHNAME|FNM_PERIOD, 0 },
+       { "?/*", "a/b", FNM_PATHNAME|FNM_PERIOD, 0 },
+       { ".*/?", ".a/b", FNM_PATHNAME|FNM_PERIOD, 0 },
+       { "*/.?", "a/.b", FNM_PATHNAME|FNM_PERIOD, 0 },
+       { "*/*", "a/.b", FNM_PATHNAME|FNM_PERIOD, FNM_NOMATCH },
+/*45*/ { "*[.]/b", "a./b", FNM_PATHNAME|FNM_PERIOD, 0 },
+       { "a?b", "a.b", FNM_PATHNAME|FNM_PERIOD, 0 },
+       { "a*b", "a.b", FNM_PATHNAME|FNM_PERIOD, 0 },
+       { "a[.]b", "a.b", FNM_PATHNAME|FNM_PERIOD, 0 },
+/*49*/ { "*a*", "a/b", FNM_PATHNAME|FNM_LEADING_DIR, 0 },
+       { "[/b", "[/b", 0, 0},
 #ifdef FULL_TEST
        /* This test takes a *long* time */
        {"a*b*c*d*e*f*g*h*i*j*k*l*m*n*o*p*q*r*s*t*u*v*w*x*y*z*",