/*
- * Bacula thread watchdog routine. General routine that monitors
- * the daemon and signals a thread if it is blocked on a BSOCK
- * too long. This prevents catastropic long waits -- generally
- * due to Windows "hanging" the app.
+ * Bacula thread watchdog routine. General routine that
+ * allows setting a watchdog timer with a callback that is
+ * called when the timer goes off.
*
* Kern Sibbald, January MMII
*
*/
/*
- Copyright (C) 2000-2004 Kern Sibbald and John Walker
+ Copyright (C) 2000-2005 Kern Sibbald
This program is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License as
#include "jcr.h"
/* Exported globals */
-time_t watchdog_time = 0; /* this has granularity of SLEEP_TIME */
-time_t watchdog_sleep_time = 1; /* examine things every second */
+time_t watchdog_time = 0; /* this has granularity of SLEEP_TIME */
+time_t watchdog_sleep_time = 60; /* examine things every 60 seconds */
+/* Locals */
+static pthread_mutex_t timer_mutex = PTHREAD_MUTEX_INITIALIZER;
+static pthread_cond_t timer = PTHREAD_COND_INITIALIZER;
/* Forward referenced functions */
extern "C" void *watchdog_thread(void *arg);
/* Static globals */
static bool quit = false;;
static bool wd_is_init = false;
-static brwlock_t lock; /* watchdog lock */
+static brwlock_t lock; /* watchdog lock */
static pthread_t wd_tid;
static dlist *wd_queue;
static dlist *wd_inactive;
-/*
+/*
* Start watchdog thread
*
* Returns: 0 on success
- * errno on failure
+ * errno on failure
*/
int start_watchdog(void)
{
if (wd_is_init) {
return 0;
}
- Dmsg0(400, "Initialising NicB-hacked watchdog thread\n");
+ Dmsg0(800, "Initialising NicB-hacked watchdog thread\n");
watchdog_time = time(NULL);
if ((errstat=rwl_init(&lock)) != 0) {
- Emsg1(M_ABORT, 0, _("Unable to initialize watchdog lock. ERR=%s\n"),
- strerror(errstat));
+ Emsg1(M_ABORT, 0, _("Unable to initialize watchdog lock. ERR=%s\n"),
+ strerror(errstat));
}
- wd_queue = new dlist(wd_queue, &dummy->link);
- wd_inactive = new dlist(wd_inactive, &dummy->link);
+ wd_queue = New(dlist(dummy, &dummy->link));
+ wd_inactive = New(dlist(dummy, &dummy->link));
if ((stat = pthread_create(&wd_tid, NULL, watchdog_thread, NULL)) != 0) {
return stat;
return 0;
}
+/*
+ * Wake watchdog timer thread so that it walks the
+ * queue and adjusts its wait time (or exits).
+ */
+static void ping_watchdog()
+{
+ P(timer_mutex);
+ pthread_cond_signal(&timer);
+ V(timer_mutex);
+}
+
/*
* Terminate the watchdog thread
*
* Returns: 0 on success
- * errno on failure
+ * errno on failure
*/
int stop_watchdog(void)
{
int stat;
- watchdog_t *p;
+ watchdog_t *p;
if (!wd_is_init) {
return 0;
}
- quit = true; /* notify watchdog thread to stop */
+ quit = true; /* notify watchdog thread to stop */
wd_is_init = false;
+ ping_watchdog();
stat = pthread_join(wd_tid, NULL);
while (!wd_queue->empty()) {
wd_queue->remove(item);
p = (watchdog_t *)item;
if (p->destructor != NULL) {
- p->destructor(p);
+ p->destructor(p);
}
free(p);
}
wd_inactive->remove(item);
p = (watchdog_t *)item;
if (p->destructor != NULL) {
- p->destructor(p);
+ p->destructor(p);
}
free(p);
}
bool register_watchdog(watchdog_t *wd)
{
if (!wd_is_init) {
- Emsg0(M_ABORT, 0, "BUG! register_watchdog called before start_watchdog\n");
+ Emsg0(M_ABORT, 0, _("BUG! register_watchdog called before start_watchdog\n"));
}
if (wd->callback == NULL) {
- Emsg1(M_ABORT, 0, "BUG! Watchdog %p has NULL callback\n", wd);
+ Emsg1(M_ABORT, 0, _("BUG! Watchdog %p has NULL callback\n"), wd);
}
if (wd->interval == 0) {
- Emsg1(M_ABORT, 0, "BUG! Watchdog %p has zero interval\n", wd);
+ Emsg1(M_ABORT, 0, _("BUG! Watchdog %p has zero interval\n"), wd);
}
wd_lock();
wd->next_fire = watchdog_time + wd->interval;
wd_queue->append(wd);
- Dmsg3(400, "Registered watchdog %p, interval %d%s\n",
+ Dmsg3(800, "Registered watchdog %p, interval %d%s\n",
wd, wd->interval, wd->one_shot ? " one shot" : "");
wd_unlock();
+ ping_watchdog();
return false;
}
-bool unregister_watchdog_unlocked(watchdog_t *wd)
+bool unregister_watchdog(watchdog_t *wd)
{
watchdog_t *p;
+ bool ok = false;
if (!wd_is_init) {
- Emsg0(M_ABORT, 0, "BUG! unregister_watchdog_unlocked called before start_watchdog\n");
+ Emsg0(M_ABORT, 0, _("BUG! unregister_watchdog_unlocked called before start_watchdog\n"));
}
+ wd_lock();
foreach_dlist(p, wd_queue) {
if (wd == p) {
- wd_queue->remove(wd);
- Dmsg1(400, "Unregistered watchdog %p\n", wd);
- return true;
+ wd_queue->remove(wd);
+ Dmsg1(800, "Unregistered watchdog %p\n", wd);
+ ok = true;
+ goto get_out;
}
}
foreach_dlist(p, wd_inactive) {
if (wd == p) {
- wd_inactive->remove(wd);
- Dmsg1(400, "Unregistered inactive watchdog %p\n", wd);
- return true;
+ wd_inactive->remove(wd);
+ Dmsg1(800, "Unregistered inactive watchdog %p\n", wd);
+ ok = true;
+ goto get_out;
}
}
- Dmsg1(400, "Failed to unregister watchdog %p\n", wd);
- return false;
-}
-
-bool unregister_watchdog(watchdog_t *wd)
-{
- bool ret;
-
- if (!wd_is_init) {
- Emsg0(M_ABORT, 0, "BUG! unregister_watchdog called before start_watchdog\n");
- }
+ Dmsg1(800, "Failed to unregister watchdog %p\n", wd);
- wd_lock();
- ret = unregister_watchdog_unlocked(wd);
+get_out:
wd_unlock();
-
- return ret;
+ ping_watchdog();
+ return ok;
}
+/*
+ * This is the thread that walks the watchdog queue
+ * and when a queue item fires, the callback is
+ * invoked. If it is a one shot, the queue item
+ * is moved to the inactive queue.
+ */
extern "C" void *watchdog_thread(void *arg)
{
- Dmsg0(400, "NicB-reworked watchdog thread entered\n");
+ struct timespec timeout;
+ struct timeval tv;
+ struct timezone tz;
+ time_t next_time;
+
+ Dmsg0(800, "NicB-reworked watchdog thread entered\n");
while (!quit) {
- watchdog_t *p, *q;
+ watchdog_t *p;
- /*
+ /*
+ *
+ * NOTE. lock_jcr_chain removed, but the message below
+ * was left until we are sure there are no deadlocks.
+ *
* We lock the jcr chain here because a good number of the
* callback routines lock the jcr chain. We need to lock
* it here *before* the watchdog lock because the SD message
* lock in the same order, we get a deadlock -- each holds
* the other's needed lock.
*/
- lock_jcr_chain();
wd_lock();
- watchdog_time = time(NULL);
+walk_list:
+ watchdog_time = time(NULL);
+ next_time = watchdog_time + watchdog_sleep_time;
foreach_dlist(p, wd_queue) {
- if (p->next_fire < watchdog_time) {
- /* Run the callback */
- p->callback(p);
+ if (p->next_fire <= watchdog_time) {
+ /* Run the callback */
+ p->callback(p);
/* Reschedule (or move to inactive list if it's a one-shot timer) */
- if (p->one_shot) {
- /*
- * Note, when removing an item while walking the list
- * we must get the previous pointer (q) and set the
- * current pointer (p) to this previous pointer after
- * removing the current pointer, otherwise, we won't
- * walk the rest of the list.
- */
- q = (watchdog_t *)wd_queue->prev(p);
- wd_queue->remove(p);
- wd_inactive->append(p);
- p = q;
- } else {
- p->next_fire = watchdog_time + p->interval;
- }
- }
+ if (p->one_shot) {
+ wd_queue->remove(p);
+ wd_inactive->append(p);
+ goto walk_list;
+ } else {
+ p->next_fire = watchdog_time + p->interval;
+ }
+ }
+ if (p->next_fire < next_time) {
+ next_time = p->next_fire;
+ }
}
wd_unlock();
- unlock_jcr_chain();
- bmicrosleep(watchdog_sleep_time, 0);
+
+ /*
+ * Wait sleep time or until someone wakes us
+ */
+ gettimeofday(&tv, &tz);
+ timeout.tv_nsec = tv.tv_usec * 1000;
+ timeout.tv_sec = tv.tv_sec + next_time - time(NULL);
+ while (timeout.tv_nsec >= 1000000000) {
+ timeout.tv_nsec -= 1000000000;
+ timeout.tv_sec++;
+ }
+
+ Dmsg1(1900, "pthread_cond_timedwait %d\n", timeout.tv_sec - tv.tv_sec);
+ /* Note, this unlocks mutex during the sleep */
+ P(timer_mutex);
+ pthread_cond_timedwait(&timer, &timer_mutex, &timeout);
+ V(timer_mutex);
}
- Dmsg0(400, "NicB-reworked watchdog thread exited\n");
+ Dmsg0(800, "NicB-reworked watchdog thread exited\n");
return NULL;
}
{
int errstat;
if ((errstat=rwl_writelock(&lock)) != 0) {
- Emsg1(M_ABORT, 0, "rwl_writelock failure. ERR=%s\n",
- strerror(errstat));
+ Emsg1(M_ABORT, 0, _("rwl_writelock failure. ERR=%s\n"),
+ strerror(errstat));
}
-}
+}
/*
* Unlock the watchdog. This can be called multiple times by the
{
int errstat;
if ((errstat=rwl_writeunlock(&lock)) != 0) {
- Emsg1(M_ABORT, 0, "rwl_writeunlock failure. ERR=%s\n",
- strerror(errstat));
+ Emsg1(M_ABORT, 0, _("rwl_writeunlock failure. ERR=%s\n"),
+ strerror(errstat));
}
-}
+}
projects / bacula / bacula / blobdiff